[L] Change in fuchsia/fuchsia[main]: [zx][rs] Remove AsHandleRef::wait_handle.
0 views
Skip to first unread message
'Adam Perry (Gerrit)' via owners-override
Jan 5, 2026, 5:54:13 PMJan 5
to Owners Override, Adam Barth
Attention needed from Adam Barth and Owners Override
Adam Perry has uploaded the change for review![]( "Open in Gerrit")
Adam Perry would like Owners Override and Adam Barth to review this change.
Commit message
[zx][rs] Remove AsHandleRef::wait_handle.
Replaced by wait_one() method on handle wrapper types.
Named wait_one() instead of wait() to distinguish from
Port::wait().
Adds AsRef<NullableHandle> for downstream libraries to
use in defining their own handle abstractions. Should
eventually be able to replace AsHandleRef.
Bug: 434762683
Depends-on: turquoise-internal:Ie5c593d4d3bec2dc249d90a38ca8910ec9243b93
Change-Id: I9d8d07a2874b3e87bc4fa8b8b717ec04adacb217
Change diff
Change information
Files:
- M sdk/rust/zx/src/channel/mod.rs
- M sdk/rust/zx/src/debuglog.rs
- M sdk/rust/zx/src/eventpair.rs
- M sdk/rust/zx/src/handle.rs
- M sdk/rust/zx/src/job.rs
- M sdk/rust/zx/src/macros.rs
- M sdk/rust/zx/src/process.rs
- M sdk/rust/zx/src/time.rs
- M sdk/rust/zx/src/wait.rs
- M src/connectivity/bluetooth/tools/tests/bt-tool-cli-tests/src/lib.rs
- M src/connectivity/network/netstack3/src/bindings/socket/datagram.rs
- M src/connectivity/network/netstack3/src/bindings/socket/stream/buffer.rs
- M src/connectivity/network/testing/netemul/rust/src/lib.rs
- M src/connectivity/network/tests/integration/power/src/lib.rs
- M src/connectivity/network/tests/integration/socket/src/lib.rs
- M src/connectivity/policy/http-client/src/main.rs
- M src/diagnostics/archivist/src/logs/shared_buffer.rs
- M src/lib/diagnostics/inspect/rust/src/writer/types/node.rs
- M src/lib/diagnostics/log/rust/src/fuchsia_28/sink.rs
- M src/lib/fake-clock/svc/src/main.rs
- M src/lib/fidl/rust/external_tests/src/handle_rights.rs
- M src/lib/fidl/rust/external_tests/src/unknown_interactions.rs
- M src/lib/fidl/rust/fidl/src/client.rs
- M src/lib/fidl/rust_next/fidl_next_protocol/src/fuchsia/channel.rs
- M src/lib/fuchsia-async/src/handle/zircon/fifo.rs
- M src/lib/fuchsia-async/src/handle/zircon/on_signals.rs
- M src/lib/fuchsia-async/src/handle/zircon/rwhandle.rs
- M src/lib/fuchsia-async/src/lib.rs
- M src/lib/mapped-vmo/src/immutable.rs
- M src/lib/pty/src/pty.rs
- M src/lib/scoped_task/src/zircon.rs
- M src/lib/scoped_task/test/main.rs
- M src/session/bin/element_manager/src/element_manager.rs
- M src/starnix/kernel/core/fs/fuchsia/remote_unix_domain_socket.rs
- M src/starnix/kernel/core/fs/fuchsia/sync_file.rs
- M src/starnix/kernel/core/fs/fuchsia/zxio.rs
- M src/starnix/kernel/core/task/hr_timer_manager.rs
- M src/starnix/kernel/core/task/task.rs
- M src/starnix/kernel/core/vfs/pidfd.rs
- M src/starnix/kernel/core/vfs/timer.rs
- M src/starnix/lib/kernel_manager/src/suspend.rs
- M src/starnix/modules/nanohub/datachannel_file.rs
- M src/storage/lib/block_server/integration/src/lib.rs
- M src/storage/lib/block_server/src/c_interface.rs
- M src/sys/component_manager/lib/logger/src/klog.rs
- M src/sys/component_manager/lib/sandbox/src/receiver.rs
- M src/sys/component_manager/lib/serve_processargs/src/namespace.rs
- M src/sys/component_manager/src/framework/realm_query.rs
- M src/sys/component_manager/src/model/tests/directory.rs
- M src/sys/fuzzing/manager/src/manager.rs
- M src/sys/lib/namespace/src/lib.rs
- M src/sys/pkg/bin/fake-system-update-committer/src/main.rs
- M src/sys/pkg/bin/pkg-cache/src/gc_service.rs
- M src/sys/pkg/bin/system-update-committer/src/metadata.rs
- M src/sys/pkg/lib/fidl-fuchsia-update-ext/src/commit.rs
- M src/sys/pkg/lib/fuchsia-pkg-testing/src/package.rs
- M src/sys/pkg/tests/pkgdir/src/directory.rs
- M src/sys/pkg/tests/pkgdir/src/node.rs
- M src/sys/pkg/tests/system-update-committer/src/lib.rs
- M src/sys/time/timekeeper/alarms/src/emu.rs
- M src/testing/sl4f/src/time/facade.rs
- M src/tests/fidl/dynsuite/client_suite/runners/rust_sync/src/main.rs
- M src/ui/lib/input_pipeline/src/display_ownership.rs
- M src/virtualization/bin/vmm/device/virtio_vsock/src/connection_states.rs
- M src/virtualization/tests/virtio_vsock_test_util/src/fuchsia_main.rs
Change size: L
Delta: 65 files changed, 237 insertions(+), 245 deletions(-)
Related details
Attention is currently required from:
- Adam Barth
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c02adceee4885e7938c4f9395201b34c1e809e80-HTML%40fuchsia-review.googlesource.com.
'Adam Perry (Gerrit)' via owners-override
Jan 5, 2026, 5:54:16 PMJan 5
to Adam Barth, Owners Override, GI Try Builder, CQ Bot
Attention needed from Adam Barth and Owners Override
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Adam Barth
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c02adceee4885e7938c4f9395201b34c1e809e80-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
Jan 5, 2026, 5:55:16 PMJan 5
to Adam Perry, Owners Override, GI Try Builder, CQ Bot
Attention needed from Adam Perry and Owners Override
Adam Barth voted![]( "Open in Gerrit")
Attention is currently required from:
- Adam Perry
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e16eaadede64fee31c4e1b509c9b2054e88f5204-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Perry (Gerrit)' via owners-override
Jan 5, 2026, 6:00:09 PMJan 5
to CL Deps Checker, Adam Barth, Owners Override, GI Try Builder, CQ Bot
Attention needed from Owners Override
Adam Perry voted Fuchsia-Auto-Submit+1![]( "Open in Gerrit")
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c453c42d80ae667e5ef199dd502804009c05a7de-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
Jan 5, 2026, 11:12:48 PMJan 5
to Adam Perry, CL Deps Checker, Adam Barth, Owners Override, GI Try Builder
CQ Bot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[zx][rs] Remove AsHandleRef::wait_handle.
Replaced by wait_one() method on handle wrapper types.
Named wait_one() instead of wait() to distinguish from
Port::wait().
Adds AsRef<NullableHandle> for downstream libraries to
use in defining their own handle abstractions. Should
eventually be able to replace AsHandleRef.
Bug: 434762683
Depends-on: turquoise-internal:Ie5c593d4d3bec2dc249d90a38ca8910ec9243b93
Change-Id: I9d8d07a2874b3e87bc4fa8b8b717ec04adacb217
Owners-Override: Adam Barth <aba...@google.com>
Dependencies-Satisfied: CL Deps Checker <cl-deps...@fuchsia-internal-service-accts.iam.gserviceaccount.com>
Reviewed-by: Adam Barth <aba...@google.com>
Commit-Queue: Adam Perry <adam...@google.com>
Fuchsia-Auto-Submit: Adam Perry <adam...@google.com>
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by Adam Barth
Dependencies-Satisfied: +1 by CL Deps Checker
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/46f6e785f2532973e19ba7350df74c76549f288b-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Jan 5, 2026, 11:15:19 PMJan 5
to Adam Perry, CQ Bot, CL Deps Checker, Adam Barth, Owners Override, GI Try Builder
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1132716
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5ad430b4a3d851c329cbcab2d4e84a157bbc0165-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages