[M] Change in fuchsia/fuchsia[main]: [zx][rs] Remove HandleBased::from_handle.

['Adam Perry (Gerrit)' via owners-override]

Attention needed from Adam Barth and Owners Override

Adam Perry has uploaded the change for review

Adam Perry would like Owners Override and Adam Barth to review this change.

Commit message

[zx][rs] Remove HandleBased::from_handle.

There are a few categories of usage with different
replacements:

1. working around lack of inherent duplicate/replace on
   typed handle wrappers, replaced with usage of those
   new methods
2. used the same way From<NullableHandle> works,
   replaced with that
3. creating an invalid/null typed handle wrapper, replaced
    with the new invalid() inherent method added to
    typed handle wrappers
4. performing identity conversions, those usages are
   just removed

NO_IFTTT=superficial api change
Bug: 434763877

Change-Id: Id66465e31da3e19a7673e6bb2e2a1104f55bf5cc

Change diff

Change information

Files:

• M sdk/rust/zx/src/handle.rs
• M sdk/rust/zx/src/macros.rs
• M src/connectivity/overnet/lib/core/src/peer/mod.rs
• M src/connectivity/overnet/lib/core/src/proxy/handle/channel.rs
• M src/connectivity/overnet/lib/core/src/proxy/handle/event_pair.rs
• M src/connectivity/overnet/lib/core/src/proxy/handle/socket.rs
• M src/connectivity/overnet/lib/core/src/router/mod.rs
• M src/connectivity/overnet/tests/fidl/src/lib.rs
• M src/connectivity/wlan/testing/hw-sim/src/test_utils.rs
• M src/connectivity/wlan/tests/drivers-only/common/src/lib.rs
• M src/lib/fdomain/container/src/lib.rs
• M src/lib/fidl/rust/gidl_util/src/lib.rs
• M src/lib/fidl/rust/handle_tests/src/channel.rs
• M src/lib/fuchsia-async/src/handle/emulated/mod.rs
• M src/lib/pty/src/pty.rs
• M src/lib/ui/carnelian/src/view/strategies/display_direct.rs
• M src/starnix/lib/usercopy/src/lib.rs
• M src/starnix/modules/kgsl/libmagma/kgsl_libmagma.rs
• M src/starnix/modules/magma/BUILD.gn
• M src/starnix/modules/magma/image_file.rs
• M src/starnix/runner/lib/kernel_manager/src/suspend.rs
• M src/sys/lib/task-exceptions/src/lib.rs
• M src/sys/test_runners/src/launch.rs
• M src/ui/lib/input_pipeline/src/touch_injector_handler.rs
• M src/virtualization/bin/guest/src/vsh/pty.rs

Change size: M

Delta: 25 files changed, 67 insertions(+), 106 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

• Adam Barth
• Owners Override

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Id66465e31da3e19a7673e6bb2e2a1104f55bf5cc

Gerrit-Change-Number: 1504990

Gerrit-PatchSet: 3

Gerrit-Owner: Adam Perry <adam...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: Adam Perry <adam...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Attention: Adam Barth <aba...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5627249df9aba7445df2617a5e2990ddab2c9d86-HTML%40fuchsia-review.googlesource.com.

['Adam Perry (Gerrit)' via owners-override]

Attention needed from Adam Barth and Owners Override

Adam Perry voted

Commit-Queue	+1
Fuchsia-Auto-Submit	+1

Open in Gerrit

Related details

Attention is currently required from:

• Adam Barth
• Owners Override

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Id66465e31da3e19a7673e6bb2e2a1104f55bf5cc

Gerrit-Change-Number: 1504990

Gerrit-PatchSet: 3

Gerrit-Owner: Adam Perry <adam...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: Adam Perry <adam...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Attention: Adam Barth <aba...@google.com>

Gerrit-Comment-Date: Fri, 20 Mar 2026 15:43:26 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5627249df9aba7445df2617a5e2990ddab2c9d86-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['Adam Barth (Gerrit)' via owners-override]

Attention needed from Adam Perry and Owners Override

Adam Barth voted Code-Review+2

Code-Review

+2

Open in Gerrit

Related details

Attention is currently required from:

• Adam Perry
• Owners Override

Submit Requirements:

• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Id66465e31da3e19a7673e6bb2e2a1104f55bf5cc

Gerrit-Change-Number: 1504990

Gerrit-PatchSet: 3

Gerrit-Owner: Adam Perry <adam...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: Adam Perry <adam...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Adam Perry <adam...@google.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Comment-Date: Fri, 20 Mar 2026 15:50:37 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f9542d125c0969e9a7c4e20b7548c03db9f259e9-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['Adam Barth (Gerrit)' via owners-override]

Attention needed from Adam Perry and Owners Override

Adam Barth voted Owners-Override+1

Owners-Override

+1

Open in Gerrit

Related details

Attention is currently required from:

• Adam Perry
• Owners Override

Submit Requirements:

• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Id66465e31da3e19a7673e6bb2e2a1104f55bf5cc

Gerrit-Change-Number: 1504990

Gerrit-PatchSet: 3

Gerrit-Owner: Adam Perry <adam...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: Adam Perry <adam...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Adam Perry <adam...@google.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Comment-Date: Fri, 20 Mar 2026 15:50:46 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/faaf0b88f1fa4ae8951c8611d9a913584e30437f-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['CQ Bot (Gerrit)' via owners-override]

CQ Bot submitted the change

Change information

Commit message:

[zx][rs] Remove HandleBased::from_handle.

There are a few categories of usage with different
replacements:

1. working around lack of inherent duplicate/replace on
   typed handle wrappers, replaced with usage of those
   new methods
2. used the same way From<NullableHandle> works,
   replaced with that
3. creating an invalid/null typed handle wrapper, replaced
    with the new invalid() inherent method added to
    typed handle wrappers
4. performing identity conversions, those usages are
   just removed

NO_IFTTT=superficial api change
Bug: 434763877

Change-Id: Id66465e31da3e19a7673e6bb2e2a1104f55bf5cc

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1504990

Reviewed-by: Adam Barth <aba...@google.com>

Commit-Queue: Adam Perry <adam...@google.com>

Fuchsia-Auto-Submit: Adam Perry <adam...@google.com>

Owners-Override: Adam Barth <aba...@google.com>

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +2 by Adam Barth

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Id66465e31da3e19a7673e6bb2e2a1104f55bf5cc

Gerrit-Change-Number: 1504990

Gerrit-PatchSet: 4

Gerrit-Owner: Adam Perry <adam...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: Adam Perry <adam...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/4432548c049b2d4be8409e9c042a9b58cb113142-HTML%40fuchsia-review.googlesource.com.

['GI Roller (Gerrit)' via owners-override]

Message from GI Roller

Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1205589

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Id66465e31da3e19a7673e6bb2e2a1104f55bf5cc

Gerrit-Change-Number: 1504990

Gerrit-PatchSet: 4

Gerrit-Owner: Adam Perry <adam...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: Adam Perry <adam...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: GI Roller <global-integra...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Comment-Date: Fri, 20 Mar 2026 15:54:56 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/63d7c8bcb088ce3e22614a98320cbee247cf2767-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.