[M] Change in fuchsia/fuchsia[main]: [state-recorder] Make `lazy_static_cstr` private and excluded from lsan

0 views
Skip to first unread message

'Prabhu Karthikeyan Rajasekaran (Gerrit)' via owners-override

unread,
Feb 12, 2026, 9:11:30 PM (7 days ago) Feb 12
to Owners Override
Attention needed from Erick Tryzelaar, Marc Khouri and Owners Override

Erick Tryzelaar has uploaded the change for review

Prabhu Karthikeyan Rajasekaran would like Owners Override to review this change authored by Erick Tryzelaar.

Commit message

[state-recorder] Make `lazy_static_cstr` private and excluded from lsan

An upcoming toolchain roll is erroring out because the leak sanitizer is
erroring out on the leak created by `lazy_static_cstr`. Since the leak
is intentional, this patch:

* Makes the function private since it's not needed externally.
* Excludes the explicitly leaked memory from LeakSanitizer.
Bug: 477259622
Change-Id: Ifa63fe94a963f4a42b54c5e22581d6bd34d452a1

Change diff


Change information

Files:
  • M sdk/lib/power/state_recorder/rust/src/lib.rs
  • M src/connectivity/wlan/wlanix/src/ifaces.rs
Change size: M
Delta: 2 files changed, 43 insertions(+), 10 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Erick Tryzelaar
  • Marc Khouri
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ifa63fe94a963f4a42b54c5e22581d6bd34d452a1
Gerrit-Change-Number: 1504962
Gerrit-PatchSet: 2
Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Marc Khouri <mn...@google.com>
Gerrit-Reviewer: Onath Dillinger <clar...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Prabhu Karthikeyan Rajasekaran <prab...@google.com>
Gerrit-Attention: Marc Khouri <mn...@google.com>
Gerrit-Attention: Erick Tryzelaar <etryz...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/02fdfdb8193bfd38556cc3aa7da64daf1243461c-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Prabhu Karthikeyan Rajasekaran (Gerrit)' via owners-override

unread,
Feb 12, 2026, 9:11:34 PM (7 days ago) Feb 12
to Erick Tryzelaar, Owners Override, Onath Dillinger, GI Try Builder, Marc Khouri, CQ Bot
Attention needed from Erick Tryzelaar, Marc Khouri and Owners Override

Prabhu Karthikeyan Rajasekaran added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Prabhu Karthikeyan Rajasekaran . resolved

Requesting owners override as this patch will unblock us in rolling the toolchain which is time sensitive.

Open in Gerrit

Related details

Attention is currently required from:
  • Erick Tryzelaar
  • Marc Khouri
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ifa63fe94a963f4a42b54c5e22581d6bd34d452a1
Gerrit-Change-Number: 1504962
Gerrit-PatchSet: 2
Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Marc Khouri <mn...@google.com>
Gerrit-Reviewer: Onath Dillinger <clar...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Prabhu Karthikeyan Rajasekaran <prab...@google.com>
Gerrit-Attention: Marc Khouri <mn...@google.com>
Gerrit-Attention: Erick Tryzelaar <etryz...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Fri, 13 Feb 2026 02:11:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/02fdfdb8193bfd38556cc3aa7da64daf1243461c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Prabhu Karthikeyan Rajasekaran (Gerrit)' via owners-override

unread,
Feb 12, 2026, 9:33:59 PM (7 days ago) Feb 12
to Erick Tryzelaar, Owners Override, Onath Dillinger, GI Try Builder, Marc Khouri, CQ Bot
Attention needed from Erick Tryzelaar, Marc Khouri and Owners Override

Prabhu Karthikeyan Rajasekaran voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Erick Tryzelaar
  • Marc Khouri
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ifa63fe94a963f4a42b54c5e22581d6bd34d452a1
Gerrit-Change-Number: 1504962
Gerrit-PatchSet: 2
Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Marc Khouri <mn...@google.com>
Gerrit-Reviewer: Onath Dillinger <clar...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Prabhu Karthikeyan Rajasekaran <prab...@google.com>
Gerrit-Attention: Marc Khouri <mn...@google.com>
Gerrit-Attention: Erick Tryzelaar <etryz...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Fri, 13 Feb 2026 02:33:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/89bc0dbc9bf21f70477826c6610247347e5d9306-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
Feb 13, 2026, 12:37:21 AM (7 days ago) Feb 13
to Erick Tryzelaar, Prabhu Karthikeyan Rajasekaran, Owners Override, Onath Dillinger, GI Try Builder, Marc Khouri, CQ Bot
Attention needed from Erick Tryzelaar, Marc Khouri and Owners Override

Adam Barth voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Erick Tryzelaar
  • Marc Khouri
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ifa63fe94a963f4a42b54c5e22581d6bd34d452a1
Gerrit-Change-Number: 1504962
Gerrit-PatchSet: 2
Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Marc Khouri <mn...@google.com>
Gerrit-Reviewer: Onath Dillinger <clar...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Prabhu Karthikeyan Rajasekaran <prab...@google.com>
Gerrit-Attention: Marc Khouri <mn...@google.com>
Gerrit-Attention: Erick Tryzelaar <etryz...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Fri, 13 Feb 2026 05:37:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/664d80dc33ddb725551a617a152c7449d953e280-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Feb 13, 2026, 12:38:06 AM (7 days ago) Feb 13
to Erick Tryzelaar, Adam Barth, Prabhu Karthikeyan Rajasekaran, Owners Override, Onath Dillinger, GI Try Builder, Marc Khouri

CQ Bot submitted the change

Change information

Commit message:
[state-recorder] Make `lazy_static_cstr` private and excluded from lsan

An upcoming toolchain roll is erroring out because the leak sanitizer is
erroring out on the leak created by `lazy_static_cstr`. Since the leak
is intentional, this patch:

* Makes the function private since it's not needed externally.
* Excludes the explicitly leaked memory from LeakSanitizer.
Bug: 477259622
Change-Id: Ifa63fe94a963f4a42b54c5e22581d6bd34d452a1
Reviewed-by: Onath Dillinger <clar...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Reviewed-by: Prabhu Karthikeyan Rajasekaran <prab...@google.com>
Fuchsia-Auto-Submit: Erick Tryzelaar <etryz...@google.com>
Commit-Queue: Erick Tryzelaar <etryz...@google.com>
Files:
  • M sdk/lib/power/state_recorder/rust/src/lib.rs
  • M src/connectivity/wlan/wlanix/src/ifaces.rs
Change size: M
Delta: 2 files changed, 43 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Onath Dillinger, +2 by Prabhu Karthikeyan Rajasekaran
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ifa63fe94a963f4a42b54c5e22581d6bd34d452a1
Gerrit-Change-Number: 1504962
Gerrit-PatchSet: 3
Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Marc Khouri <mn...@google.com>
Gerrit-Reviewer: Onath Dillinger <clar...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Prabhu Karthikeyan Rajasekaran <prab...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/3b161111063e331574cf9980a2217cdd29059052-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Feb 13, 2026, 12:40:17 AM (7 days ago) Feb 13
to Erick Tryzelaar, CQ Bot, Adam Barth, Prabhu Karthikeyan Rajasekaran, Owners Override, Onath Dillinger, GI Try Builder, Marc Khouri

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ifa63fe94a963f4a42b54c5e22581d6bd34d452a1
Gerrit-Change-Number: 1504962
Gerrit-PatchSet: 3
Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Marc Khouri <mn...@google.com>
Gerrit-Reviewer: Onath Dillinger <clar...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Prabhu Karthikeyan Rajasekaran <prab...@google.com>
Gerrit-Comment-Date: Fri, 13 Feb 2026 05:40:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7a51cb5e392cfb5edf843655b8542b164c1f2216-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages