[L] Change in fuchsia/fuchsia[main]: [async][sdk] Move async libs from Zircon to the SDK

0 views
Skip to first unread message

'Ian McKellar (Gerrit)' via owners-override

unread,
Sep 5, 2024, 2:48:43 PM9/5/24
to Owners Override
Attention needed from Owners Override

Ian McKellar has uploaded the change for review

Ian McKellar would like Owners Override to review this change.

Commit message

[async][sdk] Move async libs from Zircon to the SDK

For legacy reasons some SDK libraries are in //zircon/system/ulib/
rather than //sdk/lib/. I'm moving some of these to where they belong.

There are "forwarding" rules in //zircon/system/ulib/ so that not all
BUILD.gn references have to be cleaned up at once.

This does not move the build rules from zx_library to sdk_source_set
because it turns out that is its own whole can of complexity.
Change-Id: Ib34d1d3c60e5f5cbde72773c7acfb65c3017a62b

Change diff


Change information

Files:
  • M build/BUILD.gn
  • M build/sdk/BUILD.gn
  • M docs/concepts/drivers/driver-dispatcher-and-threads.md
  • M docs/contribute/governance/rfcs/0240_async_ops_are_on_objects.md
  • M docs/contribute/open_projects/graduated/ubsan.md
  • M docs/development/components/build.md
  • M docs/development/graphics/magma/concepts/porting.md
  • M docs/development/languages/c-cpp/fpromise_promise_guide.md
  • M docs/development/languages/c-cpp/thread-safe-async.md
  • M docs/development/languages/fidl/tutorials/cpp/basics/server.md
  • M docs/development/languages/fidl/tutorials/hlcpp/basics/server.md
  • M docs/development/languages/fidl/tutorials/rust/basics/server.md
  • M docs/development/languages/new/structure.md
  • M sdk/BUILD.gn
  • M sdk/lib/async-cpp/async-cpp.api
  • A sdk/lib/async-default/BUILD.gn
  • R sdk/lib/async-default/default.c
  • R sdk/lib/async-default/include/lib/async/default.h
  • M sdk/lib/async-loop-default/async-loop-default.api
  • M sdk/lib/async-loop-testing/cpp/BUILD.gn
  • M sdk/lib/async-loop-testing/cpp/tests/BUILD.gn
  • A sdk/lib/async-loop/BUILD.gn
  • R sdk/lib/async-loop/OWNERS
  • R sdk/lib/async-loop/README.md
  • R sdk/lib/async-loop/default.c
  • R sdk/lib/async-loop/include/lib/async-loop/cpp/loop.h
  • R sdk/lib/async-loop/include/lib/async-loop/default.h
  • R sdk/lib/async-loop/include/lib/async-loop/loop.h
  • R sdk/lib/async-loop/loop.c
  • R sdk/lib/async-loop/loop_wrapper.cc
  • R sdk/lib/async-loop/test/BUILD.gn
  • R sdk/lib/async-loop/test/loop_tests.cc
  • A sdk/lib/async-testing/BUILD.gn
  • R sdk/lib/async-testing/OWNERS
  • R sdk/lib/async-testing/dispatcher_stub.cc
  • R sdk/lib/async-testing/include/lib/async-testing/dispatcher_stub.h
  • R sdk/lib/async-testing/include/lib/async-testing/test_loop.h
  • R sdk/lib/async-testing/include/lib/async-testing/test_loop_dispatcher.h
  • R sdk/lib/async-testing/include/lib/async-testing/test_subloop.h
  • R sdk/lib/async-testing/test/BUILD.gn
  • R sdk/lib/async-testing/test/test_loop_tests.cc
  • R sdk/lib/async-testing/test_loop.cc
  • R sdk/lib/async-testing/test_loop_dispatcher.cc
  • A sdk/lib/async/BUILD.gn
  • R sdk/lib/async/OWNERS
  • R sdk/lib/async/README.md
  • M sdk/lib/async/async.api
  • R sdk/lib/async/executor.cc
  • R sdk/lib/async/include/lib/async/cpp/executor.h
  • R sdk/lib/async/include/lib/async/cpp/irq.h
  • R sdk/lib/async/include/lib/async/cpp/paged_vmo.h
  • R sdk/lib/async/include/lib/async/cpp/receiver.h
  • R sdk/lib/async/include/lib/async/cpp/sequence_checker.h
  • R sdk/lib/async/include/lib/async/cpp/task.h
  • R sdk/lib/async/include/lib/async/cpp/time.h
  • R sdk/lib/async/include/lib/async/cpp/trap.h
  • R sdk/lib/async/include/lib/async/cpp/wait.h
  • R sdk/lib/async/include/lib/async/dispatcher.h
  • R sdk/lib/async/include/lib/async/irq.h
  • R sdk/lib/async/include/lib/async/paged_vmo.h
  • R sdk/lib/async/include/lib/async/receiver.h
  • R sdk/lib/async/include/lib/async/sequence_id.h
  • R sdk/lib/async/include/lib/async/task.h
  • R sdk/lib/async/include/lib/async/time.h
  • R sdk/lib/async/include/lib/async/trap.h
  • R sdk/lib/async/include/lib/async/wait.h
  • R sdk/lib/async/irq.cc
  • R sdk/lib/async/ops.c
  • R sdk/lib/async/paged_vmo.cc
  • R sdk/lib/async/receiver.cc
  • R sdk/lib/async/sequence_checker.cc
  • R sdk/lib/async/task.cc
  • R sdk/lib/async/test/BUILD.gn
  • R sdk/lib/async/test/default_tests.cc
  • R sdk/lib/async/test/dispatcher_tests.cc
  • R sdk/lib/async/test/executor_tests.cc
  • R sdk/lib/async/test/irq_tests.cc
  • R sdk/lib/async/test/paged_vmo_tests.cc
  • R sdk/lib/async/test/receiver_tests.cc
  • R sdk/lib/async/test/sequence_checker_tests.cc
  • R sdk/lib/async/test/sequence_id_tests.cc
  • R sdk/lib/async/test/task_tests.cc
  • R sdk/lib/async/test/time_tests.cc
  • R sdk/lib/async/test/trap_tests.cc
  • R sdk/lib/async/test/wait_tests.cc
  • R sdk/lib/async/trap.cc
  • R sdk/lib/async/wait.cc
  • M sdk/lib/async_patterns/cpp/BUILD.gn
  • M sdk/lib/async_patterns/cpp/tests/BUILD.gn
  • M sdk/lib/async_patterns/testing/cpp/BUILD.gn
  • M sdk/lib/async_patterns/testing/cpp/tests/BUILD.gn
  • M sdk/lib/async_patterns/testing/next/cpp/BUILD.gn
  • M sdk/lib/async_patterns/testing/next/cpp/tests/BUILD.gn
  • M sdk/lib/component/outgoing/cpp/BUILD.gn
  • M sdk/lib/component/tests/BUILD.gn
  • M sdk/lib/device-watcher/cpp/BUILD.gn
  • M sdk/lib/diagnostics/reader/cpp/tests/BUILD.gn
  • M sdk/lib/driver/async-helpers/cpp/BUILD.gn
  • M sdk/lib/driver/component/cpp/BUILD.gn
  • M sdk/lib/driver/devfs/cpp/BUILD.gn
  • M sdk/lib/driver/metadata/cpp/BUILD.gn
  • M sdk/lib/driver/platform-device/cpp/BUILD.gn
  • M sdk/lib/driver/power/cpp/testing/BUILD.gn
  • M sdk/lib/driver/runtime/BUILD.gn
  • M sdk/lib/driver/runtime/testing/cpp/BUILD.gn
  • M sdk/lib/driver/testing/cpp/BUILD.gn
  • M sdk/lib/driver_test_realm/BUILD.gn
  • M sdk/lib/driver_test_realm/realm_builder/cpp/BUILD.gn
  • M sdk/lib/fdio/tests/BUILD.gn
  • M sdk/lib/fidl/cpp/BUILD.gn
  • M sdk/lib/fidl/cpp/tests/dispatcher/BUILD.gn
  • M sdk/lib/fidl/cpp/tests/integration/BUILD.gn
  • M sdk/lib/fidl/cpp/wire/BUILD.gn
  • M sdk/lib/fidl/hlcpp/BUILD.gn
  • M sdk/lib/fidl/hlcpp/fuzzing/BUILD.gn
  • M sdk/lib/fidl_driver/tests/transport/BUILD.gn
  • M sdk/lib/input_report_reader/BUILD.gn
  • M sdk/lib/inspect/component/cpp/BUILD.gn
  • M sdk/lib/inspect/component/cpp/tests/BUILD.gn
  • M sdk/lib/ld/testing/BUILD.gn
  • M sdk/lib/svc/BUILD.gn
  • M sdk/lib/sys/component/cpp/tests/BUILD.gn
  • M sdk/lib/sys/cpp/tests/BUILD.gn
  • M sdk/lib/sys/service/cpp/BUILD.gn
  • M sdk/lib/syslog/cpp/BUILD.gn
  • M sdk/lib/ui/scenic/cpp/testing/BUILD.gn
  • M sdk/lib/vfs/cpp/BUILD.gn
  • M sdk/lib/vfs/internal/BUILD.gn
  • M sdk/lib/zxio/tests/BUILD.gn
  • M src/connectivity/network/netstack/tracing/go_tracing_include_dirs.gni
  • M src/connectivity/wlan/drivers/wlanphy/tests/wlanphy_device_test.cc
  • M src/devices/bus/drivers/pci/kpci.cc
  • M src/devices/usb/lib/usb-endpoint/BUILD.gn
  • M src/devices/usb/lib/usb-endpoint/testing/fake-usb-endpoint-server.h
  • M src/media/audio/drivers/usb-audio/tests/usb-audio-test.cc
  • M zircon/system/ulib/async-default/BUILD.gn
  • M zircon/system/ulib/async-loop/BUILD.gn
  • M zircon/system/ulib/async-testing/BUILD.gn
  • M zircon/system/ulib/async/BUILD.gn
  • M zircon/system/ulib/syslog/BUILD.gn
  • M zircon/system/ulib/trace-engine/BUILD.gn
  • M zircon/system/ulib/trace-provider/BUILD.gn
  • M zircon/system/ulib/trace/BUILD.gn
Change size: L
Delta: 143 files changed, 464 insertions(+), 432 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedAPI-Review
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ib34d1d3c60e5f5cbde72773c7acfb65c3017a62b
Gerrit-Change-Number: 1113214
Gerrit-PatchSet: 4
Gerrit-Owner: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Fuchsia Try Builder <fuchsia-t...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/eb85211275db48f24ea9b2e2c8c0b3dcb00a631d-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Ian McKellar (Gerrit)' via owners-override

unread,
Sep 5, 2024, 2:48:51 PM9/5/24
to Owners Override, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Adam Barth, Fuchsia Try Builder, CQ Bot, James Robinson
Attention needed from Owners Override

Ian McKellar voted Fuchsia-Auto-Submit+1

Fuchsia-Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedAPI-Review
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ib34d1d3c60e5f5cbde72773c7acfb65c3017a62b
Gerrit-Change-Number: 1113214
Gerrit-PatchSet: 4
Gerrit-Owner: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Fuchsia Try Builder <fuchsia-t...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Thu, 05 Sep 2024 14:48:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/eb85211275db48f24ea9b2e2c8c0b3dcb00a631d-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
Sep 5, 2024, 3:57:44 PM9/5/24
to Ian McKellar, Owners Override, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Fuchsia Try Builder, CQ Bot, James Robinson
Attention needed from Ian McKellar and Owners Override

Adam Barth voted

API-Review+1
Code-Review+2
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ian McKellar
  • Owners Override
Submit Requirements:
  • requirement satisfiedAPI-Review
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ib34d1d3c60e5f5cbde72773c7acfb65c3017a62b
Gerrit-Change-Number: 1113214
Gerrit-PatchSet: 4
Gerrit-Owner: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Fuchsia Try Builder <fuchsia-t...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Ian McKellar <ian...@google.com>
Gerrit-Comment-Date: Thu, 05 Sep 2024 15:57:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9d47fccce4017206f134daebf97c17441981ca04-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Sep 5, 2024, 3:58:19 PM9/5/24
to Ian McKellar, Auto-Submit, Adam Barth, Owners Override, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Fuchsia Try Builder, James Robinson

CQ Bot submitted the change

Change information

Commit message:
[async][sdk] Move async libs from Zircon to the SDK

For legacy reasons some SDK libraries are in //zircon/system/ulib/
rather than //sdk/lib/. I'm moving some of these to where they belong.

There are "forwarding" rules in //zircon/system/ulib/ so that not all
BUILD.gn references have to be cleaned up at once.

This does not move the build rules from zx_library to sdk_source_set
because it turns out that is its own whole can of complexity.
Change-Id: Ib34d1d3c60e5f5cbde72773c7acfb65c3017a62b
Reviewed-by: Adam Barth <aba...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Fuchsia-Auto-Submit: Ian McKellar <ian...@google.com>
API-Review: Adam Barth <aba...@google.com>
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedAPI-Review: +1 by Adam Barth
  • requirement satisfiedCode-Review: +2 by Adam Barth
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ib34d1d3c60e5f5cbde72773c7acfb65c3017a62b
Gerrit-Change-Number: 1113214
Gerrit-PatchSet: 5
Gerrit-Owner: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/effe0d1a4b8ffa0cbe8eaaa9840e35ec1a02843a-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Sep 5, 2024, 4:10:13 PM9/5/24
to Ian McKellar, CQ Bot, Auto-Submit, Adam Barth, Owners Override, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Fuchsia Try Builder, James Robinson

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedAPI-Review
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ib34d1d3c60e5f5cbde72773c7acfb65c3017a62b
Gerrit-Change-Number: 1113214
Gerrit-PatchSet: 5
Gerrit-Owner: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Fuchsia Try Builder <fuchsia-t...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Comment-Date: Thu, 05 Sep 2024 16:10:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c105e6d414cbb3fb549c03150eb918d4cb51fd3c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages