[XL] Change in fuchsia/fuchsia[main]: [curl] Finish migration to new layout [2/3]

0 views
Skip to first unread message

'Aaron Wood (Gerrit)' via owners-override

unread,
Aug 5, 2025, 2:41:44 PMAug 5
to Owners Override
Attention needed from Jacob Rutherford and Owners Override

Jacob Rutherford has uploaded the change for review

Aaron Wood would like Owners Override to review this change authored by Jacob Rutherford.

Commit message

[curl] Finish migration to new layout [2/3]

This moves the files stored at //build/secondary/third_party/curl to
the new //third_party/curl directory and updates the build file to point
to the new sources.
Bug: 432038197
Change-Id: If79be1bf33df9737b098313a989302158fcacd1f

Change diff


Change information

Files:
  • D build/secondary/third_party/curl/BUILD.gn
  • M bundles/tools/BUILD.gn
  • M src/developer/debug/zxdb/common/BUILD.gn
  • A third_party/curl/BUILD.gn
  • R third_party/curl/OWNERS
  • R third_party/curl/README.fuchsia
  • R third_party/curl/curl_config.h.fuchsia
  • R third_party/curl/curl_config.h.host
Change size: XL
Delta: 8 files changed, 556 insertions(+), 556 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Jacob Rutherford
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: If79be1bf33df9737b098313a989302158fcacd1f
Gerrit-Change-Number: 1326825
Gerrit-PatchSet: 8
Gerrit-Owner: Jacob Rutherford <jru...@google.com>
Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
Gerrit-Reviewer: Jacob Rutherford <jru...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Jacob Rutherford <jru...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/147942dce392a96934e663745a9acd430ef666ff-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Jacob Rutherford (Gerrit)' via owners-override

unread,
Aug 5, 2025, 2:45:41 PMAug 5
to Owners Override, Aaron Wood, GI Try Builder, CQ Bot
Attention needed from Owners Override

Jacob Rutherford added 1 comment

File third_party/curl/curl_config.h.host
File-level comment, Patchset 8 (Latest):
Jacob Rutherford . resolved

Hm maybe I need to move this in the final CL so that OWNERS gets applied to it?

Aaron Wood

OWNERS changes have to land before they can be used. We can use the global owners override to fix.

Jacob Rutherford

Sounds good, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: If79be1bf33df9737b098313a989302158fcacd1f
    Gerrit-Change-Number: 1326825
    Gerrit-PatchSet: 8
    Gerrit-Owner: Jacob Rutherford <jru...@google.com>
    Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
    Gerrit-Reviewer: Jacob Rutherford <jru...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Comment-Date: Tue, 05 Aug 2025 18:45:27 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Jacob Rutherford <jru...@google.com>
    Comment-In-Reply-To: Aaron Wood <aaro...@google.com>

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e5cf1f221e7adb18a8ae7a43770e04f8d686a009-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    'Jacob Rutherford (Gerrit)' via owners-override

    unread,
    Aug 5, 2025, 2:49:05 PMAug 5
    to Owners Override, Aaron Wood, GI Try Builder, CQ Bot
    Attention needed from Owners Override

    Jacob Rutherford voted Fuchsia-Auto-Submit+1

    Fuchsia-Auto-Submit+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Owners Override
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: If79be1bf33df9737b098313a989302158fcacd1f
    Gerrit-Change-Number: 1326825
    Gerrit-PatchSet: 8
    Gerrit-Owner: Jacob Rutherford <jru...@google.com>
    Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
    Gerrit-Reviewer: Jacob Rutherford <jru...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Comment-Date: Tue, 05 Aug 2025 18:48:49 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/adc070355aaede72967b4d004dcb9c56710bf90f-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    'Adam Barth (Gerrit)' via owners-override

    unread,
    Aug 5, 2025, 3:03:37 PMAug 5
    to Jacob Rutherford, Owners Override, Aaron Wood, GI Try Builder, CQ Bot
    Attention needed from Jacob Rutherford and Owners Override

    Adam Barth voted Owners-Override+1

    Owners-Override+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jacob Rutherford
    • Owners Override
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: If79be1bf33df9737b098313a989302158fcacd1f
    Gerrit-Change-Number: 1326825
    Gerrit-PatchSet: 8
    Gerrit-Owner: Jacob Rutherford <jru...@google.com>
    Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Jacob Rutherford <jru...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: Jacob Rutherford <jru...@google.com>
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Comment-Date: Tue, 05 Aug 2025 19:03:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/d95555937c23fd8fe73ad74dd0021c20f50c665d-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    open
    diffy

    'CQ Bot (Gerrit)' via owners-override

    unread,
    Aug 5, 2025, 4:46:59 PMAug 5
    to Jacob Rutherford, Adam Barth, Owners Override, Aaron Wood, GI Try Builder

    CQ Bot submitted the change

    Change information

    Commit message:
    [curl] Finish migration to new layout [2/3]

    This moves the files stored at //build/secondary/third_party/curl to
    the new //third_party/curl directory and updates the build file to point
    to the new sources.
    Bug: 432038197
    Change-Id: If79be1bf33df9737b098313a989302158fcacd1f
    Reviewed-by: Aaron Wood <aaro...@google.com>
    Owners-Override: Adam Barth <aba...@google.com>
    Commit-Queue: Jacob Rutherford <jru...@google.com>
    Fuchsia-Auto-Submit: Jacob Rutherford <jru...@google.com>
    Files:
    • D build/secondary/third_party/curl/BUILD.gn
    • M bundles/tools/BUILD.gn
    • M src/developer/debug/zxdb/common/BUILD.gn
    • A third_party/curl/BUILD.gn
    • R third_party/curl/OWNERS
    • R third_party/curl/README.fuchsia
    • R third_party/curl/curl_config.h.fuchsia
    • R third_party/curl/curl_config.h.host
    Change size: XL
    Delta: 8 files changed, 556 insertions(+), 556 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +2 by Aaron Wood
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: If79be1bf33df9737b098313a989302158fcacd1f
    Gerrit-Change-Number: 1326825
    Gerrit-PatchSet: 9
    Gerrit-Owner: Jacob Rutherford <jru...@google.com>
    Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Jacob Rutherford <jru...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/1cc8bd07462382222684c1f253ecf5d3aacd9e66-HTML%40fuchsia-review.googlesource.com.
    open
    diffy
    satisfied_requirement

    'GI Roller (Gerrit)' via owners-override

    unread,
    Aug 5, 2025, 4:49:31 PMAug 5
    to Jacob Rutherford, CQ Bot, Adam Barth, Owners Override, Aaron Wood, GI Try Builder

    Message from GI Roller

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: If79be1bf33df9737b098313a989302158fcacd1f
    Gerrit-Change-Number: 1326825
    Gerrit-PatchSet: 9
    Gerrit-Owner: Jacob Rutherford <jru...@google.com>
    Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Jacob Rutherford <jru...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Comment-Date: Tue, 05 Aug 2025 20:49:28 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/fa345b4a8a0e8c505be0e47930b96b6f3044dc21-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages