Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

[M] Change in fuchsia/fuchsia[main]: [mypy] Enable mypy checks on fuchsia/scripts:tests targets

0 views
Skip to first unread message

'Mahesh Saripalli (Gerrit)' via owners-override

unread,
May 23, 2024, 7:04:57 PM5/23/24
to Owners Override
Attention needed from Owners Override

Mahesh Saripalli has uploaded the change for review

Mahesh Saripalli would like Owners Override to review this change.

Commit message

[mypy] Enable mypy checks on fuchsia/scripts:tests targets
Bug: 332584036
Change-Id: I34768926cac85a90172a593d9052ae06b52b7d16

Change diff


Change information

Files:
  • M scripts/BUILD.gn
  • M scripts/build_id_conv.py
  • M scripts/build_id_conv_test.py
Change size: M
Delta: 3 files changed, 29 insertions(+), 25 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I34768926cac85a90172a593d9052ae06b52b7d16
Gerrit-Change-Number: 1053798
Gerrit-PatchSet: 1
Gerrit-Owner: Mahesh Saripalli <mahe...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: Mahesh Saripalli <mahe...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c5ec69220c4f6a73cc4181c63b4b965554da727f-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
May 24, 2024, 12:53:24 AM5/24/24
to Mahesh Saripalli, Owners Override, David Fang, CQ Bot
Attention needed from Mahesh Saripalli and Owners Override

Adam Barth voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mahesh Saripalli
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I34768926cac85a90172a593d9052ae06b52b7d16
Gerrit-Change-Number: 1053798
Gerrit-PatchSet: 1
Gerrit-Owner: Mahesh Saripalli <mahe...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: Mahesh Saripalli <mahe...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Mahesh Saripalli <mahe...@google.com>
Gerrit-Comment-Date: Fri, 24 May 2024 04:53:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/aaa01581133eb6497c87a6427c033a148185dfef-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
May 24, 2024, 5:16:14 PM5/24/24
to Mahesh Saripalli, Owners Override, David Fang, CQ Bot
Attention needed from Mahesh Saripalli and Owners Override

Adam Barth voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mahesh Saripalli
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I34768926cac85a90172a593d9052ae06b52b7d16
Gerrit-Change-Number: 1053798
Gerrit-PatchSet: 2
Gerrit-Owner: Mahesh Saripalli <mahe...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: Mahesh Saripalli <mahe...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Mahesh Saripalli <mahe...@google.com>
Gerrit-Comment-Date: Fri, 24 May 2024 21:16:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/8b1c27c141e5d72f726748a68679e7035cc4f88d-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
May 24, 2024, 5:16:51 PM5/24/24
to Mahesh Saripalli, Auto-Submit, Adam Barth, Owners Override, David Fang

CQ Bot submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: scripts/build_id_conv.py
Insertions: 5, Deletions: 5.

@@ -151,14 +151,14 @@
 
     args = parser.parse_args(unparsed_args)
 
-    input_paths = map(os.path.abspath, args.input)
-    input_paths_list = list(
-        filter(os.path.exists, input_paths)
+    input_paths_map = map(os.path.abspath, args.input)
+    input_paths = list(
+        filter(os.path.exists, input_paths_map)
     )  # conventionally ignore empty inputs
-    input_dirs = list(filter(os.path.isdir, input_paths_list))
+    input_dirs = list(filter(os.path.isdir, input_paths))
     if len(input_dirs) > 0:
         assert len(input_dirs) == len(
-            input_paths_list
+            input_paths
         ), "input formats cannot be mixed"
         in_fmt = build_id_fmt
     else:
```

Change information

Commit message:
[mypy] Enable mypy checks on fuchsia/scripts:tests targets
Bug: 332584036
Change-Id: I34768926cac85a90172a593d9052ae06b52b7d16
Fuchsia-Auto-Submit: Mahesh Saripalli <mahe...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Reviewed-by: David Fang <fan...@google.com>
Files:
  • M scripts/BUILD.gn
  • M scripts/build_id_conv.py
  • M scripts/build_id_conv_test.py
Change size: M
Delta: 3 files changed, 28 insertions(+), 24 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by David Fang
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I34768926cac85a90172a593d9052ae06b52b7d16
Gerrit-Change-Number: 1053798
Gerrit-PatchSet: 3
Gerrit-Owner: Mahesh Saripalli <mahe...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: Mahesh Saripalli <mahe...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/10a758fd91c1dc0ece5981e9daca65dbdaa90e1e-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
May 24, 2024, 5:19:06 PM5/24/24
to Mahesh Saripalli, CQ Bot, Auto-Submit, Adam Barth, Owners Override, David Fang

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I34768926cac85a90172a593d9052ae06b52b7d16
Gerrit-Change-Number: 1053798
Gerrit-PatchSet: 3
Gerrit-Owner: Mahesh Saripalli <mahe...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: Mahesh Saripalli <mahe...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Fri, 24 May 2024 21:19:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/57c56c2bf50572ca3e824dbc7c1ea2ff2f65ee7e-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages