[M] Change in fuchsia/fuchsia[main]: [alacritty] Migrate to new layout [1/2]

['Erick Tryzelaar (Gerrit)' via owners-override]

Attention needed from Owners Override

Erick Tryzelaar has uploaded the change for review

Erick Tryzelaar would like Owners Override to review this change.

Commit message

[alacritty] Migrate to new layout [1/2]

This starts the process to migrate `alacritty` to the modern [3p layout].
This first stages files in `build/secondary` and moves the git
repository into `third_party/alacritty/src`. The following CL will move
files from `build/secondary/third_party/alacritty` into
`third_party/alacritty`.

[3p layout]: https://fuchsia.dev/fuchsia-src/development/source_code/third-party-management#migrating_legacy_third-party_code_to_current_layout

Bug: 42137978

Change-Id: Ic48f5f7aa9ac36d4d07b48f9b1519f0a273c9353

Change diff

Change information

Files:

• M .gitignore
• M build/rust/docs/2021-edition-migration.md
• A build/secondary/third_party/alacritty/OWNERS
• A build/secondary/third_party/alacritty/README.fuchsia
• A build/secondary/third_party/alacritty/alacritty_terminal/BUILD.gn
• A build/secondary/third_party/alacritty/vte/BUILD.gn
• M fuchsia.code-workspace
• M manifests/third_party/all
• A third_party/alacritty-migrating/README.fuchsia
• M tools/check-licenses/assets/readmes/third_party/alacritty/README.fuchsia
• M tools/check-licenses/directory/_config.json

Change size: M

Delta: 11 files changed, 151 insertions(+), 6 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

• Owners Override

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Ic48f5f7aa9ac36d4d07b48f9b1519f0a273c9353

Gerrit-Change-Number: 1342934

Gerrit-PatchSet: 5

Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>

Gerrit-Reviewer: Aaron Wood <aaro...@google.com>

Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>

Gerrit-Reviewer: Jerry Belton <jce...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9b8428c3e707d98a8e57e0aa50e64d70df641e98-HTML%40fuchsia-review.googlesource.com.

['Erick Tryzelaar (Gerrit)' via owners-override]

Attention needed from Owners Override

Erick Tryzelaar voted and added 1 comment

Votes added by Erick Tryzelaar

Commit-Queue	+1
Fuchsia-Auto-Submit	+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Erick Tryzelaar . resolved

Adding owners-override since it modifies the top-level .gitignore

Open in Gerrit

Related details

Attention is currently required from:

• Owners Override

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Ic48f5f7aa9ac36d4d07b48f9b1519f0a273c9353

Gerrit-Change-Number: 1342934

Gerrit-PatchSet: 5

Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>

Gerrit-Reviewer: Aaron Wood <aaro...@google.com>

Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>

Gerrit-Reviewer: Jerry Belton <jce...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Comment-Date: Tue, 12 Aug 2025 17:15:08 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9b8428c3e707d98a8e57e0aa50e64d70df641e98-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['Adam Barth (Gerrit)' via owners-override]

Attention needed from Erick Tryzelaar and Owners Override

Adam Barth voted Owners-Override+1

Owners-Override

+1

Open in Gerrit

Related details

Attention is currently required from:

• Erick Tryzelaar
• Owners Override

Submit Requirements:

• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Ic48f5f7aa9ac36d4d07b48f9b1519f0a273c9353

Gerrit-Change-Number: 1342934

Gerrit-PatchSet: 6

Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>

Gerrit-Reviewer: Aaron Wood <aaro...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>

Gerrit-Reviewer: Jerry Belton <jce...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Attention: Erick Tryzelaar <etryz...@google.com>

Gerrit-Comment-Date: Tue, 12 Aug 2025 17:36:44 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7d0333b74884c7e8baf06dd3e68be5dad9898e6d-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['CQ Bot (Gerrit)' via owners-override]

CQ Bot submitted the change with unreviewed changes

Unreviewed changes

3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: tools/check-licenses/directory/_config.json
Insertions: 1, Deletions: 0.

@@ -8,6 +8,7 @@
                 ],
                 "paths": [
                     "build/secondary/third_party/acpica",
+                    "build/secondary/third_party/alacritty",
                     "build/secondary/third_party/glog",
                     "build/secondary/third_party/grpc",
                     "build/secondary/third_party/mesa"
```
```
The name of the file: build/secondary/third_party/alacritty/OWNERS
Insertions: 8, Deletions: 0.

@@ -0,0 +1,8 @@
+# AUTOGENERATED FROM DEPENDENT BUILD TARGETS.
+# TO MAKE CHANGES HERE, UPDATE //third_party/owners.toml.
+# DOCS: https://fuchsia.dev/reference/tools/fx/cmd/update-3p-owners
+
+include /src/bringup/bin/virtcon/OWNERS
+include /src/lib/ui/OWNERS
+include /src/ui/bin/terminal/OWNERS
+include /src/virtualization/OWNERS
```
```
The name of the file: build/secondary/third_party/alacritty/README.fuchsia
Insertions: 12, Deletions: 0.

@@ -0,0 +1,12 @@
+Name: Alacritty
+
+License File: src/LICENSE-APACHE
+ -> License File Format: Single License
+ -> License Classifications: Apache-2.0
+
+License File: src/vte/LICENSE-APACHE
+ -> License File Format: Single License
+
+License File: src/vte/LICENSE-MIT
+ -> License File Format: Single License
+ -> License Classifications: Copyright, MIT
```
```
The name of the file: build/secondary/third_party/alacritty/alacritty_terminal/BUILD.gn
Insertions: 1, Deletions: 1.

@@ -53,7 +53,7 @@
 
   source_root = "$_source_root/src/lib.rs"
 
-  # TODO(fxbug.dev/69442) remove this allowance
+  # TODO(https://fxbug.dev/69442) remove this allowance
   configs += [
     ":allow_elided_named_lifetimes",
     "//build/config/rust:allow_legacy_derive_helpers",
```
```
The name of the file: third_party/alacritty-migrating/README.fuchsia
Insertions: 12, Deletions: 0.

@@ -0,0 +1,12 @@
+Name: Alacritty
+
+License File: src/LICENSE-APACHE
+ -> License File Format: Single License
+ -> License Classifications: Apache-2.0
+
+License File: src/vte/LICENSE-APACHE
+ -> License File Format: Single License
+
+License File: src/vte/LICENSE-MIT
+ -> License File Format: Single License
+ -> License Classifications: Copyright, MIT
```
```
The name of the file: .gitignore
Insertions: 2, Deletions: 0.

@@ -95,6 +95,8 @@
 # Third party repos.
 /third_party/*
 !/third_party/BUILD.gn
+!/third_party/alacritty-migrating
+/third_party/alacritty-migrating/src
 !/third_party/android/platform/system/keymint
 /third_party/android/platform/system/keymint/src
 !/third_party/boringssl/
```

Change information

Commit message:

[alacritty] Migrate to new layout [1/2]

This starts the process to migrate `alacritty` to the modern [3p layout].
This first stages files in `build/secondary` and moves the git
repository into `third_party/alacritty/src`. The following CL will move
files from `build/secondary/third_party/alacritty` into
`third_party/alacritty`.

[3p layout]: https://fuchsia.dev/fuchsia-src/development/source_code/third-party-management#migrating_legacy_third-party_code_to_current_layout

Bug: 42137978

Change-Id: Ic48f5f7aa9ac36d4d07b48f9b1519f0a273c9353

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1342934

Reviewed-by: Aaron Wood <aaro...@google.com>

Fuchsia-Auto-Submit: Erick Tryzelaar <etryz...@google.com>

Owners-Override: Adam Barth <aba...@google.com>

Reviewed-by: Jerry Belton <jce...@google.com>

Commit-Queue: Erick Tryzelaar <etryz...@google.com>

Files:

• M .gitignore
• M build/rust/docs/2021-edition-migration.md
• A build/secondary/third_party/alacritty/OWNERS
• A build/secondary/third_party/alacritty/README.fuchsia
• A build/secondary/third_party/alacritty/alacritty_terminal/BUILD.gn
• A build/secondary/third_party/alacritty/vte/BUILD.gn
• M fuchsia.code-workspace
• M manifests/third_party/all
• A third_party/alacritty-migrating/README.fuchsia
• M tools/check-licenses/assets/readmes/third_party/alacritty/README.fuchsia
• M tools/check-licenses/directory/_config.json

Change size: M

Delta: 11 files changed, 151 insertions(+), 6 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +2 by Jerry Belton, +2 by Aaron Wood

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Ic48f5f7aa9ac36d4d07b48f9b1519f0a273c9353

Gerrit-Change-Number: 1342934

Gerrit-PatchSet: 7

Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>

Gerrit-Reviewer: Aaron Wood <aaro...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>

Gerrit-Reviewer: Jerry Belton <jce...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/72ac0d13e5fa28829b8b9b6b83249e19ba9f8c5e-HTML%40fuchsia-review.googlesource.com.

['GI Roller (Gerrit)' via owners-override]

Message from GI Roller

Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1029184

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Ic48f5f7aa9ac36d4d07b48f9b1519f0a273c9353

Gerrit-Change-Number: 1342934

Gerrit-PatchSet: 7

Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>

Gerrit-Reviewer: Aaron Wood <aaro...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>

Gerrit-Reviewer: Jerry Belton <jce...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: GI Roller <global-integra...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Comment-Date: Tue, 12 Aug 2025 19:03:57 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f6c19ce3003699ce65ea09606e43583d7a0a6b97-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.