[S] Change in fuchsia/fuchsia[main]: [ubsan-custom] Skeleton for new directory //src/lib/ubsan-custom

0 views
Skip to first unread message

'Roland McGrath (Gerrit)' via owners-override

unread,
Apr 13, 2024, 1:30:55 AMApr 13
to Owners Override
Attention needed from Leonard Chan, Marco Vanotti, Owners Override and Petr Hosek

Roland McGrath has uploaded the change for review

Roland McGrath would like Owners Override to review this change.

Commit message

[ubsan-custom] Skeleton for new directory //src/lib/ubsan-custom

This will be used both in multiple places in the kernel, and
eventually beyond the kernel in other specialized places.
Bug: 334165273
Change-Id: I6b995be2e9efc88fa84e08692f135c3dbe79e866

Change diff

diff --git a/src/lib/BUILD.gn b/src/lib/BUILD.gn
index 8f20cb1..44a999b 100644
--- a/src/lib/BUILD.gn
+++ b/src/lib/BUILD.gn
@@ -95,6 +95,7 @@
"trace:tests",
"transfer_manifest:tests",
"trivial-allocator:tests",
+ "ubsan-custom:tests",
"ui:tests",
"unwinder:tests",
"usb_bulk:tests",
diff --git a/src/lib/ubsan-custom/BUILD.gn b/src/lib/ubsan-custom/BUILD.gn
new file mode 100644
index 0000000..723c269
--- /dev/null
+++ b/src/lib/ubsan-custom/BUILD.gn
@@ -0,0 +1,11 @@
+# Copyright 2024 The Fuchsia Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# **TODO(https://fxbug.dev/334165273):** Contents forthcoming
+group("ubsan-custom") {
+}
+
+group("tests") {
+ testonly = true
+}
diff --git a/src/lib/ubsan-custom/OWNERS b/src/lib/ubsan-custom/OWNERS
new file mode 100644
index 0000000..96c33a4
--- /dev/null
+++ b/src/lib/ubsan-custom/OWNERS
@@ -0,0 +1,4 @@
+leona...@google.com
+mcgr...@google.com
+mvan...@google.com
+pho...@google.com
diff --git a/src/lib/ubsan-custom/README.md b/src/lib/ubsan-custom/README.md
new file mode 100644
index 0000000..d3be5c5
--- /dev/null
+++ b/src/lib/ubsan-custom/README.md
@@ -0,0 +1,12 @@
+# Minimal UndefinedBehaviorSanitizer for custom embedded uses
+
+This is a small header-only library that makes it simple to define the runtime
+required by (UndefinedBehaviorSanitizer)[ubsan]. The runtime implementations
+in LLVM's compiler-rt, even the "minimal" one, cannot fit into custom build
+situations such as kernel or embedded code, for a variety of reasons.
+
+**TODO(https://fxbug.dev/334165273):**
+This may be upstreamed into LLVM in the future, removing the need
+for this separate header library.
+
+[ubsan]: https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html

Change information

Files:
  • M src/lib/BUILD.gn
  • A src/lib/ubsan-custom/BUILD.gn
  • A src/lib/ubsan-custom/OWNERS
  • A src/lib/ubsan-custom/README.md
Change size: S
Delta: 4 files changed, 28 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Leonard Chan
  • Marco Vanotti
  • Owners Override
  • Petr Hosek
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I6b995be2e9efc88fa84e08692f135c3dbe79e866
Gerrit-Change-Number: 1027132
Gerrit-PatchSet: 2
Gerrit-Owner: Roland McGrath <mcgr...@google.com>
Gerrit-Reviewer: Leonard Chan <leona...@google.com>
Gerrit-Reviewer: Marco Vanotti <mvan...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Petr Hosek <pho...@google.com>
Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>
Gerrit-Attention: Leonard Chan <leona...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Petr Hosek <pho...@google.com>
Gerrit-Attention: Marco Vanotti <mvan...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/acfe90564d3c814c88fdc22f8f72e4a2e6c8cb0f-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'Roland McGrath (Gerrit)' via owners-override

unread,
Apr 13, 2024, 1:30:58 AMApr 13
to Owners Override, Marco Vanotti, Leonard Chan, Petr Hosek, CQ Bot
Attention needed from Leonard Chan, Marco Vanotti, Owners Override and Petr Hosek

Roland McGrath voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Leonard Chan
  • Marco Vanotti
  • Owners Override
  • Petr Hosek
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I6b995be2e9efc88fa84e08692f135c3dbe79e866
Gerrit-Change-Number: 1027132
Gerrit-PatchSet: 2
Gerrit-Owner: Roland McGrath <mcgr...@google.com>
Gerrit-Reviewer: Leonard Chan <leona...@google.com>
Gerrit-Reviewer: Marco Vanotti <mvan...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Petr Hosek <pho...@google.com>
Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>
Gerrit-Attention: Leonard Chan <leona...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Petr Hosek <pho...@google.com>
Gerrit-Attention: Marco Vanotti <mvan...@google.com>
Gerrit-Comment-Date: Sat, 13 Apr 2024 05:30:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/acfe90564d3c814c88fdc22f8f72e4a2e6c8cb0f-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
Apr 13, 2024, 3:11:07 AMApr 13
to Roland McGrath, Owners Override, Marco Vanotti, Leonard Chan, Petr Hosek, CQ Bot
Attention needed from Leonard Chan, Marco Vanotti, Owners Override, Petr Hosek and Roland McGrath

Adam Barth voted

Code-Review+2
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Leonard Chan
  • Marco Vanotti
  • Owners Override
  • Petr Hosek
  • Roland McGrath
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I6b995be2e9efc88fa84e08692f135c3dbe79e866
Gerrit-Change-Number: 1027132
Gerrit-PatchSet: 2
Gerrit-Owner: Roland McGrath <mcgr...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Leonard Chan <leona...@google.com>
Gerrit-Reviewer: Marco Vanotti <mvan...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Petr Hosek <pho...@google.com>
Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>
Gerrit-Attention: Leonard Chan <leona...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Petr Hosek <pho...@google.com>
Gerrit-Attention: Marco Vanotti <mvan...@google.com>
Gerrit-Attention: Roland McGrath <mcgr...@google.com>
Gerrit-Comment-Date: Sat, 13 Apr 2024 07:10:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/792f4f79dc216ad58d17eb3fe79da523b730e02c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Marco Vanotti (Gerrit)' via owners-override

unread,
Apr 13, 2024, 10:25:18 AMApr 13
to Roland McGrath, Marco Vanotti, Adam Barth, Owners Override, Leonard Chan, Petr Hosek, CQ Bot
Attention needed from Leonard Chan, Owners Override, Petr Hosek and Roland McGrath

Marco Vanotti voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Leonard Chan
Gerrit-Attention: Roland McGrath <mcgr...@google.com>
Gerrit-Comment-Date: Sat, 13 Apr 2024 14:25:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/ebfccdf3c0e110a0cb824b5942c777c73b152011-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Leonard Chan (Gerrit)' via owners-override

unread,
Apr 15, 2024, 1:51:43 PMApr 15
to Roland McGrath, Marco Vanotti, Adam Barth, Owners Override, Petr Hosek, CQ Bot
Attention needed from Owners Override, Petr Hosek and Roland McGrath

Leonard Chan voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
  • Petr Hosek
  • Roland McGrath
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I6b995be2e9efc88fa84e08692f135c3dbe79e866
Gerrit-Change-Number: 1027132
Gerrit-PatchSet: 2
Gerrit-Owner: Roland McGrath <mcgr...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Leonard Chan <leona...@google.com>
Gerrit-Reviewer: Marco Vanotti <mvan...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Petr Hosek <pho...@google.com>
Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Petr Hosek <pho...@google.com>
Gerrit-Attention: Roland McGrath <mcgr...@google.com>
Gerrit-Comment-Date: Mon, 15 Apr 2024 17:51:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/68f5b9e0ff8e44248e9f63864e775c2ffc64a8a3-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Roland McGrath (Gerrit)' via owners-override

unread,
Apr 19, 2024, 5:40:57 PMApr 19
to Auto-Submit, Leonard Chan, Marco Vanotti, Adam Barth, Owners Override, Petr Hosek, CQ Bot
Attention needed from Owners Override and Petr Hosek

Roland McGrath voted Fuchsia-Auto-Submit+0

Fuchsia-Auto-Submit+0
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
  • Petr Hosek
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I6b995be2e9efc88fa84e08692f135c3dbe79e866
Gerrit-Change-Number: 1027132
Gerrit-PatchSet: 3
Gerrit-Owner: Roland McGrath <mcgr...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: Leonard Chan <leona...@google.com>
Gerrit-Reviewer: Marco Vanotti <mvan...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Petr Hosek <pho...@google.com>
Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Petr Hosek <pho...@google.com>
Gerrit-Comment-Date: Fri, 19 Apr 2024 21:40:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/26231fb1f3fe956a9b23c8517f473bf1e881c4f1-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Roland McGrath (Gerrit)' via owners-override

unread,
Apr 19, 2024, 5:42:39 PMApr 19
to Auto-Submit, Leonard Chan, Marco Vanotti, Adam Barth, Owners Override, Petr Hosek, CQ Bot
Attention needed from Owners Override and Petr Hosek

Roland McGrath voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
  • Petr Hosek
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I6b995be2e9efc88fa84e08692f135c3dbe79e866
Gerrit-Change-Number: 1027132
Gerrit-PatchSet: 4
Gerrit-Owner: Roland McGrath <mcgr...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: Leonard Chan <leona...@google.com>
Gerrit-Reviewer: Marco Vanotti <mvan...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Petr Hosek <pho...@google.com>
Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Petr Hosek <pho...@google.com>
Gerrit-Comment-Date: Fri, 19 Apr 2024 21:42:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/3f042155cf81fbd708577877c54ba226e3929d78-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Apr 19, 2024, 6:58:29 PMApr 19
to Roland McGrath, Auto-Submit, Leonard Chan, Marco Vanotti, Adam Barth, Owners Override, Petr Hosek

CQ Bot submitted the change with unreviewed changes

Unreviewed changes

2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
[ubsan-custom] Skeleton for new directory //src/lib/ubsan-custom

This will be used both in multiple places in the kernel, and
eventually beyond the kernel in other specialized places.
Bug: 334165273
Change-Id: I6b995be2e9efc88fa84e08692f135c3dbe79e866
Owners-Override: Adam Barth <aba...@google.com>
Reviewed-by: Marco Vanotti <mvan...@google.com>
Reviewed-by: Adam Barth <aba...@google.com>
Commit-Queue: Roland McGrath <mcgr...@google.com>
Reviewed-by: Leonard Chan <leona...@google.com>
Files:
  • M src/lib/BUILD.gn
  • A src/lib/ubsan-custom/BUILD.gn
  • A src/lib/ubsan-custom/OWNERS
  • A src/lib/ubsan-custom/README.md
Change size: S
Delta: 4 files changed, 28 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Adam Barth, +2 by Marco Vanotti, +2 by Leonard Chan
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I6b995be2e9efc88fa84e08692f135c3dbe79e866
Gerrit-Change-Number: 1027132
Gerrit-PatchSet: 5
Gerrit-Owner: Roland McGrath <mcgr...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: Leonard Chan <leona...@google.com>
Gerrit-Reviewer: Marco Vanotti <mvan...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Petr Hosek <pho...@google.com>
Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/284c3992ebed0ee26e62c8045dabd59cc407f58c-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Apr 19, 2024, 7:02:39 PMApr 19
to CQ Bot, Roland McGrath, Auto-Submit, Leonard Chan, Marco Vanotti, Adam Barth, Owners Override, Petr Hosek

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I6b995be2e9efc88fa84e08692f135c3dbe79e866
Gerrit-Change-Number: 1027132
Gerrit-PatchSet: 5
Gerrit-Owner: Roland McGrath <mcgr...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: Leonard Chan <leona...@google.com>
Gerrit-Reviewer: Marco Vanotti <mvan...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Petr Hosek <pho...@google.com>
Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>
Gerrit-Comment-Date: Fri, 19 Apr 2024 23:02:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/6de32d3ea3877d2ef1d6731b2df72e48a81a283c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages