'Hunter Freyer (Gerrit)' via owners-override

unread,

Jul 21, 2025, 1:28:55 PMJul 21

to Owners Override

Attention needed from Owners Override

Hunter Freyer has uploaded the change for review

Hunter Freyer would like Owners Override to review this change.

Commit message

[sdk] Retire API level 16.

... Could it be? Is it really gone????

Bug: 350050052
Bug: 42157740
Bug: 42077935

Depends-on: turquoise-internal:I9ea02a45d7893ebb5b79f454aaac2103284cce5b

Change-Id: Id9861d0eaba7621ac5c14e6fd8c1f60adef1f0f0

Change diff

Change information

Files:

M sdk/fidl/fuchsia.component/fuchsia.component.api
M sdk/fidl/fuchsia.diagnostics/fuchsia.diagnostics.api
M sdk/fidl/fuchsia.driver.test/fuchsia.driver.test.api
M sdk/fidl/fuchsia.element/fuchsia.element.api
M sdk/fidl/fuchsia.gpu.magma/fuchsia.gpu.magma.api
M sdk/fidl/fuchsia.hardware.audio.signalprocessing/fuchsia.hardware.audio.signalprocessing.api
M sdk/fidl/fuchsia.hardware.audio/fuchsia.hardware.audio.api
M sdk/fidl/fuchsia.hardware.network/fuchsia.hardware.network.api
M sdk/fidl/fuchsia.images2/fuchsia.images2.api
M sdk/fidl/fuchsia.input.report/fuchsia.input.report.api
M sdk/fidl/fuchsia.net.interfaces/fuchsia.net.interfaces.api
M sdk/fidl/fuchsia.sys2/fuchsia.sys2.api
M sdk/fidl/fuchsia.sysmem/fuchsia.sysmem.api
M sdk/version_history.json
M src/connectivity/bluetooth/lib/fuchsia-audio-device/src/codec.rs
M src/connectivity/network/netstack/fuchsia_net_interfaces.go
M src/connectivity/network/netstack/fuchsia_net_interfaces_test.go
M src/connectivity/network/netstack3/src/bindings/interfaces_watcher.rs
M src/connectivity/network/tests/fidl/interfaces/src/lib.rs
M src/developer/debug/debug_agent/test_realm.cc
M src/developer/ffx/plugins/audio/device/src/serde_ext.rs
M src/developer/ffx/plugins/log/src/testing_utils.rs
M src/devices/power/drivers/nelson-brownout-protection/nelson-brownout-protection-test.cc
M src/diagnostics/archivist/src/logs/servers/log_settings.rs
M src/diagnostics/iquery/test_support/src/test_support.rs
M src/graphics/magma/lib/magma_service/sys_driver/primary_fidl_server.cc
M src/graphics/magma/lib/magma_service/sys_driver/primary_fidl_server.h
M src/lib/network/fidl_fuchsia_net_interfaces_ext/src/lib.rs
M src/lib/ui/carnelian/BUILD.gn
M src/lib/ui/carnelian/src/color.rs
M src/media/audio/drivers/aml-g12-tdm/test/stream-test.cc
M src/media/audio/drivers/codecs/da7219/da7219-server.cc
M src/media/audio/drivers/codecs/da7219/da7219-server.h
M src/media/audio/drivers/configurator/src/default.rs
M src/media/audio/drivers/testing/realm/test-codec.cc
M src/media/audio/drivers/testing/realm/test-codec2.cc
M src/media/audio/drivers/tests/admin_test.cc
M src/media/audio/drivers/virtual-audio-legacy/virtual-audio-codec.cc
M src/media/audio/drivers/virtual-audio-legacy/virtual-audio-codec.h
M src/media/audio/lib/rust/src/sigproc.rs
M src/media/audio/lib/simple-codec/include/lib/simple-codec/simple-codec-client.h
M src/media/audio/lib/simple-codec/include/lib/simple-codec/simple-codec-server-internal.h
M src/media/audio/lib/simple-codec/include/lib/simple-codec/simple-codec-server.h
M src/media/audio/lib/simple-codec/simple-codec-client.cc
M src/media/audio/lib/simple-codec/simple-codec-server.cc
M src/media/audio/lib/simple-codec/tests/test.cc
M src/media/audio/services/device_registry/testing/fake_codec.h
M src/sys/component_manager/lib/hooks/src/lib.rs
M src/sys/component_manager/src/framework/realm_query.rs
M src/sys/lib/component-events/src/events.rs
M src/sys/lib/component_debug/src/realm.rs
M src/sys/lib/component_debug/src/test_utils.rs
M src/sysmem/server/buffer_collection.cc
M src/sysmem/server/buffer_collection.h
M src/testing/end_to_end/honeydew/honeydew/affordances/connectivity/netstack/types.py

Change size: L

Delta: 55 files changed, 20 insertions(+), 372 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Owners Override

Submit Requirements:

API-Review
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/123fd9806ea71403fecb106edaa109ba6fa94972-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

unsatisfied_requirement

open

diffy

'Hunter Freyer (Gerrit)' via owners-override

unread,

Jul 21, 2025, 1:28:56 PMJul 21

to Owners Override, David Dorwin, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, GI Try Builder, CQ Bot

Attention needed from Owners Override

Hunter Freyer voted and added 3 comments

Votes added by Hunter Freyer

API-Review	+1
Commit-Queue	+1
Fuchsia-Auto-Submit	+1

3 comments

Commit Message

Line 11, Patchset 4:Bug: 350050052

David Dorwin . resolved

Also addresses parts of 42157740, 42077935.

Hunter Freyer

Done

File src/connectivity/network/netstack3/src/bindings/interfaces_watcher.rs

Line 996, Patchset 4:

/// A helper to convert to the backing FIDL type, while maintaining
/// backwards compatibility of removed fields.
trait IntoFidlBackwardsCompatible<F> {
    fn into_fidl_backwards_compatible(self) -> F;
}

// TODO(https://fxbug.dev/42157740): Remove this implementation.
impl<I: finterfaces_ext::FieldInterests> IntoFidlBackwardsCompatible<finterfaces::Properties>
    for finterfaces_ext::Properties<I>
{
    fn into_fidl_backwards_compatible(self) -> finterfaces::Properties {
        finterfaces::Properties { ..finterfaces::Properties::from(self) }
    }
}

David Dorwin . resolved

Can the whole thing be removed?

Hunter Freyer

Probably, but I tried and it wasn't trivial.

File src/sys/lib/component_debug/src/realm.rs

Line 367, Patchset 4: // TODO(https://fxbug.dev/42077935) switch to get_resolved_declaration once OK for ffx compat

David Dorwin . resolved

Delete

Hunter Freyer

Done

Open in Gerrit

Related details

Attention is currently required from:

Owners Override

Submit Requirements:

API-Review
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/123fd9806ea71403fecb106edaa109ba6fa94972-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

unsatisfied_requirement

open

diffy

'Adam Barth (Gerrit)' via owners-override

unread,

Jul 21, 2025, 1:48:51 PMJul 21

to Hunter Freyer, Owners Override, David Dorwin, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, GI Try Builder, CQ Bot

Attention needed from Hunter Freyer and Owners Override

Adam Barth voted Owners-Override+1

Owners-Override

+1

Open in Gerrit

Related details

Attention is currently required from:

Hunter Freyer
Owners Override

Submit Requirements:

API-Review
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/53da5cfc057d9a62292a3a2af0edb6d477c06f8f-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'CQ Bot (Gerrit)' via owners-override

unread,

Jul 21, 2025, 3:41:35 PMJul 21

to Hunter Freyer, Adam Barth, Owners Override, David Dorwin, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, GI Try Builder

CQ Bot submitted the change with unreviewed changes

Unreviewed changes

4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/sys/lib/component_debug/src/realm.rs
Insertions: 0, Deletions: 1.

@@ -364,7 +364,6 @@
     realm_query: &fsys::RealmQueryProxy,
 ) -> Result<ComponentDecl, GetDeclarationError> {
     let moniker_str = moniker.to_string();
-    // TODO(https://fxbug.dev/42077935) switch to get_resolved_declaration once OK for ffx compat
     let iterator = match realm_query.get_resolved_declaration(&moniker_str).await? {
         Ok(iterator) => Ok(iterator),
         Err(fsys::GetDeclarationError::InstanceNotFound) => {
```

Change information

Commit message:

[sdk] Retire API level 16.

... Could it be? Is it really gone????

Bug: 350050052
Bug: 42157740
Bug: 42077935

Depends-on: turquoise-internal:I9ea02a45d7893ebb5b79f454aaac2103284cce5b

Change-Id: Id9861d0eaba7621ac5c14e6fd8c1f60adef1f0f0

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1325651

API-Review: Hunter Freyer <hjfr...@google.com>

Reviewed-by: David Dorwin <ddo...@google.com>

Fuchsia-Auto-Submit: Hunter Freyer <hjfr...@google.com>

Owners-Override: Adam Barth <aba...@google.com>

Commit-Queue: Hunter Freyer <hjfr...@google.com>

Branch: refs/heads/main

Submit Requirements:

API-Review: +1 by Hunter Freyer
Code-Review: +2 by David Dorwin

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/592472fca9305f146105570bb539cbf168c57449-HTML%40fuchsia-review.googlesource.com.

open

diffy

satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,

Jul 21, 2025, 3:45:19 PMJul 21

to Hunter Freyer, CQ Bot, Adam Barth, Owners Override, David Dorwin, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, GI Try Builder

Message from GI Roller

Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1019924

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

API-Review

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/bc657920b6b9ce5a4aecc04547526718247a643e-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[L] Change in fuchsia/fuchsia[main]: [sdk] Retire API level 16.

'Hunter Freyer (Gerrit)' via owners-override

Hunter Freyer has uploaded the change for review

Commit message

Change diff

Change information

Related details

'Hunter Freyer (Gerrit)' via owners-override

Hunter Freyer voted and added 3 comments

Votes added by Hunter Freyer

3 comments

Related details

'Adam Barth (Gerrit)' via owners-override

Adam Barth voted Owners-Override+1

Related details

'CQ Bot (Gerrit)' via owners-override

CQ Bot submitted the change with unreviewed changes

Unreviewed changes

Change information

'GI Roller (Gerrit)' via owners-override

Message from GI Roller

Related details