[XL] Change in fuchsia/fuchsia[main]: [fuchsia-component-test] Use generic return type

1 view
Skip to first unread message

'Chris Suter (Gerrit)' via owners-override

unread,
Jun 10, 2025, 8:27:00 PM6/10/25
to Owners Override
Attention needed from Owners Override

Chris Suter has uploaded the change for review

Chris Suter would like Owners Override to review this change.

Commit message

[fuchsia-component-test] Use generic return type

Use generic return type for connect_to_protocol_at_exposed_dir.

This allows it to be used for asynchronous proxies, synchronous proxies
and ClientEnd<...> and allows type inference to work.
Change-Id: I267e7da0e548b53b99131f452f5dd7606efc0c04
Depends-on: turquoise-internal:Iaf760bf6751ecae64878d03df484be00dcd3450b

Change diff


Change information

Files:
  • M examples/components/realm_builder/rust/src/lib.rs
  • M examples/components/runner/colocated/integration_tests/src/lib.rs
  • M examples/diagnostics/inspect/codelab/rust/testing/src/lib.rs
  • M examples/drivers/simple/rust/realm_test.rs
  • M examples/drivers/transport/zircon/rust/realm_test.rs
  • M examples/power/optimistic_lease_management/src/test.rs
  • M examples/power/suspend_config/rust/src/power_config_client_integration_test.rs
  • M sdk/lib/driver_test_realm/realm_builder/rust/src/lib.rs
  • M sdk/lib/driver_test_realm/tests/test.rs
  • M src/connectivity/bluetooth/testing/bt-test-harness/src/access.rs
  • M src/connectivity/bluetooth/testing/bt-test-harness/src/bootstrap.rs
  • M src/connectivity/bluetooth/testing/bt-test-harness/src/host_realm.rs
  • M src/connectivity/bluetooth/testing/bt-test-harness/src/host_watcher.rs
  • M src/connectivity/bluetooth/testing/bt-test-harness/src/inspect.rs
  • M src/connectivity/bluetooth/testing/bt-test-harness/src/low_energy_central.rs
  • M src/connectivity/bluetooth/testing/bt-test-harness/src/low_energy_peripheral.rs
  • M src/connectivity/bluetooth/testing/bt-test-harness/src/profile.rs
  • M src/connectivity/bluetooth/testing/mock-piconet-server/src/lib.rs
  • M src/connectivity/bluetooth/tests/bt-manifest-integration-tests/src/bt_a2dp_smoke_test.rs
  • M src/connectivity/bluetooth/tests/bt-manifest-integration-tests/src/bt_avrcp_smoke_test.rs
  • M src/connectivity/bluetooth/tests/bt-manifest-integration-tests/src/bt_avrcp_target_smoke_test.rs
  • M src/connectivity/bluetooth/tests/bt-manifest-integration-tests/src/bt_gap_smoke_test.rs
  • M src/connectivity/bluetooth/tests/bt-manifest-integration-tests/src/bt_hfp_audio_gateway_smoke_test.rs
  • M src/connectivity/bluetooth/tests/bt-manifest-integration-tests/src/bt_init_smoke_test.rs
  • M src/connectivity/bluetooth/tests/bt-manifest-integration-tests/src/bt_rfcomm_smoke_test.rs
  • M src/connectivity/location/regulatory_region/tests/src/lib.rs
  • M src/connectivity/network/tests/iptables/BUILD.gn
  • M src/connectivity/network/tests/iptables/src/lib.rs
  • M src/connectivity/policy/http-client/integration/src/lib.rs
  • M src/connectivity/policy/netcfg/src/dns.rs
  • M src/connectivity/policy/socket-proxy/integration/src/lib.rs
  • M src/connectivity/policy/socket-proxy/src/dns_watcher.rs
  • M src/connectivity/policy/socket-proxy/src/registry.rs
  • M src/devices/interconnect/drivers/interconnect/integration_test.rs
  • M src/devices/tests/driver-development/test.rs
  • M src/devices/tests/driver-register/test.rs
  • M src/devices/tests/v2/index_stop_idle/test.rs
  • M src/devices/tests/v2/reload-driver-nested-composite/test.rs
  • M src/devices/tests/v2/reload-driver/test.rs
  • M src/devices/tests/v2/replace-driver/test.rs
  • M src/devices/tests/v2/replace-failed-driver/test.rs
  • M src/devices/tests/v2/restart-on-crash/test.rs
  • M src/diagnostics/archivist/bench/src/logging_e2e.rs
  • M src/diagnostics/iquery/src/tests/utils.rs
  • M src/diagnostics/persistence/tests/lib.rs
  • M src/diagnostics/validator/logs/sink/src/main.rs
  • M src/factory/factoryctl/src/main.rs
  • M src/fonts/tests/integration/BUILD.gn
  • M src/fonts/tests/integration/src/old_api/mod.rs
  • M src/fonts/tests/integration/src/util.rs
  • M src/intl/time_zone_info_service/tests/src/tests.rs
  • M src/lib/diagnostics/log/rust/src/fuchsia/mod.rs
  • M src/lib/diagnostics/reader/rust/BUILD.gn
  • M src/lib/diagnostics/reader/rust/src/lib.rs
  • M src/lib/fidl/rust/fidl-contrib/src/protocol_connector.rs
  • M src/lib/fuchsia-component-test/src/lib.rs
  • M src/lib/fuchsia-component-test/src/local_component_runner.rs
  • M src/lib/fuchsia-component-test/tests/BUILD.gn
  • M src/lib/fuchsia-component-test/tests/offered_cap_passthrough/lib.rs
  • M src/lib/fuchsia-component-test/tests/scoped_instance/lib.rs
  • M src/lib/fuchsia-component-test/tests/scoped_instance/realm.rs
  • M src/lib/fuchsia-component-test/tests/src/arbitrary_realm_test.rs
  • M src/lib/fuchsia-component-test/tests/src/lib.rs
  • M src/media/sessions/src/test/integration.rs
  • M src/power/broker/client/tests/integration/src/main.rs
  • M src/power/broker/tests/integration/src/main.rs
  • M src/power/power-manager/integration/lib/src/lib.rs
  • M src/power/shutdown-shim/tests/src/main.rs
  • M src/power/shutdown-shim/tests/src/reboot_watcher_client.rs
  • M src/power/system-activity-governor-controller/tests/src/lib.rs
  • M src/power/system-activity-governor/fake/tests/src/lib.rs
  • M src/power/testing/client/rust/tests/src/lib.rs
  • M src/power/testing/topology-test-daemon/tests/src/lib.rs
  • M src/session/tests/session_manager/src/main.rs
  • M src/settings/service/integration_tests/accessibility_tests/src/common.rs
  • M src/settings/service/integration_tests/audio_tests/src/common.rs
  • M src/settings/service/integration_tests/display_tests/src/common.rs
  • M src/settings/service/integration_tests/do_not_disturb_tests/lib.rs
  • M src/settings/service/integration_tests/earcons_tests/src/common.rs
  • M src/settings/service/integration_tests/factory_reset_tests/src/common.rs
  • M src/settings/service/integration_tests/hanging_get_tests/src/common.rs
  • M src/settings/service/integration_tests/input_tests/src/common.rs
  • M src/settings/service/integration_tests/intl_tests/src/common.rs
  • M src/settings/service/integration_tests/keyboard_tests/src/common.rs
  • M src/settings/service/integration_tests/light_tests/src/light_realm.rs
  • M src/settings/service/integration_tests/night_mode_tests/src/common.rs
  • M src/settings/service/integration_tests/privacy_tests/src/common.rs
  • M src/settings/service/integration_tests/setup_tests/src/common.rs
  • M src/starnix/tests/memory_attribution/main.rs
  • M src/starnix/tests/psi/src/puppet.rs
  • M src/starnix/tests/reboot/src/test_runner.rs
  • M src/starnix/tests/remotevol/stat/src/stat_locked_file_test.rs
  • M src/starnix/tests/remotevol/symlinks/src/locked_symlink_test.rs
  • M src/starnix/tests/scheduler/role_manager/src/main.rs
  • M src/starnix/tests/suspend/src/test_runner.rs
  • M src/storage/benchmarks/fuchsia/src/filesystems/pkgdir.rs
  • M src/storage/fshost/integration/src/disk_builder.rs
  • M src/storage/fshost/integration/src/lib.rs
  • M src/storage/fshost/integration/tests/corrupt.rs
  • M src/storage/fshost/integration/tests/fshost_integration_test.rs
  • M src/storage/fshost/integration/tests/wipe_storage.rs
  • M src/storage/fshost/integration/tests/write_data_file.rs
  • M src/storage/stress-tests/genericfs/BUILD.gn
  • M src/storage/stress-tests/genericfs/environment.rs
  • M src/sys/component_manager/stress_tests/lib.rs
  • M src/sys/component_manager/tests/abi_compatibility/src/integration_test.rs
  • M src/sys/component_manager/tests/attributed_logging/e2e-test.rs
  • M src/sys/component_manager/tests/builtin_dispatcher_component/builtin_dispatcher_component.rs
  • M src/sys/component_manager/tests/builtin_runner/builtin_runner_test.rs
  • M src/sys/component_manager/tests/controller/src/lib.rs
  • M src/sys/component_manager/tests/crash_introspect/crash_introspect_test.rs
  • M src/sys/component_manager/tests/destruction/integration_test.rs
  • M src/sys/component_manager/tests/diagnostics/integration_test.rs
  • M src/sys/component_manager/tests/dynamic_offers/integration_test.rs
  • M src/sys/component_manager/tests/elf_runner/elf_runner_test.rs
  • M src/sys/component_manager/tests/events/BUILD.gn
  • M src/sys/component_manager/tests/events/integration_test.rs
  • M src/sys/component_manager/tests/exit_code/integration_test.rs
  • M src/sys/component_manager/tests/fuchsia_boot_resolver/src/resolve_bootfs_package.rs
  • M src/sys/component_manager/tests/introspector/src/main.rs
  • M src/sys/component_manager/tests/lifecycle_benchmark/src/main.rs
  • M src/sys/component_manager/tests/namespace_capabilities/BUILD.gn
  • M src/sys/component_manager/tests/namespace_capabilities/integration_test.rs
  • M src/sys/component_manager/tests/ota_health_verification/integration_test.rs
  • M src/sys/component_manager/tests/resolvers/boot/src/integration_test.rs
  • M src/sys/component_manager/tests/rights/rights_integration_test.rs
  • M src/sys/component_manager/tests/security_policy/util/lib.rs
  • M src/sys/component_manager/tests/services/src/service_routing_test.rs
  • M src/sys/component_manager/tests/stop_with_escrow/stop_with_escrow_integration_test.rs
  • M src/sys/component_manager/tests/storage/BUILD.gn
  • M src/sys/component_manager/tests/storage/integration_test.rs
  • M src/sys/component_manager/tests/structured_config/parent_overrides/integration_test.rs
  • M src/sys/component_manager/tests/utc-time/BUILD.gn
  • M src/sys/component_manager/tests/utc-time/integration_test.rs
  • M src/sys/lib/elf_runner/BUILD.gn
  • M src/sys/lib/elf_runner/tests/lifecycle/component_exit.rs
  • M src/sys/lib/elf_runner/tests/stdout/src/lib.rs
  • M src/sys/pkg/bin/pkg-resolver/src/component_resolver.rs
  • M src/sys/pkg/lib/isolated-swd/src/cache.rs
  • M src/sys/pkg/lib/isolated-swd/src/updater.rs
  • M src/sys/pkg/tests/isolated-ota/BUILD.gn
  • M src/sys/pkg/tests/isolated-ota/src/lib.rs
  • M src/sys/pkg/tests/omaha-client/src/lib.rs
  • M src/sys/pkg/tests/pkg-cache-as-base-resolver/using-realm-builder/src/lib.rs
  • M src/sys/pkg/tests/pkg-cache/src/inspect.rs
  • M src/sys/pkg/tests/pkg-cache/src/lib.rs
  • M src/sys/pkg/tests/pkg-resolver/src/lib.rs
  • M src/sys/pkg/tests/system-update-checker/src/lib.rs
  • M src/sys/pkg/tests/system-update-committer/src/lib.rs
  • M src/sys/pkg/tests/system-updater/src/lib.rs
  • M src/sys/run_test_suite/tests/test_data/BUILD.gn
  • M src/sys/run_test_suite/tests/test_data/logspam.rs
  • M src/sys/test_manager/src/debug_data_processor.rs
  • M src/sys/test_manager/src/resolver.rs
  • M src/sys/test_manager/src/running_suite.rs
  • M src/sys/test_manager/tests/diagnostics_tests/BUILD.gn
  • M src/sys/test_manager/tests/diagnostics_tests/main.rs
  • M src/sys/test_runners/inspect/tests/main.rs
  • M src/sys/time/testing/lib/lib.rs
  • M src/ui/bin/text/tests/keyboard3.rs
  • M src/ui/tests/integration_input_tests/factory-reset-handler/src/lib.rs
  • M src/ui/tests/integration_input_tests/interaction-state/src/lib.rs
  • M src/ui/tests/scenic-stress-tests/src/flatland_environment.rs
  • M src/ui/tests/scenic-stress-tests/src/flatland_instance.rs
  • M src/virtualization/bin/vmm_launcher/tests/integration.rs
Change size: XL
Delta: 165 files changed, 707 insertions(+), 979 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedDependencies-Satisfied
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I267e7da0e548b53b99131f452f5dd7606efc0c04
Gerrit-Change-Number: 1294247
Gerrit-PatchSet: 6
Gerrit-Owner: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Claire Gonyeo <cgo...@google.com>
Gerrit-Reviewer: Marie Janssen <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/1f2bebf48a611a389a4e2ac8e422dc391289ea6b-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
unsatisfied_requirement
open
diffy

'Chris Suter (Gerrit)' via owners-override

unread,
Jun 10, 2025, 8:27:12 PM6/10/25
to Owners Override, Marie Janssen, Claire Gonyeo, GI Try Builder, CQ Bot, CL Deps Checker
Attention needed from Owners Override

Chris Suter voted

Commit-Queue+1
Fuchsia-Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedDependencies-Satisfied
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I267e7da0e548b53b99131f452f5dd7606efc0c04
Gerrit-Change-Number: 1294247
Gerrit-PatchSet: 6
Gerrit-Owner: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Claire Gonyeo <cgo...@google.com>
Gerrit-Reviewer: Marie Janssen <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Wed, 11 Jun 2025 00:26:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/1f2bebf48a611a389a4e2ac8e422dc391289ea6b-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
unsatisfied_requirement
open
diffy

'Hunter Freyer (Gerrit)' via owners-override

unread,
Jun 11, 2025, 10:57:59 AM6/11/25
to Chris Suter, Owners Override, Marie Janssen, Claire Gonyeo, GI Try Builder, CQ Bot, CL Deps Checker
Attention needed from Chris Suter and Owners Override

Hunter Freyer voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Chris Suter
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement is not satisfiedDependencies-Satisfied
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I267e7da0e548b53b99131f452f5dd7606efc0c04
Gerrit-Change-Number: 1294247
Gerrit-PatchSet: 6
Gerrit-Owner: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Claire Gonyeo <cgo...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Marie Janssen <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Chris Suter <csu...@google.com>
Gerrit-Comment-Date: Wed, 11 Jun 2025 14:57:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9555a235033d1e7cab15762650c79ab957e5fe55-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
unsatisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Jun 11, 2025, 7:55:33 PM6/11/25
to Chris Suter, CL Deps Checker, Hunter Freyer, Owners Override, Marie Janssen, Claire Gonyeo, GI Try Builder

CQ Bot submitted the change

Unreviewed changes

5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
[fuchsia-component-test] Use generic return type

Use generic return type for connect_to_protocol_at_exposed_dir.

This allows it to be used for asynchronous proxies, synchronous proxies
and ClientEnd<...> and allows type inference to work.
Change-Id: I267e7da0e548b53b99131f452f5dd7606efc0c04
Depends-on: turquoise-internal:Iaf760bf6751ecae64878d03df484be00dcd3450b
Commit-Queue: Chris Suter <csu...@google.com>
Reviewed-by: Marie Janssen <jam...@google.com>
Owners-Override: Hunter Freyer <hjfr...@google.com>
Reviewed-by: Claire Gonyeo <cgo...@google.com>
Fuchsia-Auto-Submit: Chris Suter <csu...@google.com>
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Marie Janssen, +2 by Claire Gonyeo
  • requirement satisfiedDependencies-Satisfied: +1 by CL Deps Checker
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I267e7da0e548b53b99131f452f5dd7606efc0c04
Gerrit-Change-Number: 1294247
Gerrit-PatchSet: 7
Gerrit-Owner: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Claire Gonyeo <cgo...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Marie Janssen <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f162f369c12066938aed6160e16a93b95dfbcc0e-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Jun 11, 2025, 8:01:24 PM6/11/25
to Chris Suter, CQ Bot, CL Deps Checker, Hunter Freyer, Owners Override, Marie Janssen, Claire Gonyeo, GI Try Builder

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedDependencies-Satisfied
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I267e7da0e548b53b99131f452f5dd7606efc0c04
Gerrit-Change-Number: 1294247
Gerrit-PatchSet: 7
Gerrit-Owner: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Claire Gonyeo <cgo...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Marie Janssen <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Thu, 12 Jun 2025 00:01:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/73cd1197d40127ec30d458014f65a3bee850d4d2-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages