Groups keyboard shortcuts have been updated
Dismiss
See shortcuts
[M] Change in fuchsia/fuchsia[main]: [shac] Format all *.fidl except *.noformat.test.fidl
0 views
Skip to first unread message
'Mitchell Kember (Gerrit)' via owners-override
Mar 28, 2024, 4:58:25 PM3/28/24
to Owners Override, Auto-Submit, Oliver Newman, CQ Bot, Clayton Wilkinson
Attention needed from Clayton Wilkinson and Owners Override
Mitchell Kember voted Fuchsia-Auto-Submit+1![]( "Open in Gerrit")
| Fuchsia-Auto-Submit | +1 |
Related details
Attention is currently required from:
- Clayton Wilkinson
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/ec2a4a2176070455fe1cc4521e3a317776aa548a-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
'Mitchell Kember (Gerrit)' via owners-override
Mar 28, 2024, 4:58:25 PM3/28/24
to Owners Override, Ian McKellar
Attention needed from Clayton Wilkinson and Owners Override
Mitchell Kember has uploaded the change for review![]( "Open in Gerrit")
Mitchell Kember would like Owners Override to review this change.
Mitchell Kember removed Ian McKellar from reviewers of this change.
Commit message
[shac] Format all *.fidl except *.noformat.test.fidl
This makes the FIDL shac rule only skip formatting *.noformat.test.fidl
files. Previously it skipped all *.test.fidl files. This was too broad,
since there are many test FIDL files and only a minority of them
specifically test parsing/lexing failures.
Id9c776b3895ad581543bc87702ed02a0425c6878 was the change that started
skipping formatting for all *.test.fidl files.
The motivation for this was running fx regen_fidl_benchmark_suite and
realizing fx format-code no longer formatted its results, as we
previously relied on.
Test: git ls-files '*.fidl' | xargs -d ',' -I% fx format-code --files=%
Change-Id: Ic5886f433fa85208e9c3348d715dc796ed1f7b8a
Change diff
Change information
Files:
- M scripts/shac/fidl.star
- M sdk/fidl/fuchsia.io.test/io.test.fidl
- M src/developer/ffx/lib/fuchsia-controller/fidl/fuchsia_controller_other.test.fidl
- M src/devices/tests/fidl-service/echo.test.fidl
- M src/diagnostics/archivist/testing/fidl/puppet.test.fidl
- M src/power/system-activity-governor/integration/testing/fidl/realm_factory.test.fidl
- M src/storage/benchmarks/verity/src/test.fxfs.test.fidl
- M src/sys/component_manager/tests/structured_config/capabilities/dynamic/config.test.fidl
- M src/sys/time/testing/fidl/test.time.realm/push_source_puppet.test.fidl
- M src/sys/time/testing/fidl/test.time.realm/rtc_updates.test.fidl
- M src/zircon/bin/role_manager/testing/fidl/realm_factory.test.fidl
- M tools/fidl/fidlc/tests/attributes_tests.cc
- M tools/fidl/fidlc/tests/errors_tests.cc
- R tools/fidl/fidlc/tests/fidl/bad/fi-0001.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0002.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0003.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0004.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0006.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0007.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0008.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0009.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0010-a.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0010-b.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0011.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0012.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0013.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0014.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0015.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0016-a.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0016-b.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0017-a.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0017-b.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0018.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0020.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0022.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0023.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0024.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0025.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0026.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0027.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0028.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0029.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0030.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0031.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0032.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0033.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0163.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0184.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0185.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0186.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0187.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0188.noformat.test.fidl
- R tools/fidl/fidlc/tests/fidl/bad/fi-0189.noformat.test.fidl
- M tools/fidl/fidlc/tests/fidl/bad/files.txt
- M tools/fidl/fidlc/tests/parsing_tests.cc
- M tools/fidl/fidlc/tests/protocol_tests.cc
- M tools/fidl/fidlc/tests/recoverable_parsing_tests.cc
- M tools/fidl/fidlc/tests/resource_tests.cc
- M tools/fidl/fidlc/tests/strictness_tests.cc
- M tools/fidl/fidlc/tests/table_tests.cc
- M tools/fidl/fidlc/tests/union_tests.cc
- M tools/fidl/scripts/add_errcat_entry.py
- M tools/testgen/testdata/goldens/integration_test/testing/fidl/realm_factory.test.fidl
Change size: M
Delta: 63 files changed, 115 insertions(+), 121 deletions(-)
Related details
Attention is currently required from:
- Clayton Wilkinson
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/ec2a4a2176070455fe1cc4521e3a317776aa548a-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Hunter Freyer (Gerrit)' via owners-override
Mar 28, 2024, 4:59:30 PM3/28/24
to Mitchell Kember, Owners Override, Auto-Submit, Oliver Newman, CQ Bot, Clayton Wilkinson
Attention needed from Clayton Wilkinson, Mitchell Kember and Owners Override
Hunter Freyer voted Owners-Override+1![]( "Open in Gerrit")
Attention is currently required from:
- Clayton Wilkinson
- Mitchell Kember
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9438dfae9fc5affff2e8fb84c7fef71efc354dff-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Hunter Freyer (Gerrit)' via owners-override
Mar 29, 2024, 9:40:16 AM3/29/24
to Mitchell Kember, Auto-Submit, Owners Override, Oliver Newman, CQ Bot, Clayton Wilkinson
Attention needed from Clayton Wilkinson, Mitchell Kember and Owners Override
Hunter Freyer voted Owners-Override+1![]( "Open in Gerrit")
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Clayton Wilkinson
- Mitchell Kember
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/71f69aff2c2921980c841e6c63c9f780d875c3c9-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Mitchell Kember (Gerrit)' via owners-override
Mar 29, 2024, 12:02:13 PM3/29/24
to Auto-Submit, Hunter Freyer, Owners Override, Oliver Newman, CQ Bot, Clayton Wilkinson
Attention needed from Clayton Wilkinson and Owners Override
Mitchell Kember voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Clayton Wilkinson
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9b26ca1488630509b740ad42c9741238c075af09-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Fuchsia Try Builder (Gerrit)' via owners-override
Mar 29, 2024, 12:53:36 PM3/29/24
to Mitchell Kember, Auto-Submit, Hunter Freyer, Owners Override, Oliver Newman, CQ Bot, Clayton Wilkinson
Attention needed from Clayton Wilkinson, Mitchell Kember and Owners Override
Message from Fuchsia Try Builder![]( "Open in Gerrit")
A builder created multiplier shards. Click the following link for more details: https://ci.chromium.org/b/8752113720220304913
Related details
Attention is currently required from:
- Clayton Wilkinson
- Mitchell Kember
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/6cf281f8b88d2f8b06af9db11e402ee6e46e2a66-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
Mar 29, 2024, 1:07:59 PM3/29/24
to Mitchell Kember, Fuchsia Try Builder, Auto-Submit, Hunter Freyer, Owners Override, Oliver Newman, Clayton Wilkinson
CQ Bot submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/devices/tests/fidl-service/echo.test.fidl
Insertions: 0, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/storage/benchmarks/verity/src/test.fxfs.test.fidl
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/sys/time/testing/fidl/test.time.realm/rtc_updates.test.fidl
Insertions: 12, Deletions: 16.
The diff is too large to show. Please review the diff.
```
```
The name of the file: tools/testgen/testdata/goldens/integration_test/testing/fidl/realm_factory.test.fidl
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/power/system-activity-governor/integration/testing/fidl/realm_factory.test.fidl
Insertions: 2, Deletions: 2.
The diff is too large to show. Please review the diff.
```
```
The name of the file: tools/testgen/templates/integration_test/testing/fidl/realm_factory.test.fidl.hbrs
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/developer/ffx/lib/fuchsia-controller/fidl/fuchsia_controller_other.test.fidl
Insertions: 3, Deletions: 3.
The diff is too large to show. Please review the diff.
```
```
The name of the file: sdk/fidl/fuchsia.io.test/io.test.fidl
Insertions: 9, Deletions: 9.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/sys/component_manager/tests/structured_config/capabilities/dynamic/config.test.fidl
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/zircon/bin/role_manager/testing/fidl/realm_factory.test.fidl
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/diagnostics/archivist/testing/fidl/puppet.test.fidl
Insertions: 2, Deletions: 2.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/sys/time/testing/fidl/test.time.realm/push_source_puppet.test.fidl
Insertions: 0, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[shac] Format all *.fidl except *.noformat.test.fidl
This makes the FIDL shac rule only skip formatting *.noformat.test.fidl
files. Previously it skipped all *.test.fidl files. This was too broad,
since there are many test FIDL files and only a minority of them
specifically test parsing/lexing failures.
Id9c776b3895ad581543bc87702ed02a0425c6878 was the change that started
skipping formatting for all *.test.fidl files.
The motivation for this was running fx regen_fidl_benchmark_suite and
realizing fx format-code no longer formatted its results, as we
previously relied on.
Test: fx format-code --files=$(git ls-files '*.fidl' | tr '\n' ',')
Multiply: fuchsia-pkg://fuchsia.com/verity-benchmarks#meta/storage-verity-benchmarks.cm: 1
Change-Id: Ic5886f433fa85208e9c3348d715dc796ed1f7b8a
Fuchsia-Auto-Submit: Mitchell Kember <mke...@google.com>
Commit-Queue: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Owners-Override: Hunter Freyer <hjfr...@google.com>
Reviewed-by: Oliver Newman <oliver...@google.com>
Files:
- M tools/testgen/templates/integration_test/testing/fidl/realm_factory.test.fidl.hbrs
- M tools/testgen/testdata/goldens/integration_test/testing/fidl/realm_factory.test.fidl
Change size: M
Delta: 64 files changed, 116 insertions(+), 122 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by Oliver Newman
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/4b1e9fd3657416b15661c49a8e2f8938632045b0-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Mar 29, 2024, 1:12:58 PM3/29/24
to CQ Bot, Mitchell Kember, Fuchsia Try Builder, Auto-Submit, Hunter Freyer, Owners Override, Oliver Newman, Clayton Wilkinson
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: http://go/roll-cl/40928332933ca42f8b57f4fd9a2bf1472214bb27
Related details
Attention set is empty
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/4a677b7e5f373c2e8416ff2b34d9a68b54981a48-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages