[M] Change in fuchsia/fuchsia[main]: [fuchsia.io] Make Symlinks support Open
0 views
Skip to first unread message
'Chris Suter (Gerrit)' via owners-override
Mar 25, 2026, 11:12:46 PM (5 days ago) Mar 25
to Owners Override
Attention needed from Benjamin Lerman and Owners Override
Chris Suter has uploaded the change for review![]( "Open in Gerrit")
Chris Suter would like Owners Override to review this change.
Commit message
[fuchsia.io] Make Symlinks support Open
To support pipelined open requests, change Symlink to support Open in
case the symlink target happens to be a directory. This allows a
pipelined Open request to be sent to a node where it might be a
directory or a symlink. If it's a symlink, the server will just close
the object argument, but it will keep the connection to the symlink
open.
Bug: 1547382
Change-Id: Ib578ae0f22900064121b704b6b663f07a62e58e7
Change diff
Change information
Files:
- M sdk/fidl/fuchsia.io/BUILD.bazel
- M sdk/fidl/fuchsia.io/BUILD.gn
- M sdk/fidl/fuchsia.io/directory.fidl
- M sdk/fidl/fuchsia.io/fuchsia.io.api
- A sdk/fidl/fuchsia.io/openable.fidl
- M sdk/fidl/fuchsia.io/symlink.fidl
- M sdk/history/NEXT/fuchsia.io.api_summary.json
- M src/developer/adb/bin/adb-file-sync/adb-file-sync-test.cc
- M src/developer/debug/debug_agent/testing/runtime_dir_helper.cc
- M src/lib/fidl_codec/builtin_semantic.h
- M src/lib/fidl_codec/builtin_semantic_test.cc
- M src/storage/lib/vfs/cpp/connection/directory_connection.cc
- M src/storage/lib/vfs/cpp/remote_dir.cc
- M src/storage/lib/vfs/cpp/remote_dir.h
- M src/storage/lib/vfs/cpp/vnode.cc
- M src/storage/lib/vfs/cpp/vnode.h
- M src/storage/lib/vfs/rust/src/symlink.rs
- M src/tests/end_to_end/fidlcat/fidlcat_e2e_tests.py
- M src/ui/lib/escher/shaders/util/spirv_file_util.cc
- M src/ui/lib/escher/vk/shader_module_template.cc
- M src/ui/scenic/lib/utils/escher_provider.cc
Change size: M
Delta: 21 files changed, 156 insertions(+), 53 deletions(-)
Related details
Attention is currently required from:
- Benjamin Lerman
- Owners Override
Submit Requirements:
API-Review
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/aaf895b599aa4c92ada74f9dca64ab086406def2-HTML%40fuchsia-review.googlesource.com.
'Benjamin Lerman (Gerrit)' via owners-override
Mar 26, 2026, 4:24:59 AM (5 days ago) Mar 26
to Chris Suter, Owners Override, Adam Barth, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, GI Try Builder, CQ Bot
Attention needed from Chris Suter and Owners Override
Benjamin Lerman voted Code-Review+2![]( "Open in Gerrit")
Attention is currently required from:
- Chris Suter
- Owners Override
Submit Requirements:
API-Review
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/502284a4691a5a735abff8723990d9bb6721af25-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Benjamin Lerman (Gerrit)' via owners-override
Mar 26, 2026, 4:25:39 AM (5 days ago) Mar 26
to Chris Suter, Owners Override, Adam Barth, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, GI Try Builder, CQ Bot
Attention needed from Chris Suter and Owners Override
Benjamin Lerman voted Owners-Override+1![]( "Open in Gerrit")
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Chris Suter
- Owners Override
Submit Requirements:
API-Review
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c83b1a63caecb4a73d155918384b3d4c850d5a95-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Chris Suter (Gerrit)' via owners-override
Mar 26, 2026, 4:59:10 AM (5 days ago) Mar 26
to Benjamin Lerman, Owners Override, Adam Barth, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, GI Try Builder, CQ Bot
Attention needed from Owners Override
Chris Suter voted Fuchsia-Auto-Submit+1![]( "Open in Gerrit")
Attention is currently required from:
- Owners Override
Submit Requirements:
API-Review
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/d42bbe4622019cc5f875c1ebe1880613c37588e9-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
Mar 26, 2026, 5:00:04 AM (5 days ago) Mar 26
to Chris Suter, Benjamin Lerman, Owners Override, Adam Barth, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, GI Try Builder
CQ Bot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[fuchsia.io] Make Symlinks support Open
To support pipelined open requests, change Symlink to support Open in
case the symlink target happens to be a directory. This allows a
pipelined Open request to be sent to a node where it might be a
directory or a symlink. If it's a symlink, the server will just close
the object argument, but it will keep the connection to the symlink
open.
Bug: 1547382
Change-Id: Ib578ae0f22900064121b704b6b663f07a62e58e7
Reviewed-by: Benjamin Lerman <q...@google.com>
Reviewed-by: Adam Barth <aba...@google.com>
Commit-Queue: Chris Suter <csu...@google.com>
API-Review: Adam Barth <aba...@google.com>
Owners-Override: Benjamin Lerman <q...@google.com>
Fuchsia-Auto-Submit: Chris Suter <csu...@google.com>
Files:
- M sdk/fidl/fuchsia.io/BUILD.bazel
- M sdk/fidl/fuchsia.io/BUILD.gn
- M sdk/fidl/fuchsia.io/directory.fidl
- M sdk/fidl/fuchsia.io/fuchsia.io.api
- A sdk/fidl/fuchsia.io/openable.fidl
- M sdk/fidl/fuchsia.io/symlink.fidl
- M sdk/history/NEXT/fuchsia.io.api_summary.json
- M src/developer/adb/bin/adb-file-sync/adb-file-sync-test.cc
- M src/developer/debug/debug_agent/testing/runtime_dir_helper.cc
- M src/lib/fidl_codec/builtin_semantic.h
- M src/lib/fidl_codec/builtin_semantic_test.cc
- M src/storage/lib/vfs/cpp/connection/directory_connection.cc
- M src/storage/lib/vfs/cpp/remote_dir.cc
- M src/storage/lib/vfs/cpp/remote_dir.h
- M src/storage/lib/vfs/cpp/vnode.cc
- M src/storage/lib/vfs/cpp/vnode.h
- M src/storage/lib/vfs/rust/src/symlink.rs
- M src/tests/end_to_end/fidlcat/fidlcat_e2e_tests.py
- M src/ui/lib/escher/shaders/util/spirv_file_util.cc
- M src/ui/lib/escher/vk/shader_module_template.cc
- M src/ui/scenic/lib/utils/escher_provider.cc
Change size: M
Delta: 21 files changed, 156 insertions(+), 53 deletions(-)
Branch: refs/heads/main
Submit Requirements:
API-Review: +1 by Adam Barth
Code-Review: +2 by Adam Barth, +2 by Benjamin Lerman
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/d55463599156727924666537c39410a587312b2f-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Mar 26, 2026, 5:03:30 AM (5 days ago) Mar 26
to Chris Suter, CQ Bot, Benjamin Lerman, Owners Override, Adam Barth, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, GI Try Builder
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1211458
Related details
Attention set is empty
Submit Requirements:
API-Review
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/29ba0d7f45f3828ebc7d77560d1bdc99bcd07220-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages