[S] Change in fuchsia/fuchsia[main]: [zx][rs] Remove AsHandleRef::get_name.
0 views
Skip to first unread message
'Adam Perry (Gerrit)' via owners-override
Jan 13, 2026, 10:28:36 AM (yesterday) Jan 13
to Owners Override, Adam Barth
Attention needed from Adam Barth and Owners Override
Adam Perry has uploaded the change for review![]( "Open in Gerrit")
Adam Perry would like Owners Override and Adam Barth to review this change.
Commit message
[zx][rs] Remove AsHandleRef::get_name.
Adds a concrete get_name() method to all the handle
wrappers that can be reached through
AsHandleRef::as_handle_ref.
Bug: 434762683
Change-Id: I692c6a4d06b4364eb9ca7361fdbdd61cf882f091
Change diff
diff --git a/sdk/rust/zx/src/handle.rs b/sdk/rust/zx/src/handle.rs
index fb35c2b..6a6ef87 100644
--- a/sdk/rust/zx/src/handle.rs
+++ b/sdk/rust/zx/src/handle.rs
@@ -685,15 +685,6 @@
NullableHandle::raw_handle(&self.as_handle_ref())
}
- /// Get the [Property::NAME] property for this object.
- ///
- /// Wraps a call to the
- /// [zx_object_get_property](https://fuchsia.dev/fuchsia-src/reference/syscalls/object_get_property.md)
- /// syscall for the ZX_PROP_NAME property.
- fn get_name(&self) -> Result<Name, Status> {
- NullableHandle::get_name(&self.as_handle_ref())
- }
-
/// Set the [Property::NAME] property for this object.
///
/// The name's length must be less than [sys::ZX_MAX_NAME_LEN], i.e.
diff --git a/sdk/rust/zx/src/macros.rs b/sdk/rust/zx/src/macros.rs
index 7b9472d..5d2d336 100644
--- a/sdk/rust/zx/src/macros.rs
+++ b/sdk/rust/zx/src/macros.rs
@@ -87,6 +87,13 @@
) -> Result<(), $crate::Status> {
self.0.wait_async(port, key, signals, options)
}
+
+ /// Wraps a call to the
+ /// [`zx_object_get_property`](https://fuchsia.dev/fuchsia-src/reference/syscalls/object_get_property)
+ /// syscall for the `ZX_PROP_NAME` property.
+ pub fn get_name(&self) -> Result<$crate::Name, $crate::Status> {
+ self.0.get_name()
+ }
};
}
diff --git a/src/performance/memory/attribution/monitor/src/resources.rs b/src/performance/memory/attribution/monitor/src/resources.rs
index 4e284c2..2e1cf54 100644
--- a/src/performance/memory/attribution/monitor/src/resources.rs
+++ b/src/performance/memory/attribution/monitor/src/resources.rs
@@ -274,7 +274,7 @@
}
fn get_name(&self) -> Result<zx::Name, zx::Status> {
- fidl::AsHandleRef::get_name(&self)
+ zx::Job::get_name(&self)
}
fn children(&self) -> Result<Vec<zx::Koid>, zx::Status> {
@@ -323,7 +323,7 @@
impl Process for zx::Process {
fn get_name(&self) -> Result<zx::Name, zx::Status> {
- fidl::AsHandleRef::get_name(self)
+ zx::Process::get_name(&self)
}
fn info_vmos<'a>(
diff --git a/src/starnix/lib/starnix_kernel_runner/src/serve_protocols.rs b/src/starnix/lib/starnix_kernel_runner/src/serve_protocols.rs
index 34cda0d..180ffa8 100644
--- a/src/starnix/lib/starnix_kernel_runner/src/serve_protocols.rs
+++ b/src/starnix/lib/starnix_kernel_runner/src/serve_protocols.rs
@@ -4,7 +4,6 @@
use crate::Container;
use anyhow::{Context as _, Error};
-use fidl::AsHandleRef;
use fidl::endpoints::{ControlHandle, RequestStream, ServerEnd};
use fuchsia_async::{
DurationExt, {self as fasync},
diff --git a/src/starnix/tests/fp_stack_glue/src/lib.rs b/src/starnix/tests/fp_stack_glue/src/lib.rs
index 0c3bfb0..7799a03 100644
--- a/src/starnix/tests/fp_stack_glue/src/lib.rs
+++ b/src/starnix/tests/fp_stack_glue/src/lib.rs
@@ -12,7 +12,7 @@
};
use futures::StreamExt;
use log::{info, warn};
-use zx::{AsHandleRef, Task};
+use zx::Task;
use {
fidl_fuchsia_buildinfo as fbuildinfo, fidl_fuchsia_component_runner as frunner,
fidl_fuchsia_sys2 as fsys,
diff --git a/src/sys/lib/elf_runner/src/vdso_vmo.rs b/src/sys/lib/elf_runner/src/vdso_vmo.rs
index 0af47b1..2bc0f6f 100644
--- a/src/sys/lib/elf_runner/src/vdso_vmo.rs
+++ b/src/sys/lib/elf_runner/src/vdso_vmo.rs
@@ -6,7 +6,7 @@
use fuchsia_runtime::{HandleInfo, HandleType, take_startup_handle};
use std::collections::HashMap;
use std::sync::LazyLock;
-use zx::{self as zx, AsHandleRef, HandleBased};
+use zx::HandleBased;
fn take_vdso_vmos() -> Result<HashMap<zx::Name, zx::Vmo>, VdsoError> {
let mut vmos = HashMap::new();
Change information
Files:
- M sdk/rust/zx/src/handle.rs
- M sdk/rust/zx/src/macros.rs
- M src/performance/memory/attribution/monitor/src/resources.rs
- M src/starnix/lib/starnix_kernel_runner/src/serve_protocols.rs
- M src/starnix/tests/fp_stack_glue/src/lib.rs
- M src/sys/lib/elf_runner/src/vdso_vmo.rs
Change size: S
Delta: 6 files changed, 11 insertions(+), 14 deletions(-)
Related details
Attention is currently required from:
- Adam Barth
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/2a377a0f384266275911cffd540b18bba596b67a-HTML%40fuchsia-review.googlesource.com.
'Adam Perry (Gerrit)' via owners-override
Jan 13, 2026, 10:28:39 AM (yesterday) Jan 13
to Adam Barth, Owners Override, GI Try Builder, CQ Bot
Attention needed from Adam Barth and Owners Override
Adam Perry voted![]( "Open in Gerrit")
| Commit-Queue | +1 |
| Fuchsia-Auto-Submit | +1 |
Related details
Attention is currently required from:
- Adam Barth
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/2a377a0f384266275911cffd540b18bba596b67a-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
Jan 13, 2026, 10:45:13 AM (yesterday) Jan 13
to Adam Perry, Owners Override, GI Try Builder, CQ Bot
Attention needed from Adam Perry and Owners Override
Adam Barth voted![]( "Open in Gerrit")
Attention is currently required from:
- Adam Perry
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/d81cc404013aa36313c47c28d246e7033b4f3158-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
Jan 13, 2026, 12:13:45 PM (yesterday) Jan 13
to Adam Perry, Adam Barth, Owners Override, GI Try Builder
CQ Bot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[zx][rs] Remove AsHandleRef::get_name.
Adds a concrete get_name() method to all the handle
wrappers that can be reached through
AsHandleRef::as_handle_ref.
Bug: 434762683
Change-Id: I692c6a4d06b4364eb9ca7361fdbdd61cf882f091
Fuchsia-Auto-Submit: Adam Perry <adam...@google.com>
Commit-Queue: Adam Perry <adam...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Reviewed-by: Adam Barth <aba...@google.com>
Files:
- M sdk/rust/zx/src/handle.rs
- M sdk/rust/zx/src/macros.rs
- M src/performance/memory/attribution/monitor/src/resources.rs
- M src/starnix/lib/starnix_kernel_runner/src/serve_protocols.rs
- M src/starnix/tests/fp_stack_glue/src/lib.rs
- M src/sys/lib/elf_runner/src/vdso_vmo.rs
Change size: S
Delta: 6 files changed, 11 insertions(+), 14 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by Adam Barth
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/92906a475e13c6ac5f43c4a473467261ed4b5d9d-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Jan 13, 2026, 12:19:58 PM (yesterday) Jan 13
to Adam Perry, CQ Bot, Adam Barth, Owners Override, GI Try Builder
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1139013
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b0412add7dc7381dd35ce4ce267eb9f30a1a521e-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages