Groups keyboard shortcuts have been updated
Dismiss
See shortcuts
[L] Change in fuchsia/fuchsia[main]: Revert "[vfs][rust] Complete Open Rename"
0 views
Skip to first unread message
'Brian Bosak (Gerrit)' via owners-override
Apr 10, 2025, 1:14:08 PMApr 10
to Brandon Castellano, Owners Override, Chris Drouillard, CQ Bot, James Robinson, GI Try Builder, GI Roller
Attention needed from Brandon Castellano, Chris Drouillard, James Robinson and Owners Override
Brian Bosak has uploaded the change for review![]( "Open in Gerrit")
Brian Bosak would like Brandon Castellano, Owners Override, Chris Drouillard, CQ Bot and James Robinson to review this change.
Commit message
Revert "[vfs][rust] Complete Open Rename"
This reverts commit 3d006001dfd50f512da6a82787995a8c7f975066.
Reason for revert: b/409611771
Original change's description:
> [vfs][rust] Complete Open Rename
>
> Rename all instances of `open3` in public methods to `open`, and mark
> all deprecated io1 Open methods as `deprecated_open`. Add a default
> implementation for `deprecated_open` and remove it from test
> implementations where it is not required.
>
> There still remain a few callers of the `deprecated_open` methods which
> will be addressed in more targeted follow up changes.
>
> Test: No functional change, rename only.
> Bug: 324111518
> Change-Id: Id0a574af5059bc81a5bab1daec73b060f8130ae1
> Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1248404
> Owners-Override: James Robinson <jam...@google.com>
> Commit-Queue: Brandon Castellano <bcas...@google.com>
> Reviewed-by: Chris Drouillard <cdr...@google.com>
Bug: 324111518
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I81e00e43fd032465d634e5dd8d83058b035e4edf
Change diff
Change information
Files:
- M sdk/lib/device-watcher/rust/src/lib.rs
- M sdk/lib/driver_test_realm/tests/test.rs
- M sdk/lib/zxio/tests/zxio-test.rs
- M src/connectivity/network/netstack-proxy/src/main.rs
- M src/connectivity/network/testing/netemul/service/src/main.rs
- M src/connectivity/wlan/wlandevicemonitor/src/device_watch.rs
- M src/developer/ffx/tools/playground/src/cf_fs.rs
- M src/developer/ffx/tools/playground/src/host_fs.rs
- M src/fonts/testing/mock_font_resolver/src/main.rs
- M src/lib/fuchsia-component-test/realm_builder_server/src/builtin.rs
- M src/lib/fuchsia-component/server/src/lib.rs
- M src/lib/fuchsia-fs/src/directory/watcher.rs
- M src/lib/process_builder/src/process_builder.rs
- M src/recovery/system/src/ota.rs
- M src/recovery/system/src/ota_main.rs
- M src/starnix/kernel/vfs/file_server.rs
- M src/storage/benchmarks/fuchsia/src/filesystems/pkgdir.rs
- M src/storage/block_adapter/src/lib.rs
- M src/storage/conformance/conformance_harness/rustvfs/src/main.rs
- M src/storage/ext4/server/src/main.rs
- M src/storage/factory/export_ffs/src/lib.rs
- M src/storage/fs_realm/src/main.rs
- M src/storage/fshost/integration/src/disk_builder.rs
- M src/storage/fshost/integration/src/mocks.rs
- M src/storage/fshost/src/main.rs
- M src/storage/fshost/src/watcher.rs
- M src/storage/fuchsia-fatfs/mounter/src/device.rs
- M src/storage/fuchsia-fatfs/src/component.rs
- M src/storage/fuchsia-fatfs/src/directory.rs
- M src/storage/fuchsia-fatfs/src/filesystem.rs
- M src/storage/fuchsia-fatfs/src/lib.rs
- M src/storage/fvm/src/main.rs
- M src/storage/fxfs/platform/src/fuchsia/component.rs
- M src/storage/fxfs/platform/src/fuchsia/debug.rs
- M src/storage/fxfs/platform/src/fuchsia/directory.rs
- M src/storage/fxfs/platform/src/fuchsia/fxblob/directory.rs
- M src/storage/fxfs/platform/src/fuchsia/paged_object_handle.rs
- M src/storage/fxfs/platform/src/fuchsia/testing.rs
- M src/storage/fxfs/platform/src/fuchsia/volume.rs
- M src/storage/fxfs/platform/src/fuchsia/volumes_directory.rs
- M src/storage/fxfs/test-fxfs/src/main.rs
- M src/storage/gpt/component/src/gpt.rs
- M src/storage/gpt/component/src/service.rs
- M src/storage/lib/vfs/rust/src/directory/connection.rs
- M src/storage/lib/vfs/rust/src/directory/entry.rs
- M src/storage/lib/vfs/rust/src/directory/entry_container.rs
- M src/storage/lib/vfs/rust/src/directory/immutable/simple/tests.rs
- M src/storage/lib/vfs/rust/src/directory/mutable/connection.rs
- M src/storage/lib/vfs/rust/src/directory/simple.rs
- M src/storage/lib/vfs/rust/src/lib.rs
- M src/storage/lib/vfs/rust/src/remote.rs
- M src/storage/lib/vfs/rust/src/remote/tests.rs
- M src/storage/lib/vfs/rust/src/test_utils/run.rs
- M src/storage/lib/vfs/rust/src/token_registry.rs
- M src/storage/open3_migration.gni
- M src/sys/component_manager/lib/sandbox/src/fidl/dict.rs
- M src/sys/component_manager/lib/sandbox/src/fidl/dir_entry.rs
- M src/sys/component_manager/lib/serve_processargs/src/lib.rs
- M src/sys/component_manager/lib/serve_processargs/src/namespace.rs
- M src/sys/component_manager/src/builtin/fuchsia_boot_resolver.rs
- M src/sys/component_manager/src/framework/realm_query.rs
- M src/sys/component_manager/src/model/routing/service.rs
- M src/sys/component_manager/src/model/storage/admin_protocol.rs
- M src/sys/component_manager/src/model/testing/out_dir.rs
- M src/sys/component_manager/src/model/tests/directory.rs
- M src/sys/component_manager/tests/resolvers/boot/src/integration_test.rs
- M src/sys/full-resolver/src/main.rs
- M src/sys/lib/elf_runner/src/runtime_dir.rs
- M src/sys/pkg/bin/pkg-cache/src/base_resolver/package.rs
- M src/sys/pkg/bin/pkg-cache/src/cache_service.rs
- M src/sys/pkg/bin/pkg-cache/src/compat/pkgfs/validation.rs
- M src/sys/pkg/bin/pkg-cache/src/main.rs
- M src/sys/pkg/bin/pkg-cache/src/root_dir.rs
- M src/sys/pkg/lib/package-directory/src/lib.rs
- M src/sys/pkg/lib/package-directory/src/meta_as_dir.rs
- M src/sys/pkg/lib/package-directory/src/meta_subdir.rs
- M src/sys/pkg/lib/package-directory/src/non_meta_subdir.rs
- M src/sys/pkg/lib/package-directory/src/root_dir.rs
- M src/sys/pkg/lib/package-directory/src/root_dir_cache.rs
- M src/sys/pkg/tests/isolated-ota/src/lib.rs
- M src/sys/pkg/tests/pkg-cache-as-base-resolver/as-a-component-resolver/fake_dependencies.rs
- M src/sys/pkg/tests/pkg-cache-as-base-resolver/using-realm-builder/src/lib.rs
- M src/sys/pkg/tests/pkg-cache/src/lib.rs
- M src/sys/pkg/tests/pkg-resolver/src/lib.rs
- M src/sys/pkg/tests/pkgctl/src/lib.rs
- M src/sys/test_runners/src/elf/elf_component.rs
Change size: L
Delta: 86 files changed, 316 insertions(+), 331 deletions(-)
Related details
Attention is currently required from:
- Brandon Castellano
- Chris Drouillard
- James Robinson
- Owners Override
Submit Requirements:
Code-Review
Commit-Message-Has-Tags
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5abff19d2a66baaf8bfefd3c0cee0e838aeffc93-HTML%40fuchsia-review.googlesource.com.
'Brian Bosak (Gerrit)' via owners-override
Apr 10, 2025, 1:15:08 PMApr 10
to RubberStamper 🤖?, Rubber Stamper (Chrome), Brandon Castellano, Owners Override, Chris Drouillard, CQ Bot, James Robinson, GI Try Builder, GI Roller
Brian Bosak submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "[vfs][rust] Complete Open Rename"
This reverts commit 3d006001dfd50f512da6a82787995a8c7f975066.
Reason for revert: b/409611771
Original change's description:
> [vfs][rust] Complete Open Rename
>
> Rename all instances of `open3` in public methods to `open`, and mark
> all deprecated io1 Open methods as `deprecated_open`. Add a default
> implementation for `deprecated_open` and remove it from test
> implementations where it is not required.
>
> There still remain a few callers of the `deprecated_open` methods which
> will be addressed in more targeted follow up changes.
>
> Test: No functional change, rename only.
> Bug: 324111518
> Change-Id: Id0a574af5059bc81a5bab1daec73b060f8130ae1
> Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1248404
> Owners-Override: James Robinson <jam...@google.com>
> Commit-Queue: Brandon Castellano <bcas...@google.com>
> Reviewed-by: Chris Drouillard <cdr...@google.com>
Bug: 324111518
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I81e00e43fd032465d634e5dd8d83058b035e4edf
Reviewed-by: RubberStamper 🤖 <android-bu...@system.gserviceaccount.com>
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by RubberStamper 🤖
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f80196aa1e33df2e5f576b4a6a1d11280f8355a9-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Apr 10, 2025, 1:23:38 PMApr 10
to Brian Bosak, RubberStamper 🤖?, Rubber Stamper (Chrome), Brandon Castellano, Owners Override, Chris Drouillard, CQ Bot, James Robinson, GI Try Builder
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: http://go/roll-cl/5fa99833bbce4ed02d04a2544f1ae19109b1d278
Related details
Attention set is empty
Submit Requirements:
Code-Review
Commit-Message-Has-Tags
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/6083949905378e451238a6a24d17788e9bc7f15a-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Brandon Castellano (Gerrit)' via owners-override
Apr 10, 2025, 4:05:02 PMApr 10
to Brian Bosak, RubberStamper 🤖?, Rubber Stamper (Chrome), Owners Override, Chris Drouillard, CQ Bot, James Robinson, GI Try Builder, GI Roller
Brandon Castellano has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Review
Commit-Message-Has-Tags
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9c3563aa72f6a3b9a816e83c37556cafbed718f6-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages