[XL] Change in fuchsia/fuchsia[main]: [mesa] Migrate to new layout [1/3]

1 view
Skip to first unread message

'Erick Tryzelaar (Gerrit)' via owners-override

unread,
Jul 31, 2025, 6:18:17 PMJul 31
to Owners Override
Attention needed from Paul Kirth

Erick Tryzelaar has uploaded the change for review

Commit message

[mesa] Migrate to new layout [1/3]

This starts the process to migrate `mesa` to the modern [3p layout].
Unfortunately jiri doesn't always handle moving a git repository into a
subdirectory, such as in this circumstance with us moving
`third_party/mesa` into `third_party/mesa/src`. If there are any files
in a submodule jiri will error out.

So we'll do this migration in 3 patches:

1. First, migrate this repository to `//third_party/mesa-migrating/src`.
   Then move the top-level `BUILD.gn` into
   `//third_party/mesa-migrating`. Finally, move all the remaining build
   files into `//third_party/mesa-migrating/build` (we use `build/`
   since the mesa repository has a `src/` directory, so we have a name
   collision.)

2. Remove the build artifacts from `//third_party/mesa-migrating/src`,
   and update the reference to point at this commit.

3. Migrate all the migrated repositories to their final path. In this
   case `//third_party/mesa`. Doing this in a single patch will allow us
   to send out a PSA with clear instructions, rather than handling
   issues on a patch-by-patch basis.

[3p layout]: https://fuchsia.dev/fuchsia-src/development/source_code/third-party-management#migrating_legacy_third-party_code_to_current_layout

Bug: 42137978
Change-Id: I222e7faf1a514e18d6306f940b49fedfa6257e45

Change diff


Change information

Files:
  • M .gitignore
  • M build/config/BUILD.gn
  • M build/cpp/hlcpp_visibility.gni
  • M manifests/third_party/all
  • M src/graphics/drivers/intel-gen/icd/BUILD.gn
  • M src/graphics/lib/lavapipe-vulkan/BUILD.gn
  • M src/graphics/lib/magma/src/libmagma/BUILD.gn
  • M src/virtualization/bin/vmm/device/BUILD.gn
  • A third_party/mesa-migrating/BUILD.gn
  • A third_party/mesa-migrating/OWNERS
  • A third_party/mesa-migrating/README.fuchsia
  • A third_party/mesa-migrating/build/include/BUILD.gn
  • A third_party/mesa-migrating/build/mesa.gni
  • A third_party/mesa-migrating/build/scripts/gn_script_wrapper.sh
  • A third_party/mesa-migrating/build/src/BUILD.gn
  • A third_party/mesa-migrating/build/src/c11/BUILD.gn
  • A third_party/mesa-migrating/build/src/compiler/BUILD.gn
  • A third_party/mesa-migrating/build/src/compiler/glsl/BUILD.gn
  • A third_party/mesa-migrating/build/src/compiler/nir/BUILD.gn
  • A third_party/mesa-migrating/build/src/compiler/spirv/BUILD.gn
  • A third_party/mesa-migrating/build/src/gallium/BUILD.gn
  • A third_party/mesa-migrating/build/src/gallium/auxiliary/BUILD.gn
  • A third_party/mesa-migrating/build/src/gallium/auxiliary/pipe-loader/BUILD.gn
  • A third_party/mesa-migrating/build/src/gallium/drivers/llvmpipe/BUILD.gn
  • A third_party/mesa-migrating/build/src/gallium/frontends/lavapipe/BUILD.gn
  • A third_party/mesa-migrating/build/src/gallium/winsys/sw/dri/BUILD.gn
  • A third_party/mesa-migrating/build/src/gallium/winsys/sw/null/BUILD.gn
  • A third_party/mesa-migrating/build/src/gallium/winsys/sw/wrapper/BUILD.gn
  • A third_party/mesa-migrating/build/src/intel/BUILD.gn
  • A third_party/mesa-migrating/build/src/intel/blorp/BUILD.gn
  • A third_party/mesa-migrating/build/src/intel/common/BUILD.gn
  • A third_party/mesa-migrating/build/src/intel/compiler/BUILD.gn
  • A third_party/mesa-migrating/build/src/intel/dev/BUILD.gn
  • A third_party/mesa-migrating/build/src/intel/ds/BUILD.gn
  • A third_party/mesa-migrating/build/src/intel/genxml/BUILD.gn
  • A third_party/mesa-migrating/build/src/intel/perf/BUILD.gn
  • A third_party/mesa-migrating/build/src/intel/vulkan/BUILD.gn
  • A third_party/mesa-migrating/build/src/intel/vulkan/tests/BUILD.gn
  • A third_party/mesa-migrating/build/src/os/BUILD.gn
  • A third_party/mesa-migrating/build/src/util/BUILD.gn
  • A third_party/mesa-migrating/build/src/util/format/BUILD.gn
  • A third_party/mesa-migrating/build/src/util/magma/BUILD.gn
  • A third_party/mesa-migrating/build/src/util/tests/BUILD.gn
  • A third_party/mesa-migrating/build/src/util/tests/futex/BUILD.gn
  • A third_party/mesa-migrating/build/src/util/tests/inflight_list/BUILD.gn
  • A third_party/mesa-migrating/build/src/util/tests/magma_map/BUILD.gn
  • A third_party/mesa-migrating/build/src/util/tests/magma_wait/BUILD.gn
  • A third_party/mesa-migrating/build/src/vulkan/runtime/BUILD.gn
  • A third_party/mesa-migrating/build/src/vulkan/util/BUILD.gn
  • A third_party/mesa-migrating/build/src/vulkan/wsi/BUILD.gn
  • A third_party/mesa-migrating/build/tests/BUILD.gn
  • M tools/check-licenses/assets/allowlists/Exception/BSL-1.0.json
  • M tools/check-licenses/assets/allowlists/Exception/SGI-B-2.0.json
  • M tools/check-licenses/assets/readmes/third_party/mesa/README.fuchsia
  • M tools/check-licenses/directory/_config.json
Change size: XL
Delta: 55 files changed, 5086 insertions(+), 135 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Paul Kirth
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I222e7faf1a514e18d6306f940b49fedfa6257e45
Gerrit-Change-Number: 1333169
Gerrit-PatchSet: 24
Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
Gerrit-Reviewer: Craig Stout <cst...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Jerry Belton <jce...@google.com>
Gerrit-Reviewer: Oliver Newman <oliver...@google.com>
Gerrit-Reviewer: Paul Kirth <paul...@google.com>
Gerrit-CC: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Paul Kirth <paul...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c65c8c38c3ea309c79f3360dbf75c4acfce76dc1-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Erick Tryzelaar (Gerrit)' via owners-override

unread,
Jul 31, 2025, 6:18:18 PMJul 31
to Owners Override, Aaron Wood, Craig Stout, Jerry Belton, Oliver Newman, Paul Kirth, GI Try Builder, CQ Bot
Attention needed from Paul Kirth

Erick Tryzelaar voted and added 1 comment

Votes added by Erick Tryzelaar

Commit-Queue+1
Fuchsia-Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 24 (Latest):
Erick Tryzelaar . resolved

Adding owners-override@ for third_party/mesa-migrating/build/scripts/ gn_script_wrapper.sh

Open in Gerrit

Related details

Attention is currently required from:
  • Paul Kirth
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I222e7faf1a514e18d6306f940b49fedfa6257e45
Gerrit-Change-Number: 1333169
Gerrit-PatchSet: 24
Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
Gerrit-Reviewer: Craig Stout <cst...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Jerry Belton <jce...@google.com>
Gerrit-Reviewer: Oliver Newman <oliver...@google.com>
Gerrit-Reviewer: Paul Kirth <paul...@google.com>
Gerrit-CC: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Paul Kirth <paul...@google.com>
Gerrit-Comment-Date: Thu, 31 Jul 2025 22:18:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c65c8c38c3ea309c79f3360dbf75c4acfce76dc1-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Erick Tryzelaar (Gerrit)' via owners-override

unread,
Aug 5, 2025, 4:41:33 PMAug 5
to Owners Override, Aaron Wood, Craig Stout, Jerry Belton, Oliver Newman, Paul Kirth, GI Try Builder, CQ Bot
Attention needed from Paul Kirth

Erick Tryzelaar voted Fuchsia-Auto-Submit+0

Fuchsia-Auto-Submit+0
Open in Gerrit

Related details

Attention is currently required from:
  • Paul Kirth
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Submodule-Changes
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I222e7faf1a514e18d6306f940b49fedfa6257e45
    Gerrit-Change-Number: 1333169
    Gerrit-PatchSet: 29
    Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
    Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
    Gerrit-Reviewer: Craig Stout <cst...@google.com>
    Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
    Gerrit-Reviewer: Jerry Belton <jce...@google.com>
    Gerrit-Reviewer: Oliver Newman <oliver...@google.com>
    Gerrit-Reviewer: Paul Kirth <paul...@google.com>
    Gerrit-CC: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: Paul Kirth <paul...@google.com>
    Gerrit-Comment-Date: Tue, 05 Aug 2025 20:41:26 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b9a1f24da51a25e4683f5e0d28a01ea20117215b-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    'Adam Barth (Gerrit)' via owners-override

    unread,
    Aug 5, 2025, 4:47:53 PMAug 5
    to Erick Tryzelaar, Owners Override, Aaron Wood, Craig Stout, Jerry Belton, Oliver Newman, Paul Kirth, GI Try Builder, CQ Bot
    Attention needed from Erick Tryzelaar and Paul Kirth

    Adam Barth voted Owners-Override+1

    Owners-Override+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Erick Tryzelaar
    • Paul Kirth
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Submodule-Changes
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I222e7faf1a514e18d6306f940b49fedfa6257e45
    Gerrit-Change-Number: 1333169
    Gerrit-PatchSet: 29
    Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
    Gerrit-Reviewer: Aaron Wood <aaro...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Craig Stout <cst...@google.com>
    Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
    Gerrit-Reviewer: Jerry Belton <jce...@google.com>
    Gerrit-Reviewer: Oliver Newman <oliver...@google.com>
    Gerrit-Reviewer: Paul Kirth <paul...@google.com>
    Gerrit-CC: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: Paul Kirth <paul...@google.com>
    Gerrit-Attention: Erick Tryzelaar <etryz...@google.com>
    Gerrit-Comment-Date: Tue, 05 Aug 2025 20:47:45 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f0da66f7c58c8fe1cf98b091b077f70ea68d03f8-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages