[S] Change in fuchsia/fuchsia[main]: [cpp][cleanup] Include cinttypes when appropriate

['Ian McKellar (Gerrit)' via owners-override]

Attention needed from Owners Override and Roland McGrath

Ian McKellar has uploaded the change for review

Ian McKellar would like Owners Override to review this change.

Commit message

[cpp][cleanup] Include cinttypes when appropriate

The cinttypes header gives you macros like PRIx32 that you can use to
make your printf strings theoretically more readable. The cstdint header
gives you standard integer types like uint32_t.

FIDL bindings include cinttypes, but don't actually use those printf
macros.  I'd like to remove that include from the FIDL C++ bindings. But
there's code that uses the C++ FIDL bindings and the printf macros and
doesn't explicitly include cinttypes because they've always come for
free. This updates some of that code to explicitly have the include they
need.

Change-Id: I424a3614d535d737ae63e0498bdc2060d6a54464

Change diff

Change information

Files:

• M src/connectivity/bluetooth/hci/vendor/intel/firmware_loader.cc
• M src/connectivity/bluetooth/hci/vendor/intel/vendor_hci.cc
• M src/connectivity/ethernet/drivers/usb-cdc-ecm/usb-cdc-ecm.cc
• M src/connectivity/ethernet/drivers/usb-cdc-function/usb-cdc-function.cc
• M src/devices/board/drivers/astro/post-init/post-init.cc
• M src/devices/board/drivers/astro/post-init/touch.cc
• M src/devices/board/drivers/nelson/post-init/post-init.cc
• M src/devices/lib/acpi/object.h
• M src/devices/lib/goldfish/pipe_io/pipe_io.cc
• M src/graphics/display/bin/display-test/main.cc
• M src/graphics/display/drivers/aml-canvas/board-resources.cc
• M src/graphics/display/drivers/intel-display/testing/fake-buffer-collection.cc
• M src/graphics/display/lib/api-types/cpp/pixel-format.h
• M src/graphics/drivers/misc/goldfish_control/device_local_heap.cc
• M src/storage/lib/paver/gpt.cc
• M src/storage/lib/paver/uefi.cc
• M src/ui/input/drivers/buttons/buttons.cc
• M src/ui/input/drivers/hidctl/hidctl.cc
• M src/ui/input/drivers/virtio/input_touch.cc

Change size: S

Delta: 19 files changed, 26 insertions(+), 0 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

• Owners Override
• Roland McGrath

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I424a3614d535d737ae63e0498bdc2060d6a54464

Gerrit-Change-Number: 1366162

Gerrit-PatchSet: 5

Gerrit-Owner: Ian McKellar <ian...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: Ian McKellar <ian...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Roland McGrath <mcgr...@google.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/cfc82007d0c5f9eb1548d55096a8e0f540bc9673-HTML%40fuchsia-review.googlesource.com.

['Ian McKellar (Gerrit)' via owners-override]

Attention needed from Owners Override and Roland McGrath

Ian McKellar voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Owners Override
• Roland McGrath

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I424a3614d535d737ae63e0498bdc2060d6a54464

Gerrit-Change-Number: 1366162

Gerrit-PatchSet: 5

Gerrit-Owner: Ian McKellar <ian...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: Ian McKellar <ian...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Roland McGrath <mcgr...@google.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Comment-Date: Fri, 12 Sep 2025 22:16:29 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/cfc82007d0c5f9eb1548d55096a8e0f540bc9673-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['Adam Barth (Gerrit)' via owners-override]

Attention needed from Ian McKellar, Owners Override and Roland McGrath

Adam Barth voted Owners-Override+1

Owners-Override

+1

Open in Gerrit

Related details

Attention is currently required from:

• Ian McKellar
• Owners Override
• Roland McGrath

Submit Requirements:

• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I424a3614d535d737ae63e0498bdc2060d6a54464

Gerrit-Change-Number: 1366162

Gerrit-PatchSet: 5

Gerrit-Owner: Ian McKellar <ian...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: Ian McKellar <ian...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Ian McKellar <ian...@google.com>

Gerrit-Attention: Roland McGrath <mcgr...@google.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Comment-Date: Fri, 12 Sep 2025 22:21:04 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/3c9a404458e931e65a9e283982d24a52ab4de647-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['CQ Bot (Gerrit)' via owners-override]

CQ Bot submitted the change

Change information

Commit message:

[cpp][cleanup] Include cinttypes when appropriate

The cinttypes header gives you macros like PRIx32 that you can use to
make your printf strings theoretically more readable. The cstdint header
gives you standard integer types like uint32_t.

FIDL bindings include cinttypes, but don't actually use those printf
macros.  I'd like to remove that include from the FIDL C++ bindings. But
there's code that uses the C++ FIDL bindings and the printf macros and
doesn't explicitly include cinttypes because they've always come for
free. This updates some of that code to explicitly have the include they
need.

Change-Id: I424a3614d535d737ae63e0498bdc2060d6a54464

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1366162

Commit-Queue: Ian McKellar <ian...@google.com>

Reviewed-by: Adam Barth <aba...@google.com>

Fuchsia-Auto-Submit: Ian McKellar <ian...@google.com>

Owners-Override: Adam Barth <aba...@google.com>

Files:

• M src/connectivity/bluetooth/hci/vendor/intel/firmware_loader.cc
• M src/connectivity/bluetooth/hci/vendor/intel/vendor_hci.cc
• M src/connectivity/ethernet/drivers/usb-cdc-ecm/usb-cdc-ecm.cc
• M src/connectivity/ethernet/drivers/usb-cdc-function/usb-cdc-function.cc
• M src/devices/board/drivers/astro/post-init/post-init.cc
• M src/devices/board/drivers/astro/post-init/touch.cc
• M src/devices/board/drivers/nelson/post-init/post-init.cc
• M src/devices/lib/acpi/object.h
• M src/devices/lib/goldfish/pipe_io/pipe_io.cc
• M src/graphics/display/bin/display-test/main.cc
• M src/graphics/display/drivers/aml-canvas/board-resources.cc
• M src/graphics/display/drivers/intel-display/testing/fake-buffer-collection.cc
• M src/graphics/display/lib/api-types/cpp/pixel-format.h
• M src/graphics/drivers/misc/goldfish_control/device_local_heap.cc
• M src/storage/lib/paver/gpt.cc
• M src/storage/lib/paver/uefi.cc
• M src/ui/input/drivers/buttons/buttons.cc
• M src/ui/input/drivers/hidctl/hidctl.cc
• M src/ui/input/drivers/virtio/input_touch.cc

Change size: S

Delta: 19 files changed, 26 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +2 by Adam Barth

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I424a3614d535d737ae63e0498bdc2060d6a54464

Gerrit-Change-Number: 1366162

Gerrit-PatchSet: 6

Gerrit-Owner: Ian McKellar <ian...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Ian McKellar <ian...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/50b306ed22fbfa14ce3ffc2a20409df4539d8e7f-HTML%40fuchsia-review.googlesource.com.

['GI Roller (Gerrit)' via owners-override]

Message from GI Roller

Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1044745

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I424a3614d535d737ae63e0498bdc2060d6a54464

Gerrit-Change-Number: 1366162

Gerrit-PatchSet: 6

Gerrit-Owner: Ian McKellar <ian...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Ian McKellar <ian...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>

Gerrit-CC: GI Roller <global-integra...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Comment-Date: Fri, 12 Sep 2025 22:25:20 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5a0e05d5ad7abf336debf623a4ffa927533e4443-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.