[M] Change in fuchsia/fuchsia[main]: [rust][clippy] Apply fix for unused_parens
4 views
Skip to first unread message
'Gwen Mittertreiner (Gerrit)' via owners-override
Jul 7, 2025, 8:11:04 PM7/7/25
to Owners Override
Attention needed from Owners Override
Gwen Mittertreiner has uploaded the change for review![]( "Open in Gerrit")
Gwen Mittertreiner would like Owners Override to review this change.
Commit message
[rust][clippy] Apply fix for unused_parens
The new clippy version ships with a warning about parens. Ran
```
fx clippy --all --raw | fx shush lint --force --lint unused_parens fix
```
To apply this across the code base.
Change-Id: I146a396db4b60afc0c1936259b948fe3303c007c
Change diff
Change information
Files:
- M src/connectivity/bluetooth/profiles/bt-a2dp/src/media/player_sink.rs
- M src/connectivity/network/tests/integration/common/src/ndp.rs
- M src/developer/ffx/command/src/subcommand.rs
- M src/developer/ffx/frontends/ffx/src/main.rs
- M src/diagnostics/lib/triage/src/metrics.rs
- M src/diagnostics/lib/triage/src/metrics/arithmetic.rs
- M src/settings/storage/src/device_storage.rs
- M src/starnix/kernel/logging/logging.rs
- M src/storage/fuchsia-fatfs/src/directory.rs
- M src/storage/fxfs/src/object_store/transaction.rs
- M src/storage/lib/vfs/rust/src/directory/read_dirents.rs
- M src/sys/pkg/bin/pkg-cache/src/compat/pkgfs/validation.rs
- M src/sys/pkg/lib/package-directory/src/meta_as_dir.rs
- M src/sys/pkg/lib/package-directory/src/meta_subdir.rs
- M src/sys/pkg/lib/package-directory/src/non_meta_subdir.rs
- M src/sys/pkg/lib/package-directory/src/root_dir.rs
Change size: M
Delta: 16 files changed, 26 insertions(+), 26 deletions(-)
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/eb1a962e70c8e58039eaff7506e5fb58fcca3aa9-HTML%40fuchsia-review.googlesource.com.
'Gwen Mittertreiner (Gerrit)' via owners-override
Jul 7, 2025, 8:11:06 PM7/7/25
to Owners Override, GI Try Builder, CQ Bot
Attention needed from Owners Override
Gwen Mittertreiner added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Gwen Mittertreiner . unresolved
Requesting owners override since this is a fully automatic change which would require 6-8 reviewers otherwise.
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/eb1a962e70c8e58039eaff7506e5fb58fcca3aa9-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
Jul 7, 2025, 9:50:39 PM7/7/25
to Gwen Mittertreiner, Owners Override, GI Try Builder, CQ Bot
Attention needed from Gwen Mittertreiner and Owners Override
Adam Barth voted Owners-Override+1![]( "Open in Gerrit")
Attention is currently required from:
- Gwen Mittertreiner
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e51b43c03a5eb4744c4a82db4d1102370d8304b4-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
Jul 7, 2025, 9:50:46 PM7/7/25
to Gwen Mittertreiner, Owners Override, GI Try Builder, CQ Bot
Attention needed from Gwen Mittertreiner and Owners Override
Adam Barth voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
Related details
Attention is currently required from:
- Gwen Mittertreiner
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5cf09f29fb30d5431cf427d4b27514fc7f773054-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Gwen Mittertreiner (Gerrit)' via owners-override
Jul 8, 2025, 11:57:41 AM7/8/25
to Adam Barth, Owners Override, GI Try Builder, CQ Bot
Attention needed from Owners Override
Gwen Mittertreiner added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Gwen Mittertreiner . resolved
Requesting owners override since this is a fully automatic change which would require 6-8 reviewers otherwise.
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/bcc608c993fd4a37bda4f1cf6d4ce1370d2a6186-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Gwen Mittertreiner (Gerrit)' via owners-override
Jul 8, 2025, 11:57:54 AM7/8/25
to Adam Barth, Owners Override, GI Try Builder, CQ Bot
Attention needed from Owners Override
Gwen Mittertreiner voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e3f2149ac5b30faf797eb641fed1db49ae9498a8-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
Jul 8, 2025, 1:07:16 PM7/8/25
to Gwen Mittertreiner, Adam Barth, Owners Override, GI Try Builder
CQ Bot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[rust][clippy] Apply fix for unused_parens
The new clippy version ships with a warning about parens. Ran
```
fx clippy --all --raw | fx shush lint --force --lint unused_parens fix
```
To apply this across the code base.
Change-Id: I146a396db4b60afc0c1936259b948fe3303c007c
Commit-Queue: Gwen Mittertreiner <gm...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Reviewed-by: Adam Barth <aba...@google.com>
Files:
- M src/connectivity/bluetooth/profiles/bt-a2dp/src/media/player_sink.rs
- M src/connectivity/network/tests/integration/common/src/ndp.rs
- M src/developer/ffx/command/src/subcommand.rs
- M src/developer/ffx/frontends/ffx/src/main.rs
- M src/diagnostics/lib/triage/src/metrics.rs
- M src/diagnostics/lib/triage/src/metrics/arithmetic.rs
- M src/settings/storage/src/device_storage.rs
- M src/starnix/kernel/logging/logging.rs
- M src/storage/fuchsia-fatfs/src/directory.rs
- M src/storage/fxfs/src/object_store/transaction.rs
- M src/storage/lib/vfs/rust/src/directory/read_dirents.rs
- M src/sys/pkg/bin/pkg-cache/src/compat/pkgfs/validation.rs
- M src/sys/pkg/lib/package-directory/src/meta_as_dir.rs
- M src/sys/pkg/lib/package-directory/src/meta_subdir.rs
- M src/sys/pkg/lib/package-directory/src/non_meta_subdir.rs
- M src/sys/pkg/lib/package-directory/src/root_dir.rs
Change size: M
Delta: 16 files changed, 26 insertions(+), 26 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by Adam Barth
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0b8cab67324ef6f0b4f25f02c294d05af01f51bf-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Jul 8, 2025, 1:09:22 PM7/8/25
to Gwen Mittertreiner, CQ Bot, Adam Barth, Owners Override, GI Try Builder
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1013688
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5a34834d604afb6caa4f5c11387cf2f390ce2669-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages