[XS] Change in fuchsia/fuchsia[main]: [scripts] Fix syntax error in fx-env.fish

0 views
Skip to first unread message

'Peter DeLong (Gerrit)' via owners-override

unread,
Dec 5, 2025, 1:35:18 PM (6 days ago) Dec 5
to Owners Override
Attention needed from Owners Override

Peter DeLong has uploaded the change for review

Peter DeLong would like Owners Override to review this change.

Commit message

[scripts] Fix syntax error in fx-env.fish

The newline was unintentionally removed in
Ifbe8b4b3014918c5c8a84d1fa2623e016a6a6964.
Change-Id: I4a5510fbaedfc0d4941f61923c407fc66a6a6964

Change diff

diff --git a/scripts/fx-env.fish b/scripts/fx-env.fish
index a5ede87..8ea8983 100644
--- a/scripts/fx-env.fish
+++ b/scripts/fx-env.fish
@@ -22,7 +22,8 @@
 set -x FUCHSIA_DIR (readlink -f (dirname (dirname (status -f))))
 
 # export PATH to include .jiri_root/bin
-set jiri_root_bin "$FUCHSIA_DIR/.jiri_root/bin" if not contains $jiri_root_bin $PATH
+set jiri_root_bin "$FUCHSIA_DIR/.jiri_root/bin"
+if not contains $jiri_root_bin $PATH
   set -x PATH $PATH $jiri_root_bin
 end

Change information

Files:
  • M scripts/fx-env.fish
Change size: XS
Delta: 1 file changed, 2 insertions(+), 1 deletion(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I4a5510fbaedfc0d4941f61923c407fc66a6a6964
Gerrit-Change-Number: 1442348
Gerrit-PatchSet: 1
Gerrit-Owner: Peter DeLong <pde...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Peter DeLong <pde...@google.com>
Gerrit-Reviewer: Suraj Malhotra <surajm...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7be3b9d4a32949ccc297bbddb3dc891a60886ccc-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Peter DeLong (Gerrit)' via owners-override

unread,
Dec 5, 2025, 1:35:21 PM (6 days ago) Dec 5
to Owners Override, Suraj Malhotra, GI Try Builder, CQ Bot
Attention needed from Owners Override

Peter DeLong added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Peter DeLong . resolved

Adding owners override as the OWNER (crjohns@) is OOO today. Given how trivial the change is, it doesn't seem worth rolling back the original to fix things

Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I4a5510fbaedfc0d4941f61923c407fc66a6a6964
Gerrit-Change-Number: 1442348
Gerrit-PatchSet: 1
Gerrit-Owner: Peter DeLong <pde...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Peter DeLong <pde...@google.com>
Gerrit-Reviewer: Suraj Malhotra <surajm...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Fri, 05 Dec 2025 18:35:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7be3b9d4a32949ccc297bbddb3dc891a60886ccc-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'James Robinson (Gerrit)' via owners-override

unread,
Dec 5, 2025, 1:40:36 PM (6 days ago) Dec 5
to Peter DeLong, Owners Override, Suraj Malhotra, GI Try Builder, CQ Bot
Attention needed from Owners Override and Peter DeLong

James Robinson voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
  • Peter DeLong
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I4a5510fbaedfc0d4941f61923c407fc66a6a6964
Gerrit-Change-Number: 1442348
Gerrit-PatchSet: 1
Gerrit-Owner: Peter DeLong <pde...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Peter DeLong <pde...@google.com>
Gerrit-Reviewer: Suraj Malhotra <surajm...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Peter DeLong <pde...@google.com>
Gerrit-Comment-Date: Fri, 05 Dec 2025 18:40:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a9d0313a38fd961cd5e4bec71c28d779533c29a5-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Peter DeLong (Gerrit)' via owners-override

unread,
Dec 5, 2025, 1:40:58 PM (6 days ago) Dec 5
to James Robinson, Owners Override, Suraj Malhotra, GI Try Builder, CQ Bot
Attention needed from Owners Override

Peter DeLong voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I4a5510fbaedfc0d4941f61923c407fc66a6a6964
Gerrit-Change-Number: 1442348
Gerrit-PatchSet: 1
Gerrit-Owner: Peter DeLong <pde...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Peter DeLong <pde...@google.com>
Gerrit-Reviewer: Suraj Malhotra <surajm...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Fri, 05 Dec 2025 18:40:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/90580f8d2f803425c5ef46d85507b63b0689ecca-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Dec 5, 2025, 1:45:06 PM (6 days ago) Dec 5
to Peter DeLong, James Robinson, Owners Override, Suraj Malhotra, GI Try Builder

CQ Bot submitted the change

Change information

Commit message:
[scripts] Fix syntax error in fx-env.fish

The newline was unintentionally removed in
Ifbe8b4b3014918c5c8a84d1fa2623e016a6a6964.
Change-Id: I4a5510fbaedfc0d4941f61923c407fc66a6a6964
Owners-Override: James Robinson <jam...@google.com>
Commit-Queue: Peter DeLong <pde...@google.com>
Reviewed-by: Suraj Malhotra <surajm...@google.com>
Files:
  • M scripts/fx-env.fish
Change size: XS
Delta: 1 file changed, 2 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Suraj Malhotra
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I4a5510fbaedfc0d4941f61923c407fc66a6a6964
Gerrit-Change-Number: 1442348
Gerrit-PatchSet: 2
Gerrit-Owner: Peter DeLong <pde...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Peter DeLong <pde...@google.com>
Gerrit-Reviewer: Suraj Malhotra <surajm...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/bdca8bc4ca1dccabd3d4400eff3889833132b6e0-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Dec 5, 2025, 1:48:05 PM (6 days ago) Dec 5
to Peter DeLong, CQ Bot, James Robinson, Owners Override, Suraj Malhotra, GI Try Builder

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I4a5510fbaedfc0d4941f61923c407fc66a6a6964
Gerrit-Change-Number: 1442348
Gerrit-PatchSet: 2
Gerrit-Owner: Peter DeLong <pde...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Peter DeLong <pde...@google.com>
Gerrit-Reviewer: Suraj Malhotra <surajm...@google.com>
Gerrit-Comment-Date: Fri, 05 Dec 2025 18:48:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/d4c69ba13ba9d77cad614c6c213c28db3f8b5529-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages