[NoOp] Change in fuchsia/fuchsia[main]: Reland "[fatfs] Temporarily disable fat-fuzzer tests when using lsan"

0 views
Skip to first unread message

'Leonard Chan (Gerrit)' via owners-override

unread,
Sep 4, 2025, 5:25:16 PM (3 days ago) Sep 4
to Owners Override
Attention needed from Chris Drouillard, James Sullivan, Leonard Chan, Owners Override and Roland McGrath

Leonard Chan has uploaded the change for review

Leonard Chan would like Owners Override to review this change.

Commit message

Reland "[fatfs] Temporarily disable fat-fuzzer tests when using lsan"

This reverts commit 466335a0ba97a52daa9b712bb2c2ca4e97c63bb8.

Reason for revert: This depends on a fix introduced by the clang roll which is being reverted.

Bug: 443061431

Original change's description:
> Revert "[fatfs] Temporarily disable fat-fuzzer tests when using lsan"
>
> This reverts commit 4c4396c7f2162501970115f5e6d6249d9e6e788f.
>
> Reason for revert: This was fixed upstream and rolled in via the last clang roll.
>
> Fixed: 431396031, 436923423
> Original change's description:
> > [fatfs] Temporarily disable fat-fuzzer tests when using lsan
> >
> > Disable this while we investigate the flake in fxb/431396031.
> >
> > Bugs: 431396031, 436923423
> > Change-Id: Idb5419db743967fa62ac4d0d62349bb97691b51d
> > Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1340346
> > Commit-Queue: Chris Suter <csu...@google.com>
> > Reviewed-by: Chris Suter <csu...@google.com>
> > Fuchsia-Auto-Submit: Chris Suter <csu...@google.com>
>
> Change-Id: I43d4b5a2ccaa5f9a1238a45d8fb5a409a07a4cb2
> Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1361063
> Reviewed-by: Chris Suter <csu...@google.com>
> Commit-Queue: Leonard Chan <leona...@google.com>
Change-Id: I477fb21cf44910e552999c8d6b854f6a9b13167c

Change diff


Change information

Files:
    Change size: NoOp
    Delta: 0 files changed, 0 insertions(+), 0 deletions(-)
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Chris Drouillard
    • James Sullivan
    • Leonard Chan
    • Owners Override
    • Roland McGrath
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement satisfiedCommit-Message-Has-Tags
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: newchange
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I477fb21cf44910e552999c8d6b854f6a9b13167c
    Gerrit-Change-Number: 1361757
    Gerrit-PatchSet: 2
    Gerrit-Owner: Leonard Chan <leona...@google.com>
    Gerrit-Reviewer: Chris Drouillard <cdr...@google.com>
    Gerrit-Reviewer: Chris Suter <csu...@google.com>
    Gerrit-Reviewer: James Sullivan <jfsu...@google.com>
    Gerrit-Reviewer: Leonard Chan <leona...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>
    Gerrit-Reviewer: Rubber Stamper (Chrome) <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Attention: Leonard Chan <leona...@google.com>
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: Chris Drouillard <cdr...@google.com>
    Gerrit-Attention: James Sullivan <jfsu...@google.com>
    Gerrit-Attention: Roland McGrath <mcgr...@google.com>

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/21ecbd1dee77ea6ee87fb28caaebdc2238ea0f94-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    'Leonard Chan (Gerrit)' via owners-override

    unread,
    Sep 4, 2025, 5:25:21 PM (3 days ago) Sep 4
    to Owners Override, Chris Drouillard, CQ Bot, Chris Suter, Rubber Stamper (Chrome), James Sullivan, Roland McGrath, GI Try Builder, GI Roller
    Attention needed from Chris Drouillard, James Sullivan, Leonard Chan, Owners Override and Roland McGrath

    Leonard Chan voted Code-Review+0

    Code-Review+0
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Chris Drouillard
    • James Sullivan
    • Leonard Chan
    • Owners Override
    • Roland McGrath
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement satisfiedCommit-Message-Has-Tags
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I477fb21cf44910e552999c8d6b854f6a9b13167c
    Gerrit-Change-Number: 1361757
    Gerrit-PatchSet: 2
    Gerrit-Owner: Leonard Chan <leona...@google.com>
    Gerrit-Reviewer: Chris Drouillard <cdr...@google.com>
    Gerrit-Reviewer: Chris Suter <csu...@google.com>
    Gerrit-Reviewer: James Sullivan <jfsu...@google.com>
    Gerrit-Reviewer: Leonard Chan <leona...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>
    Gerrit-Reviewer: Rubber Stamper (Chrome) <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Attention: Leonard Chan <leona...@google.com>
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: Chris Drouillard <cdr...@google.com>
    Gerrit-Attention: James Sullivan <jfsu...@google.com>
    Gerrit-Attention: Roland McGrath <mcgr...@google.com>
    Gerrit-Comment-Date: Thu, 04 Sep 2025 21:25:13 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/21ecbd1dee77ea6ee87fb28caaebdc2238ea0f94-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    'Leonard Chan (Gerrit)' via owners-override

    unread,
    Sep 4, 2025, 5:36:17 PM (3 days ago) Sep 4
    to Owners Override, Chris Drouillard, CQ Bot, Chris Suter, Rubber Stamper (Chrome), James Sullivan, Roland McGrath, GI Try Builder, GI Roller
    Attention needed from Chris Drouillard, James Sullivan, Owners Override and Roland McGrath

    Leonard Chan voted Code-Review+2

    Code-Review+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Chris Drouillard
    • James Sullivan
    • Owners Override
    • Roland McGrath
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: Chris Drouillard <cdr...@google.com>
    Gerrit-Attention: James Sullivan <jfsu...@google.com>
    Gerrit-Attention: Roland McGrath <mcgr...@google.com>
    Gerrit-Comment-Date: Thu, 04 Sep 2025 21:36:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/22c84e89a3a0d54fe39d9f6f6fd4e756cacdc31d-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    'Francois Rousseau (Gerrit)' via owners-override

    unread,
    Sep 4, 2025, 5:37:27 PM (3 days ago) Sep 4
    to Leonard Chan, Owners Override, Chris Drouillard, CQ Bot, Chris Suter, Rubber Stamper (Chrome), James Sullivan, Roland McGrath, GI Try Builder, GI Roller
    Attention needed from Chris Drouillard, James Sullivan, Leonard Chan, Owners Override and Roland McGrath

    Francois Rousseau voted Code-Review+2

    Code-Review+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Chris Drouillard
    • James Sullivan
    • Leonard Chan
    • Owners Override
    • Roland McGrath
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedCommit-Message-Has-Tags
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I477fb21cf44910e552999c8d6b854f6a9b13167c
    Gerrit-Change-Number: 1361757
    Gerrit-PatchSet: 2
    Gerrit-Owner: Leonard Chan <leona...@google.com>
    Gerrit-Reviewer: Chris Drouillard <cdr...@google.com>
    Gerrit-Reviewer: Chris Suter <csu...@google.com>
    Gerrit-Reviewer: Francois Rousseau <frou...@google.com>
    Gerrit-Reviewer: James Sullivan <jfsu...@google.com>
    Gerrit-Reviewer: Leonard Chan <leona...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>
    Gerrit-Reviewer: Rubber Stamper (Chrome) <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Attention: Leonard Chan <leona...@google.com>
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: Chris Drouillard <cdr...@google.com>
    Gerrit-Attention: James Sullivan <jfsu...@google.com>
    Gerrit-Attention: Roland McGrath <mcgr...@google.com>
    Gerrit-Comment-Date: Thu, 04 Sep 2025 21:37:18 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/77584c619a3f9b057cef40d4a8de93e42979ec33-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    open
    diffy

    'Chris Suter (Gerrit)' via owners-override

    unread,
    Sep 4, 2025, 5:39:20 PM (3 days ago) Sep 4
    to Leonard Chan, Francois Rousseau, Owners Override, Chris Drouillard, CQ Bot, Rubber Stamper (Chrome), James Sullivan, Roland McGrath, GI Try Builder, GI Roller
    Attention needed from Chris Drouillard, James Sullivan, Leonard Chan, Owners Override and Roland McGrath

    Chris Suter added 1 comment

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    Chris Suter . unresolved

    This commit looks empty to me.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Chris Drouillard
    • James Sullivan
    • Leonard Chan
    • Owners Override
    • Roland McGrath
    Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedCommit-Message-Has-Tags
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Gerrit-Comment-Date: Thu, 04 Sep 2025 21:39:00 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No

      --
      You received this message because you are subscribed to the Google Groups "owners-override" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
      To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/289163791bb0884b2dbc95ef622e37d70405054d-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      'Leonard Chan (Gerrit)' via owners-override

      unread,
      Sep 4, 2025, 5:43:00 PM (3 days ago) Sep 4
      to Francois Rousseau, Owners Override, Chris Drouillard, CQ Bot, Chris Suter, Rubber Stamper (Chrome), James Sullivan, Roland McGrath, GI Try Builder, GI Roller
      Attention needed from Chris Drouillard, Chris Suter, James Sullivan, Owners Override and Roland McGrath

      Leonard Chan added 1 comment

      Patchset-level comments
      Chris Suter . unresolved

      This commit looks empty to me.

      Leonard Chan

      In between Base and Patchest 1 has the changes. Is there a way I can have it go back to patchset 1?

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Chris Drouillard
      • Chris Suter
      • James Sullivan
      • Owners Override
      • Roland McGrath
      Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
      Gerrit-Attention: Chris Drouillard <cdr...@google.com>
      Gerrit-Attention: Chris Suter <csu...@google.com>
      Gerrit-Attention: James Sullivan <jfsu...@google.com>
      Gerrit-Attention: Roland McGrath <mcgr...@google.com>
      Gerrit-Comment-Date: Thu, 04 Sep 2025 21:42:51 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Chris Suter <csu...@google.com>

      --
      You received this message because you are subscribed to the Google Groups "owners-override" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
      To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/afffddb3e12a6e2b3e6e9e15f160b8b1840a950f-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      'Leonard Chan (Gerrit)' via owners-override

      unread,
      Sep 4, 2025, 5:43:28 PM (3 days ago) Sep 4
      to Francois Rousseau, Owners Override, Chris Drouillard, CQ Bot, Chris Suter, Rubber Stamper (Chrome), James Sullivan, Roland McGrath, GI Try Builder, GI Roller
      Attention needed from Chris Drouillard, Chris Suter, James Sullivan, Owners Override and Roland McGrath

      Leonard Chan voted and added 1 comment

      Votes added by Leonard Chan

      Commit-Queue+2

      1 comment

      Patchset-level comments
      Chris Suter . resolved

      This commit looks empty to me.

      Leonard Chan

      In between Base and Patchest 1 has the changes. Is there a way I can have it go back to patchset 1?

      Leonard Chan

      Done

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Chris Drouillard
      • Chris Suter
      • James Sullivan
      • Owners Override
      • Roland McGrath
      Submit Requirements:
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedCommit-Message-Has-Tags
        • requirement satisfiedReview-Enforcement
        Gerrit-Comment-Date: Thu, 04 Sep 2025 21:43:20 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Leonard Chan <leona...@google.com>
        Comment-In-Reply-To: Chris Suter <csu...@google.com>

        --
        You received this message because you are subscribed to the Google Groups "owners-override" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
        To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/93d09767b24e011e7c1db5d80b535a72bd020c77-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
        satisfied_requirement
        open
        diffy

        'Leonard Chan (Gerrit)' via owners-override

        unread,
        Sep 4, 2025, 6:07:04 PM (3 days ago) Sep 4
        to Owners Override
        Attention needed from Chris Drouillard, Chris Suter, James Sullivan, Owners Override and Roland McGrath

        Leonard Chan has uploaded the change for review

        Leonard Chan would like Owners Override to review this change.

        Commit message

        Reland "[fatfs] Temporarily disable fat-fuzzer tests when using lsan"

        This reverts commit 466335a0ba97a52daa9b712bb2c2ca4e97c63bb8.

        Reason for revert: Reason for revert: This depends on a fix introduced by the clang roll which is being reverted.


        Original change's description:
        > Revert "[fatfs] Temporarily disable fat-fuzzer tests when using lsan"
        >
        > This reverts commit 4c4396c7f2162501970115f5e6d6249d9e6e788f.
        >
        > Reason for revert: This was fixed upstream and rolled in via the last clang roll.
        >
        > Fixed: 431396031, 436923423
        > Original change's description:
        > > [fatfs] Temporarily disable fat-fuzzer tests when using lsan
        > >
        > > Disable this while we investigate the flake in fxb/431396031.
        > >
        > > Bugs: 431396031, 436923423
        > > Change-Id: Idb5419db743967fa62ac4d0d62349bb97691b51d
        > > Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1340346
        > > Commit-Queue: Chris Suter <csu...@google.com>
        > > Reviewed-by: Chris Suter <csu...@google.com>
        > > Fuchsia-Auto-Submit: Chris Suter <csu...@google.com>
        >
        > Change-Id: I43d4b5a2ccaa5f9a1238a45d8fb5a409a07a4cb2
        > Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1361063
        > Reviewed-by: Chris Suter <csu...@google.com>
        > Commit-Queue: Leonard Chan <leona...@google.com>
        Change-Id: I1707ee411f124ab768a6136d4dcbc7327a10d563

        Change diff

        diff --git a/src/storage/fuchsia-fatfs/BUILD.gn b/src/storage/fuchsia-fatfs/BUILD.gn
        index d8d46c3..f791e29 100644
        --- a/src/storage/fuchsia-fatfs/BUILD.gn
        +++ b/src/storage/fuchsia-fatfs/BUILD.gn
        @@ -69,6 +69,10 @@
        "//src/lib/fuzzing/rust:fuzz",
        "//third_party/rust_crates:futures",
        ]
        +
        + # TODO(https://fxbug.dev/436923423): Re-enable this for lsan once the issue
        + # regarding leak checking is fixed.
        + exclude_toolchain_tags = [ "lsan" ]
        }

        fuchsia_fuzzer_component("fat-fuzzer-component") {

        Change information

        Files:
        • M src/storage/fuchsia-fatfs/BUILD.gn
        Change size: XS
        Delta: 1 file changed, 4 insertions(+), 0 deletions(-)
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Chris Drouillard
        • Chris Suter
        • James Sullivan
        • Owners Override
        • Roland McGrath
        Submit Requirements:
        • requirement satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement satisfiedCommit-Message-Has-Tags
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: newchange
        Gerrit-Project: fuchsia
        Gerrit-Branch: main
        Gerrit-Change-Id: I1707ee411f124ab768a6136d4dcbc7327a10d563
        Gerrit-Change-Number: 1361766
        Gerrit-PatchSet: 1
        Gerrit-Owner: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Chris Drouillard <cdr...@google.com>
        Gerrit-Reviewer: Chris Suter <csu...@google.com>
        Gerrit-Reviewer: James Sullivan <jfsu...@google.com>
        Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
        Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>
        Gerrit-Reviewer: Rubber Stamper (Chrome) <rubber-...@appspot.gserviceaccount.com>
        Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
        Gerrit-Attention: Chris Drouillard <cdr...@google.com>
        Gerrit-Attention: Chris Suter <csu...@google.com>
        Gerrit-Attention: James Sullivan <jfsu...@google.com>
        Gerrit-Attention: Roland McGrath <mcgr...@google.com>

        --
        You received this message because you are subscribed to the Google Groups "owners-override" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
        To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e5140a35c900cf0cc9af40ef3fbc1ac11d43d484-HTML%40fuchsia-review.googlesource.com.
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        'James Robinson (Gerrit)' via owners-override

        unread,
        Sep 4, 2025, 6:10:23 PM (3 days ago) Sep 4
        to Leonard Chan, Owners Override, Chris Drouillard, CQ Bot, Chris Suter, Rubber Stamper (Chrome), James Sullivan, Roland McGrath, GI Try Builder, GI Roller
        Attention needed from Chris Drouillard, Chris Suter, James Sullivan, Leonard Chan, Owners Override and Roland McGrath

        James Robinson voted and added 1 comment

        Votes added by James Robinson

        Code-Review+2
        Owners-Override+1

        1 comment

        Patchset-level comments
        File-level comment, Patchset 1 (Latest):
        James Robinson . resolved

        I think the rubber stamper will also be OK with this change. It hasn't run yet

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Chris Drouillard
        • Chris Suter
        • James Sullivan
        • Leonard Chan
        • Owners Override
        • Roland McGrath
        Submit Requirements:
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedCommit-Message-Has-Tags
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: fuchsia
        Gerrit-Branch: main
        Gerrit-Change-Id: I1707ee411f124ab768a6136d4dcbc7327a10d563
        Gerrit-Change-Number: 1361766
        Gerrit-PatchSet: 1
        Gerrit-Owner: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Chris Drouillard <cdr...@google.com>
        Gerrit-Reviewer: Chris Suter <csu...@google.com>
        Gerrit-Reviewer: James Robinson <jam...@google.com>
        Gerrit-Reviewer: James Sullivan <jfsu...@google.com>
        Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
        Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>
        Gerrit-Reviewer: Rubber Stamper (Chrome) <rubber-...@appspot.gserviceaccount.com>
        Gerrit-Attention: Leonard Chan <leona...@google.com>
        Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
        Gerrit-Attention: Chris Drouillard <cdr...@google.com>
        Gerrit-Attention: Chris Suter <csu...@google.com>
        Gerrit-Attention: James Sullivan <jfsu...@google.com>
        Gerrit-Attention: Roland McGrath <mcgr...@google.com>
        Gerrit-Comment-Date: Thu, 04 Sep 2025 22:10:14 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes

        --
        You received this message because you are subscribed to the Google Groups "owners-override" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
        To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/68f7226afee69de232d2a88e0c5903e5cb5bc87f-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
        satisfied_requirement
        open
        diffy

        'Leonard Chan (Gerrit)' via owners-override

        unread,
        Sep 4, 2025, 6:12:30 PM (3 days ago) Sep 4
        to James Robinson, Owners Override, Chris Drouillard, CQ Bot, Chris Suter, Rubber Stamper (Chrome), James Sullivan, Roland McGrath, GI Try Builder, GI Roller
        Attention needed from Chris Drouillard, Chris Suter, James Sullivan, Owners Override and Roland McGrath

        Leonard Chan voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Chris Drouillard
        • Chris Suter
        • James Sullivan
        • Owners Override
        • Roland McGrath
        Submit Requirements:
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedCommit-Message-Has-Tags
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: fuchsia
        Gerrit-Branch: main
        Gerrit-Change-Id: I1707ee411f124ab768a6136d4dcbc7327a10d563
        Gerrit-Change-Number: 1361766
        Gerrit-PatchSet: 1
        Gerrit-Owner: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Chris Drouillard <cdr...@google.com>
        Gerrit-Reviewer: Chris Suter <csu...@google.com>
        Gerrit-Reviewer: James Robinson <jam...@google.com>
        Gerrit-Reviewer: James Sullivan <jfsu...@google.com>
        Gerrit-Reviewer: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
        Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>
        Gerrit-Reviewer: Rubber Stamper (Chrome) <rubber-...@appspot.gserviceaccount.com>
        Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
        Gerrit-Attention: Chris Drouillard <cdr...@google.com>
        Gerrit-Attention: Chris Suter <csu...@google.com>
        Gerrit-Attention: James Sullivan <jfsu...@google.com>
        Gerrit-Attention: Roland McGrath <mcgr...@google.com>
        Gerrit-Comment-Date: Thu, 04 Sep 2025 22:12:21 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes

        --
        You received this message because you are subscribed to the Google Groups "owners-override" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
        To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9c7bdcfc89df8bad39a5080f2ea9b3b3020670b6-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
        satisfied_requirement
        open
        diffy

        'Leonard Chan (Gerrit)' via owners-override

        unread,
        Sep 4, 2025, 6:13:51 PM (3 days ago) Sep 4
        to Francois Rousseau, Owners Override, Chris Drouillard, CQ Bot, Chris Suter, Rubber Stamper (Chrome), James Sullivan, Roland McGrath, GI Try Builder, GI Roller

        Leonard Chan abandoned this change

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Review
        • requirement satisfiedCommit-Message-Has-Tags
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: abandon
        Gerrit-Project: fuchsia
        Gerrit-Branch: main
        Gerrit-Change-Id: I477fb21cf44910e552999c8d6b854f6a9b13167c
        Gerrit-Change-Number: 1361757
        Gerrit-PatchSet: 2
        Gerrit-Owner: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Chris Drouillard <cdr...@google.com>
        Gerrit-Reviewer: Chris Suter <csu...@google.com>
        Gerrit-Reviewer: Francois Rousseau <frou...@google.com>
        Gerrit-Reviewer: James Sullivan <jfsu...@google.com>
        Gerrit-Reviewer: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
        Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>
        Gerrit-Reviewer: Rubber Stamper (Chrome) <rubber-...@appspot.gserviceaccount.com>

        --
        You received this message because you are subscribed to the Google Groups "owners-override" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
        To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/3401fa470da6e3c550e8e034060c494269a21d5f-HTML%40fuchsia-review.googlesource.com.
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages