Leonard Chan would like Owners Override to review this change.
Reland "[fatfs] Temporarily disable fat-fuzzer tests when using lsan"
This reverts commit 466335a0ba97a52daa9b712bb2c2ca4e97c63bb8.
Reason for revert: This depends on a fix introduced by the clang roll which is being reverted.
Bug: 443061431
Original change's description:
> Revert "[fatfs] Temporarily disable fat-fuzzer tests when using lsan"
>
> This reverts commit 4c4396c7f2162501970115f5e6d6249d9e6e788f.
>
> Reason for revert: This was fixed upstream and rolled in via the last clang roll.
>
> Fixed: 431396031, 436923423
> Original change's description:
> > [fatfs] Temporarily disable fat-fuzzer tests when using lsan
> >
> > Disable this while we investigate the flake in fxb/431396031.
> >
> > Bugs: 431396031, 436923423
> > Change-Id: Idb5419db743967fa62ac4d0d62349bb97691b51d
> > Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1340346
> > Commit-Queue: Chris Suter <csu...@google.com>
> > Reviewed-by: Chris Suter <csu...@google.com>
> > Fuchsia-Auto-Submit: Chris Suter <csu...@google.com>
>
> Change-Id: I43d4b5a2ccaa5f9a1238a45d8fb5a409a07a4cb2
> Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1361063
> Reviewed-by: Chris Suter <csu...@google.com>
> Commit-Queue: Leonard Chan <leona...@google.com>
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Code-Review | +2 |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
This commit looks empty to me.
In between Base and Patchest 1 has the changes. Is there a way I can have it go back to patchset 1?
Commit-Queue | +2 |
Leonard ChanThis commit looks empty to me.
In between Base and Patchest 1 has the changes. Is there a way I can have it go back to patchset 1?
Done
Leonard Chan would like Owners Override to review this change.
Reland "[fatfs] Temporarily disable fat-fuzzer tests when using lsan"
This reverts commit 466335a0ba97a52daa9b712bb2c2ca4e97c63bb8.
Reason for revert: Reason for revert: This depends on a fix introduced by the clang roll which is being reverted.
Original change's description:
> Revert "[fatfs] Temporarily disable fat-fuzzer tests when using lsan"
>
> This reverts commit 4c4396c7f2162501970115f5e6d6249d9e6e788f.
>
> Reason for revert: This was fixed upstream and rolled in via the last clang roll.
>
> Fixed: 431396031, 436923423
> Original change's description:
> > [fatfs] Temporarily disable fat-fuzzer tests when using lsan
> >
> > Disable this while we investigate the flake in fxb/431396031.
> >
> > Bugs: 431396031, 436923423
> > Change-Id: Idb5419db743967fa62ac4d0d62349bb97691b51d
> > Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1340346
> > Commit-Queue: Chris Suter <csu...@google.com>
> > Reviewed-by: Chris Suter <csu...@google.com>
> > Fuchsia-Auto-Submit: Chris Suter <csu...@google.com>
>
> Change-Id: I43d4b5a2ccaa5f9a1238a45d8fb5a409a07a4cb2
> Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1361063
> Reviewed-by: Chris Suter <csu...@google.com>
> Commit-Queue: Leonard Chan <leona...@google.com>
diff --git a/src/storage/fuchsia-fatfs/BUILD.gn b/src/storage/fuchsia-fatfs/BUILD.gn
index d8d46c3..f791e29 100644
--- a/src/storage/fuchsia-fatfs/BUILD.gn
+++ b/src/storage/fuchsia-fatfs/BUILD.gn
@@ -69,6 +69,10 @@
"//src/lib/fuzzing/rust:fuzz",
"//third_party/rust_crates:futures",
]
+
+ # TODO(https://fxbug.dev/436923423): Re-enable this for lsan once the issue
+ # regarding leak checking is fixed.
+ exclude_toolchain_tags = [ "lsan" ]
}
fuchsia_fuzzer_component("fat-fuzzer-component") {
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Code-Review | +2 |
Owners-Override | +1 |
I think the rubber stamper will also be OK with this change. It hasn't run yet
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |