'Oliver Newman (Gerrit)' via owners-override

unread,

Apr 13, 2026, 5:31:32 PM (7 days ago) Apr 13

to Owners Override

Attention needed from Owners Override

Oliver Newman has uploaded the change for review

Oliver Newman would like Owners Override to review this change.

Commit message

[owners] Fix broken OWNERS includes

Most of these breakages happened when the target file got renamed or
deleted. Making the "owners" shac check blocking will ensure that CQ
catches broken includes resulting from such changes.

Depends-on: turquoise-internal:I87c9327bddeadc64cf94cf6b26e41812d0bba868

Change-Id: Ic3ea800fa032841f8bda10a2f6c6bbafca966d78

Change diff

diff --git a/scripts/shac/owners.star b/scripts/shac/owners.star
index cb77735..2826713 100644
--- a/scripts/shac/owners.star
+++ b/scripts/shac/owners.star
@@ -31,9 +31,8 @@
         res = proc.wait()
         for finding in json.decode(res.stdout):
             for line in finding["lines"]:
-                #TODO(danikay) Change to error once broken includes are fixed.
                 ctx.emit.finding(
-                    level = "warning",
+                    level = "error",
                     filepath = f,
                     message = BROKEN_INCLUDE_MSG,
                     line = line,
diff --git a/sdk/fidl/fuchsia.net.masquerade/OWNERS b/sdk/fidl/fuchsia.net.masquerade/OWNERS
index 8f83e63..c18bbcc0 100644
--- a/sdk/fidl/fuchsia.net.masquerade/OWNERS
+++ b/sdk/fidl/fuchsia.net.masquerade/OWNERS
@@ -1,3 +1 @@
 include /src/connectivity/network/OWNERS  # Netstack team can +2
-
-include /src/connectivity/policy/netcfg/OWNERS
diff --git a/src/developer/ffx/tests/cli-goldens/goldens/ffx/efi/OWNERS b/src/developer/ffx/tests/cli-goldens/goldens/ffx/efi/OWNERS
index 07aea5b..af9952c 100644
--- a/src/developer/ffx/tests/cli-goldens/goldens/ffx/efi/OWNERS
+++ b/src/developer/ffx/tests/cli-goldens/goldens/ffx/efi/OWNERS
@@ -1 +1 @@
-include /src/developer/ffx/plugins/efi/OWNERS
\ No newline at end of file
+include /src/developer/ffx/tools/efi/OWNERS
diff --git a/src/devices/lib/sysmem/OWNERS b/src/devices/lib/sysmem/OWNERS
index 69391da..74fb0ac 100644
--- a/src/devices/lib/sysmem/OWNERS
+++ b/src/devices/lib/sysmem/OWNERS
@@ -1 +1 @@
-include /src/devices/sysmem/OWNERS
+include /src/sysmem/OWNERS
diff --git a/src/sys/lib/payload_streamer/OWNERS b/src/sys/lib/payload_streamer/OWNERS
index 002d7cf..48e1364 100644
--- a/src/sys/lib/payload_streamer/OWNERS
+++ b/src/sys/lib/payload_streamer/OWNERS
@@ -1,3 +1,3 @@
-include /src/recovery/system/installer/OWNERS
+include /src/recovery/lib/installer/OWNERS
 
 # Component: Workstation>platform
diff --git a/third_party/mini_chromium/OWNERS b/third_party/mini_chromium/OWNERS
index eef1bc3..ff07fc4 100644
--- a/third_party/mini_chromium/OWNERS
+++ b/third_party/mini_chromium/OWNERS
@@ -3,5 +3,4 @@
 # DOCS: https://fuchsia.dev/reference/tools/fx/cmd/update-3p-owners
 
 include /src/developer/debug/OWNERS
-include /src/developer/forensics/crash_reports/OWNERS
-include /src/developer/forensics/exceptions/OWNERS
+include /src/developer/forensics/OWNERS
diff --git a/third_party/rust_crates/ask2patch/byteorder/OWNERS b/third_party/rust_crates/ask2patch/byteorder/OWNERS
index 645c13e..4ff5cd9 100644
--- a/third_party/rust_crates/ask2patch/byteorder/OWNERS
+++ b/third_party/rust_crates/ask2patch/byteorder/OWNERS
@@ -7,7 +7,6 @@
 include /src/connectivity/lib/packet-formats/OWNERS
 include /src/connectivity/lowpan/lib/spinel_pack/OWNERS
 include /src/connectivity/network/dhcpv6/OWNERS
-include /src/connectivity/ppp/OWNERS
 include /src/connectivity/wlan/OWNERS
 include /src/developer/ffx/OWNERS
 include /src/developer/ffx/lib/emulator_instance/OWNERS
@@ -18,7 +17,6 @@
 include /src/fonts/OWNERS
 include /src/lib/diagnostics/OWNERS
 include /src/lib/diagnostics/inspect/format/rust/OWNERS
-include /src/lib/flyweights/OWNERS
 include /src/lib/windowed-stats/OWNERS
 include /src/media/OWNERS
 include /src/media/audio/OWNERS
diff --git a/zircon/system/utest/cmdline/OWNERS b/zircon/system/utest/cmdline/OWNERS
deleted file mode 100644
index 7dec3d0..0000000
--- a/zircon/system/utest/cmdline/OWNERS
+++ /dev/null
@@ -1 +0,0 @@
-include ../../ulib/cmdline/OWNERS

Change information

Files:

M scripts/shac/owners.star
M sdk/fidl/fuchsia.net.masquerade/OWNERS
M src/developer/ffx/tests/cli-goldens/goldens/ffx/efi/OWNERS
M src/devices/lib/sysmem/OWNERS
M src/sys/lib/payload_streamer/OWNERS
M third_party/mini_chromium/OWNERS
M third_party/rust_crates/ask2patch/byteorder/OWNERS
D zircon/system/utest/cmdline/OWNERS

Change size: S

Delta: 8 files changed, 5 insertions(+), 12 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Owners Override

Submit Requirements:

Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/846d546b9e7a1272555b826f8f7ef2f5f94eba58-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'Oliver Newman (Gerrit)' via owners-override

unread,

Apr 13, 2026, 5:31:34 PM (7 days ago) Apr 13

to Owners Override, Jerry Belton, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com

Attention needed from Owners Override

Oliver Newman voted Fuchsia-Auto-Submit+1

Fuchsia-Auto-Submit

+1

Open in Gerrit

Related details

Attention is currently required from:

Owners Override

Submit Requirements:

Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/846d546b9e7a1272555b826f8f7ef2f5f94eba58-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'Adam Barth (Gerrit)' via owners-override

unread,

Apr 13, 2026, 5:40:31 PM (7 days ago) Apr 13

to Oliver Newman, Owners Override, Jerry Belton, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com

Attention needed from Oliver Newman and Owners Override

Adam Barth voted Owners-Override+1

Owners-Override

+1

Open in Gerrit

Related details

Attention is currently required from:

Oliver Newman
Owners Override

Submit Requirements:

Code-Owners

Code-Review
Dependencies-Satisfied
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0deb00c8d2f68e230aa44a2face1a1d128594a78-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

unsatisfied_requirement

open

diffy

'Oliver Newman (Gerrit)' via owners-override

unread,

Apr 14, 2026, 7:23:33 PM (6 days ago) Apr 14

to cl-deps...@fuchsia-internal-service-accts.iam.gserviceaccount.com, Adam Barth, Owners Override, Jerry Belton, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com

Attention needed from Adam Barth and Owners Override

Oliver Newman voted and added 1 comment

Votes added by Oliver Newman

Fuchsia-Auto-Submit

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Oliver Newman . resolved

@aba...@google.com mind providing Owners-Override+1 again? I had to upload a new patchset to resolve a conflict with an OWNERS file that got deleted by another CL.

Open in Gerrit

Related details

Attention is currently required from:

Adam Barth
Owners Override

Submit Requirements:

Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/efd013a33e7a0f9b76e3f5f4bc713331ac8330e1-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

unsatisfied_requirement

satisfied_requirement

open

diffy

'James Robinson (Gerrit)' via owners-override

unread,

Apr 15, 2026, 12:51:31 PM (5 days ago) Apr 15

to Oliver Newman, cl-deps...@fuchsia-internal-service-accts.iam.gserviceaccount.com, Adam Barth, Owners Override, Jerry Belton, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com

Attention needed from Adam Barth, Oliver Newman and Owners Override

James Robinson voted Owners-Override+1

Owners-Override

+1

Open in Gerrit

Related details

Attention is currently required from:

Adam Barth
Oliver Newman
Owners Override

Submit Requirements:

Code-Owners

Code-Review
Dependencies-Satisfied
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/3626ebd7888825652d8a96a6456878fd140c8224-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)' via owners-override

unread,

Apr 15, 2026, 1:43:02 PM (5 days ago) Apr 15

to Oliver Newman, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, James Robinson, cl-deps...@fuchsia-internal-service-accts.iam.gserviceaccount.com, Adam Barth, Owners Override, Jerry Belton

fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes

Unreviewed changes

4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/sys/lib/payload_streamer/OWNERS
Insertions: 0, Deletions: 3.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:

[owners] Fix broken OWNERS includes

Most of these breakages happened when the target file got renamed or
deleted. Making the "owners" shac check blocking will ensure that CQ
catches broken includes resulting from such changes.

Depends-on: turquoise-internal:I87c9327bddeadc64cf94cf6b26e41812d0bba868

Change-Id: Ic3ea800fa032841f8bda10a2f6c6bbafca966d78

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1573854

Reviewed-by: Jerry Belton <jce...@google.com>

Commit-Queue: Oliver Newman <oliver...@google.com>

Dependencies-Satisfied: cl-deps...@fuchsia-internal-service-accts.iam.gserviceaccount.com <cl-deps...@fuchsia-internal-service-accts.iam.gserviceaccount.com>

Fuchsia-Auto-Submit: Oliver Newman <oliver...@google.com>

Owners-Override: James Robinson <jam...@google.com>

Files:

M scripts/shac/owners.star
M sdk/fidl/fuchsia.net.masquerade/OWNERS
M src/developer/ffx/tests/cli-goldens/goldens/ffx/efi/OWNERS
M src/devices/lib/sysmem/OWNERS

M third_party/mini_chromium/OWNERS
M third_party/rust_crates/ask2patch/byteorder/OWNERS
D zircon/system/utest/cmdline/OWNERS

Change size: S

Delta: 7 files changed, 4 insertions(+), 11 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +2 by Jerry Belton
Dependencies-Satisfied: +1 by cl-deps...@fuchsia-internal-service-accts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/353ecc61648c1e152069bd5272fc8e64b5753afc-HTML%40fuchsia-review.googlesource.com.

open

diffy

satisfied_requirement

'global-integration-ci-builder@fuchsia-infra.iam.gserviceaccount.com (Gerrit)' via owners-override

unread,

Apr 15, 2026, 1:55:18 PM (5 days ago) Apr 15

to Oliver Newman, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, James Robinson, cl-deps...@fuchsia-internal-service-accts.iam.gserviceaccount.com, Adam Barth, Owners Override, Jerry Belton

Message from global-integra...@fuchsia-infra.iam.gserviceaccount.com

Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1233672

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/8a9d3583a065f6edc2064e5ab6ac3e911321c6e1-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[S] Change in fuchsia/fuchsia[main]: [owners] Fix broken OWNERS includes

'Oliver Newman (Gerrit)' via owners-override

Oliver Newman has uploaded the change for review

Commit message

Change diff

Change information

Related details

'Oliver Newman (Gerrit)' via owners-override

Oliver Newman voted Fuchsia-Auto-Submit+1

Related details

'Adam Barth (Gerrit)' via owners-override

Adam Barth voted Owners-Override+1

Related details

'Oliver Newman (Gerrit)' via owners-override

Oliver Newman voted and added 1 comment

Votes added by Oliver Newman

1 comment

Related details

'James Robinson (Gerrit)' via owners-override

James Robinson voted Owners-Override+1

Related details

'fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)' via owners-override

fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes

Unreviewed changes

Change information

'global-integration-ci-builder@fuchsia-infra.iam.gserviceaccount.com (Gerrit)' via owners-override

Message from global-integra...@fuchsia-infra.iam.gserviceaccount.com

Related details