Groups keyboard shortcuts have been updated
Dismiss
See shortcuts
[L] Change in fuchsia/fuchsia[main]: [vfs] Simplify serving new directory connections
2 views
Skip to first unread message
'Brandon Castellano (Gerrit)' via owners-override
Apr 14, 2025, 5:19:24 PMApr 14
to Owners Override
Attention needed from Owners Override
Brandon Castellano has uploaded the change for review![]( "Open in Gerrit")
Brandon Castellano would like Owners Override to review this change.
Commit message
[vfs] Simplify serving new directory connections
Use new helper functions to simplify serving directories. This avoids
the need to import many types/traits from the Rust VFS crate, as well as
the need to specify the flags twice.
Change-Id: I340e08090b95475b94a999a01d26f62bed9dfe64
Change diff
Change information
Files:
- M sdk/lib/driver_test_realm/tests/test.rs
- M src/connectivity/network/testing/netemul/service/src/main.rs
- M src/fonts/testing/mock_font_resolver/src/main.rs
- M src/lib/fuchsia-component-test/realm_builder_server/src/builtin.rs
- M src/lib/fuchsia-component/server/src/lib.rs
- M src/lib/process_builder/src/process_builder.rs
- M src/recovery/system/src/ota.rs
- M src/recovery/system/src/ota_main.rs
- M src/storage/lib/vfs/rust/src/lib.rs
- M src/sys/component_manager/src/model/testing/out_dir.rs
- M src/sys/component_manager/tests/resolvers/boot/src/integration_test.rs
- M src/sys/component_manager/tests/services/src/service_routing_test.rs
- M src/sys/full-resolver/src/main.rs
- M src/sys/lib/elf_runner/src/runtime_dir.rs
- M src/sys/pkg/bin/pkg-cache/src/base_resolver/package.rs
- M src/sys/pkg/bin/pkg-cache/src/cache_service.rs
- M src/sys/pkg/bin/pkg-cache/src/main.rs
- M src/sys/pkg/lib/package-directory/src/meta_as_dir.rs
- M src/sys/pkg/lib/package-directory/src/meta_subdir.rs
- M src/sys/pkg/lib/package-directory/src/non_meta_subdir.rs
- M src/sys/pkg/lib/package-directory/src/root_dir.rs
- M src/sys/pkg/tests/isolated-ota/src/lib.rs
- M src/sys/pkg/tests/pkg-cache-as-base-resolver/as-a-component-resolver/fake_dependencies.rs
- M src/sys/pkg/tests/pkg-cache-as-base-resolver/using-realm-builder/src/lib.rs
- M src/sys/pkg/tests/pkg-cache/src/lib.rs
- M src/sys/pkg/tests/pkg-resolver/src/lib.rs
- M src/sys/pkg/tests/pkgctl/src/lib.rs
- M src/sys/test_runners/src/elf/elf_component.rs
Change size: L
Delta: 28 files changed, 148 insertions(+), 288 deletions(-)
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/1f2ffb28f9160fb8c280d2c1f7a8a8e7585f8a57-HTML%40fuchsia-review.googlesource.com.
'Adam Barth (Gerrit)' via owners-override
Apr 14, 2025, 5:47:58 PMApr 14
to Brandon Castellano, Owners Override, Stephen Demos, GI Try Builder, CQ Bot
Attention needed from Brandon Castellano and Owners Override
Adam Barth voted Owners-Override+1![]( "Open in Gerrit")
Attention is currently required from:
- Brandon Castellano
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c60a600fead672c37a633049c8c79521521ddce2-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Brandon Castellano (Gerrit)' via owners-override
Apr 14, 2025, 6:12:06 PMApr 14
to Adam Barth, Owners Override, Stephen Demos, GI Try Builder, CQ Bot
Attention needed from Owners Override
Brandon Castellano voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9afcef942f70bcba1c58d70fcc2687f350e032d4-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
Apr 14, 2025, 6:12:32 PMApr 14
to Brandon Castellano, Adam Barth, Owners Override, Stephen Demos, GI Try Builder
CQ Bot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[vfs] Simplify serving new directory connections
Use new helper functions to simplify serving directories. This avoids
the need to import many types/traits from the Rust VFS crate, as well as
the need to specify the flags twice.
Change-Id: I340e08090b95475b94a999a01d26f62bed9dfe64
Reviewed-by: Stephen Demos <sde...@google.com>
Commit-Queue: Brandon Castellano <bcas...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by Stephen Demos
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/fa1bf4241a8470ec8199d909fae37d93696a8702-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Apr 14, 2025, 6:15:19 PMApr 14
to Brandon Castellano, CQ Bot, Adam Barth, Owners Override, Stephen Demos, GI Try Builder
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: http://go/roll-cl/d69b2fa5eae9e85d9ec1c77a6914e295891556f6
Related details
Attention set is empty
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/ed17b4f0e020d6991cea89471f6717f55281b980-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages