[M] Change in fuchsia/fuchsia[main]: [power][sdk] Move fuchsia.power.broker into //sdk/fidl

0 views
Skip to first unread message

'Adam Barth (Gerrit)' via owners-override

unread,
Apr 4, 2024, 4:02:34 PMApr 4
to Owners Override
Attention needed from Owners Override

Adam Barth has uploaded the change for review

Adam Barth would like Owners Override to review this change.

Commit message

[power][sdk] Move fuchsia.power.broker into //sdk/fidl

According to
https://fuchsia.dev/fuchsia-src/development/source_code/layout?hl=en,
this FIDL library belongs in `//sdk/fidl` instead of in `//src/power`.
Change-Id: I448230386f7516025d6fec37173f70a20486e9f1

Change diff


Change information

Files:
  • M sdk/fidl/fuchsia.hardware.hrtimer/BUILD.gn
  • A sdk/fidl/fuchsia.power.broker/BUILD.gn
  • A sdk/fidl/fuchsia.power.broker/OWNERS
  • R sdk/fidl/fuchsia.power.broker/broker.fidl
  • M sdk/fidl/fuchsia.power.system/BUILD.gn
  • M sdk/lib/driver/power/cpp/BUILD.gn
  • M src/devices/block/drivers/aml-sdmmc/BUILD.gn
  • M src/devices/hrtimer/drivers/aml-hrtimer/BUILD.gn
  • M src/power/broker/BUILD.gn
  • M src/power/broker/client/BUILD.gn
  • M src/power/broker/tests/integration/BUILD.gn
  • M src/power/system-activity-governor/BUILD.gn
  • M src/power/system-activity-governor/integration/tests/BUILD.gn
  • M src/power/testing/fake-broker/BUILD.gn
  • M src/starnix/kernel/BUILD.gn
  • M src/sys/time/timekeeper/BUILD.gn
Change size: M
Delta: 16 files changed, 53 insertions(+), 38 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedAPI-Review
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I448230386f7516025d6fec37173f70a20486e9f1
Gerrit-Change-Number: 1021157
Gerrit-PatchSet: 6
Gerrit-Owner: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Kyle Gong <kg...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/03081a98832b169d1cae2633a80775861bbd160b-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
Apr 5, 2024, 1:09:50 AMApr 5
to Hunter Freyer, Owners Override, Kyle Gong, Tricium, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, CQ Bot
Attention needed from Hunter Freyer and Owners Override

Adam Barth voted and added 1 comment

Votes added by Adam Barth

API-Review+1
Fuchsia-Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Adam Barth . resolved

Hunter: I can haz owners-override?

Open in Gerrit

Related details

Attention is currently required from:
  • Hunter Freyer
  • Owners Override
Submit Requirements:
  • requirement satisfiedAPI-Review
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I448230386f7516025d6fec37173f70a20486e9f1
Gerrit-Change-Number: 1021157
Gerrit-PatchSet: 6
Gerrit-Owner: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Attention: Hunter Freyer <hjfr...@google.com>
Gerrit-Comment-Date: Fri, 05 Apr 2024 05:09:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e32d55bc7ffc91f2c490290889f81ce856fefdf1-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
Apr 5, 2024, 1:09:57 AMApr 5
to Hunter Freyer, Owners Override, Kyle Gong, Tricium, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, CQ Bot
Attention needed from Hunter Freyer and Owners Override

Adam Barth voted Commit-Queue+1

Commit-Queue+1
Gerrit-Comment-Date: Fri, 05 Apr 2024 05:09:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/1858a88a1d460de5ace67be4b22d7aba86e06c70-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Hunter Freyer (Gerrit)' via owners-override

unread,
Apr 5, 2024, 9:44:41 AMApr 5
to Adam Barth, Owners Override, Kyle Gong, Tricium, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, CQ Bot
Attention needed from Adam Barth and Owners Override

Hunter Freyer voted and added 1 comment

Votes added by Hunter Freyer

Owners-Override+1

1 comment

Patchset-level comments
Adam Barth . resolved

Hunter: I can haz owners-override?

Hunter Freyer

IT IS DONE

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Barth
  • Owners Override
Submit Requirements:
  • requirement satisfiedAPI-Review
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I448230386f7516025d6fec37173f70a20486e9f1
Gerrit-Change-Number: 1021157
Gerrit-PatchSet: 6
Gerrit-Owner: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Kyle Gong <kg...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Adam Barth <aba...@google.com>
Gerrit-Comment-Date: Fri, 05 Apr 2024 13:44:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Adam Barth <aba...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/058d9e4f350e6cfd186982b739b0ab4399b279a1-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Apr 5, 2024, 9:45:25 AMApr 5
to Adam Barth, Auto-Submit, Hunter Freyer, Owners Override, Kyle Gong, Tricium, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com

CQ Bot submitted the change with unreviewed changes

Unreviewed changes

4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/power/broker/src/lib.rs
Insertions: 0, Deletions: 2.

@@ -1,2 +0,0 @@
-// For forwarding library. Delete this file when soft transition complete.
-use fidl_fuchsia_power_broker as _;
```
```
The name of the file: src/power/broker/BUILD.gn
Insertions: 3, Deletions: 6.

@@ -21,13 +21,10 @@
]
}

-# Forwarding declartion for //vendor/* dependencies.
+# Forwarding declaration for //vendor/* dependencies.
# Remove after soft transition.
-rustc_library("fuchsia.power.broker_rust") {
- name = "fuchsia-power-broker-forwarding"
- edition = "2021"
- sources = [ "src/lib.rs" ]
- deps = [ "//sdk/fidl/fuchsia.power.broker:fuchsia.power.broker_rust" ]
+group("fuchsia.power.broker_rust") {
+ public_deps = [ "//sdk/fidl/fuchsia.power.broker:fuchsia.power.broker_rust" ]
visibility = [ "//vendor/*" ]
}

```
```
The name of the file: sdk/fidl/fuchsia.power.broker/OWNERS
Insertions: 4, Deletions: 0.

@@ -0,0 +1,4 @@
+clar...@google.com
+di...@google.com
+kg...@google.com
+mbru...@google.com
```

Change information

Commit message:
[power][sdk] Move fuchsia.power.broker into //sdk/fidl

According to
https://fuchsia.dev/fuchsia-src/development/source_code/layout?hl=en,
this FIDL library belongs in `//sdk/fidl` instead of in `//src/power`.
Change-Id: I448230386f7516025d6fec37173f70a20486e9f1
API-Review: Adam Barth <aba...@google.com>
Fuchsia-Auto-Submit: Adam Barth <aba...@google.com>
Reviewed-by: Kyle Gong <kg...@google.com>
Owners-Override: Hunter Freyer <hjfr...@google.com>
Files:
  • M sdk/fidl/fuchsia.hardware.hrtimer/BUILD.gn
  • A sdk/fidl/fuchsia.power.broker/BUILD.gn
  • A sdk/fidl/fuchsia.power.broker/OWNERS
  • R sdk/fidl/fuchsia.power.broker/broker.fidl
  • M sdk/fidl/fuchsia.power.system/BUILD.gn
  • M sdk/lib/driver/power/cpp/BUILD.gn
  • M src/devices/block/drivers/aml-sdmmc/BUILD.gn
  • M src/devices/hrtimer/drivers/aml-hrtimer/BUILD.gn
  • M src/power/broker/BUILD.gn
  • M src/power/broker/client/BUILD.gn
  • M src/power/broker/tests/integration/BUILD.gn
  • M src/power/system-activity-governor/BUILD.gn
  • M src/power/system-activity-governor/integration/tests/BUILD.gn
  • M src/power/testing/fake-broker/BUILD.gn
  • M src/starnix/kernel/BUILD.gn
  • M src/sys/time/timekeeper/BUILD.gn
Change size: M
Delta: 16 files changed, 53 insertions(+), 38 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedAPI-Review: +1 by Adam Barth
  • requirement satisfiedCode-Review: +2 by Kyle Gong
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I448230386f7516025d6fec37173f70a20486e9f1
Gerrit-Change-Number: 1021157
Gerrit-PatchSet: 7
Gerrit-Owner: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Kyle Gong <kg...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5c9f3d02d5a8ffd5006b2df1585e4749e1240a18-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Apr 5, 2024, 9:50:20 AMApr 5
to Adam Barth, CQ Bot, Auto-Submit, Hunter Freyer, Owners Override, Kyle Gong, Tricium, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedAPI-Review
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I448230386f7516025d6fec37173f70a20486e9f1
Gerrit-Change-Number: 1021157
Gerrit-PatchSet: 7
Gerrit-Owner: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Kyle Gong <kg...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Fri, 05 Apr 2024 13:50:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/26a9dd4bdcae03e79d66c289acf27d3e9016583f-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages