[XS] Change in fuchsia/fuchsia[main]: [mapped-vmo] Add dkoloski@google.com as an owner

0 views
Skip to first unread message

'Ben Keller (Gerrit)' via owners-override

unread,
Apr 2, 2024, 3:38:36 PMApr 2
to Owners Override, David Koloski
Attention needed from Owners Override

Ben Keller voted

Commit-Queue+1
Fuchsia-Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I8442bb8b2b4d1ed4f0d60892325fdd22bc59ff85
Gerrit-Change-Number: 1019273
Gerrit-PatchSet: 1
Gerrit-Owner: Ben Keller <galb...@google.com>
Gerrit-Reviewer: Ben Keller <galb...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: David Koloski <dkol...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Tue, 02 Apr 2024 19:38:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/277a38154a052cb0f8f653805f78b61f8d6de8ca-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'Ben Keller (Gerrit)' via owners-override

unread,
Apr 2, 2024, 3:38:36 PMApr 2
to Owners Override, David Koloski
Attention needed from Owners Override

Ben Keller has uploaded the change for review

Ben Keller would like Owners Override to review this change.

Commit message

[mapped-vmo] Add dkol...@google.com as an owner

The library has been unowned since the previous owner left.
dkol...@google.com has volunteered to be in charge of reviewing
changes to the library and is a member of the Rust team and also
the unsafe Rust team.
Change-Id: I8442bb8b2b4d1ed4f0d60892325fdd22bc59ff85

Change diff

diff --git a/src/lib/mapped-vmo/OWNERS b/src/lib/mapped-vmo/OWNERS
new file mode 100644
index 0000000..8abf3d2
--- /dev/null
+++ b/src/lib/mapped-vmo/OWNERS
@@ -0,0 +1 @@
+dkol...@google.com

Change information

Files:
  • A src/lib/mapped-vmo/OWNERS
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I8442bb8b2b4d1ed4f0d60892325fdd22bc59ff85
Gerrit-Change-Number: 1019273
Gerrit-PatchSet: 1
Gerrit-Owner: Ben Keller <galb...@google.com>
Gerrit-Reviewer: Ben Keller <galb...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: David Koloski <dkol...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/277a38154a052cb0f8f653805f78b61f8d6de8ca-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'David Koloski (Gerrit)' via owners-override

unread,
Apr 2, 2024, 3:41:38 PMApr 2
to Ben Keller, CQ Bot, Owners Override
Attention needed from Ben Keller and Owners Override

David Koloski voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ben Keller
  • Owners Override
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I8442bb8b2b4d1ed4f0d60892325fdd22bc59ff85
    Gerrit-Change-Number: 1019273
    Gerrit-PatchSet: 1
    Gerrit-Owner: Ben Keller <galb...@google.com>
    Gerrit-Reviewer: Ben Keller <galb...@google.com>
    Gerrit-Reviewer: David Koloski <dkol...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: Ben Keller <galb...@google.com>
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Comment-Date: Tue, 02 Apr 2024 19:41:32 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/44643f702fac096d91dfb1d7d3cadc0e1e27a6fc-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    'James Robinson (Gerrit)' via owners-override

    unread,
    Apr 4, 2024, 1:31:40 PMApr 4
    to Ben Keller, David Koloski, CQ Bot, Owners Override
    Attention needed from Ben Keller and Owners Override

    James Robinson added 1 comment

    Patchset-level comments
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ben Keller
    • Owners Override
    Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I8442bb8b2b4d1ed4f0d60892325fdd22bc59ff85
    Gerrit-Change-Number: 1019273
    Gerrit-PatchSet: 1
    Gerrit-Owner: Ben Keller <galb...@google.com>
    Gerrit-Reviewer: Ben Keller <galb...@google.com>
    Gerrit-Reviewer: David Koloski <dkol...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-CC: James Robinson <jam...@google.com>
    Gerrit-Attention: Ben Keller <galb...@google.com>
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Comment-Date: Thu, 04 Apr 2024 17:31:34 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/6f047d16e5175fe233d1d5cd980338d49bd75422-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    'Adam Barth (Gerrit)' via owners-override

    unread,
    Apr 4, 2024, 1:31:48 PMApr 4
    to Ben Keller, James Robinson, David Koloski, CQ Bot, Owners Override
    Attention needed from Ben Keller and Owners Override

    Adam Barth voted Code-Review+2

    Code-Review+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ben Keller
    • Owners Override
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I8442bb8b2b4d1ed4f0d60892325fdd22bc59ff85
    Gerrit-Change-Number: 1019273
    Gerrit-PatchSet: 1
    Gerrit-Owner: Ben Keller <galb...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Ben Keller <galb...@google.com>
    Gerrit-Reviewer: David Koloski <dkol...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-CC: James Robinson <jam...@google.com>
    Gerrit-Attention: Ben Keller <galb...@google.com>
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Comment-Date: Thu, 04 Apr 2024 17:31:43 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/79d5495ab006b61ae8fa0f8e39d7c71b4d784bdb-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    open
    diffy

    'Adam Barth (Gerrit)' via owners-override

    unread,
    Apr 4, 2024, 1:31:56 PMApr 4
    to Ben Keller, James Robinson, David Koloski, CQ Bot, Owners Override
    Attention needed from Ben Keller and Owners Override

    Adam Barth voted Owners-Override+1

    Owners-Override+1
    Gerrit-Comment-Date: Thu, 04 Apr 2024 17:31:50 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/984d204a68e64634b9ab80b29ffb939094b94b9a-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    open
    diffy

    'Ben Keller (Gerrit)' via owners-override

    unread,
    Apr 4, 2024, 1:34:40 PMApr 4
    to Auto-Submit, Adam Barth, James Robinson, David Koloski, CQ Bot, Owners Override
    Attention needed from Owners Override

    Ben Keller voted Fuchsia-Auto-Submit+0

    Fuchsia-Auto-Submit+0
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Owners Override
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I8442bb8b2b4d1ed4f0d60892325fdd22bc59ff85
    Gerrit-Change-Number: 1019273
    Gerrit-PatchSet: 1
    Gerrit-Owner: Ben Keller <galb...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
    Gerrit-Reviewer: Ben Keller <galb...@google.com>
    Gerrit-Reviewer: David Koloski <dkol...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-CC: James Robinson <jam...@google.com>
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Comment-Date: Thu, 04 Apr 2024 17:34:34 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/76c07b2a7ce1c145686d54fdacb9c0aaf1f58e6a-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    open
    diffy

    'CQ Bot (Gerrit)' via owners-override

    unread,
    Apr 4, 2024, 1:38:55 PMApr 4
    to Ben Keller, Auto-Submit, Adam Barth, James Robinson, David Koloski, Owners Override

    CQ Bot submitted the change

    Change information

    Commit message:
    [mapped-vmo] Add dkol...@google.com as an owner

    The library has been unowned since the previous owner left.
    dkol...@google.com has volunteered to be in charge of reviewing
    changes to the library and is a member of the Rust team and also
    the unsafe Rust team.
    Change-Id: I8442bb8b2b4d1ed4f0d60892325fdd22bc59ff85
    Reviewed-by: Adam Barth <aba...@google.com>
    Reviewed-by: David Koloski <dkol...@google.com>
    Owners-Override: Adam Barth <aba...@google.com>
    Files:
    • A src/lib/mapped-vmo/OWNERS
    Change size: XS
    Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by David Koloski, +2 by Adam Barth
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I8442bb8b2b4d1ed4f0d60892325fdd22bc59ff85
    Gerrit-Change-Number: 1019273
    Gerrit-PatchSet: 2
    Gerrit-Owner: Ben Keller <galb...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
    Gerrit-Reviewer: Ben Keller <galb...@google.com>
    Gerrit-Reviewer: David Koloski <dkol...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-CC: James Robinson <jam...@google.com>

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7b7b50a5f5bd2df8a3622112aa79049167c57d05-HTML%40fuchsia-review.googlesource.com.
    open
    diffy
    satisfied_requirement

    'Ben Keller (Gerrit)' via owners-override

    unread,
    Apr 4, 2024, 1:41:44 PMApr 4
    to CQ Bot, Auto-Submit, Adam Barth, James Robinson, David Koloski, Owners Override

    Ben Keller added 1 comment

    Patchset-level comments
    James Robinson . resolved

    Can we find a second owner? That's best practice ( https://fuchsia.dev/fuchsia-src/development/source_code/owners?hl=en#best_practices )

    Ben Keller

    i will find a second owner

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I8442bb8b2b4d1ed4f0d60892325fdd22bc59ff85
    Gerrit-Change-Number: 1019273
    Gerrit-PatchSet: 2
    Gerrit-Owner: Ben Keller <galb...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
    Gerrit-Reviewer: Ben Keller <galb...@google.com>
    Gerrit-Reviewer: David Koloski <dkol...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-CC: James Robinson <jam...@google.com>
    Gerrit-Comment-Date: Thu, 04 Apr 2024 17:41:37 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: James Robinson <jam...@google.com>

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/83b1b65e9a459238ebc236f538ee405966eaf002-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    open
    diffy

    'GI Roller (Gerrit)' via owners-override

    unread,
    Apr 4, 2024, 1:44:11 PMApr 4
    to Ben Keller, CQ Bot, Auto-Submit, Adam Barth, James Robinson, David Koloski, Owners Override

    Message from GI Roller

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I8442bb8b2b4d1ed4f0d60892325fdd22bc59ff85
    Gerrit-Change-Number: 1019273
    Gerrit-PatchSet: 2
    Gerrit-Owner: Ben Keller <galb...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
    Gerrit-Reviewer: Ben Keller <galb...@google.com>
    Gerrit-Reviewer: David Koloski <dkol...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-CC: James Robinson <jam...@google.com>
    Gerrit-Comment-Date: Thu, 04 Apr 2024 17:44:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0308fb17e185ef1f8e65c18f89910541705fb92b-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    open
    diffy

    'Ben Keller (Gerrit)' via owners-override

    unread,
    Apr 5, 2024, 3:34:04 PMApr 5
    to CQ Bot, GI Roller, Auto-Submit, Adam Barth, James Robinson, David Koloski, Owners Override

    Ben Keller added 1 comment

    Patchset-level comments
    James Robinson . resolved

    Can we find a second owner? That's best practice ( https://fuchsia.dev/fuchsia-src/development/source_code/owners?hl=en#best_practices )

    Ben Keller

    i will find a second owner

    Ben Keller

    a second owner has been found fxrev.dev/1021855

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I8442bb8b2b4d1ed4f0d60892325fdd22bc59ff85
    Gerrit-Change-Number: 1019273
    Gerrit-PatchSet: 2
    Gerrit-Owner: Ben Keller <galb...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
    Gerrit-Reviewer: Ben Keller <galb...@google.com>
    Gerrit-Reviewer: David Koloski <dkol...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-CC: James Robinson <jam...@google.com>
    Gerrit-Comment-Date: Fri, 05 Apr 2024 19:33:58 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Ben Keller <galb...@google.com>
    Comment-In-Reply-To: James Robinson <jam...@google.com>

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/d23b8c51914cbb1cb8f3432ca253dc9921ca259c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages