[S] Change in fuchsia/fuchsia[main]: [rust] Switch from .truncate(0) to .clear()

0 views
Skip to first unread message

'Erick Tryzelaar (Gerrit)' via owners-override

unread,
May 18, 2026, 2:25:58 PM (yesterday) May 18
to Owners Override
Attention needed from Owners Override

Erick Tryzelaar has uploaded the change for review

Erick Tryzelaar would like Owners Override to review this change.

Commit message

[rust] Switch from .truncate(0) to .clear()

An upcoming Rust lint now warns if you are doing a .truncate(0) and
suggests using .clear(), which may be more efficient.
Change-Id: Ia3ced0c04a7b6041b690198860ce6f4f91f5c874

Change diff

diff --git a/sdk/rust/zx/src/channel/mod.rs b/sdk/rust/zx/src/channel/mod.rs
index d8100db..b0f5ec1 100644
--- a/sdk/rust/zx/src/channel/mod.rs
+++ b/sdk/rust/zx/src/channel/mod.rs
@@ -154,8 +154,8 @@
     ) -> Result<(), Status> {
         loop {
             // Ensure the capacity slices are the entire `Vec`s.
-            bytes.truncate(0);
-            handles.truncate(0);
+            bytes.clear();
+            handles.clear();
             match self.read_uninit(bytes.spare_capacity_mut(), handles.spare_capacity_mut()) {
                 ChannelReadResult::Ok((byte_slice, handle_slice)) => {
                     // Drop the output slices before mutating the input buffers.
diff --git a/src/developer/ffx/command/src/describe.rs b/src/developer/ffx/command/src/describe.rs
index bc9a3be..bdb2e91 100644
--- a/src/developer/ffx/command/src/describe.rs
+++ b/src/developer/ffx/command/src/describe.rs
@@ -69,7 +69,7 @@
 fn new_line(current_line: &mut String, out: &mut String) {
     out.push('\n');
     out.push_str(current_line);
-    current_line.truncate(0);
+    current_line.clear();
 }
 
 #[cfg(test)]
diff --git a/src/developer/ffx/daemon/target/src/overnet/host_pipe.rs b/src/developer/ffx/daemon/target/src/overnet/host_pipe.rs
index 04840dd..1f5adcb 100644
--- a/src/developer/ffx/daemon/target/src/overnet/host_pipe.rs
+++ b/src/developer/ffx/daemon/target/src/overnet/host_pipe.rs
@@ -61,7 +61,7 @@
 
     pub fn clear(&self) {
         let mut buf = self.buf.borrow_mut();
-        buf.truncate(0);
+        buf.clear();
     }
 }
 
diff --git a/src/lib/fidl/rust/fidl/src/encoding.rs b/src/lib/fidl/rust/fidl/src/encoding.rs
index 1510a83..b8bbbf8 100644
--- a/src/lib/fidl/rust/fidl/src/encoding.rs
+++ b/src/lib/fidl/rust/fidl/src/encoding.rs
@@ -829,7 +829,7 @@
                     (padding_ptr as *mut u64).write_unaligned(0);
                 }
             }
-            handles.truncate(0);
+            handles.clear();
             Encoder { buf, handles, context, _dialect: PhantomData }
         }
         let mut encoder = prepare_for_encoding(context, buf, handles, T::inline_size(context));
diff --git a/src/lib/test_diagnostics/rust/src/lib.rs b/src/lib/test_diagnostics/rust/src/lib.rs
index c4277d3..9c1fc2c 100644
--- a/src/lib/test_diagnostics/rust/src/lib.rs
+++ b/src/lib/test_diagnostics/rust/src/lib.rs
@@ -182,7 +182,7 @@
             None => self.writer.write(bytes),
             Some(buf) if buf.len() + bytes.len() > self.max_capacity => {
                 self.writer.write_all(&buf)?;
-                buf.truncate(0);
+                buf.clear();
                 self.writer.write(bytes)
             }
             Some(buf) => Write::write(buf, bytes),

Change information

Files:
  • M sdk/rust/zx/src/channel/mod.rs
  • M src/developer/ffx/command/src/describe.rs
  • M src/developer/ffx/daemon/target/src/overnet/host_pipe.rs
  • M src/lib/fidl/rust/fidl/src/encoding.rs
  • M src/lib/test_diagnostics/rust/src/lib.rs
Change size: S
Delta: 5 files changed, 6 insertions(+), 6 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ia3ced0c04a7b6041b690198860ce6f4f91f5c874
Gerrit-Change-Number: 1612651
Gerrit-PatchSet: 1
Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Paul Kirth <paul...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/613d6f5eb5e72b107839a03b55a13430157a3f26-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Erick Tryzelaar (Gerrit)' via owners-override

unread,
May 18, 2026, 2:26:01 PM (yesterday) May 18
to Owners Override, Paul Kirth, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com
Attention needed from Owners Override

Erick Tryzelaar added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Erick Tryzelaar . resolved

adding owners override since it is somewhat across fuchsia.

Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ia3ced0c04a7b6041b690198860ce6f4f91f5c874
Gerrit-Change-Number: 1612651
Gerrit-PatchSet: 1
Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Paul Kirth <paul...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Mon, 18 May 2026 18:25:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/613d6f5eb5e72b107839a03b55a13430157a3f26-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'James Robinson (Gerrit)' via owners-override

unread,
May 18, 2026, 2:30:02 PM (yesterday) May 18
to Erick Tryzelaar, Owners Override, Paul Kirth, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com
Attention needed from Erick Tryzelaar and Owners Override

James Robinson voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Erick Tryzelaar
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ia3ced0c04a7b6041b690198860ce6f4f91f5c874
Gerrit-Change-Number: 1612651
Gerrit-PatchSet: 1
Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Attention: Erick Tryzelaar <etryz...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Mon, 18 May 2026 18:29:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/1bb787389dc427f998ab5d600d257b27a89b7409-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)' via owners-override

unread,
May 18, 2026, 4:45:13 PM (yesterday) May 18
to Erick Tryzelaar, James Robinson, Owners Override, Paul Kirth, global-integrat...@fuchsia-infra.iam.gserviceaccount.com
Commit message:
[rust] Switch from .truncate(0) to .clear()

An upcoming Rust lint now warns if you are doing a .truncate(0) and
suggests using .clear(), which may be more efficient.
Change-Id: Ia3ced0c04a7b6041b690198860ce6f4f91f5c874
Fuchsia-Auto-Submit: Erick Tryzelaar <etryz...@google.com>
Reviewed-by: Paul Kirth <paul...@google.com>
Owners-Override: James Robinson <jam...@google.com>
Commit-Queue: Erick Tryzelaar <etryz...@google.com>
Files:
  • M sdk/rust/zx/src/channel/mod.rs
  • M src/developer/ffx/command/src/describe.rs
  • M src/developer/ffx/daemon/target/src/overnet/host_pipe.rs
  • M src/lib/fidl/rust/fidl/src/encoding.rs
  • M src/lib/test_diagnostics/rust/src/lib.rs
Change size: S
Delta: 5 files changed, 6 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Paul Kirth
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ia3ced0c04a7b6041b690198860ce6f4f91f5c874
Gerrit-Change-Number: 1612651
Gerrit-PatchSet: 2
Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Paul Kirth <paul...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7240c40144c277a8932518ef0e914c508416be80-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'global-integration-ci-builder@fuchsia-infra.iam.gserviceaccount.com (Gerrit)' via owners-override

unread,
May 18, 2026, 5:00:27 PM (yesterday) May 18
to Erick Tryzelaar, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com, James Robinson, Owners Override, Paul Kirth, global-integrat...@fuchsia-infra.iam.gserviceaccount.com

Message from global-integra...@fuchsia-infra.iam.gserviceaccount.com

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ia3ced0c04a7b6041b690198860ce6f4f91f5c874
Gerrit-Change-Number: 1612651
Gerrit-PatchSet: 2
Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Paul Kirth <paul...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/d09fd59057e7c5b039dc636cfd0eacdc8787005e-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages