[XL] Change in fuchsia/fuchsia[main]: [rust][3p] Consume flyweights from crates.io.

['Adam Perry (Gerrit)' via owners-override]

Attention needed from Owners Override

Adam Perry has uploaded the change for review

Adam Perry would like Owners Override to review this change.

Commit message

[rust][3p] Consume flyweights from crates.io.

This library has no platform/OS dependencies and can easily be developed on
GitHub which allows other teams at Google to consume the library as a
dependency without having to fetch all of Fuchsia.

I made some changes in the process of exporting the crate:

1. additional docs
2. moved serde support to an optional dependency
3. moved schemars to an optional feature/dependency
4. `impl Into` -> `impl From`
5. formatting changes because no Fuchsia rustfmt config
6. a bunch of clippy lint fixes
7. ported benchmark to newer version of vanilla criterion
8. updated readme to match google releasing template
9. added static assertion to head off common feature
   request for Borrow<str> impl

Change-Id: I6514764b8292cc7dec35afdd676326453ff393f7

Change diff

Change information

Files:

• M src/developer/ffx/plugins/log/command_output/src/lib.rs
• M src/diagnostics/archivist/BUILD.gn
• M src/lib/BUILD.gn
• M src/lib/diagnostics/data/rust/BUILD.gn
• M src/lib/diagnostics/log/message/rust/BUILD.gn
• D src/lib/flyweights/BUILD.gn
• D src/lib/flyweights/METADATA.textproto
• D src/lib/flyweights/OWNERS
• D src/lib/flyweights/README.md
• D src/lib/flyweights/benchmarks/BUILD.gn
• D src/lib/flyweights/benchmarks/meta/benches.cml
• D src/lib/flyweights/benchmarks/src/main.rs
• M src/performance/lib/fxt/rust/BUILD.gn
• M src/starnix/kernel/BUILD.gn
• M src/storage/ext4/lib/metadata/BUILD.gn
• M src/sys/component_manager/BUILD.gn
• M src/sys/lib/cm_types/BUILD.gn
• M src/sys/lib/moniker/BUILD.gn
• M src/tests/end_to_end/perf/BUILD.gn
• M third_party/rust_crates/BUILD.gn
• M third_party/rust_crates/Cargo.lock
• M third_party/rust_crates/Cargo.toml
• M third_party/rust_crates/vendor/BUILD.bazel
• M third_party/rust_crates/vendor/defs.bzl
• A third_party/rust_crates/vendor/flyweights-0.1.5/.cargo-checksum.json
• A third_party/rust_crates/vendor/flyweights-0.1.5/.cargo_vcs_info.json
• A third_party/rust_crates/vendor/flyweights-0.1.5/.github/workflows/presubmit.yml
• A third_party/rust_crates/vendor/flyweights-0.1.5/BUILD.bazel
• A third_party/rust_crates/vendor/flyweights-0.1.5/Cargo.lock
• A third_party/rust_crates/vendor/flyweights-0.1.5/Cargo.toml
• A third_party/rust_crates/vendor/flyweights-0.1.5/Cargo.toml.orig
• A third_party/rust_crates/vendor/flyweights-0.1.5/LICENSE
• A third_party/rust_crates/vendor/flyweights-0.1.5/README.md
• A third_party/rust_crates/vendor/flyweights-0.1.5/benches/basic.rs
• R third_party/rust_crates/vendor/flyweights-0.1.5/src/lib.rs
• R third_party/rust_crates/vendor/flyweights-0.1.5/src/raw.rs
• M tools/fidl/abi-compat/BUILD.gn

Change size: XL

Delta: 37 files changed, 1659 insertions(+), 359 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

• Owners Override

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I6514764b8292cc7dec35afdd676326453ff393f7

Gerrit-Change-Number: 1312447

Gerrit-PatchSet: 5

Gerrit-Owner: Adam Perry <adam...@google.com>

Gerrit-Reviewer: Adam Perry <adam...@google.com>

Gerrit-Reviewer: David Koloski <dkol...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/8eeb3616679cf2cf70e121e96111df9aa631050c-HTML%40fuchsia-review.googlesource.com.

['Kevin Lindkvist (Gerrit)' via owners-override]

Attention needed from Adam Perry and Owners Override

Kevin Lindkvist voted Owners-Override+1

Owners-Override

+1

Open in Gerrit

Related details

Attention is currently required from:

• Adam Perry
• Owners Override

Submit Requirements:

• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I6514764b8292cc7dec35afdd676326453ff393f7

Gerrit-Change-Number: 1312447

Gerrit-PatchSet: 5

Gerrit-Owner: Adam Perry <adam...@google.com>

Gerrit-Reviewer: Adam Perry <adam...@google.com>

Gerrit-Reviewer: David Koloski <dkol...@google.com>

Gerrit-Reviewer: Kevin Lindkvist <lind...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Attention: Adam Perry <adam...@google.com>

Gerrit-Comment-Date: Tue, 01 Jul 2025 14:50:16 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7a56acf978b71be3438bdf86ea7a3f690f78dc87-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['CQ Bot (Gerrit)' via owners-override]

CQ Bot submitted the change

Change information

Commit message:

[rust][3p] Consume flyweights from crates.io.

This library has no platform/OS dependencies and can easily be developed on
GitHub which allows other teams at Google to consume the library as a
dependency without having to fetch all of Fuchsia.

I made some changes in the process of exporting the crate:

1. additional docs
2. moved serde support to an optional dependency
3. moved schemars to an optional feature/dependency
4. `impl Into` -> `impl From`
5. formatting changes because no Fuchsia rustfmt config
6. a bunch of clippy lint fixes
7. ported benchmark to newer version of vanilla criterion
8. updated readme to match google releasing template
9. added static assertion to head off common feature
   request for Borrow<str> impl

Change-Id: I6514764b8292cc7dec35afdd676326453ff393f7

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1312447

Reviewed-by: David Koloski <dkol...@google.com>

Owners-Override: Kevin Lindkvist <lind...@google.com>

Fuchsia-Auto-Submit: Adam Perry <adam...@google.com>

Commit-Queue: Adam Perry <adam...@google.com>

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +2 by David Koloski

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I6514764b8292cc7dec35afdd676326453ff393f7

Gerrit-Change-Number: 1312447

Gerrit-PatchSet: 6

Gerrit-Owner: Adam Perry <adam...@google.com>

Gerrit-Reviewer: Adam Perry <adam...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: David Koloski <dkol...@google.com>

Gerrit-Reviewer: Kevin Lindkvist <lind...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/139dd2fb4a89f259fa4fd680c7be5c36d853b7b6-HTML%40fuchsia-review.googlesource.com.

['GI Roller (Gerrit)' via owners-override]

Message from GI Roller

Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1011812

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I6514764b8292cc7dec35afdd676326453ff393f7

Gerrit-Change-Number: 1312447

Gerrit-PatchSet: 6

Gerrit-Owner: Adam Perry <adam...@google.com>

Gerrit-Reviewer: Adam Perry <adam...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: David Koloski <dkol...@google.com>

Gerrit-Reviewer: Kevin Lindkvist <lind...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: GI Roller <global-integra...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Comment-Date: Tue, 01 Jul 2025 20:59:23 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0b2b905e5787edc2fabc10ae1e0cd44f781d1473-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.