[XL] Change in fuchsia/fuchsia[main]: [dso_runner] Initial skeleton
0 views
Skip to first unread message
'Gary Bressler (Gerrit)' via owners-override
Feb 3, 2026, 4:51:10 PM (2 days ago) Feb 3
to Owners Override
Attention needed from Megan Batty and Owners Override
Gary Bressler has uploaded the change for review![]( "Open in Gerrit")
Gary Bressler would like Owners Override to review this change.
Commit message
[dso_runner] Initial skeleton
Basic core functionality that supports sync and async components that
share an address space. This changelist includes:
- "synchronous" components - components that get a dedicated
thread
- "async" components - components that run in a shared Fuchsia Driver
Framework thread pool, much like components in driver runner.
- Component lifecycle support for start/stop/exit
- Unit tests
- Simple example (//examples/components/dso)
Not included/upcoming in future changes:
- Namespacing support for either sync or async components. For now they
share the same global namespace/fdio/etc. as the runner process.
- Running the components in a separate address space for the runner.
This currently isn't too important since all the DSO components share
the same address space, but it could become relevant when/if we
support multiple "containers".
- Integration test - I want to have this but I think it makes sense to
land the namespacing support first.
- Routing of dso_runner in the component topology
Bug: 403545512
Change-Id: Ifcfdbdfd9d8a73665a0751a90316a4e89cdc6c11
Change diff
Change information
Files:
- A examples/components/dso/BUILD.gn
- A examples/components/dso/OWNERS
- A examples/components/dso/README.md
- A examples/components/dso/main.cc
- A examples/components/dso/meta/simple_dso.cml
- A src/lib/dso/OWNERS
- A src/lib/dso/cpp/BUILD.gn
- A src/lib/dso/cpp/async.cc
- A src/lib/dso/cpp/async.h
- A src/lib/dso/cpp/sync.cc
- A src/lib/dso/cpp/sync.h
- A src/lib/dso/fuchsia_dso.gni
- M src/sys/BUILD.gn
- M src/sys/lib/elf_runner/BUILD.gn
- M src/sys/lib/elf_runner/src/config.rs
- M src/sys/lib/elf_runner/src/error.rs
- M src/sys/lib/elf_runner/src/lib.rs
- M src/sys/lib/runner/src/lib.rs
- A src/sys/runners/BUILD.gn
- A src/sys/runners/dso/BUILD.gn
- A src/sys/runners/dso/OWNERS
- A src/sys/runners/dso/README.md
- A src/sys/runners/dso/meta/dso_runner.cml
- A src/sys/runners/dso/meta/dso_runner_tests.cml
- A src/sys/runners/dso/src/component.rs
- A src/sys/runners/dso/src/error.rs
- A src/sys/runners/dso/src/loader.rs
- A src/sys/runners/dso/src/main.rs
- A src/sys/runners/dso/src/util.rs
- A src/sys/runners/dso/test/error_async.cc
- A src/sys/runners/dso/test/error_sync.cc
- A src/sys/runners/dso/test/hanging_async.cc
- A src/sys/runners/dso/test/hanging_sync.cc
- A src/sys/runners/dso/test/simple_async.cc
- A src/sys/runners/dso/test/simple_sync.cc
Change size: XL
Delta: 35 files changed, 1927 insertions(+), 13 deletions(-)
Related details
Attention is currently required from:
- Megan Batty
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7cb105c9484435f1879e95733b32e6d019e5f195-HTML%40fuchsia-review.googlesource.com.
'Gary Bressler (Gerrit)' via owners-override
Feb 3, 2026, 4:51:14 PM (2 days ago) Feb 3
to Owners Override, Megan Batty, Suraj Malhotra, Claire Gonyeo, GI Try Builder, CQ Bot, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com
Attention needed from Megan Batty and Owners Override
Gary Bressler added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 37 (Latest):
Gary Bressler . resolved
Owners-Override for //src/lib/dso which is a new directory so it has no OWNERS and its parent also has no OWNERS
Related details
Attention is currently required from:
- Megan Batty
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7cb105c9484435f1879e95733b32e6d019e5f195-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Megan Batty (Gerrit)' via owners-override
Feb 3, 2026, 5:16:14 PM (2 days ago) Feb 3
to Gary Bressler, Owners Override, Suraj Malhotra, Claire Gonyeo, GI Try Builder, CQ Bot, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com
Attention needed from Gary Bressler and Owners Override
Megan Batty added 1 comment![]( "Open in Gerrit")
File src/sys/runners/dso/src/component.rs
Line 545, Patchset 36:
unsafe extern "C" {Megan Batty . resolved
Gary Bressleryou could actually declare these functions safe since it seems like they probably are always safe to call. You'd do that by putting `safe` in front of the `fn` declarations. This is in tests so not super important to document why, but it would probably still be a good idea to.
Megan BattyTIL about `safe`, my IDE doesn't even know about it :-)
it is very very new and but I'm personally very happy it exists now :)
Related details
Attention is currently required from:
- Gary Bressler
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/81ff698102ff67df7a309e1f084c1e206be98a08-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Megan Batty (Gerrit)' via owners-override
Feb 3, 2026, 5:18:16 PM (2 days ago) Feb 3
to Gary Bressler, Owners Override, Suraj Malhotra, Claire Gonyeo, GI Try Builder, CQ Bot, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com
Attention needed from Gary Bressler and Owners Override
Megan Batty added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 36:
Megan Batty . resolved
Gary BresslerThere's a pretty hefty amount of unsafe in this change and I'd really like to make sure it's well documented, so I did an unsafe review of this change. The general theme though is:
- unsafe blocks should be as short as possible
- unsafe comments on unsafe blocks should explain why the body doesn't break the caller
- unsafe doc comments on functions should explain how to hold the function safely (focusing on things that affect rust's memory model)
- and the two should mirror each other.
- if a C function in an `extern "C"` block is always safe to call you can mark it safe and put a comment on it explaining why that is.
There's an android doc explaining pretty good best practices for this I can link you to if you want.
Megan BattyThanks for the review and best practice tips for unsafe. BTW ome of the code and comments were copied from the `driver-host` codebase so you may want to check those as well.
yeah I thought that might be the case. I definitely think we should revisit some of this in driver-host as well.
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0e58fbc720b7c937b1a4defddd3fc4f3160bb51c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
Feb 3, 2026, 7:05:01 PM (2 days ago) Feb 3
to Gary Bressler, Owners Override, Megan Batty, Suraj Malhotra, Claire Gonyeo, GI Try Builder, CQ Bot, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com
Attention needed from Gary Bressler and Owners Override
Adam Barth added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 39 (Latest):
Adam Barth . resolved
For owners-override, please create a CL that just has empty directories with OWNERS files.
Related details
Attention is currently required from:
- Gary Bressler
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a0571b51bedb398b25d7d46dd62bf862377c00f4-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Gary Bressler (Gerrit)' via owners-override
Feb 4, 2026, 7:05:20 PM (2 days ago) Feb 4
to Adam Barth, Owners Override, Megan Batty, Suraj Malhotra, Claire Gonyeo, GI Try Builder, CQ Bot, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com
Attention needed from Adam Barth and Owners Override
Gary Bressler added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Adam Barth . resolved
For owners-override, please create a CL that just has empty directories with OWNERS files.
Attention is currently required from:
- Adam Barth
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/47b06aa00cf9245114e0e6f199bec63380484598-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Gary Bressler (Gerrit)' via owners-override
Feb 5, 2026, 12:49:22 PM (15 hours ago) Feb 5
to Owners Override, Adam Barth
Gary Bressler has uploaded the change for review![]( "Open in Gerrit")
Gary Bressler removed Owners Override and Adam Barth from reviewers of this change.
Change information
Files:
Change size: XL
Delta: 34 files changed, 1926 insertions(+), 13 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/573de06f889640751373ede166562d055bbadc40-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages