[S] Change in fuchsia/fuchsia[main]: [rust] Adds OWNERS for an upcoming //src/lib/mapped-clock library.

1 view
Skip to first unread message

'Filip Filmar (Gerrit)' via owners-override

unread,
Jun 9, 2025, 6:23:59 PM6/9/25
to Owners Override
Attention needed from Owners Override

Filip Filmar has uploaded the change for review

Filip Filmar would like Owners Override to review this change.

Commit message

[rust] Adds OWNERS for an upcoming //src/lib/mapped-clock library.
Bug: 422533641
Change-Id: I762c3009614e52231799f2cdd00c6f3f4ae9c9d6

Change diff

diff --git a/src/lib/mapped-clock/OWNERS b/src/lib/mapped-clock/OWNERS
new file mode 100644
index 0000000..3442233
--- /dev/null
+++ b/src/lib/mapped-clock/OWNERS
@@ -0,0 +1 @@
+include /src/sys/time/OWNERS
diff --git a/src/lib/mapped-clock/README.md b/src/lib/mapped-clock/README.md
new file mode 100644
index 0000000..d1fdb378
--- /dev/null
+++ b/src/lib/mapped-clock/README.md
@@ -0,0 +1,16 @@
+## Mapped clock
+
+This is a rust library implementing a safe API for a clock backed by memory
+mapped into this process' virtual address space.  See `MappedClock` for
+details.
+
+To create one, you will need a `zx::Clock`, a `zx::Vmar` and a call to
+`MappedClock::try_new`.
+
+A memory mapped clock can be read more efficiently than a regular kernel clock
+object in contexts where calling into the kernel is undesirable. At the same
+time, updates to the memory mapped clock can be observed consistently with any
+other observers of the same underlying clock, a property guaranteed by Zircon.
+
+As a tradeoff, a memory mapped clock may offer a restricted set of methods,
+and has more complex construction and lifecycle as compared to [zx::Clock].

Change information

Files:
  • A src/lib/mapped-clock/OWNERS
  • A src/lib/mapped-clock/README.md
Change size: S
Delta: 2 files changed, 17 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I762c3009614e52231799f2cdd00c6f3f4ae9c9d6
Gerrit-Change-Number: 1293655
Gerrit-PatchSet: 2
Gerrit-Owner: Filip Filmar <fm...@google.com>
Gerrit-Reviewer: Filip Filmar <fm...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/3176b77555a0f991b98f63f977ffc63f5da34a54-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'Filip Filmar (Gerrit)' via owners-override

unread,
Jun 9, 2025, 6:24:03 PM6/9/25
to Owners Override
Attention needed from Owners Override

Filip Filmar voted and added 1 comment

Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I762c3009614e52231799f2cdd00c6f3f4ae9c9d6
Gerrit-Change-Number: 1293655
Gerrit-PatchSet: 1
Gerrit-Owner: Filip Filmar <fm...@google.com>
Gerrit-Reviewer: Filip Filmar <fm...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Mon, 09 Jun 2025 22:23:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/3176b77555a0f991b98f63f977ffc63f5da34a54-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
Jun 9, 2025, 7:37:39 PM6/9/25
to Filip Filmar, Owners Override
Attention needed from Filip Filmar and Owners Override

Adam Barth voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Filip Filmar
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I762c3009614e52231799f2cdd00c6f3f4ae9c9d6
Gerrit-Change-Number: 1293655
Gerrit-PatchSet: 2
Gerrit-Owner: Filip Filmar <fm...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Filip Filmar <fm...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Filip Filmar <fm...@google.com>
Gerrit-Comment-Date: Mon, 09 Jun 2025 23:37:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/877ba7f44e8051f8e4399ab5c10bd3eefe13e835-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
Jun 9, 2025, 7:37:47 PM6/9/25
to Filip Filmar, Owners Override
Attention needed from Filip Filmar and Owners Override

Adam Barth voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Filip Filmar
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I762c3009614e52231799f2cdd00c6f3f4ae9c9d6
Gerrit-Change-Number: 1293655
Gerrit-PatchSet: 2
Gerrit-Owner: Filip Filmar <fm...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Filip Filmar <fm...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Filip Filmar <fm...@google.com>
Gerrit-Comment-Date: Mon, 09 Jun 2025 23:37:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/3f8007d9b967c9769ee8e3d839ecfdf9a69c6df2-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Jun 9, 2025, 7:39:32 PM6/9/25
to Filip Filmar, Adam Barth, Owners Override

CQ Bot submitted the change

Change information

Commit message:
[rust] Adds OWNERS for an upcoming //src/lib/mapped-clock library.
Bug: 422533641
Change-Id: I762c3009614e52231799f2cdd00c6f3f4ae9c9d6
Owners-Override: Adam Barth <aba...@google.com>
Fuchsia-Auto-Submit: Filip Filmar <fm...@google.com>
Commit-Queue: Filip Filmar <fm...@google.com>
Reviewed-by: Adam Barth <aba...@google.com>
Files:
  • A src/lib/mapped-clock/OWNERS
  • A src/lib/mapped-clock/README.md
Change size: S
Delta: 2 files changed, 17 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Adam Barth
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I762c3009614e52231799f2cdd00c6f3f4ae9c9d6
Gerrit-Change-Number: 1293655
Gerrit-PatchSet: 3
Gerrit-Owner: Filip Filmar <fm...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Filip Filmar <fm...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/3a795757543274417e5849aacbba3e7668ec5100-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Jun 9, 2025, 7:51:07 PM6/9/25
to Filip Filmar, CQ Bot, Adam Barth, Owners Override

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I762c3009614e52231799f2cdd00c6f3f4ae9c9d6
Gerrit-Change-Number: 1293655
Gerrit-PatchSet: 3
Gerrit-Owner: Filip Filmar <fm...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Filip Filmar <fm...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Mon, 09 Jun 2025 23:51:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0c5dd1973fcd26ee5f672986d0ad0a1aca75f239-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages