[XS] Change in fuchsia/fuchsia[main]: [scripts] Scrub goma from git-file-tidy

['David Fang (Gerrit)' via owners-override]

Attention needed from Owners Override

David Fang has uploaded the change for review

David Fang would like Owners Override to review this change.

Commit message

[scripts] Scrub goma from git-file-tidy

Goma is no more.

Bug: 340581192

Change-Id: I1b24355db6d5cde31a5adf597b01344524e7f084

Change diff

diff --git a/scripts/git/git-file-tidy b/scripts/git/git-file-tidy
index ed93542..cc19893 100755
--- a/scripts/git/git-file-tidy
+++ b/scripts/git/git-file-tidy
@@ -78,10 +78,6 @@
     db = subprocess.check_output(
         cmd, cwd=FUCHSIA_ROOT, universal_newlines=True)
 
-    # Strip away `gomacc` from the compile commands. This seems to fix problems
-    # with clang-tidy not being able to load system headers.
-    db = re.sub("\"/[\S]+/gomacc ", "\"", db)
-
     with open(os.path.join(out_dir, "compile_commands.json"), "w+") as db_file:
         db_file.write(db)

Change information

Files:

• M scripts/git/git-file-tidy

Change size: XS

Delta: 1 file changed, 0 insertions(+), 4 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

• Owners Override

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I1b24355db6d5cde31a5adf597b01344524e7f084

Gerrit-Change-Number: 1089244

Gerrit-PatchSet: 1

Gerrit-Owner: David Fang <fan...@google.com>

Gerrit-Reviewer: David Fang <fan...@google.com>

Gerrit-Reviewer: Oliver Newman <oliver...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b3991c23cc43a2d2a6445c56200ccb5e3b67e648-HTML%40fuchsia-review.googlesource.com.

['David Fang (Gerrit)' via owners-override]

Attention needed from Owners Override

David Fang voted Fuchsia-Auto-Submit+1

Fuchsia-Auto-Submit

+1

Open in Gerrit

Related details

Attention is currently required from:

• Owners Override

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I1b24355db6d5cde31a5adf597b01344524e7f084

Gerrit-Change-Number: 1089244

Gerrit-PatchSet: 1

Gerrit-Owner: David Fang <fan...@google.com>

Gerrit-Reviewer: David Fang <fan...@google.com>

Gerrit-Reviewer: Oliver Newman <oliver...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Comment-Date: Thu, 25 Jul 2024 20:26:21 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/cbe5303d4aac981b370f917be3a6a5ef1e09fcc9-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['Adam Barth (Gerrit)' via owners-override]

Attention needed from David Fang and Owners Override

Adam Barth voted and added 1 comment

Votes added by Adam Barth

Owners-Override

+1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Adam Barth . resolved

Please add an OWNERS file to https://fuchsia.googlesource.com/fuchsia/+/refs/heads/main/scripts/git/

Open in Gerrit

Related details

Attention is currently required from:

• David Fang
• Owners Override

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I1b24355db6d5cde31a5adf597b01344524e7f084

Gerrit-Change-Number: 1089244

Gerrit-PatchSet: 1

Gerrit-Owner: David Fang <fan...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: David Fang <fan...@google.com>

Gerrit-Reviewer: Oliver Newman <oliver...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: David Fang <fan...@google.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Comment-Date: Thu, 25 Jul 2024 20:40:05 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/d3cbf1e6af3e53c90e5a8af15c1eb7845c8d5da8-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['CQ Bot (Gerrit)' via owners-override]

CQ Bot submitted the change

Change information

Commit message:

[scripts] Scrub goma from git-file-tidy

Goma is no more.

Bug: 340581192

Change-Id: I1b24355db6d5cde31a5adf597b01344524e7f084

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1089244

Fuchsia-Auto-Submit: David Fang <fan...@google.com>

Owners-Override: Adam Barth <aba...@google.com>

Reviewed-by: Oliver Newman <oliver...@google.com>

Commit-Queue: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>

Files:

• M scripts/git/git-file-tidy

Change size: XS

Delta: 1 file changed, 0 insertions(+), 4 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +2 by Oliver Newman

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I1b24355db6d5cde31a5adf597b01344524e7f084

Gerrit-Change-Number: 1089244

Gerrit-PatchSet: 2

Gerrit-Owner: David Fang <fan...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: David Fang <fan...@google.com>

Gerrit-Reviewer: Oliver Newman <oliver...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/73889c480f7dbda2da6bf3594dfbc9196f6c2788-HTML%40fuchsia-review.googlesource.com.

['GI Roller (Gerrit)' via owners-override]

Message from GI Roller

Change has been successfully rolled: http://go/roll-cl/4e458569dc8ba2fee576ae512f18d1c1a7526cbd

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I1b24355db6d5cde31a5adf597b01344524e7f084

Gerrit-Change-Number: 1089244

Gerrit-PatchSet: 2

Gerrit-Owner: David Fang <fan...@google.com>

Gerrit-Reviewer: Adam Barth <aba...@google.com>

Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: David Fang <fan...@google.com>

Gerrit-Reviewer: Oliver Newman <oliver...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: GI Roller <global-integra...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Comment-Date: Thu, 25 Jul 2024 21:38:12 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/d8855d8ce1807b4723311c8d80b95499dacd589f-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.