[XS] Change in fuchsia/recipes[main]: Add pineapple@ to OWNERS

0 views
Skip to first unread message

'Julia Ryan (Gerrit)' via owners-override

unread,
May 23, 2024, 5:46:29 PMMay 23
to Owners Override
Attention needed from Owners Override

Julia Ryan has uploaded the change for review

Julia Ryan would like Owners Override to review this change.

Commit message

Add pineapple@ to OWNERS
Change-Id: If34bcf8fa1d61dc9917a6c1d82c5ce9110b0e903

Change diff

diff --git a/OWNERS b/OWNERS
index bf577d3..f23e6e9 100644
--- a/OWNERS
+++ b/OWNERS
@@ -19,4 +19,4 @@
 # source-of-truth recipe code.
 per-file **.expected/*.json = *
 
-per-file recipes/rust_toolchain.** = dkol...@google.com,etryz...@google.com,jose...@google.com,tma...@google.com
+per-file recipes/rust_toolchain.** = dkol...@google.com,etryz...@google.com,pine...@google.com,tma...@google.com
diff --git a/recipes/contrib/OWNERS b/recipes/contrib/OWNERS
index 73411bd..638b055 100644
--- a/recipes/contrib/OWNERS
+++ b/recipes/contrib/OWNERS
@@ -8,7 +8,7 @@
 per-file cmake.**             = file:/TOOLCHAIN_OWNERS
 per-file edk2.**              = joshua...@google.com,mcgr...@google.com
 per-file ffmpeg.**            = file:/TOOLCHAIN_OWNERS
-per-file firebase_docs.**     = jose...@google.com,tma...@google.com
+per-file firebase_docs.**     = pine...@google.com,tma...@google.com
 per-file gcc_toolchain.**     = file:/TOOLCHAIN_OWNERS
 per-file gnu_build_tools.**   = file:/TOOLCHAIN_OWNERS
 per-file linux_sysroot.**     = file:/TOOLCHAIN_OWNERS
diff --git a/recipes/rust_toolchain.py b/recipes/rust_toolchain.py
index 8ff310c..1649e5d 100644
--- a/recipes/rust_toolchain.py
+++ b/recipes/rust_toolchain.py
@@ -121,7 +121,7 @@
     api.file.ensure_directory("build", build_dir)
     pkg_dir = staging_dir.join("rust")
     api.file.ensure_directory("create pkg_dir", pkg_dir)
-    # TODO(josephry): remove when https://github.com/rust-lang/rust/pull/116349 lands
+    # TODO(pineapple): remove when https://github.com/rust-lang/rust/pull/116349 lands
     # on beta. might have to wait for it to reach stable depending on whether a
     # beta-backport is approved
     api.file.ensure_directory("create sysconf_dir", pkg_dir.join("etc"))

Change information

Files:
  • M OWNERS
  • M recipes/contrib/OWNERS
  • M recipes/rust_toolchain.py
Change size: XS
Delta: 3 files changed, 3 insertions(+), 3 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: infra/recipes
Gerrit-Branch: main
Gerrit-Change-Id: If34bcf8fa1d61dc9917a6c1d82c5ce9110b0e903
Gerrit-Change-Number: 1052974
Gerrit-PatchSet: 1
Gerrit-Owner: Julia Ryan <pine...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Julia Ryan <pine...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b581dd75cce8e125a4f5cb491e113ab08b4fe28f-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'James Robinson (Gerrit)' via owners-override

unread,
May 23, 2024, 5:47:35 PMMay 23
to Julia Ryan, Owners Override, Erick Tryzelaar, CQ Bot
Attention needed from Julia Ryan and Owners Override

James Robinson voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Julia Ryan
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: infra/recipes
Gerrit-Branch: main
Gerrit-Change-Id: If34bcf8fa1d61dc9917a6c1d82c5ce9110b0e903
Gerrit-Change-Number: 1052974
Gerrit-PatchSet: 1
Gerrit-Owner: Julia Ryan <pine...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Julia Ryan <pine...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Julia Ryan <pine...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Thu, 23 May 2024 21:47:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/28c0927725f569c45c500b56df3038a9f9fb0385-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Julia Ryan (Gerrit)' via owners-override

unread,
May 23, 2024, 5:47:57 PMMay 23
to James Robinson, Owners Override, Erick Tryzelaar, CQ Bot
Attention needed from Owners Override

Julia Ryan voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: infra/recipes
Gerrit-Branch: main
Gerrit-Change-Id: If34bcf8fa1d61dc9917a6c1d82c5ce9110b0e903
Gerrit-Change-Number: 1052974
Gerrit-PatchSet: 1
Gerrit-Owner: Julia Ryan <pine...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Julia Ryan <pine...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Thu, 23 May 2024 21:47:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/685bc1598e7b83166d9c1be7d27683c8fd09e868-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Julia Ryan (Gerrit)' via owners-override

unread,
May 23, 2024, 5:51:58 PMMay 23
to James Robinson, Owners Override, Erick Tryzelaar, CQ Bot
Attention needed from Owners Override

Julia Ryan voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: infra/recipes
Gerrit-Branch: main
Gerrit-Change-Id: If34bcf8fa1d61dc9917a6c1d82c5ce9110b0e903
Gerrit-Change-Number: 1052974
Gerrit-PatchSet: 2
Gerrit-Owner: Julia Ryan <pine...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Julia Ryan <pine...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Thu, 23 May 2024 21:51:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9f9913dd5e8e738f5106f4feb18716b6319fefe6-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
May 23, 2024, 6:01:34 PMMay 23
to Julia Ryan, James Robinson, Owners Override, Erick Tryzelaar

CQ Bot submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
Add pineapple@ to OWNERS
Change-Id: If34bcf8fa1d61dc9917a6c1d82c5ce9110b0e903
Fuchsia-Auto-Submit: Julia Ryan <pine...@google.com>
Reviewed-by: Erick Tryzelaar <etryz...@google.com>
Owners-Override: James Robinson <jam...@google.com>
Commit-Queue: Julia Ryan <pine...@google.com>
Files:
  • M OWNERS
  • M recipes/contrib/OWNERS
  • M recipes/rust_toolchain.py
Change size: XS
Delta: 3 files changed, 3 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Erick Tryzelaar
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: infra/recipes
Gerrit-Branch: main
Gerrit-Change-Id: If34bcf8fa1d61dc9917a6c1d82c5ce9110b0e903
Gerrit-Change-Number: 1052974
Gerrit-PatchSet: 3
Gerrit-Owner: Julia Ryan <pine...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Julia Ryan <pine...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/df834a40f1d2f3a5a5ec328ee3b435750fd55861-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
May 23, 2024, 6:04:34 PMMay 23
to Julia Ryan, CQ Bot, James Robinson, Owners Override, Erick Tryzelaar

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: infra/recipes
Gerrit-Branch: main
Gerrit-Change-Id: If34bcf8fa1d61dc9917a6c1d82c5ce9110b0e903
Gerrit-Change-Number: 1052974
Gerrit-PatchSet: 3
Gerrit-Owner: Julia Ryan <pine...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Julia Ryan <pine...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Thu, 23 May 2024 22:04:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a354c6f76f2347cf549fe8c074bf85b66870b497-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages