[L] Change in fuchsia/fuchsia[main]: [zx][rs] Remove AsHandleRef::signal_handle.

4 views
Skip to first unread message

'Adam Perry (Gerrit)' via owners-override

unread,
Dec 19, 2025, 7:08:15 PM12/19/25
to Owners Override
Attention needed from Owners Override

Adam Perry has uploaded the change for review

Adam Perry would like Owners Override to review this change.

Commit message

[zx][rs] Remove AsHandleRef::signal_handle.

Replaced with a signal() method on typed handle wrappers.
Bug: 434762683
Depends-on: turquoise-internal:I67549e97ab0f6166946a485203d8085229635c16
Change-Id: I75adb97c2e9a641abe59936d702b1f383973801e

Change diff


Change information

Files:
  • M sdk/lib/driver/runtime/rust/fidl/src/integration_test.rs
  • M sdk/lib/driver/runtime/rust/libasync/fidl/src/integration_test.rs
  • M sdk/rust/zx/src/handle.rs
  • M sdk/rust/zx/src/macros.rs
  • M sdk/rust/zx/src/port.rs
  • M sdk/rust/zx/src/time.rs
  • M sdk/rust/zx/src/wait.rs
  • M src/bringup/bin/critical-services/test/src/mock_services.rs
  • M src/connectivity/network/netstack3/src/bindings/socket/stream.rs
  • M src/connectivity/network/tests/fidl/filter/src/lib.rs
  • M src/developer/ffx/lib/fuchsia-controller/src/commands.rs
  • M src/developer/ffx/lib/target_net/src/socket_provider.rs
  • M src/diagnostics/archivist/src/logs/shared_buffer.rs
  • M src/lib/diagnostics/inspect/rust/src/writer/types/node.rs
  • M src/lib/fake-clock/svc/src/main.rs
  • M src/lib/fdomain/container/src/handles.rs
  • M src/lib/fdomain/container/src/lib.rs
  • M src/lib/fuchsia-async/src/handle/emulated/mod.rs
  • M src/lib/fuchsia-async/src/handle/zircon/on_signals.rs
  • M src/lib/fuchsia-async/src/runtime/fuchsia/executor/local.rs
  • M src/lib/fuchsia-async/src/runtime/fuchsia/timer.rs
  • M src/lib/trace/rust/trace-observer/src/lib.rs
  • M src/starnix/kernel/core/bpf/program.rs
  • M src/starnix/kernel/core/task/hr_timer_manager.rs
  • M src/starnix/kernel/core/task/task.rs
  • M src/starnix/lib/starnix_sync/src/port_event.rs
  • M src/starnix/lib/usercopy/src/lib.rs
  • M src/starnix/modules/procfs/pressure_directory.rs
  • M src/starnix/tests/nanohub/src/fake_datachannel.rs
  • M src/starnix/tests/psi/src/tests.rs
  • M src/storage/lib/block_server/src/c_interface.rs
  • M src/sys/component_manager/lib/diagnostics/src/task_metrics/testing.rs
  • M src/sys/fuzzing/realmfuzzer/coverage/tests/adapter/src/main.rs
  • M src/sys/fuzzing/realmfuzzer/coverage/tests/engine/src/main.rs
  • M src/sys/pkg/tests/pkg-resolver/src/lib.rs
  • M src/sys/time/testing/fake-hrtimer/src/main.rs
  • M src/sys/time/testing/fake-wake-alarms/src/lib.rs
  • M src/sys/time/timekeeper/alarms/src/lib.rs
  • M src/sys/time/timekeeper/src/clock_manager.rs
  • M src/sys/time/timekeeper/src/main.rs
Change size: L
Delta: 40 files changed, 151 insertions(+), 138 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedDependencies-Satisfied
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I75adb97c2e9a641abe59936d702b1f383973801e
Gerrit-Change-Number: 1449296
Gerrit-PatchSet: 8
Gerrit-Owner: Adam Perry <adam...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Adam Perry <adam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/de8bd0bb9e9c0efd0eab8cd324494192cfeb5ae7-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Adam Perry (Gerrit)' via owners-override

unread,
Dec 19, 2025, 7:08:18 PM12/19/25
to Owners Override, Adam Barth, GI Try Builder, CQ Bot
Attention needed from Owners Override

Adam Perry voted

Commit-Queue+1
Fuchsia-Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedDependencies-Satisfied
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I75adb97c2e9a641abe59936d702b1f383973801e
Gerrit-Change-Number: 1449296
Gerrit-PatchSet: 8
Gerrit-Owner: Adam Perry <adam...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Adam Perry <adam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Sat, 20 Dec 2025 00:08:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/de8bd0bb9e9c0efd0eab8cd324494192cfeb5ae7-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
Dec 19, 2025, 11:08:41 PM12/19/25
to Adam Perry, Owners Override, GI Try Builder, CQ Bot
Attention needed from Adam Perry and Owners Override

Adam Barth voted

Code-Review+2
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Adam Perry
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedDependencies-Satisfied
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I75adb97c2e9a641abe59936d702b1f383973801e
Gerrit-Change-Number: 1449296
Gerrit-PatchSet: 8
Gerrit-Owner: Adam Perry <adam...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Adam Perry <adam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Adam Perry <adam...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Sat, 20 Dec 2025 04:08:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/dddeb49d85889d541c8095ff708de3484d038d35-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
unsatisfied_requirement
open
diffy

'Adam Perry (Gerrit)' via owners-override

unread,
Dec 23, 2025, 6:54:20 PM12/23/25
to Adam Barth, Owners Override, GI Try Builder, CQ Bot
Attention needed from Adam Barth and Owners Override

Adam Perry voted Fuchsia-Auto-Submit+0

Fuchsia-Auto-Submit+0
Open in Gerrit

Related details

Attention is currently required from:
  • Adam Barth
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedDependencies-Satisfied
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I75adb97c2e9a641abe59936d702b1f383973801e
Gerrit-Change-Number: 1449296
Gerrit-PatchSet: 9
Gerrit-Owner: Adam Perry <adam...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Adam Perry <adam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Adam Barth <aba...@google.com>
Gerrit-Comment-Date: Tue, 23 Dec 2025 23:54:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0841aabb7b48da14b6a955bf854e94e51122e66b-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Adam Perry (Gerrit)' via owners-override

unread,
Dec 26, 2025, 2:50:41 PM12/26/25
to Adam Barth, Owners Override, GI Try Builder, CQ Bot
Attention needed from Adam Barth and Owners Override

Adam Perry voted

Commit-Queue+1
Fuchsia-Auto-Submit+1
Gerrit-Comment-Date: Fri, 26 Dec 2025 19:50:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0e907fcff51ed2148c68e0e4d56fc0a9521f04c2-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
Jan 4, 2026, 10:30:16 PMJan 4
to Adam Perry, Owners Override, GI Try Builder, CQ Bot
Attention needed from Adam Perry and Owners Override

Adam Barth voted

Code-Review+2
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Adam Perry
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedDependencies-Satisfied
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I75adb97c2e9a641abe59936d702b1f383973801e
Gerrit-Change-Number: 1449296
Gerrit-PatchSet: 9
Gerrit-Owner: Adam Perry <adam...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Adam Perry <adam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Adam Perry <adam...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Mon, 05 Jan 2026 03:30:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/8597a2f3a4bdc448ca7fc8a276db8df6f037141d-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
unsatisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Jan 5, 2026, 12:39:57 AMJan 5
to Adam Perry, CL Deps Checker, Adam Barth, Owners Override, GI Try Builder

CQ Bot submitted the change

Change information

Commit message:
[zx][rs] Remove AsHandleRef::signal_handle.

Replaced with a signal() method on typed handle wrappers.
Bug: 434762683
Depends-on: turquoise-internal:I67549e97ab0f6166946a485203d8085229635c16
Change-Id: I75adb97c2e9a641abe59936d702b1f383973801e
Owners-Override: Adam Barth <aba...@google.com>
Reviewed-by: Adam Barth <aba...@google.com>
Commit-Queue: Adam Perry <adam...@google.com>
Fuchsia-Auto-Submit: Adam Perry <adam...@google.com>
Files:
    • M sdk/lib/driver/runtime/rust/fidl/src/integration_test.rs
    • M sdk/lib/driver/runtime/rust/libasync/fidl/src/integration_test.rs
    • M sdk/rust/zx/src/handle.rs
    • M sdk/rust/zx/src/macros.rs
    • M sdk/rust/zx/src/port.rs
    • M sdk/rust/zx/src/time.rs
    • M sdk/rust/zx/src/wait.rs
    • M src/bringup/bin/critical-services/test/src/mock_services.rs
    • M src/connectivity/network/netstack3/src/bindings/socket/stream.rs
    • M src/connectivity/network/testing/ebpf_test_util/src/lib.rs
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +2 by Adam Barth
    • requirement satisfiedDependencies-Satisfied: +1 by CL Deps Checker
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I75adb97c2e9a641abe59936d702b1f383973801e
    Gerrit-Change-Number: 1449296
    Gerrit-PatchSet: 10
    Gerrit-Owner: Adam Perry <adam...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Adam Perry <adam...@google.com>

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/1fcf7844a223e1fd905031e62bafba2415cd8298-HTML%40fuchsia-review.googlesource.com.
    open
    diffy
    satisfied_requirement

    'GI Roller (Gerrit)' via owners-override

    unread,
    Jan 5, 2026, 12:46:37 AMJan 5
    to Adam Perry, CQ Bot, CL Deps Checker, Adam Barth, Owners Override, GI Try Builder

    Message from GI Roller

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedDependencies-Satisfied
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: fuchsia
      Gerrit-Branch: main
      Gerrit-Change-Id: I75adb97c2e9a641abe59936d702b1f383973801e
      Gerrit-Change-Number: 1449296
      Gerrit-PatchSet: 10
      Gerrit-Owner: Adam Perry <adam...@google.com>
      Gerrit-Reviewer: Adam Barth <aba...@google.com>
      Gerrit-Reviewer: Adam Perry <adam...@google.com>
      Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
      Gerrit-Comment-Date: Mon, 05 Jan 2026 05:46:33 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No

      --
      You received this message because you are subscribed to the Google Groups "owners-override" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
      To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/61887b2c963d0c3bcb7b1bae870188d6458c29cf-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages