[M] Change in fuchsia/fuchsia[main]: [clang] Fix instances of conversions from iterators to raw pointers

0 views
Skip to first unread message

'Leonard Chan (Gerrit)' via owners-override

unread,
Mar 18, 2024, 2:42:03 PMMar 18
to Owners Override
Attention needed from Owners Override

Leonard Chan has uploaded the change for review

Leonard Chan would like Owners Override to review this change.

Commit message

[clang] Fix instances of conversions from iterators to raw pointers

https://github.com/llvm/llvm-project/pull/74482 in upstream libc++
changed the return type of various iterator functions (*.begin(),
*.end(), etc) from raw pointers to iterator objects. The return types
for these functions aren't guaranteed to be raw pointers, but we have a
bunch of c++ code that assumes they are. We can get pointers from these
iterators by simply dereferencing them and taking their address (`&*iter`).
Bug: 328282937
Change-Id: I2f5457fcb731f7bf04c1efb23f6234fbbe471d0c

Change diff


Change information

Files:
  • M sdk/lib/fidl/cpp/wire/status.cc
  • M src/connectivity/bluetooth/core/bt-host/public/pw_bluetooth_sapphire/internal/host/common/byte_buffer.h
  • M src/connectivity/ethernet/drivers/virtio/netdevice.cc
  • M src/connectivity/network/drivers/network-device/device/network_device-microbenchmarks.cc
  • M src/connectivity/network/drivers/network-device/device/session.cc
  • M src/connectivity/network/drivers/network-device/device/test_util_banjo.h
  • M src/connectivity/wlan/drivers/testing/lib/sim-env/test/location_tests.cc
  • M src/connectivity/wlan/drivers/testing/lib/sim-env/test/rx_tests.cc
  • M src/connectivity/wlan/drivers/testing/lib/sim-env/test/trans_time_tests.cc
  • M src/connectivity/wlan/lib/common/cpp/include/wlan/common/bitfield.h
  • M src/firmware/gigaboot/cpp/boot_zbi_items.cc
  • M src/firmware/gigaboot/cpp/cmdline.cc
  • M src/firmware/gigaboot/cpp/mdns.cc
  • M src/lib/elfldltl/test/layout-tests.cc
  • M src/lib/fidl/cpp/any_error_in.cc
  • M src/lib/fidl/cpp/fidl_cpp_v2.api
  • M src/lib/fidl/cpp/include/lib/fidl/cpp/any_error_in.h
  • M src/storage/fvm/format.cc
  • M src/storage/volume_image/adapter/commands/arguments.cc
  • M src/sys/fuzzing/common/child-process.cc
  • M tools/fidl/fidlc/src/utils.cc
  • M zircon/kernel/lib/object_cache/include/lib/object_cache.h
  • M zircon/kernel/tests/string_view_tests.cc
  • M zircon/system/ulib/inspect/vmo/state.cc
  • M zircon/system/ulib/inspector/backtrace.cc
  • M zircon/system/ulib/runtests-utils/runtests-utils.cc
  • M zircon/system/utest/core/thread-initial-state/init-state.cc
Change size: M
Delta: 27 files changed, 68 insertions(+), 67 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedAPI-Review
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I2f5457fcb731f7bf04c1efb23f6234fbbe471d0c
Gerrit-Change-Number: 1010227
Gerrit-PatchSet: 2
Gerrit-Owner: Leonard Chan <leona...@google.com>
Gerrit-Reviewer: Leonard Chan <leona...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Petr Hosek <pho...@google.com>
Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/78f821fae773c129c5e2872a3356d64b056a0daa-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'Leonard Chan (Gerrit)' via owners-override

unread,
Mar 18, 2024, 2:42:06 PMMar 18
to Owners Override, Tricium, Roland McGrath, CQ Bot, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Petr Hosek
Attention needed from Owners Override

Leonard Chan added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Leonard Chan . resolved

Adding Owners Override because this is a large change with trivial fixes that touch many files.

Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedAPI-Review
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I2f5457fcb731f7bf04c1efb23f6234fbbe471d0c
Gerrit-Change-Number: 1010227
Gerrit-PatchSet: 2
Gerrit-Owner: Leonard Chan <leona...@google.com>
Gerrit-Reviewer: Leonard Chan <leona...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Petr Hosek <pho...@google.com>
Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Mon, 18 Mar 2024 18:41:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/78f821fae773c129c5e2872a3356d64b056a0daa-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'James Robinson (Gerrit)' via owners-override

unread,
Mar 18, 2024, 3:03:18 PMMar 18
to Leonard Chan, Owners Override, Tricium, Roland McGrath, CQ Bot, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Petr Hosek
Attention needed from Leonard Chan and Owners Override

James Robinson voted and added 3 comments

Votes added by James Robinson

Code-Review+2
Owners-Override+1

3 comments

Patchset-level comments
James Robinson . resolved

Seems fine - a few places seem to have extra parens but that's not a huge deal.

In the future please get a CR+2 from someone before requesting owners override.

Looks like you'll need API-Review as well - I don't have that bit (and owners override doesn't override it).

File src/connectivity/wlan/lib/common/cpp/include/wlan/common/bitfield.h
Line 123, Patchset 2 (Latest): if constexpr (len + first_bit_idx_in_cell == 64) {
James Robinson . unresolved

this looks like an unrelated change

File src/firmware/gigaboot/cpp/cmdline.cc
Line 51, Patchset 2 (Latest): std::string_view key(&(*pos), key_end - pos);
James Robinson . unresolved

why the extra parens?

i see them in changes later in the diff as well

Open in Gerrit

Related details

Attention is currently required from:
  • Leonard Chan
  • Owners Override
Submit Requirements:
    • requirement is not satisfiedAPI-Review
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I2f5457fcb731f7bf04c1efb23f6234fbbe471d0c
    Gerrit-Change-Number: 1010227
    Gerrit-PatchSet: 2
    Gerrit-Owner: Leonard Chan <leona...@google.com>
    Gerrit-Reviewer: James Robinson <jam...@google.com>
    Gerrit-Reviewer: Leonard Chan <leona...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Reviewer: Petr Hosek <pho...@google.com>
    Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>
    Gerrit-Attention: Leonard Chan <leona...@google.com>
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Comment-Date: Mon, 18 Mar 2024 19:03:11 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/60fb14d9997307133ec907c2f70e06b8fdbc69ca-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    'Leonard Chan (Gerrit)' via owners-override

    unread,
    Mar 18, 2024, 3:09:53 PMMar 18
    to James Robinson, Owners Override, Tricium, Roland McGrath, CQ Bot, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Petr Hosek
    Attention needed from James Robinson, Leonard Chan and Owners Override

    Leonard Chan added 3 comments

    Patchset-level comments
    James Robinson . resolved

    Seems fine - a few places seem to have extra parens but that's not a huge deal.

    In the future please get a CR+2 from someone before requesting owners override.

    Looks like you'll need API-Review as well - I don't have that bit (and owners override doesn't override it).

    Leonard Chan

    Who might I be able to add to get an API review?

    File src/connectivity/wlan/lib/common/cpp/include/wlan/common/bitfield.h
    Line 123, Patchset 2: if constexpr (len + first_bit_idx_in_cell == 64) {
    James Robinson . unresolved

    this looks like an unrelated change

    Leonard Chan

    Removed

    File src/firmware/gigaboot/cpp/cmdline.cc
    Line 51, Patchset 2: std::string_view key(&(*pos), key_end - pos);
    James Robinson . unresolved

    why the extra parens?

    i see them in changes later in the diff as well

    Leonard Chan

    This was before I tried making a clang fixit to automate adding the `&*` to each of these errors. I couldn't figure out how to add the parentheses automatically. The shouldn't be necessary though.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • James Robinson
    • Leonard Chan
    • Owners Override
    Submit Requirements:
    • requirement is not satisfiedAPI-Review
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I2f5457fcb731f7bf04c1efb23f6234fbbe471d0c
    Gerrit-Change-Number: 1010227
    Gerrit-PatchSet: 3
    Gerrit-Owner: Leonard Chan <leona...@google.com>
    Gerrit-Reviewer: James Robinson <jam...@google.com>
    Gerrit-Reviewer: Leonard Chan <leona...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Reviewer: Petr Hosek <pho...@google.com>
    Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>
    Gerrit-Attention: Leonard Chan <leona...@google.com>
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: James Robinson <jam...@google.com>
    Gerrit-Comment-Date: Mon, 18 Mar 2024 19:09:44 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: James Robinson <jam...@google.com>

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/774c92a3f607fe0b3d254a0f623ec56bafa5b792-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    'James Robinson (Gerrit)' via owners-override

    unread,
    Mar 18, 2024, 3:17:12 PMMar 18
    to Leonard Chan, Owners Override, Tricium, Roland McGrath, CQ Bot, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Petr Hosek
    Attention needed from Leonard Chan and Owners Override

    James Robinson voted and added 1 comment

    Votes added by James Robinson

    Code-Review+2

    1 comment

    Patchset-level comments
    James Robinson . resolved

    Seems fine - a few places seem to have extra parens but that's not a huge deal.

    In the future please get a CR+2 from someone before requesting owners override.

    Looks like you'll need API-Review as well - I don't have that bit (and owners override doesn't override it).

    Leonard Chan

    Who might I be able to add to get an API review?

    James Robinson

    It looks like the FIDL library edit is triggering the API review bit and ianloic@ is the API owner for FIDL per https://fuchsia.dev/fuchsia-src/contribute/governance/api_council?hl=en#membership

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Leonard Chan
    • Owners Override
    Gerrit-Comment-Date: Mon, 18 Mar 2024 19:17:04 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Leonard Chan <leona...@google.com>
    Comment-In-Reply-To: James Robinson <jam...@google.com>

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/86f0776c1effffe720c2bc5641a1bd19f05e6666-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    'Ian McKellar (Gerrit)' via owners-override

    unread,
    Mar 18, 2024, 3:24:41 PMMar 18
    to Leonard Chan, James Robinson, Owners Override, Tricium, Roland McGrath, CQ Bot, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Petr Hosek
    Attention needed from Leonard Chan

    Ian McKellar voted Code-Review+2

    Code-Review+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Leonard Chan
    Submit Requirements:
    • requirement is not satisfiedAPI-Review
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I2f5457fcb731f7bf04c1efb23f6234fbbe471d0c
    Gerrit-Change-Number: 1010227
    Gerrit-PatchSet: 3
    Gerrit-Owner: Leonard Chan <leona...@google.com>
    Gerrit-Reviewer: Ian McKellar <ian...@google.com>
    Gerrit-Reviewer: James Robinson <jam...@google.com>
    Gerrit-Reviewer: Leonard Chan <leona...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Reviewer: Petr Hosek <pho...@google.com>
    Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>
    Gerrit-Attention: Leonard Chan <leona...@google.com>
    Gerrit-Comment-Date: Mon, 18 Mar 2024 19:24:34 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/69ab710ccec9baa349546b68d8c65637c66f8f41-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    'Adam Barth (Gerrit)' via owners-override

    unread,
    Mar 18, 2024, 3:39:12 PMMar 18
    to Leonard Chan, Ian McKellar, James Robinson, Owners Override, Tricium, Roland McGrath, CQ Bot, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Petr Hosek
    Attention needed from Leonard Chan

    Adam Barth voted API-Review+1

    API-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Leonard Chan
    Submit Requirements:
    • requirement satisfiedAPI-Review
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I2f5457fcb731f7bf04c1efb23f6234fbbe471d0c
    Gerrit-Change-Number: 1010227
    Gerrit-PatchSet: 3
    Gerrit-Owner: Leonard Chan <leona...@google.com>
    Gerrit-Reviewer: Adam Barth <aba...@google.com>
    Gerrit-Reviewer: Ian McKellar <ian...@google.com>
    Gerrit-Reviewer: James Robinson <jam...@google.com>
    Gerrit-Reviewer: Leonard Chan <leona...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Reviewer: Petr Hosek <pho...@google.com>
    Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>
    Gerrit-Attention: Leonard Chan <leona...@google.com>
    Gerrit-Comment-Date: Mon, 18 Mar 2024 19:39:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/528a0d768fcec3a8cc7208b57208f7731246aebb-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    open
    diffy

    'Leonard Chan (Gerrit)' via owners-override

    unread,
    Mar 19, 2024, 2:50:00 PMMar 19
    to Owners Override

    Leonard Chan has uploaded the change for review

    Leonard Chan removed Owners Override from reviewers of this change.

    Commit message

    [clang] Fix instances of conversions from iterators to raw pointers

    https://github.com/llvm/llvm-project/pull/74482 in upstream libc++
    changed the return type of various iterator functions (*.begin(),
    *.end(), etc) from raw pointers to iterator objects. The return types
    for these functions aren't guaranteed to be raw pointers, but we have a
    bunch of c++ code that assumes they are. We can get pointers from these
    iterators by simply dereferencing them and taking their address (`&*iter`).
    Bug: 328282937
    Change-Id: I2f5457fcb731f7bf04c1efb23f6234fbbe471d0c

    Change diff


    Change information

    Files:
      • M sdk/lib/fidl/cpp/wire/status.cc
      • M src/connectivity/bluetooth/core/bt-host/public/pw_bluetooth_sapphire/internal/host/common/byte_buffer.h
      • M src/connectivity/ethernet/drivers/virtio/netdevice.cc
      • M src/connectivity/network/drivers/network-device/device/network_device-microbenchmarks.cc
      • M src/connectivity/network/drivers/network-device/device/session.cc
      • M src/connectivity/network/drivers/network-device/device/test_util_banjo.h
      • M src/connectivity/wlan/drivers/testing/lib/sim-env/test/location_tests.cc
      • M src/connectivity/wlan/drivers/testing/lib/sim-env/test/rx_tests.cc
      • M src/connectivity/wlan/drivers/testing/lib/sim-env/test/trans_time_tests.cc
      • M src/firmware/gigaboot/cpp/boot_zbi_items.cc
      • M src/firmware/gigaboot/cpp/cmdline.cc
      • M src/firmware/gigaboot/cpp/mdns.cc
      • M src/lib/elfldltl/test/layout-tests.cc
      • M src/lib/fidl/cpp/any_error_in.cc
      • M src/lib/fidl/cpp/fidl_cpp_v2.api
      • M src/lib/fidl/cpp/include/lib/fidl/cpp/any_error_in.h
      • M src/storage/fvm/format.cc
      • M src/storage/volume_image/adapter/commands/arguments.cc
      • M src/sys/fuzzing/common/child-process.cc
      • M tools/fidl/fidlc/src/utils.cc
      • M zircon/kernel/lib/object_cache/include/lib/object_cache.h
      • M zircon/kernel/tests/string_view_tests.cc
      • M zircon/system/ulib/inspect/vmo/state.cc
      • M zircon/system/ulib/inspector/backtrace.cc
      • M zircon/system/ulib/runtests-utils/runtests-utils.cc
      • M zircon/system/utest/core/thread-initial-state/init-state.cc
        Change size: M
        Delta: 26 files changed, 67 insertions(+), 66 deletions(-)
        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedAPI-Review
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: newchange
        Gerrit-Project: fuchsia
        Gerrit-Branch: main
        Gerrit-Change-Id: I2f5457fcb731f7bf04c1efb23f6234fbbe471d0c
        Gerrit-Change-Number: 1010227
        Gerrit-PatchSet: 3
        Gerrit-Owner: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Adam Barth <aba...@google.com>
        Gerrit-Reviewer: Ian McKellar <ian...@google.com>
        Gerrit-Reviewer: James Robinson <jam...@google.com>
        Gerrit-Reviewer: Leonard Chan <leona...@google.com>

        --
        You received this message because you are subscribed to the Google Groups "owners-override" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
        To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/bc3352d1650fe88ef4ff12d17022037fcd7e0a5e-HTML%40fuchsia-review.googlesource.com.
        satisfied_requirement
        open
        diffy

        'Leonard Chan (Gerrit)' via owners-override

        unread,
        Mar 19, 2024, 2:50:14 PMMar 19
        to Owners Override
        Attention needed from Owners Override

        Leonard Chan has uploaded the change for review

        Leonard Chan would like Owners Override to review this change.

        Related details

        Attention is currently required from:
        • Owners Override
        Submit Requirements:
        • requirement satisfiedAPI-Review
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: newchange
        Gerrit-Project: fuchsia
        Gerrit-Branch: main
        Gerrit-Change-Id: I2f5457fcb731f7bf04c1efb23f6234fbbe471d0c
        Gerrit-Change-Number: 1010227
        Gerrit-PatchSet: 3
        Gerrit-Owner: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Adam Barth <aba...@google.com>
        Gerrit-Reviewer: Ian McKellar <ian...@google.com>
        Gerrit-Reviewer: James Robinson <jam...@google.com>
        Gerrit-Reviewer: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
        Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

        --
        You received this message because you are subscribed to the Google Groups "owners-override" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
        To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c959d826427cfb5462765cce0b235df63b89ec5b-HTML%40fuchsia-review.googlesource.com.
        satisfied_requirement
        open
        diffy

        'James Robinson (Gerrit)' via owners-override

        unread,
        Mar 19, 2024, 3:15:34 PMMar 19
        to Leonard Chan, Owners Override, Adam Barth, Ian McKellar, Tricium, Roland McGrath, CQ Bot, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Petr Hosek
        Attention needed from Leonard Chan and Owners Override

        James Robinson voted Owners-Override+1

        Owners-Override+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Leonard Chan
        • Owners Override
        Submit Requirements:
        • requirement satisfiedAPI-Review
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: fuchsia
        Gerrit-Branch: main
        Gerrit-Change-Id: I2f5457fcb731f7bf04c1efb23f6234fbbe471d0c
        Gerrit-Change-Number: 1010227
        Gerrit-PatchSet: 3
        Gerrit-Owner: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Adam Barth <aba...@google.com>
        Gerrit-Reviewer: Ian McKellar <ian...@google.com>
        Gerrit-Reviewer: James Robinson <jam...@google.com>
        Gerrit-Reviewer: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
        Gerrit-Reviewer: Petr Hosek <pho...@google.com>
        Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>
        Gerrit-Attention: Leonard Chan <leona...@google.com>
        Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
        Gerrit-Comment-Date: Tue, 19 Mar 2024 19:15:26 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes

        --
        You received this message because you are subscribed to the Google Groups "owners-override" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
        To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f29d4127bf3fcbaa9180352748d7b65feb4c5c09-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
        satisfied_requirement
        open
        diffy

        'Leonard Chan (Gerrit)' via owners-override

        unread,
        Mar 19, 2024, 3:17:11 PMMar 19
        to James Robinson, Owners Override, Adam Barth, Ian McKellar, Tricium, Roland McGrath, CQ Bot, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Petr Hosek
        Attention needed from Owners Override

        Leonard Chan voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Owners Override
        Submit Requirements:
        • requirement satisfiedAPI-Review
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: fuchsia
        Gerrit-Branch: main
        Gerrit-Change-Id: I2f5457fcb731f7bf04c1efb23f6234fbbe471d0c
        Gerrit-Change-Number: 1010227
        Gerrit-PatchSet: 3
        Gerrit-Owner: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Adam Barth <aba...@google.com>
        Gerrit-Reviewer: Ian McKellar <ian...@google.com>
        Gerrit-Reviewer: James Robinson <jam...@google.com>
        Gerrit-Reviewer: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
        Gerrit-Reviewer: Petr Hosek <pho...@google.com>
        Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>
        Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
        Gerrit-Comment-Date: Tue, 19 Mar 2024 19:17:05 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes

        --
        You received this message because you are subscribed to the Google Groups "owners-override" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
        To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e38a7303ca71f05725a6242d84af1f647df8ad18-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
        satisfied_requirement
        open
        diffy

        'CQ Bot (Gerrit)' via owners-override

        unread,
        Mar 19, 2024, 3:53:52 PMMar 19
        to Leonard Chan, James Robinson, Owners Override, Adam Barth, Ian McKellar, Tricium, Roland McGrath, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Petr Hosek

        CQ Bot submitted the change

        Change information

        Commit message:
        [clang] Fix instances of conversions from iterators to raw pointers

        https://github.com/llvm/llvm-project/pull/74482 in upstream libc++
        changed the return type of various iterator functions (*.begin(),
        *.end(), etc) from raw pointers to iterator objects. The return types
        for these functions aren't guaranteed to be raw pointers, but we have a
        bunch of c++ code that assumes they are. We can get pointers from these
        iterators by simply dereferencing them and taking their address (`&*iter`).
        Bug: 328282937
        Change-Id: I2f5457fcb731f7bf04c1efb23f6234fbbe471d0c
        Owners-Override: James Robinson <jam...@google.com>
        Reviewed-by: Ian McKellar <ian...@google.com>
        Reviewed-by: James Robinson <jam...@google.com>
        Commit-Queue: Leonard Chan <leona...@google.com>
        API-Review: Adam Barth <aba...@google.com>
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedAPI-Review: +1 by Adam Barth
        • requirement satisfiedCode-Review: +2 by James Robinson, +2 by Ian McKellar
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: fuchsia
        Gerrit-Branch: main
        Gerrit-Change-Id: I2f5457fcb731f7bf04c1efb23f6234fbbe471d0c
        Gerrit-Change-Number: 1010227
        Gerrit-PatchSet: 4
        Gerrit-Owner: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Adam Barth <aba...@google.com>
        Gerrit-Reviewer: Ian McKellar <ian...@google.com>
        Gerrit-Reviewer: James Robinson <jam...@google.com>
        Gerrit-Reviewer: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
        Gerrit-Reviewer: Petr Hosek <pho...@google.com>
        Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>

        --
        You received this message because you are subscribed to the Google Groups "owners-override" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
        To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/98117f52cf3a13c7939d7496455813c0a96b68d4-HTML%40fuchsia-review.googlesource.com.
        open
        diffy
        satisfied_requirement

        'GI Roller (Gerrit)' via owners-override

        unread,
        Mar 19, 2024, 3:56:47 PMMar 19
        to Leonard Chan, CQ Bot, James Robinson, Owners Override, Adam Barth, Ian McKellar, Tricium, Roland McGrath, fuchsia-c...@fuchsia-infra.iam.gserviceaccount.com, Petr Hosek

        Message from GI Roller

        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedAPI-Review
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: fuchsia
        Gerrit-Branch: main
        Gerrit-Change-Id: I2f5457fcb731f7bf04c1efb23f6234fbbe471d0c
        Gerrit-Change-Number: 1010227
        Gerrit-PatchSet: 4
        Gerrit-Owner: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Adam Barth <aba...@google.com>
        Gerrit-Reviewer: Ian McKellar <ian...@google.com>
        Gerrit-Reviewer: James Robinson <jam...@google.com>
        Gerrit-Reviewer: Leonard Chan <leona...@google.com>
        Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
        Gerrit-Reviewer: Petr Hosek <pho...@google.com>
        Gerrit-Reviewer: Roland McGrath <mcgr...@google.com>
        Gerrit-Comment-Date: Tue, 19 Mar 2024 19:56:40 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: No

        --
        You received this message because you are subscribed to the Google Groups "owners-override" group.
        To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
        To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e4e8014afa4d9a5e2e7061d23a22ac4475211b26-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages