[XS] Change in fuchsia/fuchsia[main]: [storage] Remove unused constant
'Paul Kirth (Gerrit)' via owners-override
Attention is currently required from: Chris Drouillard, James Sullivan, Owners Override.
Paul Kirth would like Owners Override, Chris Drouillard and James Sullivan to review this change.
[storage] Remove unused constant
In the upcoming clang roll, the -Wunused-const-variable diagnostic is
much more stringent in C++20 mode, and will flag unused constants.
Change-Id: I6285d767044fede29366cd0f626c023af39299a9
---
M src/storage/lib/fs_management/cpp/options_test.cc
1 file changed, 0 insertions(+), 2 deletions(-)
diff --git a/src/storage/lib/fs_management/cpp/options_test.cc b/src/storage/lib/fs_management/cpp/options_test.cc
index ebb0a88..e3ddf16 100644
--- a/src/storage/lib/fs_management/cpp/options_test.cc
+++ b/src/storage/lib/fs_management/cpp/options_test.cc
@@ -10,8 +10,6 @@
namespace {
-const std::string kTestBinary = "/test/binary";
-
void AssertStartOptionsEqual(const fuchsia_fs_startup::wire::StartOptions& a,
const fuchsia_fs_startup::wire::StartOptions& b) {
ASSERT_EQ(a.read_only, b.read_only);
To view, visit change 933435. To unsubscribe, or for help writing mail filters, visit settings.
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/81d8788957c58ccc7df58f895e4d4162b45a1a4d-HTML%40fuchsia-review.googlesource.com.
'Paul Kirth (Gerrit)' via owners-override
Attention is currently required from: Chris Drouillard, James Sullivan, Owners Override.
Patch set 1:Fuchsia-Auto-Submit +1
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Chris Drouillard (Gerrit)' via owners-override
Attention is currently required from: James Sullivan, Owners Override, Paul Kirth.
Patch set 2:Code-Review +2
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
Attention is currently required from: James Sullivan, Owners Override, Paul Kirth.
1 comment:
Patchset:
I'm curious why this CL was sent to owners-override for review. This change looks like a narrowly scoped changed that should be reviewed using the normal OWNERS.
To view, visit change 933435. To unsubscribe, or for help writing mail filters, visit settings.
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Paul Kirth (Gerrit)' via owners-override
Attention is currently required from: Adam Barth, James Sullivan, Owners Override.
Patch set 2:Fuchsia-Auto-Submit +1
1 comment:
Patchset:
I'm curious why this CL was sent to owners-override for review. […]
oh, I guess I misread the changes in procedure linked in the announcement. I had read the directions for changes that were cutting across the codebase, but but looking I see it's mostly intended for large scale changes. There have been quite a few of these cropping up, but looking at the document and announcement again, I'd say I made an error adding it. I will be a bit more careful in the future.
To view, visit change 933435. To unsubscribe, or for help writing mail filters, visit settings.
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
Attention is currently required from: James Sullivan, Owners Override, Paul Kirth.
1 comment:
Patchset:
oh, I guess I misread the changes in procedure linked in the announcement. […]
Ok, thanks!
To view, visit change 933435. To unsubscribe, or for help writing mail filters, visit settings.
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
CQ Bot submitted this change.
[storage] Remove unused constant
In the upcoming clang roll, the -Wunused-const-variable diagnostic is
much more stringent in C++20 mode, and will flag unused constants.
Fixed:135339
Change-Id: I6285d767044fede29366cd0f626c023af39299a9
Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/933435
Fuchsia-Auto-Submit: Paul Kirth <paul...@google.com>
Reviewed-by: Chris Drouillard <cdr...@google.com>
Commit-Queue: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
---
M src/storage/lib/fs_management/cpp/options_test.cc
1 file changed, 0 insertions(+), 2 deletions(-)
diff --git a/src/storage/lib/fs_management/cpp/options_test.cc b/src/storage/lib/fs_management/cpp/options_test.cc
index ebb0a88..e3ddf16 100644
--- a/src/storage/lib/fs_management/cpp/options_test.cc
+++ b/src/storage/lib/fs_management/cpp/options_test.cc
@@ -10,8 +10,6 @@
namespace {
-const std::string kTestBinary = "/test/binary";
-
void AssertStartOptionsEqual(const fuchsia_fs_startup::wire::StartOptions& a,
const fuchsia_fs_startup::wire::StartOptions& b) {
ASSERT_EQ(a.read_only, b.read_only);
To view, visit change 933435. To unsubscribe, or for help writing mail filters, visit settings.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Change has been successfully rolled: http://go/roll-cl/6777c4893a62b89c1043ed779d8a136a45ef04b9
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.