'Chris Phoenix (Gerrit)' via owners-override

unread,

Apr 24, 2025, 6:15:24 PMApr 24

to Owners Override

Attention needed from Aaron Wood, Alice Neels and Owners Override

Chris Phoenix has uploaded the change for review

Chris Phoenix would like Owners Override to review this change.

Commit message

[CTF] Skeleton of test-disable script

//scripts/disable_ctf_tests/BUILD.gn (runs unit tests on .py sources)
//scripts/disable_ctf_tests/main.py (almost empty)
//scripts/disable_ctf_tests/tests/all_tests.py (almost empty)
//sdk/ctf/disabled_tests.json (an empty list)

Bug: b/412727988

Change-Id: Ib4d2c7476542d605c6e219ddf13b990bc1035f79

Change diff

diff --git a/scripts/BUILD.gn b/scripts/BUILD.gn
index d52e6c2..a0bbffc 100644
--- a/scripts/BUILD.gn
+++ b/scripts/BUILD.gn
@@ -21,6 +21,7 @@
   testonly = true
   deps = [
     ":build_id_conv_test($host_toolchain)",
+    "disable_ctf_tests:tests",
     "ffx_complete:tests",
     "fxtest:tests",
     "lib:tests",
diff --git a/scripts/OWNERS b/scripts/OWNERS
index f8c0926..3f0cb12 100644
--- a/scripts/OWNERS
+++ b/scripts/OWNERS
@@ -2,8 +2,8 @@
 # This file intentionally does not contain any (non-per-file) OWNERS. See
 # //scripts/README.md for more info.
 
-# shell- and fx-related utilities.
-per-file fuchsia-vendored-python*,fx,fx-*,hermetic-env = crj...@google.com
+# shell-, fx-, and ctf-related utilities.
+per-file fuchsia-vendored-python*,fx,fx-*,hermetic-env,disable_ctf_tests = crj...@google.com
 
 # FIDL-related scripts.
 per-file generate-fidl-* = file://tools/fidl/OWNERS
diff --git a/scripts/disable_ctf_tests/BUILD.gn b/scripts/disable_ctf_tests/BUILD.gn
new file mode 100644
index 0000000..853cb41
--- /dev/null
+++ b/scripts/disable_ctf_tests/BUILD.gn
@@ -0,0 +1,31 @@
+# Copyright 2025 The Fuchsia Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import("//build/python/host.gni")
+import("//build/python/python_binary.gni")
+import("//build/python/python_host_test.gni")
+
+group("tests") {
+  testonly = true
+
+  deps = [ ":disable_ctf_tests_test($host_toolchain)" ]
+}
+
+if (is_host) {
+  # Main executable target.
+  python_binary("disable_ctf_tests") {
+    # Unbuffer so output can be piped to other programs nicely.
+    unbuffered_output = true
+    main_source = "main.py"
+    output_name = "disable_ctf_tests.pyz"
+    sources = []
+  }
+
+  python_host_test("disable_ctf_tests_test") {
+    main_source = "tests/all_tests.py"
+    main_callable = "unittest.main"
+    extra_args = [ "-v" ]
+    libraries = []
+  }
+}
diff --git a/scripts/disable_ctf_tests/main.py b/scripts/disable_ctf_tests/main.py
new file mode 100644
index 0000000..62c4fb7
--- /dev/null
+++ b/scripts/disable_ctf_tests/main.py
@@ -0,0 +1,17 @@
+# Copyright 2025 The Fuchsia Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import sys
+
+
+def Main(args: list[str]) -> int:
+    return 0
+
+
+def run_unittests() -> None:
+    pass
+
+
+if __name__ == "__main__":
+    sys.exit(Main(sys.argv[1:]))
diff --git a/scripts/disable_ctf_tests/tests/all_tests.py b/scripts/disable_ctf_tests/tests/all_tests.py
new file mode 100644
index 0000000..e26921b
--- /dev/null
+++ b/scripts/disable_ctf_tests/tests/all_tests.py
@@ -0,0 +1,12 @@
+# Copyright 2025 The Fuchsia Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+
+import unittest
+
+
+class TestTheApp(unittest.TestCase):
+    def test_the_tester(self) -> None:
+        """Assert False to make sure the tests are running, True to commit."""
+        self.assertTrue(True)
diff --git a/sdk/ctf/disabled_tests.json b/sdk/ctf/disabled_tests.json
new file mode 100644
index 0000000..fe51488
--- /dev/null
+++ b/sdk/ctf/disabled_tests.json
@@ -0,0 +1 @@
+[]

Change information

Files:

M scripts/BUILD.gn
M scripts/OWNERS
A scripts/disable_ctf_tests/BUILD.gn
A scripts/disable_ctf_tests/main.py
A scripts/disable_ctf_tests/tests/all_tests.py
A sdk/ctf/disabled_tests.json

Change size: M

Delta: 6 files changed, 64 insertions(+), 2 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Aaron Wood
Alice Neels
Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/59be69a0e5429493489182610d84d5f10e9f9352-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Alice Neels (Gerrit)' via owners-override

unread,

Apr 24, 2025, 6:24:48 PMApr 24

to Chris Phoenix, Owners Override, Christopher Johnson, Aaron Wood, GI Try Builder, CQ Bot

Attention needed from Aaron Wood, Chris Phoenix and Owners Override

Alice Neels voted

Code-Review	+2
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

Aaron Wood
Chris Phoenix
Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/852ea71216e4f2480d55ddcdea9691d79eb7832d-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Chris Phoenix (Gerrit)' via owners-override

unread,

Apr 24, 2025, 7:53:17 PMApr 24

to Alice Neels, Owners Override, Christopher Johnson, Aaron Wood, GI Try Builder, CQ Bot

Attention needed from Aaron Wood and Owners Override

Chris Phoenix voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

Aaron Wood
Owners Override

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c13c2b8de640e1d168ffd36c87c40dad23a9fafc-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'CQ Bot (Gerrit)' via owners-override

unread,

Apr 24, 2025, 8:36:12 PMApr 24

to Chris Phoenix, Alice Neels, Owners Override, Christopher Johnson, Aaron Wood, GI Try Builder

CQ Bot submitted the change

Change information

Commit message:

[CTF] Skeleton of test-disable script

//scripts/disable_ctf_tests/BUILD.gn (runs unit tests on .py sources)
//scripts/disable_ctf_tests/main.py (almost empty)
//scripts/disable_ctf_tests/tests/all_tests.py (almost empty)
//sdk/ctf/disabled_tests.json (an empty list)

Bug: b/412727988

Change-Id: Ib4d2c7476542d605c6e219ddf13b990bc1035f79

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1258965

Reviewed-by: Christopher Johnson <crj...@google.com>

Owners-Override: Alice Neels <nee...@google.com>

Commit-Queue: Chris Phoenix <cpho...@google.com>

Reviewed-by: Alice Neels <nee...@google.com>

Files:

M scripts/BUILD.gn
M scripts/OWNERS
A scripts/disable_ctf_tests/BUILD.gn
A scripts/disable_ctf_tests/main.py
A scripts/disable_ctf_tests/tests/all_tests.py
A sdk/ctf/disabled_tests.json

Change size: M

Delta: 6 files changed, 64 insertions(+), 2 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +2 by Alice Neels, +2 by Christopher Johnson

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/3c01b091a1baef37b362ce50376fe22ae8eced74-HTML%40fuchsia-review.googlesource.com.

open

diffy

satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,

Apr 24, 2025, 8:43:57 PMApr 24

to Chris Phoenix, CQ Bot, Alice Neels, Owners Override, Christopher Johnson, Aaron Wood, GI Try Builder

Message from GI Roller

Change has been successfully rolled: http://go/roll-cl/98f3af4462b1bf020f530cbb9ab70c593ba01283

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/aa178968b923816e2007ece8c3bddd74dbdb6d92-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[M] Change in fuchsia/fuchsia[main]: [CTF] Skeleton of test-disable script

'Chris Phoenix (Gerrit)' via owners-override

Chris Phoenix has uploaded the change for review

Commit message

Change diff

Change information

Related details

'Alice Neels (Gerrit)' via owners-override

Alice Neels voted

Related details

'Chris Phoenix (Gerrit)' via owners-override

Chris Phoenix voted Commit-Queue+2

Related details

'CQ Bot (Gerrit)' via owners-override

CQ Bot submitted the change

Change information

'GI Roller (Gerrit)' via owners-override

Message from GI Roller

Related details