[M] Change in fuchsia/fuchsia[main]: [fidl][hlcpp] Don't depend directly on the lib
0 views
Skip to first unread message
'Ian McKellar (Gerrit)' via owners-override
Aug 21, 2025, 11:32:50 AMAug 21
to Owners Override
Attention needed from Hunter Freyer and Owners Override
Ian McKellar has uploaded the change for review![]( "Open in Gerrit")
Ian McKellar would like Owners Override to review this change.
Commit message
[fidl][hlcpp] Don't depend directly on the lib
Instead of depending directly on the HLCPP bindings library, components
should get that dependency transitively by depending on generated HLCPP
bindings.
This makes cleaning up HLCPP dependencies simpler.
Change-Id: I7b5ea72469d1ca3b0bf557f8d9060e215d88621b
Change diff
Change information
Files:
- M examples/diagnostics/inspect/cpp/BUILD.gn
- M examples/intl/wisdom/cpp/client/BUILD.gn
- M examples/intl/wisdom/cpp/server/BUILD.gn
- M sdk/ctf/tests/pkg/fidl/cpp/BUILD.gn
- M sdk/lib/component/tests/BUILD.gn
- M sdk/lib/driver/component/cpp/BUILD.gn
- M sdk/lib/driver/devfs/cpp/BUILD.gn
- M sdk/lib/driver/power/cpp/testing/BUILD.gn
- M sdk/lib/fidl/cpp/BUILD.gn
- M sdk/lib/fidl/hlcpp/BUILD.gn
- M sdk/lib/fuzzing/cpp/BUILD.gn
- M sdk/lib/sys/component/cpp/testing/BUILD.gn
- M sdk/lib/sys/component/cpp/tests/BUILD.gn
- M sdk/lib/sys/cpp/testing/BUILD.gn
- M sdk/lib/sys/cpp/tests/BUILD.gn
- M sdk/lib/sys/service/cpp/BUILD.gn
- M sdk/lib/ui/scenic/cpp/BUILD.gn
- M sdk/lib/ui/scenic/cpp/testing/BUILD.gn
- M sdk/lib/vfs/cpp/BUILD.gn
- M src/camera/bin/camera-gym/controller_client/BUILD.gn
- M src/camera/bin/camera-gym/controller_error/BUILD.gn
- M src/camera/bin/camera-gym/controller_parser/BUILD.gn
- M src/camera/bin/device/BUILD.gn
- M src/camera/bin/device/testing/BUILD.gn
- M src/camera/bin/device_watcher/BUILD.gn
- M src/camera/bin/sensor_cli/BUILD.gn
- M src/camera/bin/usb_device/BUILD.gn
- M src/camera/bin/virtual_camera/BUILD.gn
- M src/camera/drivers/usb_video/BUILD.gn
- M src/camera/lib/fake_camera/BUILD.gn
- M src/camera/lib/fake_controller/BUILD.gn
- M src/camera/lib/fake_legacy_stream/BUILD.gn
- M src/camera/lib/fake_logical_buffer_collection/BUILD.gn
- M src/camera/lib/fake_stream/BUILD.gn
- M src/connectivity/bluetooth/hci/passthrough/BUILD.gn
- M src/connectivity/bluetooth/lib/fidl/BUILD.gn
- M src/connectivity/network/testing/netemul/network-context/BUILD.gn
- M src/developer/adb/bin/adb/BUILD.gn
- M src/developer/build_info/BUILD.gn
- M src/developer/build_info/testing/BUILD.gn
- M src/developer/forensics/crash_reports/tests/BUILD.gn
- M src/developer/forensics/feedback/reboot_log/BUILD.gn
- M src/developer/forensics/feedback_data/tests/BUILD.gn
- M src/developer/forensics/public/fakes/BUILD.gn
- M src/developer/forensics/testing/fakes/BUILD.gn
- M src/developer/forensics/testing/stubs/BUILD.gn
- M src/developer/forensics/utils/BUILD.gn
- M src/devices/tee/drivers/optee/BUILD.gn
- M src/graphics/bin/agis/BUILD.gn
- M src/graphics/display/lib/driver-framework-migration-utils/namespace/BUILD.gn
- M src/graphics/display/testing/fake-display-stack-host/tests/BUILD.gn
- M src/lib/fidl/c/walker_tests/BUILD.gn
- M src/lib/fidl/contrib/connection/BUILD.gn
- M src/lib/fidl_fuchsia_intl_ext/cpp/BUILD.gn
- M src/lib/intl/intl_property_provider_impl/BUILD.gn
- M src/lib/intl/time_zone_info/BUILD.gn
- M src/lib/ui/flatland-frame-scheduling/BUILD.gn
- M src/lib/ui/scenic/cpp/BUILD.gn
- M src/lib/vulkan/gapii-pkg/BUILD.gn
- M src/lib/vulkan/vulkan-validation-pkg/BUILD.gn
- M src/media/audio/lib/format2/BUILD.gn
- M src/media/audio/lib/format2/format.cc
- M src/media/audio/lib/test/BUILD.gn
- M src/media/drivers/amlogic_decoder/BUILD.gn
- M src/media/lib/codec_impl/BUILD.gn
- M src/media/testing/mock_profile_provider/BUILD.gn
- M src/performance/experimental/profiler/BUILD.gn
- M src/performance/experimental/profiler/tests/BUILD.gn
- M src/performance/experimental/profiler/tests/component_with_children/BUILD.gn
- M src/performance/memory/sampler/instrumentation/tests/BUILD.gn
- M src/performance/trace_manager/BUILD.gn
- M src/power/testing/thermal-test-control/BUILD.gn
- M src/storage/blobfs/BUILD.gn
- M src/sys/fuzzing/libfuzzer/testing/BUILD.gn
- M src/sys/fuzzing/realmfuzzer/engine/BUILD.gn
- M src/sys/test_runners/gtest/test_data/BUILD.gn
- M src/testing/fidl/echo_realm_placeholder/echo_server/BUILD.gn
- M src/tests/benchmarks/fidl/cpp/BUILD.gn
- M src/tests/benchmarks/fidl/hlcpp/BUILD.gn
- M src/tests/benchmarks/fidl/llcpp/BUILD.gn
- M src/tests/fidl/compatibility/BUILD.gn
- M src/tests/fidl/compatibility/hlcpp/BUILD.gn
- M src/tests/fidl/dynsuite/client_suite/runners/hlcpp_async/BUILD.gn
- M src/tests/fidl/dynsuite/client_suite/runners/hlcpp_sync/BUILD.gn
- M src/tests/fidl/dynsuite/server_suite/runners/hlcpp/BUILD.gn
- M src/ui/a11y/bin/a11y_manager/BUILD.gn
- M src/ui/a11y/bin/a11y_manager/tests/BUILD.gn
- M src/ui/a11y/bin/a11y_manager/tests/mocks/BUILD.gn
- M src/ui/a11y/lib/annotation/BUILD.gn
- M src/ui/a11y/lib/annotation/tests/mocks/BUILD.gn
- M src/ui/a11y/lib/configuration/BUILD.gn
- M src/ui/a11y/lib/configuration/tests/BUILD.gn
- M src/ui/a11y/lib/focus_chain/BUILD.gn
- M src/ui/a11y/lib/focus_chain/tests/mocks/BUILD.gn
- M src/ui/a11y/lib/gesture_manager/BUILD.gn
- M src/ui/a11y/lib/gesture_manager/arena/BUILD.gn
- M src/ui/a11y/lib/gesture_manager/arena_v2/BUILD.gn
- M src/ui/a11y/lib/gesture_manager/tests/mocks/BUILD.gn
- M src/ui/a11y/lib/magnifier/BUILD.gn
- M src/ui/a11y/lib/screen_reader/BUILD.gn
- M src/ui/a11y/lib/screen_reader/focus/BUILD.gn
- M src/ui/a11y/lib/screen_reader/focus/tests/BUILD.gn
- M src/ui/a11y/lib/screen_reader/focus/tests/mocks/BUILD.gn
- M src/ui/a11y/lib/screen_reader/tests/mocks/BUILD.gn
- M src/ui/a11y/lib/screen_reader/util/BUILD.gn
- M src/ui/a11y/lib/screen_reader/util/tests/BUILD.gn
- M src/ui/a11y/lib/semantics/BUILD.gn
- M src/ui/a11y/lib/semantics/tests/BUILD.gn
- M src/ui/a11y/lib/semantics/tests/mocks/BUILD.gn
- M src/ui/a11y/lib/semantics/util/tests/BUILD.gn
- M src/ui/a11y/lib/tts/BUILD.gn
- M src/ui/a11y/lib/util/tests/mocks/BUILD.gn
- M src/ui/a11y/lib/view/BUILD.gn
- M src/ui/a11y/lib/view/tests/BUILD.gn
- M src/ui/a11y/lib/view/tests/mocks/BUILD.gn
- M src/ui/a11y/testing/BUILD.gn
- M src/ui/bin/virtual_keyboard_manager/BUILD.gn
- M src/ui/bin/virtual_keyboard_manager/tests/BUILD.gn
- M src/ui/input/lib/injector/BUILD.gn
- M src/ui/lib/escher/BUILD.gn
- M src/ui/scenic/bin/BUILD.gn
- M src/ui/scenic/lib/allocation/BUILD.gn
- M src/ui/scenic/lib/flatland/BUILD.gn
- M src/ui/scenic/lib/flatland/buffers/BUILD.gn
- M src/ui/scenic/lib/flatland/engine/BUILD.gn
- M src/ui/scenic/lib/input/tests/BUILD.gn
- M src/ui/scenic/lib/utils/BUILD.gn
- M src/ui/testing/scene_provider/BUILD.gn
- M src/ui/testing/util/BUILD.gn
- M src/ui/tests/integration_input_tests/touch/touch-flatland-client/BUILD.gn
- M src/virtualization/packages/BUILD.gn
- M zircon/system/ulib/driver-unit-test/BUILD.gn
- M zircon/system/ulib/driver-unit-test/logger.cc
- M zircon/system/ulib/runtests-utils/BUILD.gn
- M zircon/system/ulib/runtests-utils/include/runtests-utils/log-exporter.h
- M zircon/system/ulib/runtests-utils/log-exporter.cc
- M zircon/system/ulib/sysmem-version/test/BUILD.gn
- M zircon/system/ulib/sysmem-version/test/sysmem-version-test.cc
Change size: M
Delta: 138 files changed, 15 insertions(+), 176 deletions(-)
Related details
Attention is currently required from:
- Hunter Freyer
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7fcb7e11fc216bd91b8953edfa967262f224c319-HTML%40fuchsia-review.googlesource.com.
'Ian McKellar (Gerrit)' via owners-override
Aug 21, 2025, 11:32:51 AMAug 21
to Owners Override, Marie Janssen, David Koloski, GI Try Builder, CQ Bot, Hunter Freyer
Attention needed from Hunter Freyer and Owners Override
Ian McKellar voted![]( "Open in Gerrit")
| Commit-Queue | +1 |
| Fuchsia-Auto-Submit | +1 |
Related details
Attention is currently required from:
- Hunter Freyer
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7fcb7e11fc216bd91b8953edfa967262f224c319-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'James Robinson (Gerrit)' via owners-override
Aug 21, 2025, 11:41:35 AMAug 21
to Ian McKellar, Owners Override, Marie Janssen, David Koloski, GI Try Builder, CQ Bot, Hunter Freyer
Attention needed from Hunter Freyer, Ian McKellar and Owners Override
James Robinson voted Owners-Override+1![]( "Open in Gerrit")
Attention is currently required from:
- Hunter Freyer
- Ian McKellar
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5462cc0eea1cb7be5592436fa4ea7819b427c467-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
Aug 21, 2025, 11:42:48 AMAug 21
to Ian McKellar, James Robinson, Owners Override, Marie Janssen, David Koloski, GI Try Builder, Hunter Freyer
CQ Bot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[fidl][hlcpp] Don't depend directly on the lib
Instead of depending directly on the HLCPP bindings library, components
should get that dependency transitively by depending on generated HLCPP
bindings.
This makes cleaning up HLCPP dependencies simpler.
Change-Id: I7b5ea72469d1ca3b0bf557f8d9060e215d88621b
Fuchsia-Auto-Submit: Ian McKellar <ian...@google.com>
Reviewed-by: David Koloski <dkol...@google.com>
Reviewed-by: Marie Janssen <jam...@google.com>
Commit-Queue: Ian McKellar <ian...@google.com>
Owners-Override: James Robinson <jam...@google.com>
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by David Koloski, +2 by Marie Janssen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/d134bef761f91e41d0a906400a952062b4f651a5-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Aug 21, 2025, 11:45:36 AMAug 21
to Ian McKellar, CQ Bot, James Robinson, Owners Override, Marie Janssen, David Koloski, GI Try Builder, Hunter Freyer
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1033495
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/08381530f9e59157816b0433774b4078a18d7dbc-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages