[M] Change in fuchsia/fuchsia[main]: [rust] Explicitly use Itertools::exactly_once(...)

0 views
Skip to first unread message

'Erick Tryzelaar (Gerrit)' via owners-override

unread,
Dec 3, 2025, 6:04:02 PM (8 days ago) Dec 3
to Owners Override
Attention needed from Owners Override and Étienne J. Membrives

Erick Tryzelaar has uploaded the change for review

Erick Tryzelaar would like Owners Override to review this change.

Commit message

[rust] Explicitly use Itertools::exactly_once(...)

An upcoming Rust toolchain has marked that the method
`Iterator::exactly_once()` is being considered for stabilization. To
avoid confict, Rust suggests explicitly calling
`Itertools::exactly_once()` to avoid ambiguity.
Fixed: 465155441
Change-Id: I6eb459eb65ce2cbcefbefff42ebbd0e4fc0c4a6e

Change diff


Change information

Files:
  • M src/connectivity/network/netstack3/src/bindings/filter.rs
  • M src/connectivity/network/netstack3/src/bindings/routes/watcher.rs
  • M src/connectivity/network/tests/fidl/routes-admin/src/lib.rs
  • M src/lib/testing/sharding/src/main.rs
  • M src/performance/memory/pprof/src/module_map.rs
Change size: M
Delta: 5 files changed, 47 insertions(+), 52 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
  • Étienne J. Membrives
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I6eb459eb65ce2cbcefbefff42ebbd0e4fc0c4a6e
Gerrit-Change-Number: 1440452
Gerrit-PatchSet: 1
Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Peter DeLong <pde...@google.com>
Gerrit-Reviewer: Étienne J. Membrives <etie...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Étienne J. Membrives <etie...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/390d01fde7d4b554481ddcdced0482d14232e5a7-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Erick Tryzelaar (Gerrit)' via owners-override

unread,
Dec 3, 2025, 6:04:07 PM (8 days ago) Dec 3
to Owners Override, Peter DeLong, GI Try Builder, CQ Bot, Étienne J. Membrives
Attention needed from Owners Override and Étienne J. Membrives

Erick Tryzelaar added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Erick Tryzelaar . resolved

Adding owners-override since change is trivial and reviewers are unavailable.

Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
  • Étienne J. Membrives
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I6eb459eb65ce2cbcefbefff42ebbd0e4fc0c4a6e
Gerrit-Change-Number: 1440452
Gerrit-PatchSet: 1
Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Peter DeLong <pde...@google.com>
Gerrit-Reviewer: Étienne J. Membrives <etie...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Étienne J. Membrives <etie...@google.com>
Gerrit-Comment-Date: Wed, 03 Dec 2025 23:03:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/390d01fde7d4b554481ddcdced0482d14232e5a7-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Jean-François Geyelin (Gerrit)' via owners-override

unread,
Dec 3, 2025, 6:56:27 PM (8 days ago) Dec 3
to Erick Tryzelaar, Owners Override, Peter DeLong, GI Try Builder, CQ Bot, Étienne J. Membrives
Attention needed from Erick Tryzelaar, Owners Override and Étienne J. Membrives

Jean-François Geyelin voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Erick Tryzelaar
  • Owners Override
  • Étienne J. Membrives
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I6eb459eb65ce2cbcefbefff42ebbd0e4fc0c4a6e
    Gerrit-Change-Number: 1440452
    Gerrit-PatchSet: 1
    Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
    Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
    Gerrit-Reviewer: Jean-François Geyelin <j...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Reviewer: Peter DeLong <pde...@google.com>
    Gerrit-Reviewer: Étienne J. Membrives <etie...@google.com>
    Gerrit-Attention: Erick Tryzelaar <etryz...@google.com>
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: Étienne J. Membrives <etie...@google.com>
    Gerrit-Comment-Date: Wed, 03 Dec 2025 23:56:11 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/862fc4920aa11b351d860e6533d3d30787af56c5-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    open
    diffy

    'CQ Bot (Gerrit)' via owners-override

    unread,
    Dec 3, 2025, 6:57:21 PM (8 days ago) Dec 3
    to Erick Tryzelaar, Jean-François Geyelin, Owners Override, Peter DeLong, GI Try Builder, Étienne J. Membrives

    CQ Bot submitted the change

    Change information

    Commit message:
    [rust] Explicitly use Itertools::exactly_once(...)

    An upcoming Rust toolchain has marked that the method
    `Iterator::exactly_once()` is being considered for stabilization. To
    avoid confict, Rust suggests explicitly calling
    `Itertools::exactly_once()` to avoid ambiguity.
    Fixed: 465155441
    Change-Id: I6eb459eb65ce2cbcefbefff42ebbd0e4fc0c4a6e
    Reviewed-by: Jean-François Geyelin <j...@google.com>
    Reviewed-by: Peter DeLong <pde...@google.com>
    Commit-Queue: Erick Tryzelaar <etryz...@google.com>
    Fuchsia-Auto-Submit: Erick Tryzelaar <etryz...@google.com>
    Files:
    • M src/connectivity/network/netstack3/src/bindings/filter.rs
    • M src/connectivity/network/netstack3/src/bindings/routes/watcher.rs
    • M src/connectivity/network/tests/fidl/routes-admin/src/lib.rs
    • M src/lib/testing/sharding/src/main.rs
    • M src/performance/memory/pprof/src/module_map.rs
    Change size: M
    Delta: 5 files changed, 47 insertions(+), 52 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +2 by Jean-François Geyelin, +2 by Peter DeLong
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I6eb459eb65ce2cbcefbefff42ebbd0e4fc0c4a6e
    Gerrit-Change-Number: 1440452
    Gerrit-PatchSet: 2
    Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
    Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
    Gerrit-Reviewer: Jean-François Geyelin <j...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Reviewer: Peter DeLong <pde...@google.com>
    Gerrit-Reviewer: Étienne J. Membrives <etie...@google.com>

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/92d8113d0201e76d05edd55922e54da16cc1952d-HTML%40fuchsia-review.googlesource.com.
    open
    diffy
    satisfied_requirement

    'GI Roller (Gerrit)' via owners-override

    unread,
    Dec 3, 2025, 7:00:16 PM (8 days ago) Dec 3
    to Erick Tryzelaar, CQ Bot, Jean-François Geyelin, Owners Override, Peter DeLong, GI Try Builder, Étienne J. Membrives

    Message from GI Roller

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I6eb459eb65ce2cbcefbefff42ebbd0e4fc0c4a6e
    Gerrit-Change-Number: 1440452
    Gerrit-PatchSet: 2
    Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
    Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
    Gerrit-Reviewer: Jean-François Geyelin <j...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Reviewer: Peter DeLong <pde...@google.com>
    Gerrit-Reviewer: Étienne J. Membrives <etie...@google.com>
    Gerrit-Comment-Date: Thu, 04 Dec 2025 00:00:11 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/58078194af5ba2d57eca1353020207ed35973248-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages