Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

[M] Change in fuchsia/fuchsia[main]: [fuchsia-async] Rename ::cancel => ::abort

4 views
Skip to first unread message

'Bruno Dal Bo (Gerrit)' via owners-override

unread,
May 2, 2025, 1:06:52 AMMay 2
to Owners Override
Attention needed from Owners Override

Bruno Dal Bo has uploaded the change for review

Bruno Dal Bo would like Owners Override to review this change.

Commit message

[fuchsia-async] Rename ::cancel => ::abort

Renames Task and JoinHandle `cancel` fns to `abort` so they're in line
with the `abort` and `cancel` semantics in `Scope` since introduction of
cooperative cancellation.
Bug: 379944929
Change-Id: Iff4afcac63f9839f2307010912c431504bf8da5b

Change diff


Change information

Files:
  • M examples/components/runner/colocated/src/program.rs
  • M src/connectivity/bluetooth/profiles/bt-avrcp/src/peer/tasks/mod.rs
  • M src/connectivity/bluetooth/testing/test-rfcomm-client/src/lib.rs
  • M src/connectivity/bluetooth/tools/bt-cli/src/main.rs
  • M src/connectivity/bluetooth/tools/bt-le-central/src/gatt.rs
  • M src/connectivity/bluetooth/tools/bt-map-mce-tool/src/accessor.rs
  • M src/connectivity/lowpan/drivers/lowpan-ot-driver/src/driver/border_agent.rs
  • M src/connectivity/overnet/lib/usb_vsock/src/connection.rs
  • M src/developer/ffx/daemon/protocols/fastboot_target_stream/src/lib.rs
  • M src/developer/ffx/daemon/proxy/src/lib.rs
  • M src/diagnostics/archivist/src/archivist.rs
  • M src/lib/fuchsia-async/src/runtime/fuchsia/executor/scope.rs
  • M src/lib/fuchsia-async/src/runtime/fuchsia/task.rs
  • M src/lib/fuchsia-async/src/runtime/portable.rs
  • M src/lib/fuchsia-async/src/runtime/portable/scope.rs
  • M src/starnix/psi_provider/src/main.rs
  • M src/storage/fxfs/platform/src/fuchsia/volumes_directory.rs
  • M src/storage/lib/vfs/rust/src/execution_scope.rs
  • M src/sys/test_manager/src/main.rs
  • M src/ui/lib/input_pipeline/src/interaction_state_handler.rs
Change size: M
Delta: 20 files changed, 69 insertions(+), 52 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Iff4afcac63f9839f2307010912c431504bf8da5b
Gerrit-Change-Number: 1266484
Gerrit-PatchSet: 2
Gerrit-Owner: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a01b14cf26e7eb6c3e2f80264b687f82db9d86f9-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Bruno Dal Bo (Gerrit)' via owners-override

unread,
May 2, 2025, 10:01:36 AMMay 2
to Owners Override, Chris Suter, GI Try Builder, CQ Bot
Attention needed from Owners Override

Bruno Dal Bo voted Fuchsia-Auto-Submit+1

Fuchsia-Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Iff4afcac63f9839f2307010912c431504bf8da5b
Gerrit-Change-Number: 1266484
Gerrit-PatchSet: 2
Gerrit-Owner: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Fri, 02 May 2025 14:01:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9f2062f9056a7bcdf744de33558ccf4286d929ef-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Marie Janssen (Gerrit)' via owners-override

unread,
May 2, 2025, 12:54:47 PMMay 2
to Bruno Dal Bo, Owners Override, Chris Suter, GI Try Builder, CQ Bot
Attention needed from Bruno Dal Bo and Owners Override

Marie Janssen voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Bruno Dal Bo
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Iff4afcac63f9839f2307010912c431504bf8da5b
Gerrit-Change-Number: 1266484
Gerrit-PatchSet: 2
Gerrit-Owner: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Chris Suter <csu...@google.com>
Gerrit-Reviewer: Marie Janssen <jam...@google.com>
Gerrit-Attention: Bruno Dal Bo <bruno...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Fri, 02 May 2025 16:54:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/8d6f2af42d91166a6ca6c9c7dec3c7808119547d-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'James Robinson (Gerrit)' via owners-override

unread,
May 5, 2025, 4:46:28 PMMay 5
to Bruno Dal Bo, Marie Janssen, Owners Override, Chris Suter, GI Try Builder, CQ Bot
Attention needed from Bruno Dal Bo and Owners Override

James Robinson voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Bruno Dal Bo
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Iff4afcac63f9839f2307010912c431504bf8da5b
Gerrit-Change-Number: 1266484
Gerrit-PatchSet: 2
Gerrit-Owner: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Chris Suter <csu...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Marie Janssen <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Bruno Dal Bo <bruno...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Mon, 05 May 2025 20:46:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/fb8b1254faf1aef865e34b0b389735ff1f56c489-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Bruno Dal Bo (Gerrit)' via owners-override

unread,
May 5, 2025, 4:54:14 PMMay 5
to Auto-Submit, James Robinson, Marie Janssen, Owners Override, Chris Suter, GI Try Builder, CQ Bot
Attention needed from Owners Override

Bruno Dal Bo voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Iff4afcac63f9839f2307010912c431504bf8da5b
Gerrit-Change-Number: 1266484
Gerrit-PatchSet: 2
Gerrit-Owner: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Chris Suter <csu...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Marie Janssen <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Mon, 05 May 2025 20:54:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9b0651851e4bf79dcdd5f91215fc514c366d0f0f-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
May 5, 2025, 7:35:20 PMMay 5
to Bruno Dal Bo, Auto-Submit, James Robinson, Marie Janssen, Owners Override, Chris Suter, GI Try Builder

CQ Bot submitted the change

Change information

Commit message:
[fuchsia-async] Rename ::cancel => ::abort

Renames Task and JoinHandle `cancel` fns to `abort` so they're in line
with the `abort` and `cancel` semantics in `Scope` since introduction of
cooperative cancellation.
Bug: 379944929
Change-Id: Iff4afcac63f9839f2307010912c431504bf8da5b
Reviewed-by: Marie Janssen <jam...@google.com>
Fuchsia-Auto-Submit: Bruno Dal Bo <bruno...@google.com>
Owners-Override: James Robinson <jam...@google.com>
Reviewed-by: Chris Suter <csu...@google.com>
Files:
  • M examples/components/runner/colocated/src/program.rs
  • M src/connectivity/bluetooth/profiles/bt-avrcp/src/peer/tasks/mod.rs
  • M src/connectivity/bluetooth/testing/test-rfcomm-client/src/lib.rs
  • M src/connectivity/bluetooth/tools/bt-cli/src/main.rs
  • M src/connectivity/bluetooth/tools/bt-le-central/src/gatt.rs
  • M src/connectivity/bluetooth/tools/bt-map-mce-tool/src/accessor.rs
  • M src/connectivity/lowpan/drivers/lowpan-ot-driver/src/driver/border_agent.rs
  • M src/connectivity/overnet/lib/usb_vsock/src/connection.rs
  • M src/developer/ffx/daemon/protocols/fastboot_target_stream/src/lib.rs
  • M src/developer/ffx/daemon/proxy/src/lib.rs
  • M src/diagnostics/archivist/src/archivist.rs
  • M src/lib/fuchsia-async/src/runtime/fuchsia/executor/scope.rs
  • M src/lib/fuchsia-async/src/runtime/fuchsia/task.rs
  • M src/lib/fuchsia-async/src/runtime/portable.rs
  • M src/lib/fuchsia-async/src/runtime/portable/scope.rs
  • M src/starnix/psi_provider/src/main.rs
  • M src/storage/fxfs/platform/src/fuchsia/volumes_directory.rs
  • M src/storage/lib/vfs/rust/src/execution_scope.rs
  • M src/sys/test_manager/src/main.rs
  • M src/ui/lib/input_pipeline/src/interaction_state_handler.rs
Change size: M
Delta: 20 files changed, 69 insertions(+), 52 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Marie Janssen, +2 by Chris Suter
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Iff4afcac63f9839f2307010912c431504bf8da5b
Gerrit-Change-Number: 1266484
Gerrit-PatchSet: 3
Gerrit-Owner: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Chris Suter <csu...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Marie Janssen <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e9d08d3df8dc1a6346741dde015d1e1bdb8e3357-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
May 5, 2025, 7:38:33 PMMay 5
to Bruno Dal Bo, CQ Bot, Auto-Submit, James Robinson, Marie Janssen, Owners Override, Chris Suter, GI Try Builder

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Iff4afcac63f9839f2307010912c431504bf8da5b
Gerrit-Change-Number: 1266484
Gerrit-PatchSet: 3
Gerrit-Owner: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: Bruno Dal Bo <bruno...@google.com>
Gerrit-Reviewer: Chris Suter <csu...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Marie Janssen <jam...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Mon, 05 May 2025 23:38:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/21b892b22c7dd02d8d16140047c60d355f30d7b3-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages