Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

[XS] Change in fuchsia/fuchsia[main]: [ctf][disable_ctf_tests] Correct OWNERS

0 views
Skip to first unread message

'Alice Neels (Gerrit)' via owners-override

unread,
May 9, 2025, 4:38:22 PMMay 9
to Owners Override
Attention needed from Owners Override

Chris Phoenix has uploaded the change for review

Alice Neels would like Owners Override to review this change authored by Chris Phoenix.

Commit message

[ctf][disable_ctf_tests] Correct OWNERS

Fix wrong OWNERS files.
Bug: b/412727988
Change-Id: Id0d622a31f7cdcfd0f4ad9f94233900d4d8aec5a

Change diff

diff --git a/scripts/OWNERS b/scripts/OWNERS
index 3f0cb12..4f98628 100644
--- a/scripts/OWNERS
+++ b/scripts/OWNERS
@@ -3,7 +3,7 @@
 # //scripts/README.md for more info.
 
 # shell-, fx-, and ctf-related utilities.
-per-file fuchsia-vendored-python*,fx,fx-*,hermetic-env,disable_ctf_tests = crj...@google.com
+per-file fuchsia-vendored-python*,fx,fx-*,hermetic-env = crj...@google.com
 
 # FIDL-related scripts.
 per-file generate-fidl-* = file://tools/fidl/OWNERS
diff --git a/scripts/disable_ctf_tests/OWNERS b/scripts/disable_ctf_tests/OWNERS
new file mode 100644
index 0000000..8b13789
--- /dev/null
+++ b/scripts/disable_ctf_tests/OWNERS
@@ -0,0 +1 @@
+

Change information

Files:
  • M scripts/OWNERS
  • A scripts/disable_ctf_tests/OWNERS
Change size: XS
Delta: 2 files changed, 2 insertions(+), 1 deletion(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Id0d622a31f7cdcfd0f4ad9f94233900d4d8aec5a
Gerrit-Change-Number: 1271882
Gerrit-PatchSet: 1
Gerrit-Owner: Chris Phoenix <cpho...@google.com>
Gerrit-Reviewer: Chris Phoenix <cpho...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e5786dcf697dacdfc7c1584e3f4ee0b64becd7e3-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'James Robinson (Gerrit)' via owners-override

unread,
May 9, 2025, 7:34:34 PMMay 9
to Chris Phoenix, Owners Override, CQ Bot
Attention needed from Chris Phoenix and Owners Override

James Robinson added 1 comment

File scripts/disable_ctf_tests/OWNERS
Line 1, Patchset 1 (Latest):
James Robinson . unresolved

This appears to be an empty file - did you intend to put something in here? Or perhaps delete it?

Open in Gerrit

Related details

Attention is currently required from:
  • Chris Phoenix
  • Owners Override
Submit Requirements:
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: Id0d622a31f7cdcfd0f4ad9f94233900d4d8aec5a
    Gerrit-Change-Number: 1271882
    Gerrit-PatchSet: 1
    Gerrit-Owner: Chris Phoenix <cpho...@google.com>
    Gerrit-Reviewer: Chris Phoenix <cpho...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-CC: James Robinson <jam...@google.com>
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: Chris Phoenix <cpho...@google.com>
    Gerrit-Comment-Date: Fri, 09 May 2025 23:34:26 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a879ceb0d2155347a0aa3e8f35de7c365eabadfb-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    unsatisfied_requirement
    open
    diffy

    'Chris Phoenix (Gerrit)' via owners-override

    unread,
    May 10, 2025, 2:29:36 AMMay 10
    to James Robinson, Owners Override, CQ Bot
    Attention needed from James Robinson and Owners Override

    Chris Phoenix added 1 comment

    File scripts/disable_ctf_tests/OWNERS
    Line 1, Patchset 1:
    James Robinson . resolved

    This appears to be an empty file - did you intend to put something in here? Or perhaps delete it?

    Chris Phoenix

    There were literally 30 seconds between me typing two ldaps into this file, committing it, and uploading it. My vscode is set to autosave. There's no way it should have been empty. But vscode has been flaky about file saves/versions several times this week, and I'm not properly paranoid yet. Sorry for the hassle.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • James Robinson
    • Owners Override
    Submit Requirements:
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: fuchsia
      Gerrit-Branch: main
      Gerrit-Change-Id: Id0d622a31f7cdcfd0f4ad9f94233900d4d8aec5a
      Gerrit-Change-Number: 1271882
      Gerrit-PatchSet: 2
      Gerrit-Owner: Chris Phoenix <cpho...@google.com>
      Gerrit-Reviewer: Chris Phoenix <cpho...@google.com>
      Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
      Gerrit-CC: James Robinson <jam...@google.com>
      Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
      Gerrit-Attention: James Robinson <jam...@google.com>
      Gerrit-Comment-Date: Sat, 10 May 2025 06:29:28 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: James Robinson <jam...@google.com>

      --
      You received this message because you are subscribed to the Google Groups "owners-override" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
      To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/cf4bb7698c51cbf90087f587ba0d368f08188eda-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
      unsatisfied_requirement
      open
      diffy

      'James Robinson (Gerrit)' via owners-override

      unread,
      May 13, 2025, 3:41:20 PMMay 13
      to Chris Phoenix, Christopher Johnson, Owners Override, CQ Bot
      Attention needed from Chris Phoenix, Christopher Johnson and Owners Override

      James Robinson voted

      Code-Review+2
      Owners-Override+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Chris Phoenix
      • Christopher Johnson
      • Owners Override
      Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: fuchsia
      Gerrit-Branch: main
      Gerrit-Change-Id: Id0d622a31f7cdcfd0f4ad9f94233900d4d8aec5a
      Gerrit-Change-Number: 1271882
      Gerrit-PatchSet: 2
      Gerrit-Owner: Chris Phoenix <cpho...@google.com>
      Gerrit-Reviewer: Chris Phoenix <cpho...@google.com>
      Gerrit-Reviewer: Christopher Johnson <crj...@google.com>
      Gerrit-Reviewer: James Robinson <jam...@google.com>
      Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
      Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
      Gerrit-Attention: Chris Phoenix <cpho...@google.com>
      Gerrit-Attention: Christopher Johnson <crj...@google.com>
      Gerrit-Comment-Date: Tue, 13 May 2025 19:41:13 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes

      --
      You received this message because you are subscribed to the Google Groups "owners-override" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
      To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/87395e169d8f1a61cd7f266bbefb8108502bf54a-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
      satisfied_requirement
      open
      diffy

      'Chris Phoenix (Gerrit)' via owners-override

      unread,
      May 13, 2025, 5:59:29 PMMay 13
      to Christopher Johnson, James Robinson, Owners Override, CQ Bot
      Attention needed from Christopher Johnson and Owners Override

      Chris Phoenix voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Christopher Johnson
      • Owners Override
      Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: fuchsia
      Gerrit-Branch: main
      Gerrit-Change-Id: Id0d622a31f7cdcfd0f4ad9f94233900d4d8aec5a
      Gerrit-Change-Number: 1271882
      Gerrit-PatchSet: 2
      Gerrit-Owner: Chris Phoenix <cpho...@google.com>
      Gerrit-Reviewer: Chris Phoenix <cpho...@google.com>
      Gerrit-Reviewer: Christopher Johnson <crj...@google.com>
      Gerrit-Reviewer: James Robinson <jam...@google.com>
      Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
      Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
      Gerrit-Attention: Christopher Johnson <crj...@google.com>
      Gerrit-Comment-Date: Tue, 13 May 2025 21:59:20 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes

      --
      You received this message because you are subscribed to the Google Groups "owners-override" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
      To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b1c8c869ef3cb5cb6ca16625f45a36afaaac6209-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
      satisfied_requirement
      open
      diffy

      'CQ Bot (Gerrit)' via owners-override

      unread,
      May 13, 2025, 6:04:33 PMMay 13
      to Chris Phoenix, Christopher Johnson, James Robinson, Owners Override

      CQ Bot submitted the change

      Change information

      Commit message:
      [ctf][disable_ctf_tests] Correct OWNERS

      Fix wrong OWNERS files.
      Bug: b/412727988
      Change-Id: Id0d622a31f7cdcfd0f4ad9f94233900d4d8aec5a
      Reviewed-by: James Robinson <jam...@google.com>
      Owners-Override: James Robinson <jam...@google.com>
      Commit-Queue: Chris Phoenix <cpho...@google.com>
      Files:
      • M scripts/OWNERS
      • A scripts/disable_ctf_tests/OWNERS
      Change size: XS
      Delta: 2 files changed, 3 insertions(+), 1 deletion(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +2 by James Robinson
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: fuchsia
      Gerrit-Branch: main
      Gerrit-Change-Id: Id0d622a31f7cdcfd0f4ad9f94233900d4d8aec5a
      Gerrit-Change-Number: 1271882
      Gerrit-PatchSet: 3
      Gerrit-Owner: Chris Phoenix <cpho...@google.com>
      Gerrit-Reviewer: Chris Phoenix <cpho...@google.com>
      Gerrit-Reviewer: Christopher Johnson <crj...@google.com>
      Gerrit-Reviewer: James Robinson <jam...@google.com>
      Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

      --
      You received this message because you are subscribed to the Google Groups "owners-override" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
      To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7b4e1529f7131cc313ee8f07a4fefa7eb0f0c14b-HTML%40fuchsia-review.googlesource.com.
      open
      diffy
      satisfied_requirement

      'GI Roller (Gerrit)' via owners-override

      unread,
      May 13, 2025, 6:15:41 PMMay 13
      to Chris Phoenix, CQ Bot, Christopher Johnson, James Robinson, Owners Override

      Message from GI Roller

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: fuchsia
      Gerrit-Branch: main
      Gerrit-Change-Id: Id0d622a31f7cdcfd0f4ad9f94233900d4d8aec5a
      Gerrit-Change-Number: 1271882
      Gerrit-PatchSet: 3
      Gerrit-Owner: Chris Phoenix <cpho...@google.com>
      Gerrit-Reviewer: Chris Phoenix <cpho...@google.com>
      Gerrit-Reviewer: Christopher Johnson <crj...@google.com>
      Gerrit-Reviewer: James Robinson <jam...@google.com>
      Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
      Gerrit-Comment-Date: Tue, 13 May 2025 22:15:38 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No

      --
      You received this message because you are subscribed to the Google Groups "owners-override" group.
      To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
      To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/599c869fb5d077b2b906126cffbecc5df4286c7c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages