[M] Change in fuchsia/fuchsia[main]: [emulator.go] Rename methods for clarity
0 views
Skip to first unread message
'Oliver Newman (Gerrit)' via owners-override
Jun 15, 2026, 5:17:57 PMJun 15
to Owners Override
Attention needed from Owners Override
Oliver Newman has uploaded the change for review![]( "Open in Gerrit")
Oliver Newman would like Owners Override to review this change.
Commit message
[emulator.go] Rename methods for clarity
Rename "CreateContext" to "NewInstance". I assume "CreateContext" was so
called because it accepted a context.Context argument and there used to
be a "Create" method that didn't accept a context, but the latter no
longer exists, so the "Context" is unnecessary and just served to make
it harder to understand what the method was actually "creating".
Change-Id: Ie706613b53e9e984d1e4bfcbe58bc502ca749f30
Change diff
Change information
Files:
- M src/bringup/bin/console-launcher/qemu-tests/console_qemu_test.go
- M src/connectivity/network/testing/conformance/emulator/emulator.go
- M src/devices/block/drivers/ufs/test/e2e/qemu_ufs_test.go
- M src/recovery/simulator/boot_test/boot_test.go
- M src/recovery/simulator/serial_test/serial_test.go
- M src/tests/disable_shell/shell_default/shell_default_test.go
- M src/tests/disable_shell/shell_disabled/shell_disabled_test.go
- M src/tests/disable_shell/shell_enabled/shell_enabled_test.go
- M src/tests/dlog/dlog_test.go
- M src/tests/drivers_serial_log/drivers_serial_log_test.go
- M src/tests/early-boot-coverage/host-test/coverage_verifier_test.go
- M src/tests/end_to_end/component_tool/component_tool_test.go
- M src/tests/kernel_cprng/kernel_cprng_test.go
- M src/tests/kernel_crashlog/kernel_crashlog_test.go
- M src/tests/kernel_lockup_detector/kernel_lockup_detector_test.go
- M src/tests/kernel_panic/kernel_panic_test.go
- M src/tests/limited_netsvc/limited_netsvc_test.go
- M src/tests/memory_budget/boot_test.go
- M src/tests/oom/oom_test.go
- M src/tests/reboot/reboottest/reboottest.go
- M src/tests/shutdown/shutdown_test.go
- M tools/emulator/emulator.go
- M tools/emulator/emulatortest/emulatortest.go
- M zircon/system/ulib/uart/test/interrupt-test/uart_interrupt_host_test.go
- M zircon/system/ulib/uart/test/polling-input-test/uart_input_host_test.go
Change size: M
Delta: 25 files changed, 56 insertions(+), 85 deletions(-)
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/804140fe9c2795c50c59f0a47e2294e27685bacb-HTML%40fuchsia-review.googlesource.com.
'Oliver Newman (Gerrit)' via owners-override
Jun 15, 2026, 5:17:59 PMJun 15
to Owners Override, Clayton Wilkinson, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com
Attention needed from Owners Override
Oliver Newman voted Fuchsia-Auto-Submit+1![]( "Open in Gerrit")
| Fuchsia-Auto-Submit | +1 |
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/804140fe9c2795c50c59f0a47e2294e27685bacb-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Benjamin Lerman (Gerrit)' via owners-override
Jun 18, 2026, 10:52:37 AMJun 18
to Oliver Newman, Owners Override, Clayton Wilkinson, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com
Attention needed from Oliver Newman and Owners Override
Benjamin Lerman voted Owners-Override+1![]( "Open in Gerrit")
Attention is currently required from:
- Oliver Newman
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7a64d681cbc25ec6d9ba745b33a06c123248568e-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Benjamin Lerman (Gerrit)' via owners-override
Jun 18, 2026, 10:52:46 AMJun 18
to Oliver Newman, Owners Override, Clayton Wilkinson, global-integrat...@fuchsia-infra.iam.gserviceaccount.com, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com
Attention needed from Oliver Newman and Owners Override
Benjamin Lerman voted Code-Review+2![]( "Open in Gerrit")
| Code-Review | +2 |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/239632dbfc021a5bd979259fe8fe52a190dc006a-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'fuchsia-internal-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)' via owners-override
Jun 18, 2026, 11:07:07 AMJun 18
to Oliver Newman, Benjamin Lerman, Owners Override, Clayton Wilkinson, global-integrat...@fuchsia-infra.iam.gserviceaccount.com
fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[emulator.go] Rename methods for clarity
Rename "CreateContext" to "NewInstance". I assume "CreateContext" was so
called because it accepted a context.Context argument and there used to
be a "Create" method that didn't accept a context, but the latter no
longer exists, so the "Context" is unnecessary and just served to make
it harder to understand what the method was actually "creating".
Change-Id: Ie706613b53e9e984d1e4bfcbe58bc502ca749f30
Commit-Queue: Oliver Newman <oliver...@google.com>
Reviewed-by: Clayton Wilkinson <wilkin...@google.com>
Fuchsia-Auto-Submit: Oliver Newman <oliver...@google.com>
Owners-Override: Benjamin Lerman <q...@google.com>
Reviewed-by: Benjamin Lerman <q...@google.com>
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by Clayton Wilkinson, +2 by Benjamin Lerman
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/599c842e556ccc06d67960393bb69ba8ee953ef0-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'global-integration-ci-builder@fuchsia-infra.iam.gserviceaccount.com (Gerrit)' via owners-override
Jun 18, 2026, 11:10:53 AMJun 18
to Oliver Newman, fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com, Benjamin Lerman, Owners Override, Clayton Wilkinson, global-integrat...@fuchsia-infra.iam.gserviceaccount.com
Message from global-integra...@fuchsia-infra.iam.gserviceaccount.com![]( "Open in Gerrit")
Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1331719
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/89e95479dd229cfbefbbf350fc31a110fe80f37d-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages