Groups keyboard shortcuts have been updated
Dismiss
See shortcuts
[L] Change in fuchsia/fuchsia[main]: [fidl][rust] Remove dependency on log crate
4 views
Skip to first unread message
'Megan Batty (Gerrit)' via owners-override
Mar 26, 2025, 1:07:41 PMMar 26
to Owners Override
Attention needed from Ian McKellar and Owners Override
Megan Batty has uploaded the change for review![]( "Open in Gerrit")
Megan Batty would like Owners Override to review this change.
Commit message
[fidl][rust] Remove dependency on log crate
Moves functions in fidl::endpoint that are only used in tests out to
fidl_test_util. This allows for the vfs crate to not depend on the log
crate and so not force inclusion of the log crate by dylib for all
users.
Change-Id: If99018f8e78f99ffa355d45c0b1a4e71979996b7
Change diff
Change information
Files:
- M src/developer/ffx/plugins/audio/device/BUILD.gn
- M src/developer/ffx/plugins/audio/device/src/control.rs
- M src/developer/ffx/plugins/doctor/BUILD.gn
- M src/developer/ffx/plugins/doctor/src/lib.rs
- M src/developer/ffx/plugins/profile/cpu/BUILD.gn
- M src/developer/ffx/plugins/profile/cpu/load/BUILD.gn
- M src/developer/ffx/plugins/profile/cpu/load/src/lib.rs
- M src/developer/remote-control/BUILD.gn
- M src/developer/remote-control/src/lib.rs
- M src/lib/fidl/rust/BUILD.gn
- M src/lib/fidl/rust/external_tests/BUILD.gn
- M src/lib/fidl/rust/external_tests/src/lib.rs
- D src/lib/fidl/rust/external_tests/src/stream_handler_test.rs
- M src/lib/fidl/rust/fidl/BUILD.gn
- M src/lib/fidl/rust/fidl/src/endpoints.rs
- A src/lib/fidl/rust/fidl_test_util/BUILD.gn
- A src/lib/fidl/rust/fidl_test_util/src/lib.rs
- M src/media/audio/lib/rust/BUILD.gn
- M src/media/audio/lib/rust/src/device.rs
- M src/media/audio/lib/rust/src/registry.rs
- M src/session/bin/element_manager/BUILD.gn
- M src/session/bin/element_manager/src/annotation.rs
- M src/session/bin/element_manager/src/element_manager.rs
- M src/session/bin/element_manager/src/main.rs
- M src/session/bin/session_manager/BUILD.gn
- M src/session/bin/session_manager/src/session_manager.rs
- M src/session/bin/session_manager/src/startup.rs
- M src/session/lib/realm_management/BUILD.gn
- M src/session/lib/realm_management/src/lib.rs
- M src/sys/lib/component_debug/BUILD.gn
- M src/sys/lib/component_debug/src/dirs.rs
- M src/sys/lib/elf_runner/BUILD.gn
- M src/sys/lib/elf_runner/src/lib.rs
- M src/testing/sl4f/BUILD.gn
- M src/testing/sl4f/src/modular/facade.rs
- M src/ui/lib/input_pipeline/BUILD.gn
- M src/ui/lib/input_pipeline/src/input_device.rs
- M src/ui/lib/input_pipeline/src/touch_binding.rs
Change size: L
Delta: 38 files changed, 168 insertions(+), 105 deletions(-)
Related details
Attention is currently required from:
- Ian McKellar
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/8e6ab48faac08491ff7224e4bec1afc348930034-HTML%40fuchsia-review.googlesource.com.
'Megan Batty (Gerrit)' via owners-override
Mar 26, 2025, 1:07:42 PMMar 26
to Owners Override, David Koloski, Ian McKellar, Fuchsia Try Builder, GI Try Builder, CQ Bot
Attention needed from Ian McKellar and Owners Override
Megan Batty voted and added 1 comment![]( "Open in Gerrit")
Votes added by Megan Batty
| Fuchsia-Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 16 (Latest):
Megan Batty . resolved
Owners override since this is a simple move that trivially affects a lot of downstream libraries and would require a lot of individual approvals. +2 came from the FID team for the move.
Related details
Attention is currently required from:
- Ian McKellar
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/8e6ab48faac08491ff7224e4bec1afc348930034-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'James Robinson (Gerrit)' via owners-override
Mar 26, 2025, 1:22:06 PMMar 26
to Megan Batty, Owners Override, David Koloski, Ian McKellar, Fuchsia Try Builder, GI Try Builder, CQ Bot
Attention needed from Ian McKellar, Megan Batty and Owners Override
James Robinson voted Owners-Override+1![]( "Open in Gerrit")
Attention is currently required from:
- Ian McKellar
- Megan Batty
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/30ff5b212bff5bdffd2206ea1e0194e319bbd9a1-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
Mar 26, 2025, 1:23:53 PMMar 26
to Megan Batty, Auto-Submit, James Robinson, Owners Override, David Koloski, Ian McKellar, Fuchsia Try Builder, GI Try Builder
CQ Bot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[fidl][rust] Remove dependency on log crate
Moves functions in fidl::endpoint that are only used in tests out to
fidl_test_util. This allows for the vfs crate to not depend on the log
crate and so not force inclusion of the log crate by dylib for all
users.
Change-Id: If99018f8e78f99ffa355d45c0b1a4e71979996b7
Fuchsia-Auto-Submit: Megan Batty <mg...@google.com>
Reviewed-by: David Koloski <dkol...@google.com>
Owners-Override: James Robinson <jam...@google.com>
Commit-Queue: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by David Koloski
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a40a851c68fb8214317a3c2c1b13558668fcc430-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Mar 26, 2025, 1:26:33 PMMar 26
to Megan Batty, CQ Bot, Auto-Submit, James Robinson, Owners Override, David Koloski, Ian McKellar, Fuchsia Try Builder, GI Try Builder
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: http://go/roll-cl/2edae7f8827279af7f4adc8a59c93362e5f46247
Related details
Attention set is empty
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7a5b584e30436f893d6952489382cffa1114c9a6-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages