[XL] Change in fuchsia/fuchsia[main]: Reland "Parent: f3854bbb (Revert "[rust-3p] Migrate from term-mod...

0 views
Skip to first unread message

'Erick Tryzelaar (Gerrit)' via owners-override

unread,
Mar 13, 2026, 4:32:34 PM (2 days ago) Mar 13
to Owners Override
Attention needed from Abdulla Kamar, David Koloski, Emircan Uysaler, Ina Huh, Jerry Belton, Owners Override, Sarah Chan and Thomas Gales

Erick Tryzelaar has uploaded the change for review

Erick Tryzelaar would like Owners Override to review this change.

Commit message

Reland "Parent:     f3854bbb (Revert "[rust-3p] Migrate from term-model to vt100")"

This reverts commit ef1342db25cdec4574c31ca309b6edb378e0e0fb.

Reason for revert: Split out the code that's related to removing third_party/alacritty-migrating into another CL.

Original change's description:
> Revert "Parent:     f3854bbb (Revert "[rust-3p] Migrate from term-model to vt100")"
>
> This reverts commit b64251e713ade191aec710afc11be0f70aa7b508.
>
> Reason for revert: static checks failing
>
> Original change's description:
> > Parent:     f3854bbb (Revert "[rust-3p] Migrate from term-model to vt100")
> > Author:     Erick Tryzelaar <etryz...@google.com>
> > AuthorDate: 2026-03-11 07:13:58 -0700
> > Commit:     Gerrit Code Review <noreply-gerr...@google.com>
> > CommitDate: 2026-03-11 07:13:58 -0700
> >
> > Revert^2 "[rust-3p] Migrate from term-model to vt100"
> >
> > This reverts commit f3854bbbadd039b9145932c1859f3380700fcdd8.
> >
> > Reland "[rust-3p] Migrate from term-model to vt100"
> >
> > This reverts commit f3854bbbadd039b9145932c1859f3380700fcdd8.
> >
> > Reason for revert: Static check issue was unrelated.
> >
> > Original change's description:
> > > Revert "[rust-3p] Migrate from term-model to vt100"
> > >
> > > This reverts commit f14b20ed8435eb6cbd84bbd8fe36a7c4cbb3b5b7.
> > >
> > > Reason for revert: Potential culprit for static checks
> > >
> > > Original change's description:
> > > > [rust-3p] Migrate from term-model to vt100
> > > >
> > > > We have been stuck on a fork of alacritty's `term_model` for a number of
> > > > years because the latest version carries a large number of dependencies
> > > > that we don't need on Fuchsia. This patch instead switches to the
> > > > `vt100` library, which provides for similar functionality, but otherwise
> > > > does not import any other dependencies.
> > > >
> > > > This migration drops the EventProxy listener which previously triggered
> > > > UI redraws when encountering CursorDirty events. With vt100, terminal
> > > > state updates synchronously during parser.process(), so the UI redraw
> > > > event is now just triggered explicitly after processing new PTY data.
> > > >
> > > > OSRB approved vt100 in fxbug.dev/489492670.
> > > >
> > > > Fixed: 357831653
> > > > Bug: 489492670
> > > > Bug: 423022174
> > > > Change-Id: I631f98c34dc92e97f4ac7c4098f8d6788f1363c7
> > > > Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1526220
> > > > Reviewed-by: Emircan Uysaler <emi...@google.com>
> > > > Reviewed-by: Abdulla Kamar <abd...@google.com>
> > > > Commit-Queue: Erick Tryzelaar <etryz...@google.com>
> > > > Reviewed-by: Ina Huh <ih...@google.com>
> > > > Reviewed-by: Jerry Belton <jce...@google.com>
> > > > Fuchsia-Auto-Submit: Erick Tryzelaar <etryz...@google.com>
> > > > Reviewed-by: David Koloski <dkol...@google.com>
> > >
> > > Bug: 489492670
> > > Bug: 423022174
> > > Bug: 357831653
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Change-Id: I5412248c505dd56434a25d64a53db284c6582058
> > > Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1535126
> > > Exempt: RubberStamper 🤖 <android-bu...@system.gserviceaccount.com>
> > > Commit-Queue: Sarah Chan <spq...@google.com>
> >
> > Bug: 489492670
> > Bug: 423022174
> > Bug: 357831653
> > Change-Id: Ie1b51d3e4efa01dc8e2ed90e28cb439853c1a766
> > Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1536141
> > Exempt: RubberStamper 🤖 <android-bu...@system.gserviceaccount.com>
> > Reviewed-by: Sarah Chan <spq...@google.com>
> > Commit-Queue: Erick Tryzelaar <etryz...@google.com>
>
> Bug: 489492670
> Bug: 423022174
> Bug: 357831653
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: I2aa2672a74033ff6fe835a0ecb357b781072e0bf
> Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1536814
> Commit-Queue: Thomas Gales <tga...@google.com>
> Exempt: RubberStamper 🤖 <android-bu...@system.gserviceaccount.com>
Bug: 489492670
Bug: 423022174
Bug: 357831653
Change-Id: I016156f2da9298544aaa0c67a16ec640403da7d2

Change diff


Change information

Files:
  • M src/bringup/bin/virtcon/BUILD.gn
  • M src/bringup/bin/virtcon/src/app.rs
  • M src/bringup/bin/virtcon/src/log.rs
  • M src/bringup/bin/virtcon/src/logo.rs
  • M src/bringup/bin/virtcon/src/session_manager.rs
  • M src/bringup/bin/virtcon/src/terminal.rs
  • M src/bringup/bin/virtcon/src/text_grid.rs
  • M src/bringup/bin/virtcon/src/view.rs
  • M src/lib/ui/terminal/BUILD.gn
  • M src/lib/ui/terminal/src/lib.rs
  • M src/lib/ui/terminal/src/paths.rs
  • M src/lib/ui/terminal/src/renderer.rs
  • A src/lib/ui/terminal/src/terminal_callbacks.rs
  • A src/lib/ui/terminal/src/types.rs
  • M src/ui/bin/terminal/BUILD.gn
  • M src/ui/bin/terminal/src/terminal_view.rs
  • M src/ui/bin/terminal/src/ui/mod.rs
  • M src/ui/bin/terminal/src/ui/terminal_facet.rs
  • M src/virtualization/bin/guest/BUILD.gn
  • M src/virtualization/bin/guest/src/vsh/termina.rs
  • M third_party/rust_crates/BUILD.gn
  • M third_party/rust_crates/Cargo.lock
  • M third_party/rust_crates/Cargo.toml
  • A third_party/rust_crates/forks/vt100-0.16.2/.cargo_vcs_info.json
  • A third_party/rust_crates/forks/vt100-0.16.2/BUILD.bazel
  • A third_party/rust_crates/forks/vt100-0.16.2/CHANGELOG.md
  • A third_party/rust_crates/forks/vt100-0.16.2/Cargo.lock
  • A third_party/rust_crates/forks/vt100-0.16.2/Cargo.toml
  • A third_party/rust_crates/forks/vt100-0.16.2/Cargo.toml.orig
  • A third_party/rust_crates/forks/vt100-0.16.2/LICENSE
  • A third_party/rust_crates/forks/vt100-0.16.2/README.fuchsia
  • A third_party/rust_crates/forks/vt100-0.16.2/README.md
  • A third_party/rust_crates/forks/vt100-0.16.2/src/attrs.rs
  • A third_party/rust_crates/forks/vt100-0.16.2/src/callbacks.rs
  • A third_party/rust_crates/forks/vt100-0.16.2/src/cell.rs
  • A third_party/rust_crates/forks/vt100-0.16.2/src/grid.rs
  • A third_party/rust_crates/forks/vt100-0.16.2/src/lib.rs
  • A third_party/rust_crates/forks/vt100-0.16.2/src/parser.rs
  • A third_party/rust_crates/forks/vt100-0.16.2/src/perform.rs
  • A third_party/rust_crates/forks/vt100-0.16.2/src/row.rs
  • A third_party/rust_crates/forks/vt100-0.16.2/src/screen.rs
  • A third_party/rust_crates/forks/vt100-0.16.2/src/term.rs
  • M third_party/rust_crates/vendor/defs.bzl
Change size: XL
Delta: 43 files changed, 5834 insertions(+), 908 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Abdulla Kamar
  • David Koloski
  • Emircan Uysaler
  • Ina Huh
  • Jerry Belton
  • Owners Override
  • Sarah Chan
  • Thomas Gales
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-Tags
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I016156f2da9298544aaa0c67a16ec640403da7d2
Gerrit-Change-Number: 1538945
Gerrit-PatchSet: 3
Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Abdulla Kamar <abd...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Emircan Uysaler <emi...@google.com>
Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
Gerrit-Reviewer: Ina Huh <ih...@google.com>
Gerrit-Reviewer: Jerry Belton <jce...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Rubber Stamper (Chrome) <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: RubberStamper 🤖 <android-bu...@system.gserviceaccount.com>
Gerrit-Reviewer: Sarah Chan <spq...@google.com>
Gerrit-Reviewer: Thomas Gales <tga...@google.com>
Gerrit-CC: Android Build Huckle Nudge <android-build...@prod.google.com>
Gerrit-CC: Brian Bosak <bbo...@google.com>
Gerrit-Attention: Abdulla Kamar <abd...@google.com>
Gerrit-Attention: David Koloski <dkol...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Ina Huh <ih...@google.com>
Gerrit-Attention: Sarah Chan <spq...@google.com>
Gerrit-Attention: Jerry Belton <jce...@google.com>
Gerrit-Attention: Thomas Gales <tga...@google.com>
Gerrit-Attention: Emircan Uysaler <emi...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/4de66f36b9c803075898b17b0c541bcbac9f6765-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'Erick Tryzelaar (Gerrit)' via owners-override

unread,
Mar 13, 2026, 4:32:37 PM (2 days ago) Mar 13
to Owners Override, RubberStamper 🤖?, CQ Bot, David Koloski, Abdulla Kamar, Rubber Stamper (Chrome), Ina Huh, Sarah Chan, Thomas Gales, Jerry Belton, Emircan Uysaler, GI Roller, Android Build Huckle Nudge, GI Try Builder, Brian Bosak
Attention needed from Abdulla Kamar, David Koloski, Emircan Uysaler, Ina Huh, Jerry Belton, Owners Override, Sarah Chan and Thomas Gales

Erick Tryzelaar added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Erick Tryzelaar . resolved

Adding owners-override@ since after splitting up this CL it passed all the failing tests, and some of the previous reviewers are not available.

Open in Gerrit

Related details

Attention is currently required from:
  • Abdulla Kamar
  • David Koloski
  • Emircan Uysaler
  • Ina Huh
  • Jerry Belton
  • Owners Override
  • Sarah Chan
  • Thomas Gales
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-Tags
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Comment-Date: Fri, 13 Mar 2026 20:32:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/4de66f36b9c803075898b17b0c541bcbac9f6765-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
satisfied_requirement
open
diffy

'James Robinson (Gerrit)' via owners-override

unread,
Mar 13, 2026, 4:36:52 PM (2 days ago) Mar 13
to Erick Tryzelaar, Owners Override, RubberStamper 🤖?, CQ Bot, David Koloski, Abdulla Kamar, Rubber Stamper (Chrome), Ina Huh, Sarah Chan, Thomas Gales, Jerry Belton, Emircan Uysaler, GI Roller, Android Build Huckle Nudge, GI Try Builder, Brian Bosak
Attention needed from Abdulla Kamar, David Koloski, Emircan Uysaler, Erick Tryzelaar, Ina Huh, Jerry Belton, Owners Override, Sarah Chan and Thomas Gales

James Robinson voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Abdulla Kamar
  • David Koloski
  • Emircan Uysaler
  • Erick Tryzelaar
  • Ina Huh
  • Jerry Belton
  • Owners Override
  • Sarah Chan
  • Thomas Gales
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement satisfiedCommit-Message-Has-Tags
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I016156f2da9298544aaa0c67a16ec640403da7d2
    Gerrit-Change-Number: 1538945
    Gerrit-PatchSet: 3
    Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
    Gerrit-Reviewer: Abdulla Kamar <abd...@google.com>
    Gerrit-Reviewer: David Koloski <dkol...@google.com>
    Gerrit-Reviewer: Emircan Uysaler <emi...@google.com>
    Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
    Gerrit-Reviewer: Ina Huh <ih...@google.com>
    Gerrit-Reviewer: James Robinson <jam...@google.com>
    Gerrit-Reviewer: Jerry Belton <jce...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Reviewer: Rubber Stamper (Chrome) <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: RubberStamper 🤖 <android-bu...@system.gserviceaccount.com>
    Gerrit-Reviewer: Sarah Chan <spq...@google.com>
    Gerrit-Reviewer: Thomas Gales <tga...@google.com>
    Gerrit-CC: Android Build Huckle Nudge <android-build...@prod.google.com>
    Gerrit-CC: Brian Bosak <bbo...@google.com>
    Gerrit-Attention: Abdulla Kamar <abd...@google.com>
    Gerrit-Attention: David Koloski <dkol...@google.com>
    Gerrit-Attention: Erick Tryzelaar <etryz...@google.com>
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: Ina Huh <ih...@google.com>
    Gerrit-Attention: Sarah Chan <spq...@google.com>
    Gerrit-Attention: Jerry Belton <jce...@google.com>
    Gerrit-Attention: Thomas Gales <tga...@google.com>
    Gerrit-Attention: Emircan Uysaler <emi...@google.com>
    Gerrit-Comment-Date: Fri, 13 Mar 2026 20:36:45 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f65ef10ab7e6092afa30a1036eba3af66abc26b1-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    'James Robinson (Gerrit)' via owners-override

    unread,
    Mar 13, 2026, 4:37:26 PM (2 days ago) Mar 13
    to Erick Tryzelaar, Owners Override, RubberStamper 🤖?, CQ Bot, David Koloski, Abdulla Kamar, Rubber Stamper (Chrome), Ina Huh, Sarah Chan, Thomas Gales, Jerry Belton, Emircan Uysaler, GI Roller, Android Build Huckle Nudge, GI Try Builder, Brian Bosak
    Attention needed from Abdulla Kamar, David Koloski, Emircan Uysaler, Erick Tryzelaar, Ina Huh, Jerry Belton, Owners Override, Sarah Chan and Thomas Gales

    James Robinson added 2 comments

    Patchset-level comments
    Erick Tryzelaar . resolved

    Adding owners-override@ since after splitting up this CL it passed all the failing tests, and some of the previous reviewers are not available.

    James Robinson

    You still need a CR+2 from a regular reviewer.

    James Robinson . resolved

    a

    Gerrit-Comment-Date: Fri, 13 Mar 2026 20:37:16 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Erick Tryzelaar <etryz...@google.com>

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9d74b6eac0f643f83a93608386f2c118bf8978eb-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    'Erick Tryzelaar (Gerrit)' via owners-override

    unread,
    Mar 13, 2026, 4:40:00 PM (2 days ago) Mar 13
    to James Robinson, Owners Override, RubberStamper 🤖?, CQ Bot, David Koloski, Abdulla Kamar, Rubber Stamper (Chrome), Ina Huh, Sarah Chan, Thomas Gales, Jerry Belton, Emircan Uysaler, GI Roller, Android Build Huckle Nudge, GI Try Builder, Brian Bosak
    Attention needed from Abdulla Kamar, David Koloski, Emircan Uysaler, Ina Huh, Jerry Belton, Owners Override, Sarah Chan and Thomas Gales

    Erick Tryzelaar voted Fuchsia-Auto-Submit+1

    Fuchsia-Auto-Submit+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Abdulla Kamar
    • David Koloski
    • Emircan Uysaler
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: Ina Huh <ih...@google.com>
    Gerrit-Attention: Sarah Chan <spq...@google.com>
    Gerrit-Attention: Jerry Belton <jce...@google.com>
    Gerrit-Attention: Thomas Gales <tga...@google.com>
    Gerrit-Attention: Emircan Uysaler <emi...@google.com>
    Gerrit-Comment-Date: Fri, 13 Mar 2026 20:39:53 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/fb616d3944997a0903bb8195e5681875b65cf25f-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    'Sarah Chan (Gerrit)' via owners-override

    unread,
    Mar 13, 2026, 6:44:50 PM (2 days ago) Mar 13
    to Erick Tryzelaar, James Robinson, Owners Override, RubberStamper 🤖?, CQ Bot, David Koloski, Abdulla Kamar, Rubber Stamper (Chrome), Ina Huh, Thomas Gales, Jerry Belton, Emircan Uysaler, GI Roller, Android Build Huckle Nudge, GI Try Builder, Brian Bosak
    Attention needed from Abdulla Kamar, David Koloski, Emircan Uysaler, Erick Tryzelaar, Ina Huh, Jerry Belton, Owners Override and Thomas Gales

    Sarah Chan voted Code-Review+2

    Code-Review+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Abdulla Kamar
    • David Koloski
    • Emircan Uysaler
    • Erick Tryzelaar
    • Ina Huh
    • Jerry Belton
    • Owners Override
    • Thomas Gales
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedCommit-Message-Has-Tags
    • requirement satisfiedReview-Enforcement
    Gerrit-Attention: Erick Tryzelaar <etryz...@google.com>
    Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Attention: Ina Huh <ih...@google.com>
    Gerrit-Attention: Jerry Belton <jce...@google.com>
    Gerrit-Attention: Thomas Gales <tga...@google.com>
    Gerrit-Attention: Emircan Uysaler <emi...@google.com>
    Gerrit-Comment-Date: Fri, 13 Mar 2026 22:44:37 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9dd4fcf3605ebed6b659e2246e57a5f9f413a817-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    open
    diffy

    'CQ Bot (Gerrit)' via owners-override

    unread,
    Mar 13, 2026, 6:47:22 PM (2 days ago) Mar 13
    to Erick Tryzelaar, Sarah Chan, James Robinson, Owners Override, RubberStamper 🤖?, David Koloski, Abdulla Kamar, Rubber Stamper (Chrome), Ina Huh, Thomas Gales, Jerry Belton, Emircan Uysaler, GI Roller, Android Build Huckle Nudge, GI Try Builder, Brian Bosak

    CQ Bot submitted the change

    Change information

    Reviewed-by: Sarah Chan <spq...@google.com>
    Fuchsia-Auto-Submit: Erick Tryzelaar <etryz...@google.com>
    Commit-Queue: Erick Tryzelaar <etryz...@google.com>
    Owners-Override: James Robinson <jam...@google.com>
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +2 by Sarah Chan
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I016156f2da9298544aaa0c67a16ec640403da7d2
    Gerrit-Change-Number: 1538945
    Gerrit-PatchSet: 4
    Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
    Gerrit-Reviewer: Abdulla Kamar <abd...@google.com>
    Gerrit-Reviewer: David Koloski <dkol...@google.com>
    Gerrit-Reviewer: Emircan Uysaler <emi...@google.com>
    Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
    Gerrit-Reviewer: Ina Huh <ih...@google.com>
    Gerrit-Reviewer: James Robinson <jam...@google.com>
    Gerrit-Reviewer: Jerry Belton <jce...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Reviewer: Rubber Stamper (Chrome) <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: RubberStamper 🤖 <android-bu...@system.gserviceaccount.com>
    Gerrit-Reviewer: Sarah Chan <spq...@google.com>
    Gerrit-Reviewer: Thomas Gales <tga...@google.com>
    Gerrit-CC: Android Build Huckle Nudge <android-build...@prod.google.com>
    Gerrit-CC: Brian Bosak <bbo...@google.com>

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/cd835d9605fee011f394f01ca477bfa28ce47ba9-HTML%40fuchsia-review.googlesource.com.
    open
    diffy
    satisfied_requirement

    'GI Roller (Gerrit)' via owners-override

    unread,
    Mar 13, 2026, 6:49:24 PM (2 days ago) Mar 13
    to Erick Tryzelaar, CQ Bot, Sarah Chan, James Robinson, Owners Override, RubberStamper 🤖?, David Koloski, Abdulla Kamar, Rubber Stamper (Chrome), Ina Huh, Thomas Gales, Jerry Belton, Emircan Uysaler, Android Build Huckle Nudge, GI Try Builder, Brian Bosak

    Message from GI Roller

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedCommit-Message-Has-Tags
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: fuchsia
    Gerrit-Branch: main
    Gerrit-Change-Id: I016156f2da9298544aaa0c67a16ec640403da7d2
    Gerrit-Change-Number: 1538945
    Gerrit-PatchSet: 4
    Gerrit-Owner: Erick Tryzelaar <etryz...@google.com>
    Gerrit-Reviewer: Abdulla Kamar <abd...@google.com>
    Gerrit-Reviewer: David Koloski <dkol...@google.com>
    Gerrit-Reviewer: Emircan Uysaler <emi...@google.com>
    Gerrit-Reviewer: Erick Tryzelaar <etryz...@google.com>
    Gerrit-Reviewer: Ina Huh <ih...@google.com>
    Gerrit-Reviewer: James Robinson <jam...@google.com>
    Gerrit-Reviewer: Jerry Belton <jce...@google.com>
    Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
    Gerrit-Reviewer: Rubber Stamper (Chrome) <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: RubberStamper 🤖 <android-bu...@system.gserviceaccount.com>
    Gerrit-Reviewer: Sarah Chan <spq...@google.com>
    Gerrit-Reviewer: Thomas Gales <tga...@google.com>
    Gerrit-CC: Android Build Huckle Nudge <android-build...@prod.google.com>
    Gerrit-CC: Brian Bosak <bbo...@google.com>
    Gerrit-Comment-Date: Fri, 13 Mar 2026 22:49:21 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/ca6bfbdc38ea3c4b945974251d4fbd6a5eb8d4b5-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    open
    diffy

    'Abdulla Kamar (Gerrit)' via owners-override

    unread,
    Mar 14, 2026, 12:25:45 AM (yesterday) Mar 14
    to CQ Bot, Erick Tryzelaar, Sarah Chan, James Robinson, Owners Override, RubberStamper 🤖?, David Koloski, Rubber Stamper (Chrome), Ina Huh, Thomas Gales, Jerry Belton, Emircan Uysaler, GI Roller, Android Build Huckle Nudge, GI Try Builder, Brian Bosak

    Abdulla Kamar added 1 comment

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    Abdulla Kamar . resolved

    Looks like this is still breaking the static-checks.

    Gerrit-Comment-Date: Sat, 14 Mar 2026 04:25:22 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No

    --
    You received this message because you are subscribed to the Google Groups "owners-override" group.
    To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
    To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a912d8c42641f55a4c52ec45afef523c47c74b6c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages