David Dorwin would like Owners Override to review this change.
[version_history] Freeze API level 29
Generated at Git hash 23ab9fe6b719a1919b0b875f4736c1bc272fd597.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Commit-Queue | +1 |
OO: Please approve the files after `sdk/history/29/`.
// TODO(https://fxbug.dev/324081103): Delete (don't just set removed=29) this method once allDavid DorwinI don't think we want to be modifying the comments in this file...
Done
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: sdk/fidl/fuchsia.io/node.fidl
Insertions: 2, Deletions: 2.
@@ -381,7 +381,7 @@
});
/// DEPRECATED - Use `Node.GetAttributes` instead.
- // TODO(https://fxbug.dev/324081103): Delete (don't just set removed=29) this method once all
+ // TODO(https://fxbug.dev/324081103): Delete (don't just set removed=NEXT) this method once all
// we have no remaining out-of-tree callers, or when we drop support for API level 28.
@available(added=28, deprecated=HEAD, note="Use fuchsia.io/Node.GetAttributes instead.")
@selector("fuchsia.io1/Node.GetAttr")
@@ -407,7 +407,7 @@
/// DEPRECATED - Use `Node.UpdateAttributes` instead.
- // TODO(https://fxbug.dev/324081103): Delete (don't just set removed=29) this method once all
+ // TODO(https://fxbug.dev/324081103): Delete (don't just set removed=NEXT) this method once all
// we have no remaining out-of-tree callers, or when we drop support for API level 28.
@available(added=28, deprecated=HEAD, note="Use fuchsia.io/Node.UpdateAttributes instead.")
@selector("fuchsia.io1/Node.SetAttr")
```
[version_history] Freeze API level 29
Generated at Git hash 23ab9fe6b719a1919b0b875f4736c1bc272fd597.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1066993
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |