Groups keyboard shortcuts have been updated
Dismiss
See shortcuts

[M] Change in fuchsia/fuchsia[main]: [fidl][rust] Provide epitaph in closure error

4 views
Skip to first unread message

'David Koloski (Gerrit)' via owners-override

unread,
Mar 14, 2025, 3:46:05 PMMar 14
to Owners Override
Attention needed from Owners Override

David Koloski has uploaded the change for review

David Koloski would like Owners Override to review this change.

Commit message

[fidl][rust] Provide epitaph in closure error

When a FIDL channel is closed, the resulting error may now explicitly
contain a closure epitaph if any. This allows users who care about the
epitaph and need to discriminate PEER_CLOSED from an epitaph of
PEER_CLOSED to do so.
Bug: 42153053
Change-Id: Ib16adde0ebaede46d333381bed649eabd1bc3d66

Change diff


Change information

Files:
  • M src/connectivity/lowpan/lib/lowpan_driver_common/src/spinel/mock/mock_device_client.rs
  • M src/connectivity/network/dhcpv4/client/bindings/src/provider.rs
  • M src/connectivity/network/netlink/src/routes.rs
  • M src/connectivity/network/testing/netemul/service/src/main.rs
  • M src/connectivity/network/tests/fidl/debug/src/lib.rs
  • M src/connectivity/network/tests/fidl/routes-admin/src/lib.rs
  • M src/connectivity/network/tests/fidl/routes-admin/src/rules.rs
  • M src/connectivity/network/tests/integration/dhcp-client/src/lib.rs
  • M src/connectivity/policy/netcfg/src/dhcpv4.rs
  • M src/connectivity/policy/netcfg/src/filter.rs
  • M src/connectivity/wlan/wlancfg/tool/policy/src/lib.rs
  • M src/developer/ffx/plugins/trace/src/lib.rs
  • M src/devices/bin/driver-index/src/main.rs
  • M src/devices/tests/driver-development/test.rs
  • M src/graphics/display/bin/display-tweak/src/utils.rs
  • M src/lib/fidl/rust/fidl/src/client.rs
  • M src/lib/fidl/rust/fidl/src/error.rs
  • M src/lib/fuchsia-component/src/client.rs
  • M src/lib/network/fidl_fuchsia_net_dhcp_ext/src/lib.rs
  • M src/lib/network/fidl_fuchsia_net_interfaces_ext/src/admin.rs
  • M src/performance/memory/attribution/monitor/src/attribution_client.rs
  • M src/settings/service/src/job/manager.rs
  • M src/settings/service/src/tests/factory_reset_tests.rs
  • M src/sys/component_manager/src/framework/binder.rs
  • M src/sys/component_manager/src/model/testing/routing_test_helpers.rs
  • M src/sys/pkg/tests/pkgdir/src/directory.rs
Change size: M
Delta: 26 files changed, 120 insertions(+), 53 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ib16adde0ebaede46d333381bed649eabd1bc3d66
Gerrit-Change-Number: 1225705
Gerrit-PatchSet: 4
Gerrit-Owner: David Koloski <dkol...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Brandon Castellano <bcas...@google.com>
Gerrit-CC: Fuchsia Try Builder <fuchsia-t...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-CC: Nikita Jindal <nikita...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9b245792a7bcac3dffa5182ba66bf92efd1541fb-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'David Koloski (Gerrit)' via owners-override

unread,
Mar 14, 2025, 3:46:12 PMMar 14
to Owners Override, Ian McKellar, Fuchsia Try Builder, GI Try Builder, CQ Bot, Nikita Jindal, Brandon Castellano
Attention needed from Owners Override

David Koloski voted Fuchsia-Auto-Submit+1

Fuchsia-Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ib16adde0ebaede46d333381bed649eabd1bc3d66
Gerrit-Change-Number: 1225705
Gerrit-PatchSet: 4
Gerrit-Owner: David Koloski <dkol...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Brandon Castellano <bcas...@google.com>
Gerrit-CC: Fuchsia Try Builder <fuchsia-t...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-CC: Nikita Jindal <nikita...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Comment-Date: Fri, 14 Mar 2025 19:46:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9b245792a7bcac3dffa5182ba66bf92efd1541fb-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Adam Barth (Gerrit)' via owners-override

unread,
Mar 14, 2025, 8:29:16 PMMar 14
to David Koloski, Owners Override, Ian McKellar, Fuchsia Try Builder, GI Try Builder, CQ Bot, Nikita Jindal, Brandon Castellano
Attention needed from David Koloski and Owners Override

Adam Barth voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Koloski
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ib16adde0ebaede46d333381bed649eabd1bc3d66
Gerrit-Change-Number: 1225705
Gerrit-PatchSet: 4
Gerrit-Owner: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Brandon Castellano <bcas...@google.com>
Gerrit-CC: Fuchsia Try Builder <fuchsia-t...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-CC: Nikita Jindal <nikita...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: David Koloski <dkol...@google.com>
Gerrit-Comment-Date: Sat, 15 Mar 2025 00:29:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c983b09077b1b4307e037763af4be796cfa54917-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Mar 14, 2025, 8:30:05 PMMar 14
to David Koloski, Auto-Submit, Adam Barth, Owners Override, Ian McKellar, Fuchsia Try Builder, GI Try Builder, Nikita Jindal, Brandon Castellano

CQ Bot submitted the change

Change information

Commit message:
[fidl][rust] Provide epitaph in closure error

When a FIDL channel is closed, the resulting error may now explicitly
contain a closure epitaph if any. This allows users who care about the
epitaph and need to discriminate PEER_CLOSED from an epitaph of
PEER_CLOSED to do so.
Bug: 42153053
Change-Id: Ib16adde0ebaede46d333381bed649eabd1bc3d66
Reviewed-by: Ian McKellar <ian...@google.com>
Fuchsia-Auto-Submit: David Koloski <dkol...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Ian McKellar
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ib16adde0ebaede46d333381bed649eabd1bc3d66
Gerrit-Change-Number: 1225705
Gerrit-PatchSet: 5
Gerrit-Owner: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Brandon Castellano <bcas...@google.com>
Gerrit-CC: Fuchsia Try Builder <fuchsia-t...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-CC: Nikita Jindal <nikita...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a01a1ce5a0935a1677a2c098f80fa88ae5181373-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Mar 14, 2025, 8:32:52 PMMar 14
to David Koloski, CQ Bot, Auto-Submit, Adam Barth, Owners Override, Ian McKellar, Fuchsia Try Builder, GI Try Builder, Nikita Jindal, Brandon Castellano

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ib16adde0ebaede46d333381bed649eabd1bc3d66
Gerrit-Change-Number: 1225705
Gerrit-PatchSet: 5
Gerrit-Owner: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Adam Barth <aba...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: David Koloski <dkol...@google.com>
Gerrit-Reviewer: Ian McKellar <ian...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Brandon Castellano <bcas...@google.com>
Gerrit-CC: Fuchsia Try Builder <fuchsia-t...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-CC: Nikita Jindal <nikita...@google.com>
Gerrit-Comment-Date: Sat, 15 Mar 2025 00:32:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9775aa84d5b4e8d41e5b3481fe2700b875f0630b-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages