[L] Change in fuchsia/fuchsia[main]: Revert "[lacewing] Run async on the same event loop everywhere"

0 views
Skip to first unread message

'Yilong Li (Gerrit)' via owners-override

unread,
Feb 27, 2026, 1:16:36 PM (2 days ago) Feb 27
to Andrew Davies, Hunter Freyer, CQ Bot, Owners Override, CL Deps Checker, Charles Celerier, GI Roller, GI Try Builder, Yilong Li
Attention needed from Andrew Davies, Charles Celerier, Hunter Freyer and Owners Override

Yilong Li has uploaded the change for review

Yilong Li would like Andrew Davies, Hunter Freyer, CQ Bot, Owners Override, CL Deps Checker and Charles Celerier to review this change.

Commit message

Revert "[lacewing] Run async on the same event loop everywhere"

This reverts commit 3d11c5210b1601f7f82a0a1903cecdfb62eb4a74.

Reason for revert: Broke CI
First known failure: go/bbid/8688701886522434225

Original change's description:
> [lacewing] Run async on the same event loop everywhere
>
> Instead of creating a new loop every time a test needs to run a
> coroutine, this change runs all the coroutines on the same global event
> loop. This is a preparatory change for spreading the use of async to all
> the tests.
>
> Depends-on: turquoise-internal:I526098579b1e6444874fb880e0c098efa6ba2288
> Change-Id: If23a4f15ce3c2931ce226f4a25ea9a152cc9c5f9
> Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1514764
> Dependencies-Satisfied: CL Deps Checker <cl-deps...@fuchsia-internal-service-accts.iam.gserviceaccount.com>
> Commit-Queue: Charles Celerier <ch...@google.com>
> Owners-Override: Hunter Freyer <hjfr...@google.com>
> Reviewed-by: Andrew Davies <awda...@google.com>
> Fuchsia-Auto-Submit: Charles Celerier <ch...@google.com>
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I5ae0582412058ae16d1f2c9347605cca7ae0bc1e

Change diff


Change information

Files:
  • M docs/development/tools/fuchsia-controller/async-python.md
  • M scripts/lib/async_utils/__init__.py
  • M scripts/lib/async_utils/tests/async_utils_test.py
  • M scripts/lib/ffx_cmd/BUILD.gn
  • M scripts/lib/ffx_cmd/e2e_tests/test_ffx_inspect.py
  • M scripts/lib/ffx_cmd/lib.py
  • M scripts/lib/ffx_cmd/tests/__init__.py
  • M scripts/lib/ffx_cmd/tests/test_ffx_cmd.py
  • M scripts/lib/fx_cmd/lib.py
  • M scripts/lib/fx_cmd/tests/test_fx_cmd.py
  • M src/connectivity/network/tests/benchmarks/iperf/BUILD.gn
  • M src/connectivity/network/tests/benchmarks/iperf/netstack_iperf_test.py
  • M src/connectivity/wlan/tests/wlancfg/BUILD.gn
  • M src/connectivity/wlan/tests/wlancfg/RegulatoryRecoveryTest.py
  • M src/connectivity/wlan/tests/wlanix/ApfTest.py
  • M src/connectivity/wlan/tests/wlanix/BUILD.gn
  • M src/connectivity/wlan/tests/wlanix/IfaceCorrectnessAndConsistencyTest.py
  • M src/connectivity/wlan/tests/wlanix/IfaceLifecycleTest.py
  • M src/connectivity/wlan/tests/wlanix/WifiChipCorrectnessAndConsistencyTest.py
  • M src/connectivity/wlan/tests/wlanix/WifiChipExistenceTest.py
  • M src/connectivity/wlan/tests/wlanix/wlanix_testing/BUILD.gn
  • M src/connectivity/wlan/tests/wlanix/wlanix_testing/base_test.py
  • M src/developer/ffx/lib/fuchsia-controller/BUILD.gn
  • M src/developer/ffx/lib/fuchsia-controller/python/fidl/_client.py
  • M src/developer/ffx/lib/fuchsia-controller/python/fidl/_ipc.py
  • A src/developer/ffx/lib/fuchsia-controller/python/fidl/tests/BUILD.gn
  • A src/developer/ffx/lib/fuchsia-controller/python/fidl/tests/queue_wrapper_test.py
  • M src/developer/ffx/lib/fuchsia-controller/python/fuchsia_controller_py/wrappers.py
  • M src/storage/blackout/host/tests/BUILD.gn
  • M src/storage/blackout/host/tests/blackout.py
  • M src/testing/end_to_end/honeydew/honeydew/affordances/connectivity/bluetooth/bluetooth_common/bluetooth_common_using_fc.py
  • M src/testing/end_to_end/honeydew/honeydew/affordances/connectivity/bluetooth/bluetooth_common/tests/unit_tests/bluetooth_common_using_fc_test.py
  • M src/testing/end_to_end/honeydew/honeydew/affordances/rtc/rtc_using_fc.py
  • M src/testing/end_to_end/honeydew/honeydew/affordances/rtc/tests/unit_tests/rtc_using_fc_test.py
  • M src/testing/end_to_end/honeydew/honeydew/affordances/ui/user_input/user_input_using_fc.py
  • M src/testing/end_to_end/honeydew/honeydew/affordances/virtual_audio/audio_using_fuchsia_controller.py
  • M src/testing/end_to_end/honeydew/honeydew/affordances/virtual_audio/tests/functional_tests/BUILD.gn
  • M src/testing/end_to_end/honeydew/honeydew/affordances/virtual_audio/tests/functional_tests/test_audio_inject_record.py
  • M src/testing/end_to_end/honeydew/honeydew/fuchsia_device/fuchsia_device_impl.py
  • M src/testing/end_to_end/mobly_base_tests/fuchsia_async_extension/BUILD.gn
  • M tools/devshell/python/system-status/main.py
  • M tools/devshell/python/system-status/tests/test_system_status.py
  • M tools/fidl/fidlgen_python/tests/test_client.py
Change size: L
Delta: 43 files changed, 544 insertions(+), 356 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Davies
  • Charles Celerier
  • Hunter Freyer
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-Tags
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I5ae0582412058ae16d1f2c9347605cca7ae0bc1e
Gerrit-Change-Number: 1521140
Gerrit-PatchSet: 1
Gerrit-Owner: Yilong Li <li...@google.com>
Gerrit-Reviewer: Andrew Davies <awda...@google.com>
Gerrit-Reviewer: Charles Celerier <ch...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Andrew Davies <awda...@google.com>
Gerrit-Attention: Hunter Freyer <hjfr...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Charles Celerier <ch...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f1d30b67d08a187a9e83b8b89602aac7c4f8317b-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
unsatisfied_requirement
open
diffy

'Hunter Freyer (Gerrit)' via owners-override

unread,
Feb 27, 2026, 1:17:07 PM (2 days ago) Feb 27
to Yilong Li, RubberStamper 🤖?, Rubber Stamper (Chrome), Andrew Davies, CQ Bot, Owners Override, CL Deps Checker, Charles Celerier, GI Roller, GI Try Builder
Attention needed from Andrew Davies, Charles Celerier, Owners Override and Yilong Li

Hunter Freyer voted and added 1 comment

Votes added by Hunter Freyer

Code-Review+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Hunter Freyer . resolved

womp womp

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Davies
  • Charles Celerier
  • Owners Override
  • Yilong Li
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-Tags
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I5ae0582412058ae16d1f2c9347605cca7ae0bc1e
Gerrit-Change-Number: 1521140
Gerrit-PatchSet: 1
Gerrit-Owner: Yilong Li <li...@google.com>
Gerrit-Reviewer: Andrew Davies <awda...@google.com>
Gerrit-Reviewer: Charles Celerier <ch...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Rubber Stamper (Chrome) <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: RubberStamper 🤖 <android-bu...@system.gserviceaccount.com>
Gerrit-Attention: Andrew Davies <awda...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Yilong Li <li...@google.com>
Gerrit-Attention: Charles Celerier <ch...@google.com>
Gerrit-Comment-Date: Fri, 27 Feb 2026 18:17:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f6e50d299170460dbb3a6975c048e24793a308fb-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Yilong Li (Gerrit)' via owners-override

unread,
Feb 27, 2026, 1:18:01 PM (2 days ago) Feb 27
to Yilong Li, Hunter Freyer, RubberStamper 🤖?, Rubber Stamper (Chrome), Andrew Davies, CQ Bot, Owners Override, CL Deps Checker, Charles Celerier, GI Roller, GI Try Builder
Attention needed from Andrew Davies, Charles Celerier and Owners Override

Yilong Li voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Davies
  • Charles Celerier
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-Tags
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I5ae0582412058ae16d1f2c9347605cca7ae0bc1e
Gerrit-Change-Number: 1521140
Gerrit-PatchSet: 1
Gerrit-Owner: Yilong Li <li...@google.com>
Gerrit-Reviewer: Andrew Davies <awda...@google.com>
Gerrit-Reviewer: Charles Celerier <ch...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Rubber Stamper (Chrome) <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: RubberStamper 🤖 <android-bu...@system.gserviceaccount.com>
Gerrit-Reviewer: Yilong Li <li...@google.com>
Gerrit-Attention: Andrew Davies <awda...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Charles Celerier <ch...@google.com>
Gerrit-Comment-Date: Fri, 27 Feb 2026 18:17:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5bd51a19152c734d28185f731ea500fb3f8d5f27-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Feb 27, 2026, 1:18:12 PM (2 days ago) Feb 27
to Yilong Li, Hunter Freyer, RubberStamper 🤖?, Rubber Stamper (Chrome), Andrew Davies, Owners Override, CL Deps Checker, Charles Celerier, GI Roller, GI Try Builder

CQ Bot submitted the change

Change information

Commit message:
Revert "[lacewing] Run async on the same event loop everywhere"

This reverts commit 3d11c5210b1601f7f82a0a1903cecdfb62eb4a74.

Reason for revert: Broke CI
First known failure: go/bbid/8688701886522434225

Original change's description:
> [lacewing] Run async on the same event loop everywhere
>
> Instead of creating a new loop every time a test needs to run a
> coroutine, this change runs all the coroutines on the same global event
> loop. This is a preparatory change for spreading the use of async to all
> the tests.
>
> Depends-on: turquoise-internal:I526098579b1e6444874fb880e0c098efa6ba2288
> Change-Id: If23a4f15ce3c2931ce226f4a25ea9a152cc9c5f9
> Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1514764
> Dependencies-Satisfied: CL Deps Checker <cl-deps...@fuchsia-internal-service-accts.iam.gserviceaccount.com>
> Commit-Queue: Charles Celerier <ch...@google.com>
> Owners-Override: Hunter Freyer <hjfr...@google.com>
> Reviewed-by: Andrew Davies <awda...@google.com>
> Fuchsia-Auto-Submit: Charles Celerier <ch...@google.com>
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I5ae0582412058ae16d1f2c9347605cca7ae0bc1e
Exempt: RubberStamper 🤖 <android-bu...@system.gserviceaccount.com>
Reviewed-by: Hunter Freyer <hjfr...@google.com>
Commit-Queue: Yilong Li <li...@google.com>
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Hunter Freyer, Exempt+1 by RubberStamper 🤖
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I5ae0582412058ae16d1f2c9347605cca7ae0bc1e
Gerrit-Change-Number: 1521140
Gerrit-PatchSet: 2
Gerrit-Owner: Yilong Li <li...@google.com>
Gerrit-Reviewer: Andrew Davies <awda...@google.com>
Gerrit-Reviewer: Charles Celerier <ch...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Rubber Stamper (Chrome) <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: RubberStamper 🤖 <android-bu...@system.gserviceaccount.com>
Gerrit-Reviewer: Yilong Li <li...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e2b9b03e22323dcbd3491de3aa7d05861871eee5-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Feb 27, 2026, 1:33:37 PM (2 days ago) Feb 27
to Yilong Li, CQ Bot, Hunter Freyer, RubberStamper 🤖?, Rubber Stamper (Chrome), Andrew Davies, Owners Override, CL Deps Checker, Charles Celerier, GI Try Builder

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-Tags
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I5ae0582412058ae16d1f2c9347605cca7ae0bc1e
Gerrit-Change-Number: 1521140
Gerrit-PatchSet: 2
Gerrit-Owner: Yilong Li <li...@google.com>
Gerrit-Reviewer: Andrew Davies <awda...@google.com>
Gerrit-Reviewer: Charles Celerier <ch...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Rubber Stamper (Chrome) <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: RubberStamper 🤖 <android-bu...@system.gserviceaccount.com>
Gerrit-Reviewer: Yilong Li <li...@google.com>
Gerrit-Comment-Date: Fri, 27 Feb 2026 18:33:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/1f36563f3a2860575e664edb1397e7468bb9c42c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Charles Celerier (Gerrit)' via owners-override

unread,
Feb 27, 2026, 2:03:14 PM (2 days ago) Feb 27
to CQ Bot, Yilong Li, Hunter Freyer, RubberStamper 🤖?, Rubber Stamper (Chrome), Andrew Davies, Owners Override, CL Deps Checker, GI Roller, GI Try Builder

Charles Celerier has created a revert of this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedCommit-Message-Has-Tags
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: revert
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: I5ae0582412058ae16d1f2c9347605cca7ae0bc1e
Gerrit-Change-Number: 1521140
Gerrit-PatchSet: 2
Gerrit-Owner: Yilong Li <li...@google.com>
Gerrit-Reviewer: Andrew Davies <awda...@google.com>
Gerrit-Reviewer: Charles Celerier <ch...@google.com>
Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Rubber Stamper (Chrome) <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: RubberStamper 🤖 <android-bu...@system.gserviceaccount.com>
Gerrit-Reviewer: Yilong Li <li...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/887e466f92e7cac081f884963a31bbec381835d9-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages