[L] Change in fuchsia/fuchsia[main]: [vfs][rust] Complete Open Rename

['Brandon Castellano (Gerrit)' via owners-override]

Attention needed from Chris Drouillard and Owners Override

Brandon Castellano has uploaded the change for review

Brandon Castellano would like Owners Override and Chris Drouillard to review this change.

Commit message

[vfs][rust] Complete Open Rename

Rename all instances of `open3` in public methods to `open`, and mark
all deprecated io1 Open methods as `deprecated_open`. Add a default
implementation for `deprecated_open` and remove it from test
implementations where it is not required.

There still remain a few callers of the `deprecated_open` methods which
will be addressed in more targeted follow up changes.

Test: No functional change, rename only.

Bug: 324111518

Change-Id: Id0a574af5059bc81a5bab1daec73b060f8130ae1

Change diff

Change information

Files:

• M sdk/lib/device-watcher/rust/src/lib.rs
• M sdk/lib/driver_test_realm/tests/test.rs
• M sdk/lib/zxio/tests/zxio-test.rs
• M src/connectivity/network/netstack-proxy/src/main.rs
• M src/connectivity/network/testing/netemul/service/src/main.rs
• M src/connectivity/wlan/wlandevicemonitor/src/device_watch.rs
• M src/developer/ffx/tools/playground/src/cf_fs.rs
• M src/developer/ffx/tools/playground/src/host_fs.rs
• M src/fonts/testing/mock_font_resolver/src/main.rs
• M src/lib/fuchsia-component-test/realm_builder_server/src/builtin.rs
• M src/lib/fuchsia-component/server/src/lib.rs
• M src/lib/fuchsia-fs/src/directory/watcher.rs
• M src/lib/process_builder/src/process_builder.rs
• M src/recovery/system/src/ota.rs
• M src/recovery/system/src/ota_main.rs
• M src/starnix/kernel/vfs/file_server.rs
• M src/storage/benchmarks/fuchsia/src/filesystems/pkgdir.rs
• M src/storage/block_adapter/src/lib.rs
• M src/storage/conformance/conformance_harness/rustvfs/src/main.rs
• M src/storage/ext4/server/src/main.rs
• M src/storage/factory/export_ffs/src/lib.rs
• M src/storage/fs_realm/src/main.rs
• M src/storage/fshost/integration/src/disk_builder.rs
• M src/storage/fshost/integration/src/mocks.rs
• M src/storage/fshost/src/main.rs
• M src/storage/fshost/src/watcher.rs
• M src/storage/fuchsia-fatfs/mounter/src/device.rs
• M src/storage/fuchsia-fatfs/src/component.rs
• M src/storage/fuchsia-fatfs/src/directory.rs
• M src/storage/fuchsia-fatfs/src/filesystem.rs
• M src/storage/fuchsia-fatfs/src/lib.rs
• M src/storage/fvm/src/main.rs
• M src/storage/fxfs/platform/src/fuchsia/component.rs
• M src/storage/fxfs/platform/src/fuchsia/debug.rs
• M src/storage/fxfs/platform/src/fuchsia/directory.rs
• M src/storage/fxfs/platform/src/fuchsia/fxblob/directory.rs
• M src/storage/fxfs/platform/src/fuchsia/paged_object_handle.rs
• M src/storage/fxfs/platform/src/fuchsia/testing.rs
• M src/storage/fxfs/platform/src/fuchsia/volume.rs
• M src/storage/fxfs/platform/src/fuchsia/volumes_directory.rs
• M src/storage/fxfs/test-fxfs/src/main.rs
• M src/storage/gpt/component/src/gpt.rs
• M src/storage/gpt/component/src/service.rs
• M src/storage/lib/vfs/rust/src/directory/connection.rs
• M src/storage/lib/vfs/rust/src/directory/entry.rs
• M src/storage/lib/vfs/rust/src/directory/entry_container.rs
• M src/storage/lib/vfs/rust/src/directory/immutable/simple/tests.rs
• M src/storage/lib/vfs/rust/src/directory/mutable/connection.rs
• M src/storage/lib/vfs/rust/src/directory/simple.rs
• M src/storage/lib/vfs/rust/src/lib.rs
• M src/storage/lib/vfs/rust/src/remote.rs
• M src/storage/lib/vfs/rust/src/remote/tests.rs
• M src/storage/lib/vfs/rust/src/test_utils/run.rs
• M src/storage/lib/vfs/rust/src/token_registry.rs
• M src/storage/open3_migration.gni
• M src/sys/component_manager/lib/sandbox/src/fidl/dict.rs
• M src/sys/component_manager/lib/sandbox/src/fidl/dir_entry.rs
• M src/sys/component_manager/lib/serve_processargs/src/lib.rs
• M src/sys/component_manager/lib/serve_processargs/src/namespace.rs
• M src/sys/component_manager/src/builtin/fuchsia_boot_resolver.rs
• M src/sys/component_manager/src/framework/realm_query.rs
• M src/sys/component_manager/src/model/routing/service.rs
• M src/sys/component_manager/src/model/storage/admin_protocol.rs
• M src/sys/component_manager/src/model/testing/out_dir.rs
• M src/sys/component_manager/src/model/tests/directory.rs
• M src/sys/component_manager/tests/resolvers/boot/src/integration_test.rs
• M src/sys/full-resolver/src/main.rs
• M src/sys/lib/elf_runner/src/runtime_dir.rs
• M src/sys/pkg/bin/pkg-cache/src/base_resolver/package.rs
• M src/sys/pkg/bin/pkg-cache/src/cache_service.rs
• M src/sys/pkg/bin/pkg-cache/src/compat/pkgfs/validation.rs
• M src/sys/pkg/bin/pkg-cache/src/main.rs
• M src/sys/pkg/bin/pkg-cache/src/root_dir.rs
• M src/sys/pkg/lib/package-directory/src/lib.rs
• M src/sys/pkg/lib/package-directory/src/meta_as_dir.rs
• M src/sys/pkg/lib/package-directory/src/meta_subdir.rs
• M src/sys/pkg/lib/package-directory/src/non_meta_subdir.rs
• M src/sys/pkg/lib/package-directory/src/root_dir.rs
• M src/sys/pkg/lib/package-directory/src/root_dir_cache.rs
• M src/sys/pkg/tests/isolated-ota/src/lib.rs
• M src/sys/pkg/tests/pkg-cache-as-base-resolver/as-a-component-resolver/fake_dependencies.rs
• M src/sys/pkg/tests/pkg-cache-as-base-resolver/using-realm-builder/src/lib.rs
• M src/sys/pkg/tests/pkg-cache/src/lib.rs
• M src/sys/pkg/tests/pkg-resolver/src/lib.rs
• M src/sys/pkg/tests/pkgctl/src/lib.rs
• M src/sys/test_runners/src/elf/elf_component.rs

Change size: L

Delta: 86 files changed, 331 insertions(+), 316 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

• Chris Drouillard
• Owners Override

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Id0a574af5059bc81a5bab1daec73b060f8130ae1

Gerrit-Change-Number: 1248404

Gerrit-PatchSet: 2

Gerrit-Owner: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: Chris Drouillard <cdr...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Attention: Chris Drouillard <cdr...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/3e1748e03cb3bfd3d4ab3ad66f3f7099540d9665-HTML%40fuchsia-review.googlesource.com.

['Brandon Castellano (Gerrit)' via owners-override]

Attention needed from Chris Drouillard and Owners Override

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

• Chris Drouillard
• Owners Override

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Id0a574af5059bc81a5bab1daec73b060f8130ae1

Gerrit-Change-Number: 1248404

Gerrit-PatchSet: 2

Gerrit-Owner: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: Chris Drouillard <cdr...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Attention: Chris Drouillard <cdr...@google.com>

Gerrit-Comment-Date: Wed, 09 Apr 2025 17:52:33 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/3e1748e03cb3bfd3d4ab3ad66f3f7099540d9665-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['Chris Drouillard (Gerrit)' via owners-override]

Attention needed from Brandon Castellano and Owners Override

Chris Drouillard voted Code-Review+2

Code-Review

+2

Open in Gerrit

Related details

Attention is currently required from:

• Brandon Castellano
• Owners Override

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Id0a574af5059bc81a5bab1daec73b060f8130ae1

Gerrit-Change-Number: 1248404

Gerrit-PatchSet: 2

Gerrit-Owner: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: Chris Drouillard <cdr...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Brandon Castellano <bcas...@google.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Comment-Date: Wed, 09 Apr 2025 18:41:32 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7d2b9d2569e883e1d4711d05d5a166c4810c6d0c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['James Robinson (Gerrit)' via owners-override]

Attention needed from Brandon Castellano and Owners Override

James Robinson voted Owners-Override+1

Owners-Override

+1

Open in Gerrit

Related details

Attention is currently required from:

• Brandon Castellano
• Owners Override

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Id0a574af5059bc81a5bab1daec73b060f8130ae1

Gerrit-Change-Number: 1248404

Gerrit-PatchSet: 3

Gerrit-Owner: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: Chris Drouillard <cdr...@google.com>

Gerrit-Reviewer: James Robinson <jam...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Brandon Castellano <bcas...@google.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Comment-Date: Wed, 09 Apr 2025 20:50:38 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/678256db4c660e90a0516e12eae51fe9e6ed3ee5-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['Brandon Castellano (Gerrit)' via owners-override]

Attention needed from Owners Override

Brandon Castellano voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

• Owners Override

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Id0a574af5059bc81a5bab1daec73b060f8130ae1

Gerrit-Change-Number: 1248404

Gerrit-PatchSet: 3

Gerrit-Owner: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: Chris Drouillard <cdr...@google.com>

Gerrit-Reviewer: James Robinson <jam...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Comment-Date: Wed, 09 Apr 2025 21:52:07 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a79f63bbc1f82448cbfc9b7ec35a2e2c357f41e0-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['CQ Bot (Gerrit)' via owners-override]

CQ Bot submitted the change with unreviewed changes

Unreviewed changes

2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/sys/pkg/tests/pkg-cache-as-base-resolver/using-realm-builder/src/lib.rs
Insertions: 22, Deletions: 29.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:

[vfs][rust] Complete Open Rename

Rename all instances of `open3` in public methods to `open`, and mark
all deprecated io1 Open methods as `deprecated_open`. Add a default
implementation for `deprecated_open` and remove it from test
implementations where it is not required.

There still remain a few callers of the `deprecated_open` methods which
will be addressed in more targeted follow up changes.

Test: No functional change, rename only.

Bug: 324111518

Change-Id: Id0a574af5059bc81a5bab1daec73b060f8130ae1

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1248404

Owners-Override: James Robinson <jam...@google.com>

Commit-Queue: Brandon Castellano <bcas...@google.com>

Reviewed-by: Chris Drouillard <cdr...@google.com>

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +2 by Chris Drouillard

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Id0a574af5059bc81a5bab1daec73b060f8130ae1

Gerrit-Change-Number: 1248404

Gerrit-PatchSet: 4

Gerrit-Owner: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Chris Drouillard <cdr...@google.com>

Gerrit-Reviewer: James Robinson <jam...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f1c1ab1460352ff09f0c7aee5deb872824e589c5-HTML%40fuchsia-review.googlesource.com.

['GI Roller (Gerrit)' via owners-override]

Message from GI Roller

Change has been successfully rolled: http://go/roll-cl/f760a08f9d33782ea93b5897d6b49ecb2fd31ed9

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Id0a574af5059bc81a5bab1daec73b060f8130ae1

Gerrit-Change-Number: 1248404

Gerrit-PatchSet: 4

Gerrit-Owner: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Chris Drouillard <cdr...@google.com>

Gerrit-Reviewer: James Robinson <jam...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: GI Roller <global-integra...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Comment-Date: Wed, 09 Apr 2025 22:26:52 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a53502e1f4db3343a19d9c8bcfc79009b4839ef6-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['Brian Bosak (Gerrit)' via owners-override]

Brian Bosak has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: revert

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: Id0a574af5059bc81a5bab1daec73b060f8130ae1

Gerrit-Change-Number: 1248404

Gerrit-PatchSet: 4

Gerrit-Owner: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Chris Drouillard <cdr...@google.com>

Gerrit-Reviewer: James Robinson <jam...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: GI Roller <global-integra...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/f3b644c9d0ca7d91fa74dfc9e1cb5caf646dc96f-HTML%40fuchsia-review.googlesource.com.