Groups keyboard shortcuts have been updated
Dismiss
See shortcuts
[M] Change in fuchsia/fuchsia[main]: [rust] Explicitly allow large error variants
0 views
Skip to first unread message
'Erick Tryzelaar (Gerrit)' via owners-override
Mar 6, 2025, 3:57:21 PMMar 6
to Owners Override
Attention needed from Owners Override
Erick Tryzelaar has uploaded the change for review![]( "Open in Gerrit")
Erick Tryzelaar would like Owners Override to review this change.
Commit message
[rust] Explicitly allow large error variants
The error result variant is typically rarely handles, but if it has a
significant size it can impact performance by causing excessive amounts
of bytes to be copied from one stack frame to another. An upcoming
rust-clippy lint check is more accurate about detecting this, so this
explicitly marks these errors as allowed, along with a TODO to clean
this up in the future.
Bug: 401253790
Change-Id: Iad7ba288c0d7597bf0b8f7cbd0c6b2f8653c561f
Change diff
Change information
Files:
- M src/connectivity/wlan/lib/sme/src/ap/authenticator.rs
- M src/connectivity/wlan/lib/sme/src/client/rsn.rs
- M src/connectivity/wlan/lib/sme/src/client/state/link_state.rs
- M src/connectivity/wlan/lib/sme/src/client/state/mod.rs
- M src/connectivity/wlan/lib/sme/src/client/test_utils.rs
- M src/developer/ffx/playground/src/interpreter.rs
- M src/developer/ffx/playground/src/value.rs
- M src/developer/ffx/playground/src/value/in_use_handle.rs
- M src/lib/fuchsia-component-test/src/lib.rs
- M src/sys/component_manager/src/model/actions/destroy.rs
- M src/sys/component_manager/src/model/component/instance.rs
- M src/sys/component_manager/src/model/component/mod.rs
- M src/sys/component_manager/src/model/context.rs
- M src/sys/component_manager/src/model/routing/open.rs
- M src/sys/component_manager/src/model/routing/service.rs
- M src/sys/lib/fidl-fuchsia-pkg-ext/src/repo.rs
- M src/sys/pkg/bin/pkg-resolver/src/repository_manager.rs
Change size: M
Delta: 17 files changed, 58 insertions(+), 0 deletions(-)
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/3435a947a4600ce53e57327b45f6b6e0fae7c78e-HTML%40fuchsia-review.googlesource.com.
'Erick Tryzelaar (Gerrit)' via owners-override
Mar 6, 2025, 3:57:25 PMMar 6
to Owners Override, GI Try Builder, Casey Dahlin, CQ Bot, Marie Janssen
Attention needed from Owners Override
Erick Tryzelaar added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Erick Tryzelaar . resolved
Adding owners override, since this is a cross-project change to opt out of a lint to unblock a rust compiler update.
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/3435a947a4600ce53e57327b45f6b6e0fae7c78e-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'Adam Barth (Gerrit)' via owners-override
Mar 6, 2025, 5:56:06 PMMar 6
to Erick Tryzelaar, Owners Override, GI Try Builder, Casey Dahlin, CQ Bot, Marie Janssen
Attention needed from Erick Tryzelaar and Owners Override
Adam Barth voted Owners-Override+1![]( "Open in Gerrit")
Attention is currently required from:
- Erick Tryzelaar
- Owners Override
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b11cc0e179e36b699ff480dd42a9b52d0a85bbaa-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
Mar 6, 2025, 6:04:35 PMMar 6
to Erick Tryzelaar, Auto-Submit, Adam Barth, Owners Override, GI Try Builder, Casey Dahlin, Marie Janssen
CQ Bot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[rust] Explicitly allow large error variants
The error result variant is typically rarely handles, but if it has a
significant size it can impact performance by causing excessive amounts
of bytes to be copied from one stack frame to another. An upcoming
rust-clippy lint check is more accurate about detecting this, so this
explicitly marks these errors as allowed, along with a TODO to clean
this up in the future.
Bug: 401253790
Change-Id: Iad7ba288c0d7597bf0b8f7cbd0c6b2f8653c561f
Commit-Queue: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Fuchsia-Auto-Submit: Erick Tryzelaar <etryz...@google.com>
Reviewed-by: Casey Dahlin <sad...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Files:
- M src/connectivity/wlan/lib/sme/src/ap/authenticator.rs
- M src/connectivity/wlan/lib/sme/src/client/rsn.rs
- M src/connectivity/wlan/lib/sme/src/client/state/link_state.rs
- M src/connectivity/wlan/lib/sme/src/client/state/mod.rs
- M src/connectivity/wlan/lib/sme/src/client/test_utils.rs
- M src/developer/ffx/playground/src/interpreter.rs
- M src/developer/ffx/playground/src/value.rs
- M src/developer/ffx/playground/src/value/in_use_handle.rs
- M src/lib/fuchsia-component-test/src/lib.rs
- M src/sys/component_manager/src/model/actions/destroy.rs
- M src/sys/component_manager/src/model/component/instance.rs
- M src/sys/component_manager/src/model/component/mod.rs
- M src/sys/component_manager/src/model/context.rs
- M src/sys/component_manager/src/model/routing/open.rs
- M src/sys/component_manager/src/model/routing/service.rs
- M src/sys/lib/fidl-fuchsia-pkg-ext/src/repo.rs
- M src/sys/pkg/bin/pkg-resolver/src/repository_manager.rs
Change size: M
Delta: 17 files changed, 58 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by Casey Dahlin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0d12dab74e160647566a0d9abfd57001fab646eb-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Mar 6, 2025, 6:07:48 PMMar 6
to Erick Tryzelaar, CQ Bot, Auto-Submit, Adam Barth, Owners Override, GI Try Builder, Casey Dahlin, Marie Janssen
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: http://go/roll-cl/9b466f5385ac12353710ebfe5b7913a23abf8da7
Related details
Attention set is empty
Submit Requirements:
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0718a5951b77370ac3a07568bb1e0f70be255049-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages