[L] Change in fuchsia/fuchsia[main]: Reland "[vfs][rust] Complete Open Rename"

['Brandon Castellano (Gerrit)' via owners-override]

Brandon Castellano has uploaded the change for review

Brandon Castellano would like Owners Override, Brian Bosak, Chris Drouillard, CQ Bot, James Robinson, Rubber Stamper (Chrome) and RubberStamper 🤖 to review this change.

Commit message

Reland "[vfs][rust] Complete Open Rename"

This reverts commit 7d95ac6e3d924cf51887f63a411baaf27ec56dc1.

Reason for reland: Not related to CQ flakes, was reverted for conflict.

Original change's description:
> Revert "[vfs][rust] Complete Open Rename"
>
> This reverts commit 3d006001dfd50f512da6a82787995a8c7f975066.
>
> Reason for revert: b/409611771
>
> Original change's description:
> > [vfs][rust] Complete Open Rename
> >
> > Rename all instances of `open3` in public methods to `open`, and mark
> > all deprecated io1 Open methods as `deprecated_open`. Add a default
> > implementation for `deprecated_open` and remove it from test
> > implementations where it is not required.
> >
> > There still remain a few callers of the `deprecated_open` methods which
> > will be addressed in more targeted follow up changes.
> >
> > Test: No functional change, rename only.
> > Bug: 324111518
> > Change-Id: Id0a574af5059bc81a5bab1daec73b060f8130ae1
> > Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1248404
> > Owners-Override: James Robinson <jam...@google.com>
> > Commit-Queue: Brandon Castellano <bcas...@google.com>
> > Reviewed-by: Chris Drouillard <cdr...@google.com>
>
> Bug: 324111518
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: I81e00e43fd032465d634e5dd8d83058b035e4edf
> Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1249884
> Reviewed-by: RubberStamper 🤖 <android-bu...@system.gserviceaccount.com>

Bug: 324111518

Change-Id: I737f4d92069f32546924c7fef11ca4dcaee9b261

Change diff

Change information

Files:

• M sdk/lib/device-watcher/rust/src/lib.rs
• M sdk/lib/driver_test_realm/tests/test.rs
• M sdk/lib/zxio/tests/zxio-test.rs
• M src/connectivity/network/netstack-proxy/src/main.rs
• M src/connectivity/network/testing/netemul/service/src/main.rs
• M src/connectivity/wlan/wlandevicemonitor/src/device_watch.rs
• M src/developer/ffx/tools/playground/src/cf_fs.rs
• M src/developer/ffx/tools/playground/src/host_fs.rs
• M src/fonts/testing/mock_font_resolver/src/main.rs
• M src/lib/fuchsia-component-test/realm_builder_server/src/builtin.rs
• M src/lib/fuchsia-component/server/src/lib.rs
• M src/lib/fuchsia-fs/src/directory/watcher.rs
• M src/lib/process_builder/src/process_builder.rs
• M src/recovery/system/src/ota.rs
• M src/recovery/system/src/ota_main.rs
• M src/starnix/kernel/vfs/file_server.rs
• M src/storage/benchmarks/fuchsia/src/filesystems/pkgdir.rs
• M src/storage/block_adapter/src/lib.rs
• M src/storage/conformance/conformance_harness/rustvfs/src/main.rs
• M src/storage/ext4/server/src/main.rs
• M src/storage/factory/export_ffs/src/lib.rs
• M src/storage/fs_realm/src/main.rs
• M src/storage/fshost/integration/src/disk_builder.rs
• M src/storage/fshost/integration/src/mocks.rs
• M src/storage/fshost/src/main.rs
• M src/storage/fshost/src/watcher.rs
• M src/storage/fuchsia-fatfs/mounter/src/device.rs
• M src/storage/fuchsia-fatfs/src/component.rs
• M src/storage/fuchsia-fatfs/src/directory.rs
• M src/storage/fuchsia-fatfs/src/filesystem.rs
• M src/storage/fuchsia-fatfs/src/lib.rs
• M src/storage/fvm/src/main.rs
• M src/storage/fxfs/platform/src/fuchsia/component.rs
• M src/storage/fxfs/platform/src/fuchsia/debug.rs
• M src/storage/fxfs/platform/src/fuchsia/directory.rs
• M src/storage/fxfs/platform/src/fuchsia/fxblob/directory.rs
• M src/storage/fxfs/platform/src/fuchsia/paged_object_handle.rs
• M src/storage/fxfs/platform/src/fuchsia/testing.rs
• M src/storage/fxfs/platform/src/fuchsia/volume.rs
• M src/storage/fxfs/platform/src/fuchsia/volumes_directory.rs
• M src/storage/fxfs/test-fxfs/src/main.rs
• M src/storage/gpt/component/src/gpt.rs
• M src/storage/gpt/component/src/service.rs
• M src/storage/lib/vfs/rust/src/directory/connection.rs
• M src/storage/lib/vfs/rust/src/directory/entry.rs
• M src/storage/lib/vfs/rust/src/directory/entry_container.rs
• M src/storage/lib/vfs/rust/src/directory/immutable/simple/tests.rs
• M src/storage/lib/vfs/rust/src/directory/mutable/connection.rs
• M src/storage/lib/vfs/rust/src/directory/simple.rs
• M src/storage/lib/vfs/rust/src/lib.rs
• M src/storage/lib/vfs/rust/src/remote.rs
• M src/storage/lib/vfs/rust/src/remote/tests.rs
• M src/storage/lib/vfs/rust/src/test_utils/run.rs
• M src/storage/lib/vfs/rust/src/token_registry.rs
• M src/storage/open3_migration.gni
• M src/sys/component_manager/lib/sandbox/src/fidl/dict.rs
• M src/sys/component_manager/lib/sandbox/src/fidl/dir_entry.rs
• M src/sys/component_manager/lib/serve_processargs/src/lib.rs
• M src/sys/component_manager/lib/serve_processargs/src/namespace.rs
• M src/sys/component_manager/src/builtin/fuchsia_boot_resolver.rs
• M src/sys/component_manager/src/framework/realm_query.rs
• M src/sys/component_manager/src/model/routing/service.rs
• M src/sys/component_manager/src/model/storage/admin_protocol.rs
• M src/sys/component_manager/src/model/testing/out_dir.rs
• M src/sys/component_manager/src/model/tests/directory.rs
• M src/sys/component_manager/tests/resolvers/boot/src/integration_test.rs
• M src/sys/full-resolver/src/main.rs
• M src/sys/lib/elf_runner/src/runtime_dir.rs
• M src/sys/pkg/bin/pkg-cache/src/base_resolver/package.rs
• M src/sys/pkg/bin/pkg-cache/src/cache_service.rs
• M src/sys/pkg/bin/pkg-cache/src/compat/pkgfs/validation.rs
• M src/sys/pkg/bin/pkg-cache/src/main.rs
• M src/sys/pkg/bin/pkg-cache/src/root_dir.rs
• M src/sys/pkg/lib/package-directory/src/lib.rs
• M src/sys/pkg/lib/package-directory/src/meta_as_dir.rs
• M src/sys/pkg/lib/package-directory/src/meta_subdir.rs
• M src/sys/pkg/lib/package-directory/src/non_meta_subdir.rs
• M src/sys/pkg/lib/package-directory/src/root_dir.rs
• M src/sys/pkg/lib/package-directory/src/root_dir_cache.rs
• M src/sys/pkg/tests/isolated-ota/src/lib.rs
• M src/sys/pkg/tests/pkg-cache-as-base-resolver/as-a-component-resolver/fake_dependencies.rs
• M src/sys/pkg/tests/pkg-cache-as-base-resolver/using-realm-builder/src/lib.rs
• M src/sys/pkg/tests/pkg-cache/src/lib.rs
• M src/sys/pkg/tests/pkg-resolver/src/lib.rs
• M src/sys/pkg/tests/pkgctl/src/lib.rs
• M src/sys/test_runners/src/elf/elf_component.rs

Change size: L

Delta: 86 files changed, 331 insertions(+), 316 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Review
• Commit-Message-Has-Tags
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I737f4d92069f32546924c7fef11ca4dcaee9b261

Gerrit-Change-Number: 1249725

Gerrit-PatchSet: 1

Gerrit-Owner: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: Brian Bosak <bbo...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Chris Drouillard <cdr...@google.com>

Gerrit-Reviewer: James Robinson <jam...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-Reviewer: Rubber Stamper (Chrome) <rubber-...@appspot.gserviceaccount.com>

Gerrit-Reviewer: RubberStamper 🤖 <android-bu...@system.gserviceaccount.com>

Gerrit-CC: GI Roller <global-integra...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/6644ca85d1fd6290ae7af0f3c2e0bd7eb47ddc3b-HTML%40fuchsia-review.googlesource.com.

['Brandon Castellano (Gerrit)' via owners-override]

Attention needed from Chris Drouillard

Brandon Castellano has uploaded the change for review

Brandon Castellano removed Owners Override, Brian Bosak, James Robinson, Rubber Stamper (Chrome) and RubberStamper 🤖 from reviewers of this change.

Change information

Files:

• M sdk/lib/driver_test_realm/tests/test.rs
• M sdk/lib/zxio/tests/zxio-test.rs
• M src/connectivity/network/testing/netemul/service/src/main.rs

Change size: L

Delta: 83 files changed, 327 insertions(+), 312 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

• Chris Drouillard

Submit Requirements:

• Code-Review
• Commit-Message-Has-Tags
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I737f4d92069f32546924c7fef11ca4dcaee9b261

Gerrit-Change-Number: 1249725

Gerrit-PatchSet: 2

Gerrit-Owner: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Chris Drouillard <cdr...@google.com>

Gerrit-CC: GI Roller <global-integra...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Chris Drouillard <cdr...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/1debebe28119d6ba798e28cc4bf54e3f026e03ba-HTML%40fuchsia-review.googlesource.com.

['Brandon Castellano (Gerrit)' via owners-override]

Attention needed from Chris Drouillard and Owners Override

Brandon Castellano has uploaded the change for review

Brandon Castellano would like Owners Override to review this change.

Related details

• Chris Drouillard
• Owners Override

Submit Requirements:

• Code-Review
• Commit-Message-Has-Tags
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I737f4d92069f32546924c7fef11ca4dcaee9b261

Gerrit-Change-Number: 1249725

Gerrit-PatchSet: 2

Gerrit-Owner: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Chris Drouillard <cdr...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: GI Roller <global-integra...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Attention: Chris Drouillard <cdr...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c1eccbb709973f27caf5f008122f3352f568b788-HTML%40fuchsia-review.googlesource.com.

['Hunter Freyer (Gerrit)' via owners-override]

Attention needed from Brandon Castellano, Chris Drouillard and Owners Override

Hunter Freyer voted

Commit-Queue	+2
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

• Brandon Castellano
• Chris Drouillard
• Owners Override

Submit Requirements:

• Code-Review
• Commit-Message-Has-Tags
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I737f4d92069f32546924c7fef11ca4dcaee9b261

Gerrit-Change-Number: 1249725

Gerrit-PatchSet: 2

Gerrit-Owner: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Chris Drouillard <cdr...@google.com>

Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: GI Roller <global-integra...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Brandon Castellano <bcas...@google.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Attention: Chris Drouillard <cdr...@google.com>

Gerrit-Comment-Date: Fri, 11 Apr 2025 13:45:26 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b4db7f5163415d038bf349ae76aab20b677ca88c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['Chris Drouillard (Gerrit)' via owners-override]

Attention needed from Brandon Castellano, Hunter Freyer and Owners Override

Chris Drouillard voted Code-Review+2

Code-Review

+2

Open in Gerrit

Related details

Attention is currently required from:

• Brandon Castellano
• Hunter Freyer
• Owners Override

Submit Requirements:

• Code-Review
• Commit-Message-Has-Tags
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I737f4d92069f32546924c7fef11ca4dcaee9b261

Gerrit-Change-Number: 1249725

Gerrit-PatchSet: 2

Gerrit-Owner: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Chris Drouillard <cdr...@google.com>

Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: GI Roller <global-integra...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Brandon Castellano <bcas...@google.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Attention: Hunter Freyer <hjfr...@google.com>

Gerrit-Comment-Date: Fri, 11 Apr 2025 13:57:09 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/4a8ac25381ccd8d79f2e737ebf275ffe72bea5f6-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['Brandon Castellano (Gerrit)' via owners-override]

Attention needed from Hunter Freyer and Owners Override

Brandon Castellano voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention is currently required from:

• Hunter Freyer
• Owners Override

Submit Requirements:

• Code-Review
• Commit-Message-Has-Tags
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I737f4d92069f32546924c7fef11ca4dcaee9b261

Gerrit-Change-Number: 1249725

Gerrit-PatchSet: 2

Gerrit-Owner: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Chris Drouillard <cdr...@google.com>

Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: GI Roller <global-integra...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>

Gerrit-Attention: Hunter Freyer <hjfr...@google.com>

Gerrit-Comment-Date: Mon, 14 Apr 2025 17:17:25 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/bec2f9f141202b0841f63706afbdef8a31625fe5-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

['CQ Bot (Gerrit)' via owners-override]

CQ Bot submitted the change

Change information

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1249725

Owners-Override: Hunter Freyer <hjfr...@google.com>

Reviewed-by: Chris Drouillard <cdr...@google.com>

Commit-Queue: Brandon Castellano <bcas...@google.com>

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +2 by Chris Drouillard

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I737f4d92069f32546924c7fef11ca4dcaee9b261

Gerrit-Change-Number: 1249725

Gerrit-PatchSet: 3

Gerrit-Owner: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Chris Drouillard <cdr...@google.com>

Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: GI Roller <global-integra...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

--

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e5598e3ae7497b9809329df49b4a7467dd65369b-HTML%40fuchsia-review.googlesource.com.

['GI Roller (Gerrit)' via owners-override]

Message from GI Roller

Change has been successfully rolled: http://go/roll-cl/c522e840a09f821933bc8059e134459ea0052ad8

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Review

• Commit-Message-Has-Tags
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: fuchsia

Gerrit-Branch: main

Gerrit-Change-Id: I737f4d92069f32546924c7fef11ca4dcaee9b261

Gerrit-Change-Number: 1249725

Gerrit-PatchSet: 3

Gerrit-Owner: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: Brandon Castellano <bcas...@google.com>

Gerrit-Reviewer: CQ Bot <fuchsia-int...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Chris Drouillard <cdr...@google.com>

Gerrit-Reviewer: Hunter Freyer <hjfr...@google.com>

Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>

Gerrit-CC: GI Roller <global-integra...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-CC: GI Try Builder <global-integrat...@fuchsia-infra.iam.gserviceaccount.com>

Gerrit-Comment-Date: Mon, 14 Apr 2025 17:30:18 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c2661ff67461bab2dd2ba32eab92c34d4e2004bd-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.