[XL] Change in fuchsia/fuchsia[main]: [fidl][cpp] Improve performance by reducing interdependence

1 view

Skip to first unread message

'Ian McKellar (Gerrit)' via owners-override

unread,

Mar 7, 2025, 10:42:19 PMMar 7

to Owners Override

Attention needed from Claire Gonyeo, David Dorwin and Owners Override

Ian McKellar has uploaded the change for review

Ian McKellar would like Owners Override to review this change.

Commit message

[fidl][cpp] Improve performance by reducing interdependence

Decouple the wire and natural bindings a little more so that they can be
selectively included. This can deliver a 25-30% build time reduction for
C++ targets.

Change-Id: I79643b6be02ac883fb3d4d97c46101587f30aa16

Change diff

Change information

Files:

M sdk/lib/fidl/cpp/fidl_cpp_v2.api
M sdk/lib/fidl/cpp/include/lib/fidl/cpp/internal/thenable.h
M sdk/lib/fidl/cpp/include/lib/fidl/cpp/unified_messaging.h
M sdk/lib/fidl/cpp/tests/integration/unknown_interactions_tests.cc
M sdk/lib/fidl/cpp/wire/fidl_cpp_wire.api
M sdk/lib/fidl/cpp/wire/include/lib/fidl/cpp/wire/client_base.h
M sdk/lib/fidl/cpp/wire/include/lib/fidl/cpp/wire/connect_service.h
M sdk/lib/fidl/cpp/wire/include/lib/fidl/cpp/wire/traits.h
M sdk/lib/fidl/cpp/wire/include/lib/fidl/cpp/wire/wire_messaging_declarations.h
M sdk/lib/fidl_driver/tests/transport/natural_unknown_interactions_driver_test.cc
M sdk/lib/fidl_driver/tests/transport/wire_unknown_interactions_driver_test.cc
M sdk/lib/sys/cpp/tests/service_directory_unittest.cc
M src/lib/fidl/llcpp/tests/integration/header_coding_test.cc
M src/lib/fidl/llcpp/tests/integration/sync_event_handler_test.cc
M src/lib/fidl/llcpp/tests/integration/unknown_interactions_tests.cc
M tools/fidl/fidlgen_cpp/codegen/file_markers.tmpl
M tools/fidl/fidlgen_cpp/codegen/file_natural_messaging_header.tmpl
M tools/fidl/fidlgen_cpp/codegen/file_natural_messaging_source.tmpl
M tools/fidl/fidlgen_cpp/codegen/fragment_method_types.tmpl
M tools/fidl/fidlgen_cpp/codegen/fragment_protocol.tmpl
M tools/fidl/fidlgen_cpp/codegen/fragment_protocol_details.tmpl
M tools/fidl/fidlgen_cpp/goldens/aliases_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/aliases_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/anonymous_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/anonymous_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/anonymous_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/anonymous_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/arrays_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/arrays_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/bindings_denylist_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/bindings_denylist_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/bindings_denylist_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/bindings_denylist_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/bits_constants_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/bits_constants_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/bits_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/bits_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/byte_and_bytes_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/byte_and_bytes_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/consts_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/consts_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/doc_comments_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/doc_comments_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/doc_comments_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/doc_comments_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/driver_handle_driver_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/driver_handle_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/driver_handle_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/driver_handle_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/driver_one_way_driver_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/driver_one_way_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/driver_one_way_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/driver_one_way_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/driver_service_driver_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/driver_service_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/driver_service_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/driver_two_way_driver_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/driver_two_way_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/driver_two_way_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/driver_two_way_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/empty_struct_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/empty_struct_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/empty_struct_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/empty_struct_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/encapsulated_structs_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/encapsulated_structs_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/enum_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/enum_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/error_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/error_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/error_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/error_syntax_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/error_syntax_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/error_syntax_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/error_syntax_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/error_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/escaping_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/escaping_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/foreign_type_in_response_used_through_compose_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/foreign_type_in_response_used_through_compose_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/foreign_type_in_response_used_through_compose_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/foreign_type_in_response_used_through_compose_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/handles_driver_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/handles_in_types_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/handles_in_types_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/handles_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/handles_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/handles_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/imported_const_values_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/imported_const_values_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/inheritance_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/inheritance_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/inheritance_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/inheritance_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/inheritance_with_recursive_decl_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/inheritance_with_recursive_decl_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/inheritance_with_recursive_decl_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/inheritance_with_recursive_decl_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/nullable_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/nullable_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/nullable_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/nullable_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/padding_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/padding_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/placement_of_attributes_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/placement_of_attributes_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/placement_of_attributes_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/placement_of_attributes_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/protocol_layouts_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/protocol_layouts_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/protocol_layouts_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/protocol_layouts_same_library_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/protocol_layouts_same_library_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/protocol_layouts_same_library_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/protocol_layouts_same_library_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/protocol_layouts_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/protocol_payloads_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/protocol_payloads_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/protocol_payloads_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/protocol_payloads_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/protocol_request_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/protocol_request_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/protocol_request_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/protocol_request_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/protocols_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/protocols_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/protocols_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/protocols_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/request_flexible_envelope_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/request_flexible_envelope_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/request_flexible_envelope_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/request_flexible_envelope_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/serializable_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/serializable_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/service_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/service_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/service_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/service_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/struct_default_value_enum_library_reference_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/struct_default_value_enum_library_reference_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/struct_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/struct_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/table_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/table_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/time_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/time_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/transitive_dependencies_compose_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/transitive_dependencies_compose_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/transitive_dependencies_compose_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/transitive_dependencies_compose_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/transitive_dependencies_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/transitive_dependencies_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/types_in_protocols_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/types_in_protocols_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/types_in_protocols_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/types_in_protocols_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/union_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/union_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/union_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/union_sandwich_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/union_sandwich_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/union_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/unknown_interactions_driver_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/unknown_interactions_driver_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/unknown_interactions_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/unknown_interactions_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/unknown_interactions_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/unknown_interactions_wire_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/vectors_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/vectors_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/versions_markers.h.golden
M tools/fidl/fidlgen_cpp/goldens/versions_natural_messaging.cc.golden
M tools/fidl/fidlgen_cpp/goldens/versions_natural_messaging.h.golden
M tools/fidl/fidlgen_cpp/goldens/versions_wire_messaging.h.golden
M tools/fidl/lib/fidlgen_cpp/protocol.go
M zircon/system/ulib/c/test/debugdata.cc

Change size: XL

Delta: 176 files changed, 1479 insertions(+), 2230 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Claire Gonyeo
David Dorwin
Owners Override

Submit Requirements:

API-Review
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0c9b2dd72a9d64984fa71f8971100c65dfe09d2e-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'Ian McKellar (Gerrit)' via owners-override

unread,

Mar 7, 2025, 10:42:25 PMMar 7

to Owners Override, John Grossman, Aaron Wood, Claire Gonyeo, GI Try Builder, David Dorwin, CQ Bot, Fuchsia Try Builder

Attention needed from Claire Gonyeo, David Dorwin and Owners Override

Ian McKellar voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

Claire Gonyeo
David Dorwin
Owners Override

Submit Requirements:

API-Review
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/0c9b2dd72a9d64984fa71f8971100c65dfe09d2e-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'James Robinson (Gerrit)' via owners-override

unread,

Mar 7, 2025, 10:46:27 PMMar 7

to Ian McKellar, Owners Override, John Grossman, Aaron Wood, Claire Gonyeo, GI Try Builder, David Dorwin, CQ Bot, Fuchsia Try Builder

Attention needed from Claire Gonyeo, David Dorwin, Ian McKellar and Owners Override

James Robinson voted

Code-Review	+2
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

Claire Gonyeo
David Dorwin
Ian McKellar
Owners Override

Submit Requirements:

API-Review
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/36eeeabbac636ec38a77144ff54cb4766c15bb6b-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

'CQ Bot (Gerrit)' via owners-override

unread,

Mar 7, 2025, 10:47:17 PMMar 7

to Ian McKellar, Auto-Submit, James Robinson, Owners Override, John Grossman, Aaron Wood, Claire Gonyeo, GI Try Builder, David Dorwin, Fuchsia Try Builder

CQ Bot submitted the change

Change information

Commit message:

[fidl][cpp] Improve performance by reducing interdependence

Decouple the wire and natural bindings a little more so that they can be
selectively included. This can deliver a 25-30% build time reduction for
C++ targets.

Change-Id: I79643b6be02ac883fb3d4d97c46101587f30aa16

Reviewed-on: https://fuchsia-review.googlesource.com/c/fuchsia/+/1221350

Reviewed-by: James Robinson <jam...@google.com>

Owners-Override: James Robinson <jam...@google.com>

Fuchsia-Auto-Submit: Ian McKellar <ian...@google.com>

Reviewed-by: Aaron Wood <aaro...@google.com>

Reviewed-by: John Grossman <joh...@google.com>

API-Review: Aaron Wood <aaro...@google.com>

Commit-Queue: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>

Branch: refs/heads/main

Submit Requirements:

API-Review: +1 by Aaron Wood
Code-Review: +2 by Aaron Wood, +2 by James Robinson, +2 by John Grossman

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/9be0dd0f2f2aae745d5de7a5756a0254a6f95d8e-HTML%40fuchsia-review.googlesource.com.

open

diffy

satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,

Mar 7, 2025, 10:49:33 PMMar 7

to Ian McKellar, CQ Bot, Auto-Submit, James Robinson, Owners Override, John Grossman, Aaron Wood, Claire Gonyeo, GI Try Builder, David Dorwin, Fuchsia Try Builder

Message from GI Roller

Change has been successfully rolled: http://go/roll-cl/676e84906b73947f374ae8b97c8322a3ee90d5ed

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

API-Review

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/65e0983b58a9f70a2daa6080e68b0d45686b2c45-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages