[L] Change in fuchsia/fuchsia[main]: [fx][bazel-tool] Rename and reformat bazel-tool script.

0 views
Skip to first unread message

'David Turner (Gerrit)' via owners-override

unread,
Mar 3, 2025, 5:23:45 PMMar 3
to Owners Override
Attention needed from Oliver Newman and Owners Override

David Turner has uploaded the change for review

David Turner would like Owners Override to review this change.

Commit message

[fx][bazel-tool] Rename and reformat bazel-tool script.

Since the file name did not end in .py, `fx format-code`
ignored it. The script is always launched from a devshell
wrapper, so renaming it should not impact workflows.

The dash is replaced with an underscore to appease
Gerrit static checks.

This will make reviewing future changes to the script
easier.

+ Minor mypy fixes.

+ Fix computation of Bazel workspace path in devshell
  wrapper. BAZEL_WORKSPACE was always empty but the
  value was not used (yet).
Change-Id: Iae13e4fb1f9ca1c0d5e5832d797998efa183ce84

Change diff


Change information

Files:
  • D scripts/bazel-tool
  • A scripts/bazel_tool.py
  • M tools/devshell/bazel-tool
Change size: L
Delta: 3 files changed, 193 insertions(+), 143 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Oliver Newman
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Iae13e4fb1f9ca1c0d5e5832d797998efa183ce84
Gerrit-Change-Number: 1216444
Gerrit-PatchSet: 2
Gerrit-Owner: David Turner <di...@google.com>
Gerrit-Reviewer: Clayton Wilkinson <wilkin...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: David Turner <di...@google.com>
Gerrit-Reviewer: Oliver Newman <oliver...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Aaron Wood <aaro...@google.com>
Gerrit-CC: Fuchsia Try Builder <fuchsia-t...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-CC: Jay Zhuang <jayz...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Oliver Newman <oliver...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/92c09105ee8eda3556f9c8f511c5f320c02337bd-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'David Turner (Gerrit)' via owners-override

unread,
Mar 3, 2025, 5:23:46 PMMar 3
to Owners Override, David Fang, Clayton Wilkinson, Fuchsia Try Builder, GI Try Builder, CQ Bot, Oliver Newman, Jay Zhuang, Aaron Wood
Attention needed from Oliver Newman and Owners Override

David Turner added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
David Turner . resolved

Ping, this requires an owner to approve this.

Clayton Wilkinson

I think for //scripts add and removes you need owners override?
See //scripts/README.md

David Turner

Oh thank you. Will do.

Open in Gerrit

Related details

Attention is currently required from:
  • Oliver Newman
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Iae13e4fb1f9ca1c0d5e5832d797998efa183ce84
Gerrit-Change-Number: 1216444
Gerrit-PatchSet: 2
Gerrit-Owner: David Turner <di...@google.com>
Gerrit-Reviewer: Clayton Wilkinson <wilkin...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: David Turner <di...@google.com>
Gerrit-Reviewer: Oliver Newman <oliver...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Aaron Wood <aaro...@google.com>
Gerrit-CC: Fuchsia Try Builder <fuchsia-t...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-CC: Jay Zhuang <jayz...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Oliver Newman <oliver...@google.com>
Gerrit-Comment-Date: Mon, 03 Mar 2025 17:23:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Clayton Wilkinson <wilkin...@google.com>
Comment-In-Reply-To: David Turner <di...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/92c09105ee8eda3556f9c8f511c5f320c02337bd-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'David Turner (Gerrit)' via owners-override

unread,
Mar 3, 2025, 5:25:13 PMMar 3
to Owners Override, David Fang, Clayton Wilkinson, Fuchsia Try Builder, GI Try Builder, CQ Bot, Oliver Newman, Jay Zhuang, Aaron Wood
Attention needed from Oliver Newman and Owners Override

David Turner added 1 comment

Patchset-level comments
David Turner . resolved

Note that I have multiple CLs coming to this file in the future, maybe we should move it to //build/bazel/scripts/ instead? or add a file-specific OWNERS line to it. wdyt?

Gerrit-Comment-Date: Mon, 03 Mar 2025 17:25:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/3a8c25cfede9b7ef765f5ba2af4cfd751410c9cf-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'James Robinson (Gerrit)' via owners-override

unread,
Mar 3, 2025, 5:44:18 PMMar 3
to David Turner, Owners Override, David Fang, Clayton Wilkinson, Fuchsia Try Builder, GI Try Builder, CQ Bot, Oliver Newman, Jay Zhuang, Aaron Wood
Attention needed from David Turner, Oliver Newman and Owners Override

James Robinson voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Turner
  • Oliver Newman
  • Owners Override
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Iae13e4fb1f9ca1c0d5e5832d797998efa183ce84
Gerrit-Change-Number: 1216444
Gerrit-PatchSet: 2
Gerrit-Owner: David Turner <di...@google.com>
Gerrit-Reviewer: Clayton Wilkinson <wilkin...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: David Turner <di...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Oliver Newman <oliver...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Aaron Wood <aaro...@google.com>
Gerrit-CC: Fuchsia Try Builder <fuchsia-t...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-CC: Jay Zhuang <jayz...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Oliver Newman <oliver...@google.com>
Gerrit-Attention: David Turner <di...@google.com>
Gerrit-Comment-Date: Mon, 03 Mar 2025 17:44:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/5c26e261c3a5587ce7f31c39d3e140aeed0db516-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Mar 3, 2025, 7:03:47 PMMar 3
to David Turner, Auto-Submit, James Robinson, Owners Override, David Fang, Clayton Wilkinson, Fuchsia Try Builder, GI Try Builder, Oliver Newman, Jay Zhuang, Aaron Wood

CQ Bot submitted the change

Change information

Commit message:
[fx][bazel-tool] Rename and reformat bazel-tool script.

Since the file name did not end in .py, `fx format-code`
ignored it. The script is always launched from a devshell
wrapper, so renaming it should not impact workflows.

The dash is replaced with an underscore to appease
Gerrit static checks.

This will make reviewing future changes to the script
easier.

+ Minor mypy fixes.

+ Fix computation of Bazel workspace path in devshell
  wrapper. BAZEL_WORKSPACE was always empty but the
  value was not used (yet).
Change-Id: Iae13e4fb1f9ca1c0d5e5832d797998efa183ce84
Owners-Override: James Robinson <jam...@google.com>
Reviewed-by: Clayton Wilkinson <wilkin...@google.com>
Fuchsia-Auto-Submit: David Turner <di...@google.com>
Reviewed-by: David Fang <fan...@google.com>
Files:
  • D scripts/bazel-tool
  • A scripts/bazel_tool.py
  • M tools/devshell/bazel-tool
Change size: L
Delta: 3 files changed, 193 insertions(+), 143 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Clayton Wilkinson, +2 by David Fang
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Iae13e4fb1f9ca1c0d5e5832d797998efa183ce84
Gerrit-Change-Number: 1216444
Gerrit-PatchSet: 3
Gerrit-Owner: David Turner <di...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: Clayton Wilkinson <wilkin...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: David Turner <di...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Oliver Newman <oliver...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Aaron Wood <aaro...@google.com>
Gerrit-CC: Fuchsia Try Builder <fuchsia-t...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-CC: Jay Zhuang <jayz...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/2b893e44b5d61097ee41b72f95d003a62badfd09-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Mar 3, 2025, 7:14:21 PMMar 3
to David Turner, CQ Bot, Auto-Submit, James Robinson, Owners Override, David Fang, Clayton Wilkinson, Fuchsia Try Builder, GI Try Builder, Oliver Newman, Jay Zhuang, Aaron Wood

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Iae13e4fb1f9ca1c0d5e5832d797998efa183ce84
Gerrit-Change-Number: 1216444
Gerrit-PatchSet: 3
Gerrit-Owner: David Turner <di...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: Clayton Wilkinson <wilkin...@google.com>
Gerrit-Reviewer: David Fang <fan...@google.com>
Gerrit-Reviewer: David Turner <di...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: Oliver Newman <oliver...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-CC: Aaron Wood <aaro...@google.com>
Gerrit-CC: Fuchsia Try Builder <fuchsia-t...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-CC: Jay Zhuang <jayz...@google.com>
Gerrit-Comment-Date: Mon, 03 Mar 2025 19:14:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/fc1cb90e177efe9ede31b1b45bca8e2ea0a22457-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages