[L] Change in fuchsia/fuchsia[main]: [paver] Move to src/firmware
1 view
Skip to first unread message
'James Sullivan (Gerrit)' via owners-override
Oct 25, 2025, 9:48:18 AMOct 25
to Owners Override
Attention needed from Owners Override
James Sullivan has uploaded the change for review![]( "Open in Gerrit")
James Sullivan would like Owners Override to review this change.
Commit message
[paver] Move to src/firmware
Now that we're mostly finished making changes to the paver for
storage-host, it's a good time to move the code to reflect ownership.
I added myself as a temporary OWNER until we've finished the cleanup
work for storage-host.
Change-Id: I3d57408ef903c5bbfe710adf7a311660598077dc
Depends-on: turquoise-internal:Ic5a3f2f774c355057f4275f82c76153e13812abe
Change diff
Change information
Files:
- M build/testing/timeouts/BUILD.gn
- M docs/contribute/open_projects/graduated/typed_channels.md
- M src/BUILD.gn
- M src/bringup/bin/netsvc/OWNERS
- M src/bringup/bin/paver/BUILD.gn
- M src/bringup/bin/paver/OWNERS
- M src/bringup/bin/paver/paver.cc
- M src/devices/block/drivers/core/BUILD.gn
- M src/devices/block/drivers/gpt/BUILD.gn
- M src/devices/testing/driver-integration-test-shim/BUILD.gn
- M src/firmware/BUILD.gn
- M src/firmware/gigaboot/boards/nuc/gen_nuc_gpt.py
- R src/firmware/paver/BUILD.gn
- A src/firmware/paver/OWNERS
- R src/firmware/paver/abr-client.cc
- R src/firmware/paver/abr-client.h
- R src/firmware/paver/android.cc
- R src/firmware/paver/android.h
- R src/firmware/paver/astro.cc
- R src/firmware/paver/astro.h
- R src/firmware/paver/block-devices.cc
- R src/firmware/paver/block-devices.h
- R src/firmware/paver/boot_control_definition.h
- R src/firmware/paver/config.h
- R src/firmware/paver/device-partitioner.cc
- R src/firmware/paver/device-partitioner.h
- R src/firmware/paver/e2e_tests/BUILD.gn
- R src/firmware/paver/e2e_tests/README.md
- R src/firmware/paver/e2e_tests/config.go
- R src/firmware/paver/e2e_tests/e2e_tests.gni
- R src/firmware/paver/e2e_tests/pave_test.go
- R src/firmware/paver/fvm.cc
- R src/firmware/paver/fvm.h
- R src/firmware/paver/gpt.cc
- R src/firmware/paver/gpt.h
- R src/firmware/paver/libboot_control.cc
- R src/firmware/paver/libboot_control.h
- R src/firmware/paver/luis.cc
- R src/firmware/paver/luis.h
- R src/firmware/paver/moonflower.cc
- R src/firmware/paver/moonflower.h
- R src/firmware/paver/nelson.cc
- R src/firmware/paver/nelson.h
- R src/firmware/paver/partition-client.cc
- R src/firmware/paver/partition-client.h
- R src/firmware/paver/pave-logging.h
- R src/firmware/paver/paver-context.h
- R src/firmware/paver/paver.cc
- R src/firmware/paver/paver.h
- R src/firmware/paver/sherlock.cc
- R src/firmware/paver/sherlock.h
- R src/firmware/paver/skip-block.cc
- R src/firmware/paver/skip-block.h
- R src/firmware/paver/sparse.cc
- R src/firmware/paver/sparse.h
- R src/firmware/paver/stream-reader.cc
- R src/firmware/paver/stream-reader.h
- R src/firmware/paver/sysconfig-fidl.cc
- R src/firmware/paver/sysconfig-fidl.h
- R src/firmware/paver/system_shutdown_state.cc
- R src/firmware/paver/system_shutdown_state.h
- R src/firmware/paver/test/BUILD.gn
- R src/firmware/paver/test/abr-test.cc
- R src/firmware/paver/test/block-devices-test.cc
- R src/firmware/paver/test/data-sink-test.cc
- R src/firmware/paver/test/device-partitioner-test.cc
- R src/firmware/paver/test/fvm-test.cc
- R src/firmware/paver/test/meta/paver-validation-fuzzer.cml
- R src/firmware/paver/test/partition-client-test.cc
- R src/firmware/paver/test/paver-context-test.cc
- R src/firmware/paver/test/paversvc-test.cc
- R src/firmware/paver/test/stream-reader-test.cc
- R src/firmware/paver/test/test-utils.cc
- R src/firmware/paver/test/test-utils.h
- R src/firmware/paver/test/validation-fuzzer.cc
- R src/firmware/paver/test/validation-test.cc
- R src/firmware/paver/uefi.cc
- R src/firmware/paver/uefi.h
- R src/firmware/paver/utils.cc
- R src/firmware/paver/utils.h
- R src/firmware/paver/validation.cc
- R src/firmware/paver/validation.h
- R src/firmware/paver/vim3.cc
- R src/firmware/paver/vim3.h
- M src/storage/bin/disk-pave/BUILD.gn
- M src/storage/bin/disk-pave/OWNERS
- M src/storage/fvm/driver/BUILD.gn
- M src/storage/lib/BUILD.gn
- D src/storage/lib/paver/OWNERS
- M tools/testing/tefmocheck/string_in_log_check.go
- M zircon/system/ulib/svc/BUILD.gn
Change size: L
Delta: 91 files changed, 240 insertions(+), 238 deletions(-)
Related details
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/58737d71ad8c9aaf849b6e859593d245824cceab-HTML%40fuchsia-review.googlesource.com.
'Adam Barth (Gerrit)' via owners-override
Oct 26, 2025, 2:30:09 AMOct 26
to James Sullivan, Owners Override, David Pursell, Yecheng Zhao, Suraj Malhotra, GI Try Builder, CQ Bot
Attention needed from James Sullivan and Owners Override
Adam Barth voted Owners-Override+1![]( "Open in Gerrit")
Attention is currently required from:
- James Sullivan
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/fb8d209cb2fabc71b981f69a15a012cc810291d2-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'James Sullivan (Gerrit)' via owners-override
Oct 27, 2025, 11:35:21 AMOct 27
to CL Deps Checker, Adam Barth, Owners Override, David Pursell, Yecheng Zhao, Suraj Malhotra, GI Try Builder, CQ Bot
Attention needed from Owners Override
James Sullivan voted![]( "Open in Gerrit")
Attention is currently required from:
- Owners Override
Submit Requirements:
Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/acb5ba9ffaeb91496c629c739b715c8d228a63f3-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'CQ Bot (Gerrit)' via owners-override
Oct 27, 2025, 4:06:25 PMOct 27
to James Sullivan, CL Deps Checker, Adam Barth, Owners Override, David Pursell, Yecheng Zhao, Suraj Malhotra, GI Try Builder
CQ Bot submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/firmware/paver/sysconfig-fidl.h
Insertions: 1, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/firmware/paver/device-partitioner.h
Insertions: 1, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: tools/testing/tefmocheck/string_in_log_check.go
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/firmware/paver/OWNERS
Insertions: 2, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/firmware/paver/config.h
Insertions: 42, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/firmware/paver/gpt.h
Insertions: 1, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: docs/contribute/open_projects/graduated/typed_channels.md
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/firmware/paver/moonflower.cc
Insertions: 0, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/firmware/paver/device-partitioner.cc
Insertions: 2, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/firmware/paver/paver.h
Insertions: 2, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/firmware/paver/sysconfig-fidl.cc
Insertions: 1, Deletions: 0.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/firmware/paver/uefi.h
Insertions: 1, Deletions: 2.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[paver] Move to src/firmware
Now that we're mostly finished making changes to the paver for
storage-host, it's a good time to move the code to reflect ownership.
I added myself as a temporary OWNER until we've finished the cleanup
work for storage-host.
Change-Id: I3d57408ef903c5bbfe710adf7a311660598077dc
Depends-on: turquoise-internal:Ic5a3f2f774c355057f4275f82c76153e13812abe
Dependencies-Satisfied: CL Deps Checker <cl-deps...@fuchsia-internal-service-accts.iam.gserviceaccount.com>
Reviewed-by: David Pursell <dpur...@google.com>
Owners-Override: Adam Barth <aba...@google.com>
Fuchsia-Auto-Submit: James Sullivan <jfsu...@google.com>
Commit-Queue: James Sullivan <jfsu...@google.com>
Delta: 91 files changed, 324 insertions(+), 322 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +2 by David Pursell
Dependencies-Satisfied: +1 by CL Deps Checker
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/b77cd4500e689893b2b6701f5947d51fcb6e4d80-HTML%40fuchsia-review.googlesource.com.To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
'GI Roller (Gerrit)' via owners-override
Oct 27, 2025, 4:09:11 PMOct 27
to James Sullivan, CQ Bot, CL Deps Checker, Adam Barth, Owners Override, David Pursell, Yecheng Zhao, Suraj Malhotra, GI Try Builder
Message from GI Roller![]( "Open in Gerrit")
Change has been successfully rolled: https://turquoise-internal-review.googlesource.com/1071033
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Dependencies-Satisfied
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/c136fd4e903968ec055c24cb9077dec0bbed07f2-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
Reply all
Reply to author
Forward
0 new messages