[S] Change in fuchsia/fuchsia[main]: [clang] Add missing headers after libc++ update

2 views
Skip to first unread message

'Paul Kirth (Gerrit)' via owners-override

unread,
Aug 14, 2024, 1:26:43 PM8/14/24
to John Rosasco, Garratt Gallagher, Owners Override, Jack Brennen, Megan Batty, Martin Puryear, Ruby Zhuang, Suraj Malhotra, Dustin Green, Craig Stout
Attention needed from Craig Stout, Dustin Green, Garratt Gallagher, Jack Brennen, John Rosasco, Martin Puryear, Megan Batty, Owners Override, Ruby Zhuang and Suraj Malhotra

Paul Kirth has uploaded the change for review

Paul Kirth would like John Rosasco, Garratt Gallagher, Owners Override, Jack Brennen, Megan Batty, Martin Puryear, Ruby Zhuang, Suraj Malhotra, Dustin Green and Craig Stout to review this change.

Commit message

[clang] Add missing headers after libc++ update

 In https://github.com/llvm/llvm-project/pull/99738 libc++ removed cmath
 from one of its header files, and several places in Fuchsia are no
 longer including the required header for rounding functions.
 Additionally, it seems some code is no longer picking up chrono.
Fixed: 359865937
Change-Id: Ica6e269a0d3b0dace2f551099f8ed42bd8990857

Change diff


Change information

Files:
  • M src/devices/acpi/drivers/intel-thermal/intel_thermal.cc
  • M src/devices/adc/drivers/adc/adc-test.cc
  • M src/devices/temperature/drivers/aml-trip/aml-trip-device.cc
  • M src/graphics/examples/vkproto/cmd-buf-benchmark/main.cc
  • M src/media/audio/audio_core/test/hardware/audio_core_hardware_test.h
  • M src/media/audio/consumer/consumer.cc
  • M src/media/audio/drivers/codecs/alc5663/tests/alc5663_test.cc
  • M src/media/audio/drivers/tests/basic_test.cc
  • M src/media/codec/codecs/sw/cvsd/codec_adapter_cvsd.h
  • M src/ui/a11y/lib/configuration/tests/color_transform_manager_test.cc
  • M src/ui/a11y/lib/view/view_coordinate_converter.cc
  • M src/ui/input/lib/injector/injector.cc
  • M src/ui/scenic/tests/flatland_integration_tests/flatland_pixeltest.cc
  • M src/ui/testing/util/test_view.cc
  • M src/virtualization/bin/vmm/device/tests/virtio_gpu_test.cc
  • M src/virtualization/bin/vmm/device/tests/virtio_input_test.cc
  • M src/virtualization/tests/lib/enclosed_guest.cc
Change size: S
Delta: 17 files changed, 24 insertions(+), 0 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Craig Stout
  • Dustin Green
  • Garratt Gallagher
  • Jack Brennen
  • John Rosasco
  • Martin Puryear
  • Megan Batty
  • Owners Override
  • Ruby Zhuang
  • Suraj Malhotra
Submit Requirements:
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ica6e269a0d3b0dace2f551099f8ed42bd8990857
Gerrit-Change-Number: 1100755
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Kirth <paul...@google.com>
Gerrit-Reviewer: Craig Stout <cst...@google.com>
Gerrit-Reviewer: Dustin Green <dusti...@google.com>
Gerrit-Reviewer: Garratt Gallagher <gar...@google.com>
Gerrit-Reviewer: Jack Brennen <jbre...@google.com>
Gerrit-Reviewer: John Rosasco <ros...@google.com>
Gerrit-Reviewer: Martin Puryear <mpur...@google.com>
Gerrit-Reviewer: Megan Batty <mg...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Ruby Zhuang <rdzh...@google.com>
Gerrit-Reviewer: Suraj Malhotra <surajm...@google.com>
Gerrit-Attention: John Rosasco <ros...@google.com>
Gerrit-Attention: Garratt Gallagher <gar...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Jack Brennen <jbre...@google.com>
Gerrit-Attention: Megan Batty <mg...@google.com>
Gerrit-Attention: Martin Puryear <mpur...@google.com>
Gerrit-Attention: Ruby Zhuang <rdzh...@google.com>
Gerrit-Attention: Suraj Malhotra <surajm...@google.com>
Gerrit-Attention: Dustin Green <dusti...@google.com>
Gerrit-Attention: Craig Stout <cst...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/e13ebea70fd2e3853164b8202dd39076fa3009d7-HTML%40fuchsia-review.googlesource.com.
unsatisfied_requirement
open
diffy

'Craig Stout (Gerrit)' via owners-override

unread,
Aug 14, 2024, 1:29:12 PM8/14/24
to Paul Kirth, Owners Override, Suraj Malhotra, Megan Batty, Martin Puryear, Ruby Zhuang, John Rosasco, Garratt Gallagher, Dustin Green, Jack Brennen
Attention needed from Dustin Green, Garratt Gallagher, Jack Brennen, John Rosasco, Martin Puryear, Megan Batty, Owners Override, Paul Kirth, Ruby Zhuang and Suraj Malhotra

Craig Stout voted and added 1 comment

Votes added by Craig Stout

Code-Review+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Craig Stout . resolved

src/graphics lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Dustin Green
  • Garratt Gallagher
  • Jack Brennen
  • John Rosasco
  • Martin Puryear
  • Megan Batty
  • Owners Override
  • Paul Kirth
  • Ruby Zhuang
  • Suraj Malhotra
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ica6e269a0d3b0dace2f551099f8ed42bd8990857
Gerrit-Change-Number: 1100755
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Kirth <paul...@google.com>
Gerrit-Reviewer: Craig Stout <cst...@google.com>
Gerrit-Reviewer: Dustin Green <dusti...@google.com>
Gerrit-Reviewer: Garratt Gallagher <gar...@google.com>
Gerrit-Reviewer: Jack Brennen <jbre...@google.com>
Gerrit-Reviewer: John Rosasco <ros...@google.com>
Gerrit-Reviewer: Martin Puryear <mpur...@google.com>
Gerrit-Reviewer: Megan Batty <mg...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Ruby Zhuang <rdzh...@google.com>
Gerrit-Reviewer: Suraj Malhotra <surajm...@google.com>
Gerrit-Attention: John Rosasco <ros...@google.com>
Gerrit-Attention: Garratt Gallagher <gar...@google.com>
Gerrit-Attention: Paul Kirth <paul...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Jack Brennen <jbre...@google.com>
Gerrit-Attention: Megan Batty <mg...@google.com>
Gerrit-Attention: Martin Puryear <mpur...@google.com>
Gerrit-Attention: Ruby Zhuang <rdzh...@google.com>
Gerrit-Attention: Suraj Malhotra <surajm...@google.com>
Gerrit-Attention: Dustin Green <dusti...@google.com>
Gerrit-Comment-Date: Wed, 14 Aug 2024 17:28:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/76d14836696697e0b0b81ff2ce6517ebb991389e-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Paul Kirth (Gerrit)' via owners-override

unread,
Aug 14, 2024, 1:43:46 PM8/14/24
to Craig Stout, Owners Override, Suraj Malhotra, Megan Batty, Martin Puryear, Ruby Zhuang, John Rosasco, Garratt Gallagher, Dustin Green, Jack Brennen
Attention needed from Dustin Green, Garratt Gallagher, Jack Brennen, John Rosasco, Martin Puryear, Megan Batty, Owners Override, Ruby Zhuang and Suraj Malhotra

Paul Kirth voted

Commit-Queue+1
Fuchsia-Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dustin Green
  • Garratt Gallagher
  • Jack Brennen
  • John Rosasco
  • Martin Puryear
  • Megan Batty
  • Owners Override
  • Ruby Zhuang
  • Suraj Malhotra
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ica6e269a0d3b0dace2f551099f8ed42bd8990857
Gerrit-Change-Number: 1100755
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Kirth <paul...@google.com>
Gerrit-Reviewer: Craig Stout <cst...@google.com>
Gerrit-Reviewer: Dustin Green <dusti...@google.com>
Gerrit-Reviewer: Garratt Gallagher <gar...@google.com>
Gerrit-Reviewer: Jack Brennen <jbre...@google.com>
Gerrit-Reviewer: John Rosasco <ros...@google.com>
Gerrit-Reviewer: Martin Puryear <mpur...@google.com>
Gerrit-Reviewer: Megan Batty <mg...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Paul Kirth <paul...@google.com>
Gerrit-Reviewer: Ruby Zhuang <rdzh...@google.com>
Gerrit-Reviewer: Suraj Malhotra <surajm...@google.com>
Gerrit-Attention: John Rosasco <ros...@google.com>
Gerrit-Attention: Garratt Gallagher <gar...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Jack Brennen <jbre...@google.com>
Gerrit-Attention: Megan Batty <mg...@google.com>
Gerrit-Attention: Martin Puryear <mpur...@google.com>
Gerrit-Attention: Ruby Zhuang <rdzh...@google.com>
Gerrit-Attention: Suraj Malhotra <surajm...@google.com>
Gerrit-Attention: Dustin Green <dusti...@google.com>
Gerrit-Comment-Date: Wed, 14 Aug 2024 17:43:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/7c7c19acb67f8941cea3752ce0e1324bc95a8d8c-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Garratt Gallagher (Gerrit)' via owners-override

unread,
Aug 14, 2024, 1:49:37 PM8/14/24
to Paul Kirth, CQ Bot, Craig Stout, Owners Override, Suraj Malhotra, Megan Batty, Martin Puryear, Ruby Zhuang, John Rosasco, Dustin Green, Jack Brennen
Attention needed from Dustin Green, Jack Brennen, John Rosasco, Martin Puryear, Megan Batty, Owners Override, Paul Kirth, Ruby Zhuang and Suraj Malhotra

Garratt Gallagher voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Dustin Green
  • Jack Brennen
  • John Rosasco
  • Martin Puryear
  • Megan Batty
  • Owners Override
  • Paul Kirth
  • Ruby Zhuang
  • Suraj Malhotra
Gerrit-Attention: John Rosasco <ros...@google.com>
Gerrit-Attention: Paul Kirth <paul...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Jack Brennen <jbre...@google.com>
Gerrit-Attention: Megan Batty <mg...@google.com>
Gerrit-Attention: Martin Puryear <mpur...@google.com>
Gerrit-Attention: Ruby Zhuang <rdzh...@google.com>
Gerrit-Attention: Suraj Malhotra <surajm...@google.com>
Gerrit-Attention: Dustin Green <dusti...@google.com>
Gerrit-Comment-Date: Wed, 14 Aug 2024 17:49:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/8e452856edbc53db638c55e41fb39dbf022684a8-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'James Robinson (Gerrit)' via owners-override

unread,
Aug 14, 2024, 1:58:58 PM8/14/24
to Paul Kirth, Garratt Gallagher, CQ Bot, Craig Stout, Owners Override, Suraj Malhotra, Megan Batty, Martin Puryear, Ruby Zhuang, John Rosasco, Dustin Green, Jack Brennen
Attention needed from Dustin Green, Jack Brennen, John Rosasco, Martin Puryear, Megan Batty, Owners Override, Paul Kirth, Ruby Zhuang and Suraj Malhotra

James Robinson voted Owners-Override+1

Owners-Override+1
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: John Rosasco <ros...@google.com>
Gerrit-Reviewer: Martin Puryear <mpur...@google.com>
Gerrit-Reviewer: Megan Batty <mg...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Paul Kirth <paul...@google.com>
Gerrit-Reviewer: Ruby Zhuang <rdzh...@google.com>
Gerrit-Reviewer: Suraj Malhotra <surajm...@google.com>
Gerrit-Attention: John Rosasco <ros...@google.com>
Gerrit-Attention: Paul Kirth <paul...@google.com>
Gerrit-Attention: Owners Override <owners-...@fuchsia.dev>
Gerrit-Attention: Jack Brennen <jbre...@google.com>
Gerrit-Attention: Megan Batty <mg...@google.com>
Gerrit-Attention: Martin Puryear <mpur...@google.com>
Gerrit-Attention: Ruby Zhuang <rdzh...@google.com>
Gerrit-Attention: Suraj Malhotra <surajm...@google.com>
Gerrit-Attention: Dustin Green <dusti...@google.com>
Gerrit-Comment-Date: Wed, 14 Aug 2024 17:58:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/77c490ead84ef2ae2e81af978f1c4782d22aaccd-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'Suraj Malhotra (Gerrit)' via owners-override

unread,
Aug 14, 2024, 2:34:44 PM8/14/24
to Paul Kirth, James Robinson, Garratt Gallagher, CQ Bot, Craig Stout, Owners Override, Megan Batty, Martin Puryear, Ruby Zhuang, John Rosasco, Dustin Green, Jack Brennen
Attention needed from Dustin Green, Jack Brennen, John Rosasco, Martin Puryear, Megan Batty, Owners Override, Paul Kirth and Ruby Zhuang

Suraj Malhotra voted Code-Review+2

Code-Review+2
Open in Gerrit

Related details

Attention is currently required from:
  • Dustin Green
  • Jack Brennen
  • John Rosasco
  • Martin Puryear
  • Megan Batty
  • Owners Override
  • Paul Kirth
  • Ruby Zhuang
Gerrit-Attention: Dustin Green <dusti...@google.com>
Gerrit-Comment-Date: Wed, 14 Aug 2024 18:34:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/a41857ed5ef7bb286c3a5be246dfa7cd807c2d99-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy

'CQ Bot (Gerrit)' via owners-override

unread,
Aug 14, 2024, 2:41:51 PM8/14/24
to Paul Kirth, Auto-Submit, Suraj Malhotra, James Robinson, Garratt Gallagher, Craig Stout, Owners Override, Megan Batty, Martin Puryear, Ruby Zhuang, John Rosasco, Dustin Green, Jack Brennen

CQ Bot submitted the change

Change information

Commit message:
[clang] Add missing headers after libc++ update

 In https://github.com/llvm/llvm-project/pull/99738 libc++ removed cmath
 from one of its header files, and several places in Fuchsia are no
 longer including the required header for rounding functions.
 Additionally, it seems some code is no longer picking up chrono.
Fixed: 359865937
Change-Id: Ica6e269a0d3b0dace2f551099f8ed42bd8990857
Fuchsia-Auto-Submit: Paul Kirth <paul...@google.com>
Reviewed-by: Garratt Gallagher <gar...@google.com>
Reviewed-by: Craig Stout <cst...@google.com>
Reviewed-by: Suraj Malhotra <surajm...@google.com>
Owners-Override: James Robinson <jam...@google.com>
Files:
  • M src/devices/acpi/drivers/intel-thermal/intel_thermal.cc
  • M src/devices/adc/drivers/adc/adc-test.cc
  • M src/devices/temperature/drivers/aml-trip/aml-trip-device.cc
  • M src/graphics/examples/vkproto/cmd-buf-benchmark/main.cc
  • M src/media/audio/audio_core/test/hardware/audio_core_hardware_test.h
  • M src/media/audio/consumer/consumer.cc
  • M src/media/audio/drivers/codecs/alc5663/tests/alc5663_test.cc
  • M src/media/audio/drivers/tests/basic_test.cc
  • M src/media/codec/codecs/sw/cvsd/codec_adapter_cvsd.h
  • M src/ui/a11y/lib/configuration/tests/color_transform_manager_test.cc
  • M src/ui/a11y/lib/view/view_coordinate_converter.cc
  • M src/ui/input/lib/injector/injector.cc
  • M src/ui/scenic/tests/flatland_integration_tests/flatland_pixeltest.cc
  • M src/ui/testing/util/test_view.cc
  • M src/virtualization/bin/vmm/device/tests/virtio_gpu_test.cc
  • M src/virtualization/bin/vmm/device/tests/virtio_input_test.cc
  • M src/virtualization/tests/lib/enclosed_guest.cc
Change size: S
Delta: 17 files changed, 24 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Suraj Malhotra, +2 by Craig Stout, +2 by Garratt Gallagher
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ica6e269a0d3b0dace2f551099f8ed42bd8990857
Gerrit-Change-Number: 1100755
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Kirth <paul...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: Craig Stout <cst...@google.com>
Gerrit-Reviewer: Dustin Green <dusti...@google.com>
Gerrit-Reviewer: Garratt Gallagher <gar...@google.com>
Gerrit-Reviewer: Jack Brennen <jbre...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: John Rosasco <ros...@google.com>
Gerrit-Reviewer: Martin Puryear <mpur...@google.com>
Gerrit-Reviewer: Megan Batty <mg...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Paul Kirth <paul...@google.com>
Gerrit-Reviewer: Ruby Zhuang <rdzh...@google.com>
Gerrit-Reviewer: Suraj Malhotra <surajm...@google.com>

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/24970830d2cddc2657cb320c716d1b19985257f2-HTML%40fuchsia-review.googlesource.com.
open
diffy
satisfied_requirement

'GI Roller (Gerrit)' via owners-override

unread,
Aug 14, 2024, 2:47:55 PM8/14/24
to Paul Kirth, CQ Bot, Auto-Submit, Suraj Malhotra, James Robinson, Garratt Gallagher, Craig Stout, Owners Override, Megan Batty, Martin Puryear, Ruby Zhuang, John Rosasco, Dustin Green, Jack Brennen

Message from GI Roller

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: fuchsia
Gerrit-Branch: main
Gerrit-Change-Id: Ica6e269a0d3b0dace2f551099f8ed42bd8990857
Gerrit-Change-Number: 1100755
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Kirth <paul...@google.com>
Gerrit-Reviewer: Auto-Submit <auto-...@fuchsia-infra.iam.gserviceaccount.com>
Gerrit-Reviewer: Craig Stout <cst...@google.com>
Gerrit-Reviewer: Dustin Green <dusti...@google.com>
Gerrit-Reviewer: Garratt Gallagher <gar...@google.com>
Gerrit-Reviewer: Jack Brennen <jbre...@google.com>
Gerrit-Reviewer: James Robinson <jam...@google.com>
Gerrit-Reviewer: John Rosasco <ros...@google.com>
Gerrit-Reviewer: Martin Puryear <mpur...@google.com>
Gerrit-Reviewer: Megan Batty <mg...@google.com>
Gerrit-Reviewer: Owners Override <owners-...@fuchsia.dev>
Gerrit-Reviewer: Paul Kirth <paul...@google.com>
Gerrit-Reviewer: Ruby Zhuang <rdzh...@google.com>
Gerrit-Reviewer: Suraj Malhotra <surajm...@google.com>
Gerrit-Comment-Date: Wed, 14 Aug 2024 18:47:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No

--
You received this message because you are subscribed to the Google Groups "owners-override" group.
To unsubscribe from this group and stop receiving emails from it, send an email to owners-overri...@fuchsia.dev.
To view this discussion on the web visit https://groups.google.com/a/fuchsia.dev/d/msgid/owners-override/ffe75ef4f10ddf7dbd578e640596d41bdb0fe681-EmailReviewComments-HTML%40fuchsia-review.googlesource.com.
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages